Citadel Development

got on track through

bbsview_renderer.c: In function ‘bbsview_get_last_seen’:
bbsview_renderer.c:63: warning: ISO C90 forbids mixed declarations and code

to

long bbsview_get_last_seen(void)

which calls GTSN to retrieve the seen-record for the room, right?

uncompressed seen records may become up to 4k aka SIZ, right?

the reply is up to '200 ' + SIZ  then in here if I get that correctly? which would be 4 bytes bigger than the buffer used to keep it.

One of two good reasons not to use static buffers; Second one: GetServerStatus() which may enable us to react to '200-' in some not to distant future.

ChrPtr gives you a const char* out of that StrBuf for your strchr; you can use StrBufCutAt() to cut it at that place as you did

Di Mai 25 2010 14:08:49 EDT von "ajc" <ajc@uncensored.citadel.org> Betreff: Citadel commit log: revision 8597

------------------------------------------------------------------------
r8597 | ajc | 2010-05-25 14:08:48 -0400 (Tue, 25 May 2010) | 1 line
Changed paths:
M /trunk/webcit/bbsview_renderer.c
M /trunk/webcit/static/t/knrooms.html
M /trunk/webcit/static/wclib.js
M /trunk/webcit/static/webcit.css

* Now attempting to fix the final few rendering problems in Internet Explorer. Testing with IE 7. I will also test with IE 8, Firefox, and WebKit (Chrome, Safari etc). IE 6 will not be tested; in fact, I am *removing* all markup which indicates that it is only present to work around IE 6 bugs.
------------------------------------------------------------------------

Some other useability problem about the new bbsview...

It sort of jumps to the 'first new' after rendring it; which makes the experience a little flashy.

maybe firebug/yslow or the google firebug plugin could also bring some more infos how to get that better...

Mi Mai 26 2010 18:50:26 EDT von dothebart @ Uncensored Betreff: Citadel commit log: revision 8597

Some other useability problem about the new bbsview...

It sort of jumps to the 'first new' after rendring it; which makes the experience a little flashy.

maybe firebug/yslow or the google firebug plugin could also bring some more infos how to get that better...

whew. Just tried out chromium. what an amazing speed. plus that nasty jumping is next to not there.

On my workstation the close button of the addressbook popup just disappeared, which is pretty nasty because of the 'post' button is buried under it :(

I'm running it with

ii  libjs-prototype                       1.6.1-1                     JavaScript Framework for dynamic web applications
ii  libjs-scriptaculous                   1.8.3-1                     JavaScript library for dynamic web applications

(which should be all external resources in the .debs)

Over here the button is still there.

I don't get any error messages while opening the popup

ugh. solved it. for some unclear reason, webcit didn't know about closewindow.gif

ah, great.

We've got a bug against pkg-citadel - webcit that it has an old copy.

Feivel will be glad to hear.

Fr Mai 28 2010 05:32:21 EDT von dothebart @ Uncensored Betreff: close button in addressbook popup gone..

On my workstation the close button of the addressbook popup just disappeared, which is pretty nasty because of the 'post' button is buried under it :(

I'm running it with

ii  libjs-prototype                       1.6.1-1                     JavaScript Framework for dynamic web applications
ii  libjs-scriptaculous                   1.8.3-1                     JavaScript library for dynamic web applications

(which should be all external resources in the .debs)

Over here the button is still there.

I don't get any error messages while opening the popup

 

ugh. solved it. for some unclear reason, webcit didn't know about closewindow.gif

Hm, maybe theres a smarter way to protect us from that? so that it for example falls back to an X if the image doesn't load??

that seems to be if get_serv_info() fails?

it does...

serv_printf("IDEN %d|%d|%d|%s|%s",
DEVELOPER_ID,
CLIENT_ID,
CLIENT_VERSION,
ChrPtr(user_agent),
ChrPtr(browser_host)
);
StrBuf_ServGetln(Buf);

serv_puts("ICAL sgi|1");
StrBuf_ServGetln(Buf);

serv_puts("INFO");
StrBuf_ServGetln(Buf);
if (GetServerStatus(Buf, NULL) != 1) {

maybe you'd like to add a debug statement here??
FreeStrBuf(&Buf);
return NULL;
}

and... it probably would be 'nice' to evaluate the return of IDEN instead of just ignoring it, right?