Checked in.  I decided not to unblock all the sessions and then wait.  There probably are not going to be many at one time to purge like this, but if there were a lot, it might take more time based on the number of threads that have to complete.  Just sleep each time before purging so the load gets spread out.

I will check into master soon.  Want to let run for a bit to test a little more.  As for the file descriptors, I don't think there is a leak condition.  I set the session descriptor to -1, shutdown, close and then later wait for the process to finish and purge.  At the point of the close, the descriptor is free and no one is pointing to it.  The purge just skips closing.

I have put code into my production system and it seems to work ok.  It is the using the shutdown()/close() and setting file descriptor to -1 just before calling purge.  I keep those sessions in the list, sleep() for a bit (quarter second) and then purge them all at once.  The SMTP and IMAP processing seems to finish processing in a split second, so the quarter second has been reliable, but still wish I could think of a better answer.

Yeah, I get it, and to be honest I haven't come up with any better ideas either.

Flushing the session and coming back later to cull it may be the only option.  Just make sure we don't leak file descriptors.

Sat Feb 28 2026 22:22:12 UTC from IGnatius T Foobar Subject: Re: Purge Sessions Question

This looks like the safest solution since it does not require any worker changes and only affects the non-normal purges that we were skipping.  The best implementation I found was to set the context file descriptor to -1 to make sure when the worker I/O wakes up, it will not try to go back and try a new I/O operation.   Then shutdown and close the socket.  At this point we need to allow the worker thread to continue until it is done processing the I/O return.  At that point, we can purge the context.

I think you're onto something there.  Calling shutdown(sock, SHUT_RDWR) and then maybe coming through and closing it later could be the solution.  Parking the socket in a place where it's no longer attached to any session could also be a design win.

 

The shutdown works great for forcing the client right away.  The close() can be done anytime after.  The trick is not purging the session until the client wakes up and finish processing using the session.

I thought of just using shutdown, preserving the sessions until the worker was done, but you still need feedback from the thread that it is done.  I am trying to avoid having the worker do anything because then I have to trace back any places the worker can block and then follow the code back to when it is done and have it update something to tell the main thread.

I have put code into my production system and it seems to work ok.  It is the using the shutdown()/close() and setting file descriptor to -1 just before calling purge.  I keep those sessions in the list, sleep() for a bit (quarter second) and then purge them all at once.  The SMTP and IMAP processing seems to finish processing in a split second, so the quarter second has been reliable, but still wish I could think of a better answer.

This looks like the safest solution since it does not require any worker changes and only affects the non-normal purges that we were skipping.  The best implementation I found was to set the context file descriptor to -1 to make sure when the worker I/O wakes up, it will not try to go back and try a new I/O operation.   Then shutdown and close the socket.  At this point we need to allow the worker thread to continue until it is done processing the I/O return.  At that point, we can purge the context.

I think you're onto something there.  Calling shutdown(sock, SHUT_RDWR) and then maybe coming through and closing it later could be the solution.  Parking the socket in a place where it's no longer attached to any session could also be a design win.

Well, spent a lot of time figuring out what the issue was and trying multiple implementations to try to come up with a clean solution.

Problem:

When a context is purged and the socket I/O is not idle in the worker thread, the worker is probably in an I/O wait.  The purge currently issues a close() which leaves the socket connection half open, so the worker stays blocked until the client eventually tries to send a character or drops the connection.  The purge continues and frees up the context right away, so when the worker eventually unblocks, the worker thinks the connection closed and ends up using the context and core dumps.

Solutions:

Doing a shutdown() before the close() will unblock the I/O when the thread is given control again.  The I/O operation returns like the client closed the connection.  It still continues and uses the context.

The two solutions I explored were

1) Have the I/O operation detect on return that the context has been purged and make sure the post processing does not access the context.

Problem with this is that all possible I/Os need to be modified to handle the condition.  This is possible, but requires a fair amount of work to even as a hack and if someone changes any of the code post-I/O, they could break the worker with the freed context.  I started to do this for SMTP and it was a bit of work.  It would have to be implemented in all the modules that do I/O, so I did not think this was a good solution.  With a lot of changes, we could rework the way we do all I/Os and handle properly.  This means reworking a lot of code, which means risk and since this is not a common occurrence, I did not pursue further.

2) For non-idle workers, before purging the context, shutdown the I/O and let the worker complete it's handling of a closed connection and then purge the context.

This looks like the safest solution since it does not require any worker changes and only affects the non-normal purges that we were skipping.  The best implementation I found was to set the context file descriptor to -1 to make sure when the worker I/O wakes up, it will not try to go back and try a new I/O operation.   Then shutdown and close the socket.  At this point we need to allow the worker thread to continue until it is done processing the I/O return.  At that point, we can purge the context.

Allowing the worker to continue just means doing a short usleep().  To detect when the worker has completed post I/O work with the context would require each I/O letting the other thread know.  Back to more code.  I found that just sleeping for a little time, the worker completes quickly.  I cannot test all I/O conditions, but I tested SMTP and IMAP and a quarter second sleep was plenty of time for the workers to complete.  I hate doing delays like this without a way to poll, but it is a simple solution and works in my testing.  The purge condition does not happen very often, so the quarter second does not impact the server much.

If anyone has another/safer idea or a better solution that I can implement, I am all ears.

Just so you don't think I disappeared, I figured out the issue.  Just working on the proper fix.  When a session is purged, there still can be clients connected.  Even after a server close, the client can still have their end open and any pending reads just wait.  The read returns when the client disconnects and normally the read will get an error code or end of input.  In some cases it will return without an error and the code will process the input.  In my DOS case, the clients stop transmitting in the middle of the data section.  The session eventually gets purged and the session is freed up.  Later when the read on the worker returns without an error it tries to use the session and gets a core dump.

Just working out the cleanest way to stop the thread from continuing on after a purge without having to to do something drastic to the worker thread.

Fri Feb 06 2026 18:30:29 UTCfrom HarlowSolutions Subject: Re: Purge Sessions Question

Tried purging KILLME_IDLE sessions that were not CON_IDLE and getting coredumps.  Will have to dig deeper into how to kill properly.

Tried purging KILLME_IDLE sessions that were not CON_IDLE and getting coredumps.  Will have to dig deeper into how to kill properly.

Subject: Re: Purge Sessions Question

I have looked through the code and only purging sessions that the connection is idle goes back to day one for context.c

Throughout the code (modules too), kill_me gets set in all sorts of conditions.  I am not sure what the state of the connection is in all of these cases, but the one I am running into is when the client has a connection open, but does not do anything in the time configured, it sets the kill_me to KILLME_IDLE.  Since the connection is not idle, the session never is ended.  I get hundreds of these in production.

Looking at the other places that set kill_me, I think they all expect the purge to kill them, but I cannot be sure, and I don't even know how to test every condition.

On my server, I added purging sessions that were set to KILLME_IDLE and it seems to clean up my issue.  Not sure how to test if we purge all kill_me scenarios.

I think adding the check for KILLME_IDLE is worth adding to the code, but what are the thoughts about the risk of purging all?

I have looked through the code and only purging sessions that the connection is idle goes back to day one for context.c

Throughout the code (modules too), kill_me gets set in all sorts of conditions.  I am not sure what the state of the connection is in all of these cases, but the one I am running into is when the client has a connection open, but does not do anything in the time configured, it sets the kill_me to KILLME_IDLE.  Since the connection is not idle, the session never is ended.  I get hundreds of these in production.

Looking at the other places that set kill_me, I think they all expect the purge to kill them, but I cannot be sure, and I don't even know how to test every condition.

On my server, I added purging sessions that were set to KILLME_IDLE and it seems to clean up my issue.  Not sure how to test if we purge all kill_me scenarios.

I think adding the check for KILLME_IDLE is worth adding to the code, but what are the thoughts about the risk of purging all?

I think the situation I am seeing on my server is bad guys are establishing a session and then just holding trying to do a DOS.  The session gets flagged as kill_me idle expecting the purge to actually drop the connection.  Since the session is not truly idle, it never gets killed.  I remember somewhere sessions can get set kill_me for admin reasons but I do not remember the conditions off the top of my head. I think the purge is really a cleanup and the code uses it to actually try to end the current connection.

I will have to look at the code a bit, but we may need to just have something that just drops the connection and not purge the session in some cases.  If a session is idle, is there a case that you can think of that the session needs to be killed rather than just ending the connection?

Very much so.  If the state of a session is not CON_IDLE, it means an active thread is using it as its session context.  If we delete such a session, the thread that is holding it will segfault.

So what we're looking at here, if we are seeing a surplus of sessions that have kill_me set and are not in CON_IDLE, is one of two things:

1. We missed a setting somewhere and it's not cleaning up properly; or

2. (more likely) A session is stuck waiting for some network event to complete

So for those sessions, the question to ask is "What thread is attached to this session, and what is it waiting for?"

As you've undoubtedly seen, worker_thread() in session.c is the lifeblood of the server.  If there's a problem in there, it's quite fundamental and we should absolutely fix it.

My best guess is that the setting for purge (kill_me) in the different parts of the code do not care about the state, but the actual purge will not purge unless it is in the CON_IDLE state.  I will have to debug to check.

If the state is not CON_IDLE, is there any issue with purging cleaning up and deleting?

I think you're on to something, because I don't get the purges that I should either.  I haven't been able to figure it out so far.

My server gets a lot of DOS attacks.  I am not sure if related, but I noticed I am getting messages "context: scheduled X idle sessions for termination" repeatedly.  I looked at the logic and sessions are marked for purging when idle for a while by setting the kill_me property.  The purge logic that runs periodically does not purge them because it only purges if the session state is CON_IDLE and kill_me, so the idle sessions just keep adding up.

Am I missing something?  It looks like the purge logic should not look at the state and just purge the session.  There are other times the kill_me property is set, so I am thinking that those conditions may not get purge either unless the session completes.  Need a second opinion :-)

And I'm JAZZED over the idea I had to re-use the mailbox view for wiki history.
Originally I was just going to borrow the mailbox table style, but then I thought, why not just borrow the entire view? It's going to look fantastic.

Cool.  Looking forward to seeing it.

Here it is.  I really like how it looks.  We'll add some more bells and whistles but this should give you an idea.

2099534501@Uncensored Date: Fri Sep 5 13:55:40 2025 -0700 wiki history output ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/floor_functions.c | 2 +- webcit-ng/server/messages.c | 12 +++++++++- webcit-ng/server/room_functions.c | 5 ----- webcit-ng/server/webcit.h | 1 + webcit-ng/server/wiki_view.c | 46 ++++++++++++++++++++++++++++++-------- 5 files changed, 50 insertions(+), 16 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534482Fri, 05 Sep 2025 15:22:15 +05002099534482@Uncensored Date: Fri Sep 5 12:21:52 2025 -0700 DRY refactor: replace repeated JSON 200 response blocks with json200out() Replaced eleven instances of boilerplate response construction—serialization, header setup, and body assignment with a single call to json200out(h, j). This preserves semantic behavior while eliminating redundancy. Verified all replacements maintain memory discipline, header hygiene, and response integrity. ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 13 +++++---- webcit-ng/server/admin_functions.c | 8 +---- webcit-ng/server/ctdl_commands.c | 9 +----- webcit-ng/server/floor_functions.c | 9 +----- webcit-ng/server/forum_view.c | 9 +----- webcit-ng/server/netconfig.c | 8 +---- webcit-ng/server/request.c | 14 +++++++++ webcit-ng/server/room_functions.c | 60 +++++--------------------------------- webcit-ng/server/upload.c | 16 ++-------- webcit-ng/server/webcit.h | 1 + webcit-ng/server/wiki_view.c | 12 ++------ webcit-ng/static/js/view_wiki.js | 19 ++++++++++-- 12 files changed, 55 insertions(+), 123 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534176Wed, 03 Sep 2025 15:16:11 +05002099534176@Uncensored Date: Wed Sep 3 12:15:52 2025 -0700 view_wiki.js: render editor box properly. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_wiki.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534169Wed, 03 Sep 2025 14:59:09 +05002099534169@Uncensored Date: Wed Sep 3 11:59:07 2025 -0700 More conversion... ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/mail_folder_list.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534168Wed, 03 Sep 2025 14:53:56 +05002099534168@Uncensored Date: Wed Sep 3 11:53:52 2025 -0700 More conversion of strings to template literals. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_mail.js | 50 ++++++++++++++++++++-------------------- 1 file changed, 25 insertions(+), 25 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534161Wed, 03 Sep 2025 14:32:19 +05002099534161@Uncensored Date: Wed Sep 3 11:32:17 2025 -0700 view_mail.js: convert Delete button to a template literal ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_mail.js | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534140Wed, 03 Sep 2025 13:03:16 +05002099534140@Uncensored Date: Wed Sep 3 10:03:12 2025 -0700 webcit-ng: makefile tuning as we did for server in previous commit ----------------------------------------------------------------------- Summary of changes: webcit-ng/GNUmakefile | 7 +++++++ 1 file changed, 7 insertions(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534111Wed, 03 Sep 2025 11:27:55 +05002099534111@Uncensored Date: Wed Sep 3 08:27:38 2025 -0700 Auto-tune parallelism via nproc; inject -j into MAKEFLAGS if unset GNU Make now detects CPU count using nproc and sets MAKEFLAGS += -jN unless the user has already specified -j. This covers the common case (Linux systems) without ceremony or fallback. Emits a banner for lore. Echoes the spirit of early Makefile magic—40 years later, still refining. ----------------------------------------------------------------------- Summary of changes: citadel/Makefile | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534060Tue, 02 Sep 2025 23:07:38 +05002099534060@Uncensored Date: Tue Sep 2 20:07:35 2025 -0700 fighting with css ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 8 +------- webcit-ng/static/js/view_wiki.js | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534054Tue, 02 Sep 2025 22:43:53 +05002099534054@Uncensored Date: Tue Sep 2 19:43:14 2025 -0700 css tweaks ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 2 ++ webcit-ng/static/js/util.js | 49 ++++++++++++++++++++-------------------- webcit-ng/static/js/view_wiki.js | 2 +- 3 files changed, 27 insertions(+), 26 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534052Tue, 02 Sep 2025 22:39:50 +05002099534052@Uncensored Date: Tue Sep 2 22:39:48 2025 -0400 wiki edit tweaks ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 4 ++++ 1 file changed, 4 insertions(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099534049Tue, 02 Sep 2025 22:26:43 +05002099534049@Uncensored Date: Tue Sep 2 22:26:37 2025 -0400 A snake and a camel walk into a bar... ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_mail.js | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099533976Tue, 02 Sep 2025 12:39:26 +05002099533976@Uncensored Date: Tue Sep 2 09:39:22 2025 -0700 Enhanced version of escapeHTMLURI() that leaves most printable characters alone. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/main.js | 2 +- webcit-ng/static/js/util.js | 30 +++++++++++++++++++++++++----- 2 files changed, 26 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099533962Tue, 02 Sep 2025 10:38:01 +05002099533962@Uncensored Date: Tue Sep 2 10:37:58 2025 -0400 baby steps ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_wiki.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099533311Thu, 28 Aug 2025 00:23:00 +05002099533311@Uncensored

Thu Aug 28 2025 03:05:29 UTC from IGnatius T Foobar Subject: Re: sendcommand web doc needs updating

It was my fault in testing.  I think I must have pushed the wrong
branch into my build environment when I was testing it.

These things happen. :)

Tonight I was tickled by the knowledge that two of us were working on Citadel at the same time, and relieved that we're working on different parts of the system. I have terrible luck with that sometimes, but tonight the rebase went beautifully.

And I'm JAZZED over the idea I had to re-use the mailbox view for wiki history.
Originally I was just going to borrow the mailbox table style, but then I thought, why not just borrow the entire view? It's going to look fantastic.

Cool.  Looking forward to seeing it.

Wed Aug 20 2025 00:25:18 UTC from IGnatius T Foobar Subject: Re: sendcommand web doc needs updating

Can you try a compile of that on a clean tree? I'm getting compile
errors.

Fixed it. Needed to include sysdep.h

I'm actually wondering how that ever worked without sysdep.h.

It was my fault in testing.  I think I must have pushed the wrong branch into my build environment when I was testing it.

A while back in my version, I had some issues with headers not including the headers for some of the prototypes they needed.  Other headers included them, so it worked, but caused some issues for me when I moved a couple around.

I am going to check in a couple little cleanup things, and I will make sure I test master :-)

I am not sure where any docs are for sendcommand and the webpage for the command needs to be update with the following:

usage: sendcommand [-h server_dir] [-r room_name] [-w watchdog_timeout]

                   [-f batch_file | server_command]

options:

  -h server_dir       - Citadel server home directory (default is 'sendcommand').

  -r room_name        - Select a room to run the command in.

  -w watchdog_timeout - Set a watchdog timer to exit if the specified time (in seconds) elapses.

  -f batch_filename   - Input commands from a file.

                        For list items, use a space as the first character on the line.

                        Blank lines and lines that start with # are ignored.

  server_command      - Server command with parameters to run on the server.

I will take a look at ctdlsh.

I liked sendcommand because it is simple.  I wanted to create 100 user accounts for testing, so I updated it to read a file and it worked great.

If you think it would add value to sendcommand, I can implement it formally (e.g. sendcommand -b batch_command_file).  I was wrong about the memory issue.  I was not able to reproduce.  May have been something with my system or fat-fingered something.

Sun Jul 20 2025 20:14:30 UTC from IGnatius T Foobar Subject: Re: Questions about sendcommand

Welcome back. The text client will always be well supported, and sendcommand seems a necessity, at least with the current system.

If you want to try anything fancy, you might be interested in playing around with ctdlsh. It's been in an "experimental" status pretty much forever, but if you take a look around that bit of code, it should be obvious that its intended purpose is to provide an administration shell for the Citadel system that doesn't require either logging in with a web browser *or* logging in to something that looks like an old-school BBS.

It's far from finished but it has enough in there that you can see its intent.

to text, use colors instead of italics to identify the quote nesting level. ----------------------------------------------------------------------- Summary of changes: .gitignore | 3 + citadel/docs/views.md | 22 +++-- libcitadel/lib/hash.c | 181 ++++++++++++++++++++--------------------- libcitadel/lib/html_to_ascii.c | 23 ++++-- 4 files changed, 120 insertions(+), 109 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099528019Sun, 20 Jul 2025 16:14:30 +05002099528019@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527860Fri, 18 Jul 2025 11:16:27 +05002099527860@Uncensored

I bet you thought I dropped off the face of Citadel :-)  Actually, the server has been running well and stable.

I am working on some new tests and I was looking at running some batch commands on the test server and was looking at the text client (citadel) and sendcommand.  Are we still supporting both of them?

If so, I noticed some bad memory handling in sendcommand when sending a command to the server, but because the server command processing is lenient, it works (e.g. "sendcommand infoxxxxx" actually works and even just using "info", extra characters are sent).

Should I clean it up?  Also, I would like to propose a new option that reads commands from stdin so it can batch.  Thoughts?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527806Thu, 17 Jul 2025 18:06:01 +05002099527806@Uncensored Date: Thu Jul 17 18:05:59 2025 -0400 Tuned up the css style on wiki, both view and edit ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527805Thu, 17 Jul 2025 18:02:00 +05002099527805@Uncensored Date: Thu Jul 17 18:01:58 2025 -0400 Changed the 'GhostWhite' color to 'WhiteSmoke' in our color scheme (which I am now calling the 'Slate color scheme') to provide a little more contrast. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527795Thu, 17 Jul 2025 16:04:10 +05002099527795@Uncensored Date: Thu Jul 17 16:04:07 2025 -0400 make the edit bar a little darker ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527789Thu, 17 Jul 2025 15:13:05 +05002099527789@Uncensored Date: Thu Jul 17 15:13:02 2025 -0400 If we can't DRY the entire editor, at least DRY some editing components ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 52 +++++++++++++++++++++------------------ webcit-ng/static/js/view_wiki.js | 14 ++++++++--- 2 files changed, 38 insertions(+), 28 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527571Tue, 15 Jul 2025 16:32:25 +05002099527571@Uncensored Date: Tue Jul 15 16:32:22 2025 -0400 Room list can now show the correct icon for Forums, Wikis, Blogs as appropriate. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/messages.c | 4 ---- webcit-ng/static/js/roomlist.js | 14 +++++++++++++- 2 files changed, 13 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527568Tue, 15 Jul 2025 15:57:40 +05002099527568@Uncensored Date: Tue Jul 15 15:57:38 2025 -0400 Saving a wiki page now works ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/messages.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527564Tue, 15 Jul 2025 15:39:28 +05002099527564@Uncensored Date: Tue Jul 15 15:39:24 2025 -0400 webcit-ng: conversion of strerror to %m ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/html2html.c | 4 ++-- webcit-ng/server/static.c | 4 ++-- webcit-ng/server/tls.c | 4 ++-- webcit-ng/server/webserver.c | 6 +++--- 4 files changed, 9 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527560Tue, 15 Jul 2025 15:30:54 +05002099527560@Uncensored Date: Tue Jul 15 15:30:51 2025 -0400 It is regrettable that %m is a glibc extension but I seem to have no choice. ----------------------------------------------------------------------- Summary of changes: ctdlsalearn/src/main.c | 4 ++-- ctdlsalearn/src/sockets.c | 6 +++--- ctdlsh/sockets.c | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527463Mon, 14 Jul 2025 23:02:44 +05002099527463@Uncensored Date: Mon Jul 14 23:02:41 2025 -0400 Removed calls to the expression strerror(errno) and used the printf macro %m when possible. The former expression makes multithreaded code crash when running under podman because Red Hat is more interested in social justice than in actually producing code that works. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/crypto/serv_crypto.c | 4 +-- citadel/server/modules/ctdlproto/serv_file.c | 18 ++++++------ citadel/server/modules/expire/serv_expire.c | 2 +- citadel/server/msgbase.c | 2 +- citadel/utils/chkpw.c | 18 ++++++------ citadel/utils/citmail.c | 6 ++-- citadel/utils/ctdlload.c | 8 +++--- citadel/utils/loadtest.c | 2 +- citadel/utils/sendcommand.c | 6 ++-- citadel/utils/setup.c | 8 ++---- libcitadel/lib/libcitadel.h | 2 +- webcit-ng/server/ctdlclient.c | 4 +-- webcit/crypto.c | 4 +-- webcit/gettext.c | 2 +- webcit/html2html.c | 9 ++---- webcit/msg_renderers.c | 4 +-- webcit/sockets.c | 41 +++++++++++++--------------- webcit/static.c | 14 +++++----- webcit/subst.c | 9 ++---- webcit/sysdep.c | 18 ++++++------ webcit/webserver.c | 6 ++-- 21 files changed, 85 insertions(+), 102 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527456Mon, 14 Jul 2025 22:28:30 +05002099527456@Uncensored Date: Mon Jul 14 22:28:28 2025 -0400 I wonder if we can use %m safely here? ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_dirs.c | 9 +++------ citadel/server/locate_host.c | 2 +- citadel/server/modules/ctdlproto/serv_file.c | 4 ++-- 3 files changed, 6 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527444Mon, 14 Jul 2025 20:17:05 +05002099527444@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527443Mon, 14 Jul 2025 20:17:04 +05002099527443@Uncensored Date: Mon Jul 14 20:17:03 2025 -0400 Release version 1020 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/sysdep.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527442Mon, 14 Jul 2025 20:16:57 +05002099527442@Uncensored Date: Mon Jul 14 20:16:55 2025 -0400 cmd_oimg: removed calls to strerror(errno) to see if they fix this in podman ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/ctdlproto/serv_file.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527433Mon, 14 Jul 2025 19:35:40 +05002099527433@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099527432Mon, 14 Jul 2025 19:35:40 +05002099527432@Uncensored Date: Mon Jul 14 19:35:38 2025 -0400 Release version 1019 generated by do-release.sh commit e4be6f0bc93dd074c673a36aa186a9c09795fd24 Author: Art Cancro Date: Mon Jul 14 19:35:29 2025 -0400 more traces ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/ctdlproto/serv_file.c | 10 ++++++++++ citadel/server/sysdep.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 6 files changed, 15 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099526714Wed, 09 Jul 2025 10:28:29 +05002099526714@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099526713Wed, 09 Jul 2025 10:28:29 +05002099526713@Uncensored Date: Wed Jul 9 10:28:28 2025 -0400 Release version 1016 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: do-release.sh | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099526705Wed, 09 Jul 2025 10:26:26 +05002099526705@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099526704Wed, 09 Jul 2025 10:26:26 +05002099526704@Uncensored Date: Wed Jul 9 10:26:25 2025 -0400 Release version 1015 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099526611Tue, 08 Jul 2025 10:07:23 +05002099526611@Uncensored Date: Tue Jul 8 10:07:20 2025 -0400 Removed the attempt at sending offsets to addr2line because it is getting them wrong. ----------------------------------------------------------------------- Summary of changes: citadel/server/server_main.c | 6 ------ citadel/server/session.c | 37 ++++--------------------------------- citadel/server/sysdep_decls.h | 1 - webcit-ng/static/js/view_wiki.js | 35 ++++++++++++++++++++++++++++++++--- 4 files changed, 36 insertions(+), 43 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099526177Thu, 03 Jul 2025 22:33:12 +05002099526177@Uncensored Date: Thu Jul 3 22:33:10 2025 -0400 Generalized the CSS for mail editor screen and made it subclassable to mail editor and wiki editor. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 37 +++++++++++++++++++++++++++++++------ webcit-ng/static/js/view_mail.js | 5 +++-- webcit-ng/static/js/view_wiki.js | 23 ++++++++++++++++++++++- 3 files changed, 56 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099526161Thu, 03 Jul 2025 19:52:13 +05002099526161@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099526160Thu, 03 Jul 2025 19:52:12 +05002099526160@Uncensored Date: Thu Jul 3 19:52:12 2025 -0400 Release version 1014 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099526159Thu, 03 Jul 2025 19:52:01 +05002099526159@Uncensored Date: Thu Jul 3 19:51:59 2025 -0400 citserver: added undocumented -b switch to aid in backtrace ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/rssclient/serv_rssclient.c | 1 + citadel/server/server_main.c | 8 ++++++- citadel/server/session.c | 26 ++++++++++++++++++++++- citadel/server/sysdep_decls.h | 1 + 4 files changed, 34 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099525801Mon, 30 Jun 2025 19:07:57 +05002099525801@Uncensored Date: Mon Jun 30 19:07:53 2025 -0400 spooky scary skeletons for wiki history and edit screens ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_wiki.js | 38 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 36 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099525329Wed, 25 Jun 2025 23:25:16 +05002099525329@Uncensored Date: Wed Jun 25 23:25:13 2025 -0400 Added web api command to fetch a wiki page historu ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 2 ++ webcit-ng/server/forum_view.c | 6 +++--- webcit-ng/server/wiki_view.c | 40 +++++++++++++++++++++++++++++++++++++++- 3 files changed, 44 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099525326Wed, 25 Jun 2025 23:03:25 +05002099525326@Uncensored Date: Wed Jun 25 23:03:23 2025 -0400 Display wiki page name next to room name in banner ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/main.js | 2 +- webcit-ng/static/js/view_wiki.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099525223Tue, 24 Jun 2025 23:55:48 +05002099525223@Uncensored Date: Tue Jun 24 23:55:46 2025 -0400 stub function for message history ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 8 ++++++-- webcit-ng/server/webcit.h | 3 +++ webcit-ng/server/wiki_view.c | 8 ++++++++ 3 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 webcit-ng/server/wiki_view.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099524603Thu, 19 Jun 2025 20:06:41 +05002099524603@Uncensored Date: Thu Jun 19 20:06:38 2025 -0400 Shure is a manufacturer of microphones and other audio equipment. It is also a misspelling of 'sure'. Fixed. ----------------------------------------------------------------------- Summary of changes: webcit/po/webcit/ar.po | 4 ++-- webcit/po/webcit/bg.po | 2 +- webcit/po/webcit/cs.po | 4 ++-- webcit/po/webcit/da.po | 4 ++-- webcit/po/webcit/de.po | 4 ++-- webcit/po/webcit/el.po | 2 +- webcit/po/webcit/en_GB.po | 4 ++-- webcit/po/webcit/es.po | 4 ++-- webcit/po/webcit/et.po | 4 ++-- webcit/po/webcit/fi.po | 2 +- webcit/po/webcit/fr.po | 4 ++-- webcit/po/webcit/he.po | 4 ++-- webcit/po/webcit/hu.po | 4 ++-- webcit/po/webcit/it.po | 4 ++-- webcit/po/webcit/kk.po | 2 +- webcit/po/webcit/ko.po | 2 +- webcit/po/webcit/nl.po | 4 ++-- webcit/po/webcit/pl.po | 4 ++-- webcit/po/webcit/pt_BR.po | 4 ++-- webcit/po/webcit/ro.po | 4 ++-- webcit/po/webcit/ru.po | 4 ++-- webcit/po/webcit/sl.po | 2 +- webcit/po/webcit/sv.po | 2 +- webcit/po/webcit/tr.po | 2 +- webcit/po/webcit/webcit.pot | 2 +- webcit/po/webcit/zh.po | 4 ++-- webcit/preferences.c | 2 +- webcit/roomlist.c | 2 +- webcit/roomtokens.c | 2 +- webcit/roomviews.c | 2 +- webcit/static/t/edit/message/attachments_pane.html | 2 +- webcit/subst.h | 2 +- 32 files changed, 49 insertions(+), 49 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099524369Tue, 17 Jun 2025 14:10:21 +05002099524369@Uncensored Date: Tue Jun 17 14:10:19 2025 -0400 Loving these assignable buttons ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_wiki.js | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099524248Mon, 16 Jun 2025 17:30:51 +05002099524248@Uncensored Date: Mon Jun 16 17:30:48 2025 -0400 Migrated the Enter and Delete buttons to assignable. No more dispatchers. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 2 +- webcit-ng/static/js/view_mail.js | 11 +++++------ webcit-ng/static/js/view_wiki.js | 18 ++++++++---------- webcit-ng/static/js/views.js | 14 +------------- 4 files changed, 15 insertions(+), 30 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099524237Mon, 16 Jun 2025 15:01:44 +05002099524237@Uncensored Date: Mon Jun 16 15:01:42 2025 -0400 New pattern: top nav buttons now begin life as dumb, poorly labeled, and ASSIGNABLE. views.js will hide and deactivate all buttons. Individual modules' renderers will assign labels and actions. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 3 +- webcit-ng/static/js/view_forum.js | 23 ++++++++------- webcit-ng/static/js/view_mail.js | 62 ++++++++++++++++++++------------------- webcit-ng/static/js/views.js | 22 +++----------- 4 files changed, 50 insertions(+), 60 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099524058Fri, 13 Jun 2025 21:23:47 +05002099524058@Uncensored Date: Fri Jun 13 21:23:42 2025 -0400 Adding user1/user2/user3 buttons to the banner with the intent of them being assignable commit aedc8797e6b060e19d8d4e348aa8919afe2df45e Author: Art Cancro Date: Fri Jun 13 20:12:23 2025 -0400 webcit-ng: handle wiki links more robustly ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 1 + webcit-ng/static/index.html | 5 ++++- webcit-ng/static/js/calendar_edit.js | 10 ++------- webcit-ng/static/js/main.js | 19 +++++++++++++++- webcit-ng/static/js/view_calendar.js | 4 ++-- webcit-ng/static/js/view_wiki.js | 43 ++++++++++++++++++++++++------------ webcit-ng/static/js/views.js | 14 ++++++++++-- webcit/po/webcit/ar.po | 2 +- webcit/po/webcit/bg.po | 2 +- webcit/po/webcit/cs.po | 2 +- webcit/po/webcit/da.po | 2 +- webcit/po/webcit/de.po | 2 +- webcit/po/webcit/el.po | 2 +- webcit/po/webcit/en_GB.po | 2 +- webcit/po/webcit/es.po | 2 +- webcit/po/webcit/et.po | 2 +- webcit/po/webcit/fi.po | 2 +- webcit/po/webcit/fr.po | 2 +- webcit/po/webcit/he.po | 2 +- webcit/po/webcit/hu.po | 2 +- webcit/po/webcit/it.po | 2 +- webcit/po/webcit/kk.po | 2 +- webcit/po/webcit/ko.po | 2 +- webcit/po/webcit/nl.po | 2 +- webcit/po/webcit/pl.po | 2 +- webcit/po/webcit/pt_BR.po | 2 +- webcit/po/webcit/ro.po | 2 +- webcit/po/webcit/ru.po | 2 +- webcit/po/webcit/sl.po | 2 +- webcit/po/webcit/sv.po | 2 +- webcit/po/webcit/tr.po | 2 +- webcit/po/webcit/webcit.pot | 2 +- webcit/po/webcit/zh.po | 2 +- 33 files changed, 94 insertions(+), 54 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099523746Tue, 10 Jun 2025 23:14:42 +05002099523746@Uncensored Date: Tue Jun 10 23:14:40 2025 -0400 view_wiki.js: basic wiki page display and navigation is working. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 4 ++++ webcit-ng/static/js/view_wiki.js | 40 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 43 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099523606Mon, 09 Jun 2025 15:05:36 +05002099523606@Uncensored Date: Mon Jun 9 15:05:33 2025 -0400 webcit-ng: renamed Makefile to GNUmakefile to reflect the fact that we do require gmake. We're heavily using gmake features such as wildcards and pattern substitutions. We still believe that the operating system is called Linux, not GNU/Linux, and we still believe that Richard Stallman is a far-left communist asshole. However, we like gmake and gcc. ----------------------------------------------------------------------- Summary of changes: webcit-ng/{Makefile => GNUmakefile} | 2 +- webcit-ng/README.md | 5 +++++ webcit-ng/static/index.html | 5 ++--- 3 files changed, 8 insertions(+), 4 deletions(-) rename webcit-ng/{Makefile => GNUmakefile} (83%) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099523244Thu, 05 Jun 2025 11:44:08 +05002099523244@Uncensored Date: Thu Jun 5 11:44:00 2025 -0400 serv_wiki.c: new subcommand 'showrev' to simply output a specific version of a specific page, instead of having to temporarily stuff it into an ephemeral message in an ephemeral room. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 43 +++++++++++++++++---------------- citadel/server/msgbase.c | 4 +-- webcit-ng/static/js/view_wiki.js | 7 +++++- 3 files changed, 30 insertions(+), 24 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522841Mon, 02 Jun 2025 17:04:56 +05002099522841@Uncensored Date: Mon Jun 2 17:04:54 2025 -0400 webcit-ng server: allow message fetch by EUID in Wiki rooms ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 1 + webcit-ng/static/index.html | 5 +++-- webcit-ng/static/js/view_wiki.js | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522723Sun, 01 Jun 2025 20:05:24 +05002099522723@Uncensored Date: Sun Jun 1 20:05:22 2025 -0400 Reused the forum list page as a wiki list page (for now?) ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 4 ++-- webcit-ng/static/js/roomlist.js | 8 ++++---- webcit-ng/static/js/{view_contacts.js => view_wiki.js} | 6 +++--- webcit-ng/static/js/views.js | 3 +-- 4 files changed, 10 insertions(+), 11 deletions(-) copy webcit-ng/static/js/{view_contacts.js => view_wiki.js} (53%) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522644Sat, 31 May 2025 17:37:46 +05002099522644@Uncensored Date: Sat May 31 17:37:43 2025 -0400 webcit-classic: disable the nonworking 'publish to blog' button ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 17 ++++++----------- webcit/static/t/navbar.html | 8 -------- 2 files changed, 6 insertions(+), 19 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522465Fri, 30 May 2025 01:11:03 +05002099522465@Uncensored

Well that was fun.

I never liked the fact that Citadel's wiki module required shell calls to diff(1) and patch(1) to create and retrieve wiki version history.  About a year ago I noticed that libxdiff exists and can do the same thing.  Since I decided that the Wiki module is going to be the next thing I work on in WebCit-NG, it followed that now is the time to make that change.  It took about a week, including a lot of failed experiments with "newer" versions of the library, but in the end I got what I wanted.

I have to admit I'm rather proud of the format we use to store the history.  We keep a named history document, store it in MIME multipart, and each part is a diff containing the changes required to roll a document back to the previous revision.  The "filename" contains metadata for that version.  So to get any version, you start with the current version, then go through each part running the patches until you get to the revision you want, then stop.

And now it's fast!  And of course more secure since there's no way someone can sneak in with a shell or filesystem vulnerability.  All that's left to do now is expose it using REST semantics.  I'm thinking about using the version control stuff in DAV from RFC3253 ... but damn I'd have to handle all of that XML crap again.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522456Thu, 29 May 2025 22:28:15 +05002099522456@Uncensored Date: Thu May 29 22:28:12 2025 -0400 This is it! Diff and patch are now completely handled in-program using libxdiff. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 76 ++++++++++++++++++--------------- citadel/tests/xdifftester/xdifftest.c | 5 ++- 2 files changed, 45 insertions(+), 36 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522447Thu, 29 May 2025 20:06:16 +05002099522447@Uncensored Date: Thu May 29 20:06:14 2025 -0400 xdifftest: added patch code and comparison test ----------------------------------------------------------------------- Summary of changes: citadel/tests/xdifftester/xdifftest.c | 42 +++++++++++++++++++++++++++++++---- 1 file changed, 38 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522442Thu, 29 May 2025 19:06:41 +05002099522442@Uncensored Date: Thu May 29 19:06:35 2025 -0400 Switched to the original libxdiff-0.23 because libgit2/libxdiff doesn't have a patch function. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 105 +-- citadel/server/modules/xdiff/COPYING | 18 - citadel/server/modules/xdiff/README.md | 25 - citadel/server/modules/xdiff/README.txt | 6 + citadel/server/modules/xdiff/git-2.48.1.patch | 240 ------- citadel/server/modules/xdiff/git-xdiff.h | 79 --- citadel/server/modules/xdiff/xadler32.c | 70 ++ .../modules/xdiff/{xprepare.h => xadler32.h} | 16 +- .../server/modules/xdiff/{xprepare.h => xalloc.c} | 35 +- citadel/server/modules/xdiff/xbdiff.c | 315 +++++++++ .../server/modules/xdiff/{xprepare.h => xbdiff.h} | 22 +- citadel/server/modules/xdiff/xbpatchi.c | 336 +++++++++ citadel/server/modules/xdiff/xdiff.h | 135 ++-- citadel/server/modules/xdiff/xdiffi.c | 786 ++++----------------- citadel/server/modules/xdiff/xdiffi.h | 10 +- citadel/server/modules/xdiff/xemit.c | 232 +----- citadel/server/modules/xdiff/xemit.h | 8 +- citadel/server/modules/xdiff/xhistogram.c | 370 ---------- citadel/server/modules/xdiff/xinclude.h | 16 +- citadel/server/modules/xdiff/xmacros.h | 40 +- citadel/server/modules/xdiff/xmerge.c | 739 ------------------- citadel/server/modules/xdiff/xmerge3.c | 66 ++ citadel/server/modules/xdiff/xpatchi.c | 641 +++++++++++++++++ citadel/server/modules/xdiff/xpatience.c | 373 ---------- citadel/server/modules/xdiff/xprepare.c | 321 +++++---- citadel/server/modules/xdiff/xprepare.h | 5 +- citadel/server/modules/xdiff/xrabdiff.c | 381 ++++++++++ citadel/server/modules/xdiff/xrabply.c | 298 ++++++++ citadel/server/modules/xdiff/xtypes.h | 5 +- citadel/server/modules/xdiff/xutils.c | 635 ++++++++++------- citadel/server/modules/xdiff/xutils.h | 23 +- citadel/server/user_ops.c | 2 +- citadel/tests/xdifftester/Makefile | 2 +- citadel/tests/xdifftester/xdifftest.c | 127 ++-- 34 files changed, 3077 insertions(+), 3405 deletions(-) delete mode 100644 citadel/server/modules/xdiff/COPYING delete mode 100644 citadel/server/modules/xdiff/README.md create mode 100644 citadel/server/modules/xdiff/README.txt delete mode 100644 citadel/server/modules/xdiff/git-2.48.1.patch delete mode 100644 citadel/server/modules/xdiff/git-xdiff.h create mode 100644 citadel/server/modules/xdiff/xadler32.c copy citadel/server/modules/xdiff/{xprepare.h => xadler32.h} (69%) copy citadel/server/modules/xdiff/{xprepare.h => xalloc.c} (52%) create mode 100644 citadel/server/modules/xdiff/xbdiff.c copy citadel/server/modules/xdiff/{xprepare.h => xbdiff.h} (62%) create mode 100644 citadel/server/modules/xdiff/xbpatchi.c delete mode 100644 citadel/server/modules/xdiff/xhistogram.c delete mode 100644 citadel/server/modules/xdiff/xmerge.c create mode 100644 citadel/server/modules/xdiff/xmerge3.c create mode 100644 citadel/server/modules/xdiff/xpatchi.c delete mode 100644 citadel/server/modules/xdiff/xpatience.c create mode 100644 citadel/server/modules/xdiff/xrabdiff.c create mode 100644 citadel/server/modules/xdiff/xrabply.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522271Wed, 28 May 2025 17:14:46 +05002099522271@Uncensored Date: Wed May 28 17:14:36 2025 -0400 xdifftest: modified to test xdl_patch, only to find out that this version of libxdiff doesn't have it anymore! ----------------------------------------------------------------------- Summary of changes: citadel/tests/xdifftester/xdifftest.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522267Wed, 28 May 2025 16:57:27 +05002099522267@Uncensored Date: Wed May 28 16:57:24 2025 -0400 xdifftest: added in-tree ----------------------------------------------------------------------- Summary of changes: citadel/tests/xdifftester/Makefile | 2 + citadel/tests/xdifftester/README.md | 10 +++++ citadel/tests/xdifftester/xdifftest.c | 81 +++++++++++++++++++++++++++++++++++ 3 files changed, 93 insertions(+) create mode 100644 citadel/tests/xdifftester/Makefile create mode 100644 citadel/tests/xdifftester/README.md create mode 100644 citadel/tests/xdifftester/xdifftest.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522213Wed, 28 May 2025 11:33:23 +05002099522213@Uncensored Date: Wed May 28 11:28:51 2025 -0400 Write to the patch pipe using a single call to fwrite(). I have realized that over the years I've given a strong preference to handling data line by line when I should just be performing operations on big buffers. This is likely a carryover from the old days when we didn't have enough memory for big buffers. In this particular case it doesn't matter that much because the code in question is about to be replaced entirely. But it's an exercise in doing things The Right Way (tm). ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522145Tue, 27 May 2025 23:09:03 +05002099522145@Uncensored Date: Tue May 27 23:09:00 2025 -0400 serv_wiki.c: fetch/revert history now sends a CtdlMessage to the callback; tempfile is created/destroyed inside the callback. This puts us into position for changing the callback to patch using libxdiff instead of a temporary file and the patch command. Almost there! ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 144 +++++++++++++++----------------- 1 file changed, 68 insertions(+), 76 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522139Tue, 27 May 2025 22:10:29 +05002099522139@Uncensored Date: Tue May 27 22:10:27 2025 -0400 serv_wiki.c: separated current, history, and synthetic msg and msgnum into different variables. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 87 +++++++++++++++++---------------- 1 file changed, 44 insertions(+), 43 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099522074Tue, 27 May 2025 14:31:47 +05002099522074@Uncensored Date: Tue May 27 14:31:45 2025 -0400 cosmetic changes ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521954Mon, 26 May 2025 21:37:27 +05002099521954@Uncensored Date: Mon May 26 21:37:25 2025 -0400 Wiki history, show rev, and revert to rev are working again. No changes were made to the client protocol, so WebCit (classic) still works as-is without modification. This version still uses the 'patch' command, but it no longer has to play around with pseudo-filenames since those are no longer included in the diffs. The next version of this will use libxdiff to patch. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521949Mon, 26 May 2025 21:02:40 +05002099521949@Uncensored Date: Mon May 26 21:02:38 2025 -0400 Fix bug which would refuse to save a brand new wiki page ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521944Mon, 26 May 2025 20:44:18 +05002099521944@Uncensored Date: Mon May 26 20:44:15 2025 -0400 Completed the generation of wiki page history using libxdiff. We are using the version of libxdiff from the libgit2 project, which is extremely well maintained. Other unfortunate bits of code have been rewritten so that we can deal with missing or corrupted histories as well. commit 9e311435d8641d0d8a5c9439f0f5a988e81e7909 Author: Art Cancro Date: Mon May 26 14:39:37 2025 -0400 This commit merges libxdiff from libgit2 into Citadel. It is included UNMODIFIED so that it can be upgraded later. This will be used to replace shell calls to 'diff' and 'patch' in the wiki module. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 161 ++-- citadel/server/modules/xdiff/COPYING | 18 + citadel/server/modules/xdiff/README.md | 25 + citadel/server/modules/xdiff/git-2.48.1.patch | 240 ++++++ citadel/server/modules/xdiff/git-xdiff.h | 79 ++ citadel/server/modules/xdiff/xdiff.h | 150 ++++ citadel/server/modules/xdiff/xdiffi.c | 1090 +++++++++++++++++++++++++ citadel/server/modules/xdiff/xdiffi.h | 62 ++ citadel/server/modules/xdiff/xemit.c | 330 ++++++++ citadel/server/modules/xdiff/xemit.h | 36 + citadel/server/modules/xdiff/xhistogram.c | 370 +++++++++ citadel/server/modules/xdiff/xinclude.h | 39 + citadel/server/modules/xdiff/xmacros.h | 71 ++ citadel/server/modules/xdiff/xmerge.c | 739 +++++++++++++++++ citadel/server/modules/xdiff/xpatience.c | 373 +++++++++ citadel/server/modules/xdiff/xprepare.c | 461 +++++++++++ citadel/server/modules/xdiff/xprepare.h | 34 + citadel/server/modules/xdiff/xtypes.h | 67 ++ citadel/server/modules/xdiff/xutils.c | 451 ++++++++++ citadel/server/modules/xdiff/xutils.h | 48 ++ 20 files changed, 4764 insertions(+), 80 deletions(-) create mode 100644 citadel/server/modules/xdiff/COPYING create mode 100644 citadel/server/modules/xdiff/README.md create mode 100644 citadel/server/modules/xdiff/git-2.48.1.patch create mode 100644 citadel/server/modules/xdiff/git-xdiff.h create mode 100644 citadel/server/modules/xdiff/xdiff.h create mode 100644 citadel/server/modules/xdiff/xdiffi.c create mode 100644 citadel/server/modules/xdiff/xdiffi.h create mode 100644 citadel/server/modules/xdiff/xemit.c create mode 100644 citadel/server/modules/xdiff/xemit.h create mode 100644 citadel/server/modules/xdiff/xhistogram.c create mode 100644 citadel/server/modules/xdiff/xinclude.h create mode 100644 citadel/server/modules/xdiff/xmacros.h create mode 100644 citadel/server/modules/xdiff/xmerge.c create mode 100644 citadel/server/modules/xdiff/xpatience.c create mode 100644 citadel/server/modules/xdiff/xprepare.c create mode 100644 citadel/server/modules/xdiff/xprepare.h create mode 100644 citadel/server/modules/xdiff/xtypes.h create mode 100644 citadel/server/modules/xdiff/xutils.c create mode 100644 citadel/server/modules/xdiff/xutils.h -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521755Sat, 24 May 2025 20:37:45 +05002099521755@Uncensored Date: Sat May 24 20:37:43 2025 -0400 serv_wiki.c: encode the null terminator as part of the synthetic filename. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521612Fri, 23 May 2025 11:50:52 +05002099521612@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521611Fri, 23 May 2025 11:50:51 +05002099521611@Uncensored Date: Fri May 23 11:50:50 2025 -0400 Release version 1013 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521610Fri, 23 May 2025 11:50:38 +05002099521610@Uncensored Date: Fri May 23 11:50:36 2025 -0400 Troubleshooting for a user who is getting crashes during a simple 'MESG hello' command. Added more logging, changed cprintf() to call va_end() sooner, and removed the strerror output from the MESG command. Dunno if any of this will work but it might produce more data. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/ctdlproto/serv_file.c | 3 ++- citadel/server/serversocket.c | 12 ++++++------ 2 files changed, 8 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521510Thu, 22 May 2025 23:34:10 +05002099521510@Uncensored

I got a coredump from endtls() in citadel/server/modules/crypto/serv_crypto.c.  It coredumped while freeing memory in SSL_free(CC->ssl).  I have only seen it once.

The only thing I can find that is suspect is the call to SSL_shutdown() before it.  The code does not check the return codes for either of the calls, but reading the docs on SSL_shutdown(), sometimes you need to call it twice if it does not return zero the first time.  Can someone who knows SSL take a look at the code and verify what the logic should be.  I do not want to change something and break it.

After a lot of hunting I couldn't find anything either.  But I do agree with your observation that we need to call SSL_shutdown() again if it asks for that.  So I added it.

I also added some code to print a stack trace to the syslog if the server crashes on sigsegv.  Hopefully that will help a bunch of people.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521509Thu, 22 May 2025 23:32:53 +05002099521509@Uncensored Date: Thu May 22 23:32:51 2025 -0400 Call SSL_shutdown() again if it returns 0, as per the instructions ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/crypto/serv_crypto.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521505Thu, 22 May 2025 23:03:01 +05002099521505@Uncensored Date: Thu May 22 23:02:57 2025 -0400 citserver now writes a stack trace to syslog when sigsegv is caught commit 8a5f80a0490d8cfe7339321c02172ce6a05624bf Author: Art Cancro Date: Thu May 22 18:23:42 2025 -0400 citserver is always dumpable. ----------------------------------------------------------------------- Summary of changes: citadel/server/server_main.c | 5 +- citadel/server/session.c | 118 +++++++++++++++++++++++++++++++------------ 2 files changed, 87 insertions(+), 36 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521416Thu, 22 May 2025 10:59:36 +05002099521416@Uncensored Date: Thu May 22 10:59:34 2025 -0400 sysdep.c: renamed to session.c ----------------------------------------------------------------------- Summary of changes: citadel/server/{sysdep.c => session.c} | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) rename citadel/server/{sysdep.c => session.c} (99%) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521414Thu, 22 May 2025 10:57:00 +05002099521414@Uncensored Date: Thu May 22 10:56:57 2025 -0400 Server network functions moved out of sysdep.c and into new serversocket.c ----------------------------------------------------------------------- Summary of changes: citadel/server/serversocket.c | 482 ++++++++++++++++++++++++++++++++++++++++++ citadel/server/sysdep.c | 469 ++-------------------------------------- 2 files changed, 498 insertions(+), 453 deletions(-) create mode 100644 citadel/server/serversocket.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521402Thu, 22 May 2025 10:05:32 +05002099521402@UncensoredI got a coredump from endtls() in >citadel/server/modules/crypto/serv_crypto.c.  It coredumped while >freeing memory in SSL_free(CC->ssl).  I have only seen it once. Interesting. I'll have a look. I wonder if we can figure out the conditions to make that happen. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521353Wed, 21 May 2025 23:39:16 +05002099521353@Uncensored Date: Wed May 21 23:39:13 2025 -0400 Went back to the old metadata format because our MIME parser doesn't extract those other fields. History is working but show-version is generating a few errors. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521350Wed, 21 May 2025 23:21:29 +05002099521350@Uncensored Date: Wed May 21 23:17:26 2025 -0400 I typed "=" instead of "==" in 2009 and wiki history has been broken ever since. :( How did this mistake persist for 16 years with no one noticing? Or did it break some other time later and the first mistake caused it? I have no idea, but no one (including me) noticed that wiki history wasn't working. Or maybe I wasn't paying attention. Anyway, it's still broken, because I'm rewriting the code and history format. commit 85eb97950b15390c59696723fda925ae2c10c63d Author: Art Cancro Date: Mon May 19 13:28:49 2025 -0400 There was no excuse for capitalizing that variable name. Fixed. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 356 ++++++++++++++++---------------- citadel/server/msgbase.c | 26 +-- webcit-ng/server/messages.c | 10 +- 3 files changed, 202 insertions(+), 190 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099521199Tue, 20 May 2025 19:41:43 +05002099521199@Uncensored

I got a coredump from endtls() in citadel/server/modules/crypto/serv_crypto.c.  It coredumped while freeing memory in SSL_free(CC->ssl).  I have only seen it once.

The only thing I can find that is suspect is the call to SSL_shutdown() before it.  The code does not check the return codes for either of the calls, but reading the docs on SSL_shutdown(), sometimes you need to call it twice if it does not return zero the first time.  Can someone who knows SSL take a look at the code and verify what the logic should be.  I do not want to change something and break it.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520676Fri, 16 May 2025 10:24:41 +05002099520676@Uncensored Date: Fri May 16 10:24:36 2025 -0400 Someday I'll rewrite the text client completely. This is not that day. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 10 +++++---- textclient/commands.c | 53 +++++++++++++++++++++++++-------------------- webcit-ng/static/js/util.js | 2 +- 3 files changed, 36 insertions(+), 29 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520633Thu, 15 May 2025 23:20:55 +05002099520633@Uncensored Date: Thu May 15 23:20:53 2025 -0400 Got the pop3client delete working. This COMPLETES THE ROOM EDITING AND CONFIGURATION SCREENS! That took WAY too long but I can finally move on to another part of the system. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520629Thu, 15 May 2025 22:46:32 +05002099520629@Uncensored Date: Thu May 15 22:46:30 2025 -0400 Fixed screen overflow on lower resolution displays when a table is inserted inside a formgrid. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 40 +++++++++++++++++++++++++++++++++------- webcit-ng/static/js/edit_room.js | 10 +++++----- 2 files changed, 38 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520616Thu, 15 May 2025 19:10:47 +05002099520616@Uncensored Date: Thu May 15 19:10:45 2025 -0400 Improved version of escapeJS() ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/util.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520609Thu, 15 May 2025 18:32:41 +05002099520609@Uncensored Date: Thu May 15 18:32:39 2025 -0400 Completed pop3client add/remove ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/netconfig.c | 9 ++++-- webcit-ng/static/js/edit_room.js | 65 ++++++++++++++++++++++++++++++---------- 2 files changed, 57 insertions(+), 17 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520601Thu, 15 May 2025 16:27:44 +05002099520601@Uncensored Date: Thu May 15 16:27:41 2025 -0400 Validate inputs and handle edge cases ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/netconfig.c | 54 ++++++++++++++++++++------------------------ 1 file changed, 25 insertions(+), 29 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520589Thu, 15 May 2025 15:08:57 +05002099520589@Uncensored Date: Thu May 15 15:08:55 2025 -0400 pop3 add client logic and ui completed ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/netconfig.c | 42 +++++++++++++++++++++++++++++++++++++++ webcit-ng/server/room_functions.c | 5 +++-- webcit-ng/server/webcit.h | 1 + webcit-ng/static/js/edit_room.js | 10 +++++----- 4 files changed, 51 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520578Thu, 15 May 2025 13:38:32 +05002099520578@Uncensored Date: Thu May 15 13:38:30 2025 -0400 Moved netconfig functions to separate file. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/netconfig.c | 179 ++++++++++++++++++++++++++++++++++++++ webcit-ng/server/room_functions.c | 160 ---------------------------------- webcit-ng/server/webcit.h | 3 + 3 files changed, 182 insertions(+), 160 deletions(-) create mode 100644 webcit-ng/server/netconfig.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520469Wed, 14 May 2025 15:46:53 +05002099520469@Uncensored Date: Wed May 14 15:46:50 2025 -0400 modify_netconfig_item() split into two functions so we can reuse part of it ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 67 +++++++++++++++++++++++---------------- 1 file changed, 40 insertions(+), 27 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520458Wed, 14 May 2025 14:49:54 +05002099520458@Uncensored Date: Wed May 14 14:49:52 2025 -0400 add pop3: completed client side of dialog ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 6 +++++- webcit-ng/static/js/edit_room.js | 37 +++++++++++++++++++++++++++++++++++-- 2 files changed, 40 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520442Wed, 14 May 2025 14:13:55 +05002099520442@Uncensored Date: Wed May 14 14:13:51 2025 -0400 Tidied up the look of the pop3client panel ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520365Tue, 13 May 2025 23:46:32 +05002099520365@Uncensored Date: Tue May 13 23:46:30 2025 -0400 render pop3client panel. wanna get this screen finished so I can move on to some other part of the system. ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 1 + webcit-ng/static/css/webcit.css | 1 - webcit-ng/static/js/edit_room.js | 89 ++++++++++++++++++++++++++++++---------- 3 files changed, 68 insertions(+), 23 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520355Tue, 13 May 2025 21:48:30 +05002099520355@Uncensored Date: Tue May 13 21:48:05 2025 -0400 ctdl-msg-header-buttons: add 1px top padding to keep the button from getting cut off ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 2 ++ 1 file changed, 2 insertions(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520354Tue, 13 May 2025 21:41:33 +05002099520354@Uncensored Date: Tue May 13 21:41:30 2025 -0400 test render for pop3client ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 5 +++++ webcit-ng/static/js/edit_room.js | 13 +++++++++++++ 2 files changed, 18 insertions(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520343Tue, 13 May 2025 19:12:40 +05002099520343@Uncensored Date: Tue May 13 19:12:38 2025 -0400 json_get_netconfig_item() can now handle multiple fields as a value. If supplied with field names, it will tokenize and output JSON dictionary. ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 7 +++++++ webcit-ng/server/room_functions.c | 35 +++++++++++++++++++++++++++-------- 2 files changed, 34 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520339Tue, 13 May 2025 18:33:35 +05002099520339@Uncensored Date: Tue May 13 18:33:32 2025 -0400 lingering_close() is no longer used, removed it ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/tcp_sockets.c | 36 ------------------------------------ webcit-ng/server/webcit.h | 1 - 2 files changed, 37 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520213Mon, 12 May 2025 14:58:31 +05002099520213@Uncensored Date: Mon May 12 14:58:29 2025 -0400 Removed ShutDownLibCitadel() and its friends. ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/libcitadel.c | 8 +--- libcitadel/lib/libcitadel.h | 1 - libcitadel/lib/libcitadellocal.h | 1 - libcitadel/lib/mime_parser.c | 99 ++++++++++++++-------------------------- webcit/sysdep.c | 1 - webcit/webserver.c | 1 - 6 files changed, 35 insertions(+), 76 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520203Mon, 12 May 2025 13:35:17 +05002099520203@Uncensored Date: Mon May 12 13:35:13 2025 -0400 The auto-generated code didn't handle UTF-8 source strings properly. Imagine that, there is no silver bullet. Tried again with better prompts and hand-modified the generated code to match surrounding code. ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/json.c | 96 ++++++++++++++++++++++++++----------------- webcit-ng/server/forum_view.c | 6 +-- 2 files changed, 61 insertions(+), 41 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520195Mon, 12 May 2025 11:57:04 +05002099520195@Uncensored Date: Mon May 12 11:56:53 2025 -0400 libcitadel: modified how we JSON-encode strings with high characters. Yes, I used Grok to generate the code for me. Not sure how I feel about that. ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/json.c | 51 +++++++++++++++++++++++++++++++------------ webcit-ng/README.md | 5 +++++ webcit-ng/server/forum_view.c | 6 +++++ 3 files changed, 48 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099520051Sat, 10 May 2025 16:56:53 +05002099520051@Uncensored Date: Sat May 10 16:56:33 2025 -0400 Fixed freeing signature buffer with OPENSSL_free() rather than free() since signature was allocated with OPENSSL_malloc(). ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/smtp/dkim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519879Thu, 08 May 2025 21:49:06 +05002099519879@Uncensored Date: Thu May 8 21:49:03 2025 -0400 random cleanup commit f15309e068d9b7dce482523450a10be7517a8756 Author: Art Cancro Date: Thu May 8 14:43:43 2025 -0400 strip_trailing_delimiters() - rewrote in a way that is easier to read. ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/stringbuf.c | 22 ++++++++++++++-------- textclient/file_transfer.c | 15 +++++++++++---- textclient/utilfunc.c | 2 +- webcit-ng/server/room_functions.c | 14 +++++++------- 4 files changed, 33 insertions(+), 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519748Wed, 07 May 2025 23:41:56 +05002099519748@Uncensored Date: Wed May 7 23:41:53 2025 -0400 modify_netconfig_item() now also handles values containing multiple fields. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519745Wed, 07 May 2025 23:26:43 +05002099519745@Uncensored Date: Wed May 7 23:26:39 2025 -0400 json_get_netconfig_item() now considers the key to be everything before the first delimiter, and the value to be everything after the first delimiter, including all subsequent delimiters. Trailing delimiters are removed, so if the value is only one field, that's all you get. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 40 +++++++++++++++++++++++++++++++++------ 1 file changed, 34 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519610Tue, 06 May 2025 23:35:09 +05002099519610@Uncensored Date: Tue May 6 23:35:07 2025 -0400 DRY the listbox populate/add/remove functions, use them for RSS feeds in addition to mailing list recipients. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 118 ++++++++++++++++++++++++++++++--------- 1 file changed, 93 insertions(+), 25 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519600Tue, 06 May 2025 22:18:07 +05002099519600@Uncensored Date: Tue May 6 22:18:05 2025 -0400 The whole config-key thing (particularly in netconfigs) fix some details and update docs ----------------------------------------------------------------------- Summary of changes: citadel/docs/databaselayout.md | 30 +++++++++++++++++------------- citadel/docs/netconfigs.txt | 27 +++++++++++++-------------- citadel/docs/views.md | 31 ++++++++++++++----------------- webcit-ng/server/room_functions.c | 12 ++++++------ 4 files changed, 50 insertions(+), 50 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519447Tue, 06 May 2025 00:23:16 +05002099519447@Uncensored Date: Tue May 6 00:23:13 2025 -0400 room_functions.c: genericize the netconfig list/add/remove ops. We were using them for mailing list recipients, but with a bit of DRY strategy they can also be used for RSS feeds. ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 9 +++++- webcit-ng/server/room_functions.c | 62 +++++++++++++++++++++++++++------------ webcit-ng/static/js/edit_room.js | 44 +++++++++++++++++++++++---- 3 files changed, 89 insertions(+), 26 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519306Sun, 04 May 2025 23:41:54 +05002099519306@Uncensored Date: Sun May 4 23:41:52 2025 -0400 webcit-ng: completed the mailing list sub/unsub admin UI. Also continued the changeover to SPDX license identifiers. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 7 +++---- webcit-ng/static/js/caldav_client.js | 6 ++---- webcit-ng/static/js/calendar_edit.js | 2 +- webcit-ng/static/js/defs.js | 4 +--- webcit-ng/static/js/edit_room.js | 35 +++++++++++++++++++++++++++++---- webcit-ng/static/js/login.js | 4 +--- webcit-ng/static/js/mail_folder_list.js | 2 +- webcit-ng/static/js/main.js | 2 +- webcit-ng/static/js/roomlist.js | 2 +- webcit-ng/static/js/upload.js | 2 +- webcit-ng/static/js/user_profile.js | 2 +- webcit-ng/static/js/util.js | 2 +- webcit-ng/static/js/view_calendar.js | 2 +- webcit-ng/static/js/view_contacts.js | 2 +- webcit-ng/static/js/view_forum.js | 2 +- webcit-ng/static/js/view_mail.js | 2 +- webcit-ng/static/js/views.js | 4 ++-- 17 files changed, 51 insertions(+), 31 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519112Sat, 03 May 2025 22:33:16 +05002099519112@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519111Sat, 03 May 2025 22:33:15 +05002099519111@Uncensored Date: Sat May 3 22:33:15 2025 -0400 Release version 1012 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099519110Sat, 03 May 2025 22:33:08 +05002099519110@Uncensored Date: Sat May 3 22:33:05 2025 -0400 cmd_lsub: reject empty or invalid email addresses. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/listsub/serv_listsub.c | 15 ++++++++++++++- libcitadel/lib/tools.c | 24 +++++++++++++----------- 2 files changed, 27 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518939Fri, 02 May 2025 13:42:03 +05002099518939@Uncensored Date: Fri May 2 13:42:01 2025 -0400 All license declarations are now in SPDX format. ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 2 +- citadel/server/backends/berkeley_db/berkeley_db.h | 2 +- citadel/server/backends/common/database.c | 2 +- citadel/server/citadel_dirs.c | 2 +- citadel/server/citadel_dirs.h | 2 +- citadel/server/citadel_ldap.h | 2 +- citadel/server/citserver.c | 2 +- citadel/server/citserver.h | 2 +- citadel/server/clientsocket.c | 2 +- citadel/server/clientsocket.h | 2 +- citadel/server/config.c | 2 +- citadel/server/config.h | 2 +- citadel/server/context.c | 2 +- citadel/server/control.c | 2 +- citadel/server/control.h | 2 +- citadel/server/ctdl_module.h | 2 +- citadel/server/database.h | 2 +- citadel/server/default_timezone.c | 2 +- citadel/server/domain.c | 2 +- citadel/server/domain.h | 2 +- citadel/server/euidindex.c | 2 +- citadel/server/genstamp.c | 2 +- citadel/server/housekeeping.c | 2 +- citadel/server/internet_addressing.c | 2 +- citadel/server/journaling.c | 2 +- citadel/server/ldap.c | 2 +- citadel/server/locate_host.c | 2 +- citadel/server/locate_host.h | 2 +- citadel/server/makeuserkey.c | 2 +- citadel/server/modules/autocompletion/serv_autocompletion.c | 2 +- citadel/server/modules/autocompletion/serv_autocompletion.h | 2 +- citadel/server/modules/bio/serv_bio.c | 2 +- citadel/server/modules/blog/serv_blog.c | 2 +- citadel/server/modules/calendar/ical_ctdl_is_overlap.c | 2 +- citadel/server/modules/calendar/serv_calendar.c | 2 +- citadel/server/modules/calendar/serv_calendar.h | 2 +- citadel/server/modules/checkpoint/serv_checkpoint.c | 2 +- citadel/server/modules/clamav/serv_virus.c | 2 +- citadel/server/modules/crypto/serv_crypto.c | 2 +- citadel/server/modules/ctdlproto/serv_ctdlproto.c | 2 +- citadel/server/modules/ctdlproto/serv_file.c | 2 +- citadel/server/modules/ctdlproto/serv_messages.c | 2 +- citadel/server/modules/ctdlproto/serv_rooms.c | 2 +- citadel/server/modules/ctdlproto/serv_session.c | 2 +- citadel/server/modules/ctdlproto/serv_syscmds.c | 2 +- citadel/server/modules/ctdlproto/serv_user.c | 2 +- citadel/server/modules/expire/expire_policy.c | 2 +- citadel/server/modules/expire/serv_expire.c | 2 +- citadel/server/modules/fulltext/ft_wordbreaker.c | 2 +- citadel/server/modules/fulltext/ft_wordbreaker.h | 2 +- citadel/server/modules/fulltext/serv_fulltext.c | 2 +- citadel/server/modules/fulltext/serv_fulltext.h | 2 +- citadel/server/modules/image/serv_image.c | 2 +- citadel/server/modules/imap/imap_acl.c | 2 +- citadel/server/modules/imap/imap_acl.h | 2 +- citadel/server/modules/imap/imap_fetch.c | 2 +- citadel/server/modules/imap/imap_fetch.h | 2 +- citadel/server/modules/imap/imap_list.c | 2 +- citadel/server/modules/imap/imap_metadata.c | 2 +- citadel/server/modules/imap/imap_metadata.h | 2 +- citadel/server/modules/imap/imap_misc.c | 2 +- citadel/server/modules/imap/imap_misc.h | 2 +- citadel/server/modules/imap/imap_search.c | 2 +- citadel/server/modules/imap/imap_search.h | 2 +- citadel/server/modules/imap/imap_store.c | 2 +- citadel/server/modules/imap/imap_store.h | 2 +- citadel/server/modules/imap/imap_tools.c | 2 +- citadel/server/modules/imap/serv_imap.c | 2 +- citadel/server/modules/imap/serv_imap.h | 2 +- citadel/server/modules/inboxrules/serv_inboxrules.c | 2 +- citadel/server/modules/inetcfg/serv_inetcfg.c | 2 +- citadel/server/modules/instmsg/serv_instmsg.c | 2 +- citadel/server/modules/listdeliver/serv_listdeliver.c | 2 +- citadel/server/modules/listsub/serv_listsub.c | 2 +- citadel/server/modules/nntp/serv_nntp.c | 2 +- citadel/server/modules/nntp/serv_nntp.h | 2 +- citadel/server/modules/notes/serv_notes.c | 2 +- citadel/server/modules/pop3/serv_pop3.c | 2 +- citadel/server/modules/pop3/serv_pop3.h | 2 +- citadel/server/modules/pop3client/serv_pop3client.c | 2 +- citadel/server/modules/roomchat/serv_roomchat.c | 2 +- citadel/server/modules/rssclient/serv_rssclient.c | 2 +- citadel/server/modules/rwho/serv_rwho.c | 2 +- citadel/server/modules/smtp/dkim.c | 2 +- citadel/server/modules/smtp/dkim_bindings.c | 2 +- citadel/server/modules/smtp/serv_smtp.c | 2 +- citadel/server/modules/smtp/serv_smtpclient.c | 2 +- citadel/server/modules/smtp/smtp_util.c | 2 +- citadel/server/modules/smtp/smtp_util.h | 2 +- citadel/server/modules/spam/serv_spam.c | 2 +- citadel/server/modules/test/serv_test.c | 2 +- citadel/server/modules/upgrade/serv_upgrade.c | 2 +- citadel/server/modules/upgrade/serv_upgrade.h | 2 +- citadel/server/modules/vcard/serv_vcard.c | 2 +- citadel/server/modules/wiki/serv_wiki.c | 2 +- citadel/server/modules/xmpp/serv_xmpp.c | 2 +- citadel/server/modules/xmpp/serv_xmpp.h | 2 +- citadel/server/modules/xmpp/xmpp_messages.c | 2 +- citadel/server/modules/xmpp/xmpp_presence.c | 2 +- citadel/server/modules/xmpp/xmpp_query_namespace.c | 2 +- citadel/server/modules/xmpp/xmpp_queue.c | 2 +- citadel/server/modules/xmpp/xmpp_sasl_service.c | 2 +- citadel/server/modules_init.c | 2 +- citadel/server/modules_init.h | 2 +- citadel/server/msgbase.c | 2 +- citadel/server/msgbase.h | 2 +- citadel/server/netconfig.c | 2 +- citadel/server/room_ops.c | 2 +- citadel/server/serv_extensions.c | 2 +- citadel/server/server_main.c | 2 +- citadel/server/support.c | 2 +- citadel/server/sysdep.c | 2 +- citadel/server/sysdep.h | 2 +- citadel/server/threads.c | 2 +- citadel/server/user_ops.c | 2 +- citadel/server/user_ops.h | 2 +- citadel/server/usetable.c | 2 +- citadel/server/visit.c | 2 +- citadel/server/visit.h | 2 +- citadel/utils/auth.c | 2 +- citadel/utils/chkpw.c | 2 +- citadel/utils/chkpwd.c | 2 +- citadel/utils/citmail.c | 2 +- citadel/utils/ctdldump.c | 2 +- citadel/utils/ctdlload.c | 2 +- citadel/utils/dbnothing.c | 2 +- citadel/utils/loadtest.c | 2 +- citadel/utils/sendcommand.c | 2 +- citadel/utils/setup.c | 2 +- libcitadel/lib/array.c | 7 ++----- libcitadel/lib/base64.c | 2 +- libcitadel/lib/decode.c | 6 ++---- libcitadel/lib/hash.c | 6 ++---- libcitadel/lib/html_to_ascii.c | 2 +- libcitadel/lib/json.c | 2 +- libcitadel/lib/libcitadel.c | 2 +- libcitadel/lib/libcitadel.h | 2 +- libcitadel/lib/mime_parser.c | 7 ++----- libcitadel/lib/stringbuf.c | 2 +- libcitadel/lib/tools.c | 2 +- libcitadel/lib/urlhandling.c | 4 ++-- libcitadel/lib/vcard.c | 7 ++----- libcitadel/lib/vnote.c | 5 +---- textclient/citadel.c | 2 +- textclient/citadel_ipc.c | 2 +- textclient/client_chat.c | 2 +- textclient/client_passwords.c | 2 +- textclient/commands.c | 2 +- textclient/file_transfer.c | 2 +- textclient/messages.c | 2 +- textclient/rooms.c | 2 +- textclient/screen.c | 2 +- textclient/sysutil.c | 2 +- textclient/tcpclient.c | 2 +- textclient/textclient.h | 2 +- textclient/tuiconfig.c | 2 +- textclient/user_functions.c | 2 +- textclient/utilfunc.c | 2 +- webcit-ng/server/admin_functions.c | 2 +- webcit-ng/server/caldav_reports.c | 2 +- webcit-ng/server/ctdl_commands.c | 2 +- webcit-ng/server/ctdlclient.c | 2 +- webcit-ng/server/ctdlfunctions.c | 2 +- webcit-ng/server/floor_functions.c | 2 +- webcit-ng/server/forum_view.c | 2 +- webcit-ng/server/html2html.c | 2 +- webcit-ng/server/http.c | 2 +- webcit-ng/server/ical_ctdl_is_overlap.c | 2 +- webcit-ng/server/main.c | 2 +- webcit-ng/server/messages.c | 2 +- webcit-ng/server/request.c | 2 +- webcit-ng/server/room_functions.c | 2 +- webcit-ng/server/static.c | 2 +- webcit-ng/server/tcp_sockets.c | 2 +- webcit-ng/server/text2html.c | 2 +- webcit-ng/server/tls.c | 2 +- webcit-ng/server/upload.c | 2 +- webcit-ng/server/user_functions.c | 2 +- webcit-ng/server/util.c | 2 +- webcit-ng/server/webcit.h | 2 +- webcit-ng/server/webserver.c | 2 +- webcit/auth.c | 2 +- webcit/autocompletion.c | 2 +- webcit/blogview_renderer.c | 2 +- webcit/calendar.c | 2 +- webcit/calendar.h | 2 +- webcit/calendar_view.c | 2 +- webcit/context_loop.c | 2 +- webcit/cookie_conversion.c | 2 +- webcit/crypto.c | 2 +- webcit/dav.h | 2 +- webcit/dav_delete.c | 2 +- webcit/dav_get.c | 2 +- webcit/dav_main.c | 2 +- webcit/dav_options.c | 2 +- webcit/dav_propfind.c | 2 +- webcit/dav_put.c | 2 +- webcit/dav_report.c | 2 +- webcit/downloads.c | 2 +- webcit/event.c | 2 +- webcit/feed_generator.c | 2 +- webcit/fmt_date.c | 2 +- webcit/gettext.c | 2 +- webcit/graphics.c | 2 +- webcit/ical_ctdl_is_overlap.c | 2 +- webcit/ical_dezonify.c | 2 +- webcit/icontheme.c | 2 +- webcit/netconf.c | 2 +- webcit/roomops.c | 2 +- webcit/sieve.c | 2 +- webcit/siteconfig.c | 5 +---- webcit/sockets.c | 2 +- webcit/sysdep.c | 2 +- webcit/webcit.h | 2 +- webcit/webserver.c | 4 +--- 215 files changed, 221 insertions(+), 242 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518925Fri, 02 May 2025 12:10:29 +05002099518925@Uncensored Date: Fri May 2 12:10:26 2025 -0400 That about wraps it up for nuking nested includes. I think I also found and fixed all of the places where the boilerplate was wrong for the copyright notice and license declaration. It wasn't *wrong* wrong, but it was inconsistent with the way we prefer to declare it now. We prefer it this way: This program is open source software. Use, duplication, or disclosure is subject to the GNU General Public License version 3. All the other stuff is *in* the GPL itself. And of course we use the phrase 'Open Source' rather than 'Free Software'. This will anger Richard Stallman, and that's a feature, not a bug. ----------------------------------------------------------------------- Summary of changes: citadel/server/config.c | 1 + citadel/server/control.c | 1 + citadel/server/domain.h | 15 +-------------- citadel/server/euidindex.c | 1 + citadel/server/internet_addressing.c | 1 + citadel/server/journaling.c | 3 ++- .../modules/autocompletion/serv_autocompletion.c | 1 + .../modules/autocompletion/serv_autocompletion.h | 13 ++----------- citadel/server/modules/bio/serv_bio.c | 1 + citadel/server/modules/blog/serv_blog.c | 1 + citadel/server/modules/calendar/serv_calendar.c | 2 +- citadel/server/modules/calendar/serv_calendar.h | 5 +---- citadel/server/modules/checkpoint/serv_checkpoint.c | 1 + citadel/server/modules/clamav/serv_virus.c | 1 + citadel/server/modules/ctdlproto/files.h | 1 - citadel/server/modules/ctdlproto/serv_ctdlproto.c | 1 - citadel/server/modules/ctdlproto/serv_file.c | 1 + citadel/server/modules/ctdlproto/serv_messages.c | 1 + citadel/server/modules/ctdlproto/serv_rooms.c | 1 + citadel/server/modules/ctdlproto/serv_user.c | 1 + citadel/server/modules/expire/expire_policy.c | 1 + citadel/server/modules/expire/serv_expire.c | 2 +- citadel/server/modules/fulltext/ft_wordbreaker.c | 1 + citadel/server/modules/fulltext/ft_wordbreaker.h | 21 +++++---------------- citadel/server/modules/fulltext/serv_fulltext.c | 5 +++-- citadel/server/modules/fulltext/serv_fulltext.h | 4 +--- citadel/server/modules/image/serv_image.c | 1 + citadel/server/modules/imap/imap_acl.c | 1 + citadel/server/modules/imap/imap_acl.h | 4 +--- citadel/server/modules/imap/imap_fetch.c | 6 +++--- citadel/server/modules/imap/imap_fetch.h | 4 +--- citadel/server/modules/imap/imap_list.c | 1 + citadel/server/modules/imap/imap_metadata.c | 4 ++-- citadel/server/modules/imap/imap_metadata.h | 4 +--- citadel/server/modules/imap/imap_misc.c | 3 ++- citadel/server/modules/imap/imap_misc.h | 4 +--- citadel/server/modules/imap/imap_search.c | 1 + citadel/server/modules/imap/imap_search.h | 4 +--- citadel/server/modules/imap/imap_store.c | 1 + citadel/server/modules/imap/imap_store.h | 4 +--- citadel/server/modules/imap/serv_imap.c | 2 +- citadel/server/modules/inboxrules/serv_inboxrules.c | 1 + citadel/server/modules/inetcfg/serv_inetcfg.c | 1 + citadel/server/modules/instmsg/serv_instmsg.c | 1 + .../server/modules/listdeliver/serv_listdeliver.c | 1 + citadel/server/modules/listsub/serv_listsub.c | 1 + citadel/server/modules/nntp/serv_nntp.c | 1 + citadel/server/modules/nntp/serv_nntp.h | 14 ++------------ citadel/server/modules/notes/serv_notes.c | 1 + citadel/server/modules/pop3/serv_pop3.c | 1 + citadel/server/modules/pop3/serv_pop3.h | 13 ++----------- citadel/server/modules/pop3client/serv_pop3client.c | 1 + citadel/server/modules/roomchat/serv_roomchat.c | 1 + citadel/server/modules/rssclient/serv_rssclient.c | 1 + citadel/server/modules/rwho/serv_rwho.c | 1 + citadel/server/modules/smtp/dkim_bindings.c | 1 + citadel/server/modules/smtp/serv_smtp.c | 1 + citadel/server/modules/smtp/serv_smtpclient.c | 1 + citadel/server/modules/smtp/smtp_util.c | 1 + citadel/server/modules/spam/serv_spam.c | 1 + citadel/server/modules/upgrade/serv_upgrade.c | 1 + citadel/server/modules/upgrade/serv_upgrade.h | 19 ++----------------- citadel/server/modules/vcard/serv_vcard.c | 1 + citadel/server/modules/wiki/serv_wiki.c | 1 + citadel/server/modules/xmpp/serv_xmpp.c | 1 + citadel/server/modules/xmpp/serv_xmpp.h | 14 +++----------- citadel/server/modules/xmpp/xmpp_presence.c | 1 + citadel/server/modules_init.h | 1 - citadel/server/msgbase.c | 2 +- citadel/server/msgbase.h | 13 ++----------- citadel/server/room_ops.c | 2 +- citadel/server/serv_extensions.c | 3 ++- citadel/server/sysdep.h | 1 - citadel/server/user_ops.c | 2 +- 74 files changed, 89 insertions(+), 148 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518917Fri, 02 May 2025 11:45:36 +05002099518917@Uncensored Date: Fri May 2 11:45:34 2025 -0400 ctdl_module.h: correct the last of the nested includes from this header ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 1 + citadel/server/backends/common/database.c | 1 + citadel/server/citserver.c | 1 + citadel/server/clientsocket.c | 1 + citadel/server/config.c | 1 + citadel/server/control.c | 1 + citadel/server/ctdl_module.h | 2 -- citadel/server/default_timezone.c | 1 + citadel/server/euidindex.c | 1 + citadel/server/housekeeping.c | 1 + citadel/server/internet_addressing.c | 1 + citadel/server/journaling.c | 1 + citadel/server/ldap.c | 1 + citadel/server/modules/autocompletion/serv_autocompletion.c | 1 + citadel/server/modules/bio/serv_bio.c | 1 + citadel/server/modules/blog/serv_blog.c | 1 + citadel/server/modules/calendar/serv_calendar.c | 1 + citadel/server/modules/checkpoint/serv_checkpoint.c | 1 + citadel/server/modules/clamav/serv_virus.c | 1 + citadel/server/modules/crypto/serv_crypto.c | 1 + citadel/server/modules/ctdlproto/serv_ctdlproto.c | 1 + citadel/server/modules/ctdlproto/serv_file.c | 1 + citadel/server/modules/ctdlproto/serv_messages.c | 1 + citadel/server/modules/ctdlproto/serv_rooms.c | 1 + citadel/server/modules/ctdlproto/serv_session.c | 1 + citadel/server/modules/ctdlproto/serv_syscmds.c | 1 + citadel/server/modules/ctdlproto/serv_user.c | 1 + citadel/server/modules/image/serv_image.c | 1 + citadel/server/modules/imap/imap_acl.c | 1 + citadel/server/modules/imap/imap_fetch.c | 1 + citadel/server/modules/imap/imap_list.c | 1 + citadel/server/modules/imap/imap_metadata.c | 1 + citadel/server/modules/imap/imap_misc.c | 1 + citadel/server/modules/imap/imap_search.c | 1 + citadel/server/modules/imap/imap_store.c | 1 + citadel/server/modules/imap/imap_tools.c | 1 + citadel/server/modules/imap/serv_imap.c | 1 + citadel/server/modules/inboxrules/serv_inboxrules.c | 1 + citadel/server/modules/inetcfg/serv_inetcfg.c | 1 + citadel/server/modules/listdeliver/serv_listdeliver.c | 1 + citadel/server/modules/listsub/serv_listsub.c | 1 + citadel/server/modules/nntp/serv_nntp.c | 1 + citadel/server/modules/notes/serv_notes.c | 1 + citadel/server/modules/pop3/serv_pop3.c | 1 + citadel/server/modules/pop3client/serv_pop3client.c | 1 + citadel/server/modules/roomchat/serv_roomchat.c | 1 + citadel/server/modules/smtp/dkim_bindings.c | 1 + citadel/server/modules/smtp/serv_smtp.c | 1 + citadel/server/modules/smtp/serv_smtpclient.c | 1 + citadel/server/modules/smtp/smtp_util.c | 1 + citadel/server/modules/spam/serv_spam.c | 1 + citadel/server/modules/test/serv_test.c | 1 + citadel/server/modules/upgrade/serv_upgrade.c | 1 + citadel/server/modules/vcard/serv_vcard.c | 1 + citadel/server/modules/wiki/serv_wiki.c | 1 + citadel/server/modules/xmpp/serv_xmpp.c | 1 + citadel/server/modules/xmpp/xmpp_messages.c | 1 + citadel/server/modules/xmpp/xmpp_presence.c | 1 + citadel/server/modules/xmpp/xmpp_query_namespace.c | 1 + citadel/server/modules/xmpp/xmpp_queue.c | 1 + citadel/server/modules/xmpp/xmpp_sasl_service.c | 1 + citadel/server/msgbase.c | 1 + citadel/server/netconfig.c | 1 + citadel/server/room_ops.c | 1 + citadel/server/server_main.c | 1 + citadel/server/support.c | 1 + citadel/server/usetable.c | 1 + 67 files changed, 66 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518909Fri, 02 May 2025 11:31:10 +05002099518909@Uncensored Date: Fri May 2 11:31:09 2025 -0400 ctdl_module.h: more correction of nested includes ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 1 + citadel/server/backends/common/database.c | 1 + citadel/server/citserver.c | 1 + citadel/server/ctdl_module.h | 1 - citadel/server/modules/crypto/serv_crypto.c | 1 + citadel/server/modules/ctdlproto/serv_file.c | 1 + citadel/server/modules/ctdlproto/serv_rooms.c | 1 + citadel/server/modules/image/serv_image.c | 1 + citadel/server/modules/upgrade/serv_upgrade.c | 1 + citadel/server/user_ops.c | 1 + 10 files changed, 9 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518907Fri, 02 May 2025 11:27:08 +05002099518907@Uncensored Date: Fri May 2 11:27:05 2025 -0400 This commit was made by my cat. ----------------------------------------------------------------------- Summary of changes: citadel/server/config.c | 1 + citadel/server/context.c | 1 + citadel/server/control.c | 1 + citadel/server/ctdl_module.h | 13 ------------- citadel/server/housekeeping.c | 1 + citadel/server/journaling.c | 1 + citadel/server/modules/autocompletion/serv_autocompletion.c | 1 + citadel/server/modules/crypto/serv_crypto.c | 3 ++- citadel/server/modules/ctdlproto/serv_syscmds.c | 1 + citadel/server/modules/ctdlproto/serv_user.c | 1 + citadel/server/modules/inboxrules/serv_inboxrules.c | 1 + citadel/server/modules/instmsg/serv_instmsg.c | 1 + citadel/server/modules/listdeliver/serv_listdeliver.c | 1 + citadel/server/modules/listsub/serv_listsub.c | 1 + citadel/server/modules/roomchat/serv_roomchat.c | 1 + citadel/server/modules/smtp/serv_smtp.c | 1 + citadel/server/modules/smtp/serv_smtpclient.c | 1 + citadel/server/modules/vcard/serv_vcard.c | 1 + citadel/server/modules/xmpp/xmpp_messages.c | 1 + citadel/server/modules/xmpp/xmpp_queue.c | 1 + citadel/server/msgbase.c | 1 + citadel/server/netconfig.c | 1 + citadel/server/room_ops.c | 1 + citadel/server/server_main.c | 1 + citadel/server/sysdep.c | 1 + citadel/server/user_ops.c | 1 + 26 files changed, 26 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518903Fri, 02 May 2025 11:13:17 +05002099518903@Uncensored Date: Fri May 2 11:13:15 2025 -0400 More whack-a-mole on nested includes ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 3 ++ citadel/server/backends/common/database.c | 3 ++ citadel/server/citserver.c | 4 +++ citadel/server/clientsocket.c | 38 ++++++++++++++-------- citadel/server/config.c | 5 +++ citadel/server/context.c | 2 ++ citadel/server/control.c | 3 ++ citadel/server/ctdl_module.h | 24 +------------- citadel/server/euidindex.c | 3 ++ citadel/server/housekeeping.c | 3 ++ citadel/server/internet_addressing.c | 1 + citadel/server/journaling.c | 1 + citadel/server/ldap.c | 4 ++- .../modules/autocompletion/serv_autocompletion.c | 5 ++- citadel/server/modules/bio/serv_bio.c | 7 ++++ citadel/server/modules/calendar/serv_calendar.c | 3 ++ citadel/server/modules/clamav/serv_virus.c | 1 + citadel/server/modules/crypto/serv_crypto.c | 5 +-- citadel/server/modules/ctdlproto/serv_ctdlproto.c | 2 ++ citadel/server/modules/ctdlproto/serv_file.c | 5 +++ citadel/server/modules/ctdlproto/serv_messages.c | 2 ++ citadel/server/modules/ctdlproto/serv_rooms.c | 3 ++ citadel/server/modules/ctdlproto/serv_session.c | 2 ++ citadel/server/modules/ctdlproto/serv_syscmds.c | 1 + citadel/server/modules/ctdlproto/serv_user.c | 4 +++ citadel/server/modules/expire/expire_policy.c | 1 + citadel/server/modules/expire/serv_expire.c | 2 ++ citadel/server/modules/fulltext/ft_wordbreaker.c | 1 + citadel/server/modules/fulltext/serv_fulltext.c | 2 ++ citadel/server/modules/image/serv_image.c | 4 +++ citadel/server/modules/imap/imap_fetch.c | 1 + citadel/server/modules/imap/imap_list.c | 1 + citadel/server/modules/imap/imap_misc.c | 1 + citadel/server/modules/imap/imap_tools.c | 1 + citadel/server/modules/imap/serv_imap.c | 2 ++ .../server/modules/inboxrules/serv_inboxrules.c | 2 ++ citadel/server/modules/inetcfg/serv_inetcfg.c | 1 + citadel/server/modules/instmsg/serv_instmsg.c | 1 + .../server/modules/listdeliver/serv_listdeliver.c | 1 + citadel/server/modules/listsub/serv_listsub.c | 1 + citadel/server/modules/nntp/serv_nntp.c | 1 + citadel/server/modules/notes/serv_notes.c | 1 + citadel/server/modules/pop3/serv_pop3.c | 2 ++ .../server/modules/pop3client/serv_pop3client.c | 1 + citadel/server/modules/roomchat/serv_roomchat.c | 1 + citadel/server/modules/rssclient/serv_rssclient.c | 1 + citadel/server/modules/rwho/serv_rwho.c | 1 + citadel/server/modules/smtp/serv_smtp.c | 1 + citadel/server/modules/smtp/serv_smtpclient.c | 2 ++ citadel/server/modules/spam/serv_spam.c | 1 + citadel/server/modules/test/serv_test.c | 2 ++ citadel/server/modules/upgrade/serv_upgrade.c | 1 + citadel/server/modules/vcard/serv_vcard.c | 2 ++ citadel/server/modules/wiki/serv_wiki.c | 2 ++ citadel/server/modules/xmpp/serv_xmpp.c | 2 ++ citadel/server/modules/xmpp/xmpp_messages.c | 2 ++ citadel/server/modules/xmpp/xmpp_presence.c | 3 ++ citadel/server/modules/xmpp/xmpp_query_namespace.c | 2 ++ citadel/server/modules/xmpp/xmpp_queue.c | 1 + citadel/server/modules/xmpp/xmpp_sasl_service.c | 2 ++ citadel/server/modules_init.c | 2 ++ citadel/server/msgbase.c | 4 +++ citadel/server/netconfig.c | 2 ++ citadel/server/room_ops.c | 4 +++ citadel/server/serv_extensions.c | 2 ++ citadel/server/server_main.c | 4 +++ citadel/server/sysdep.c | 2 ++ citadel/server/threads.c | 3 ++ citadel/server/user_ops.c | 7 +++- citadel/server/usetable.c | 1 + citadel/server/visit.c | 1 + 71 files changed, 177 insertions(+), 42 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518891Fri, 02 May 2025 09:46:11 +05002099518891@Uncensored Date: Fri May 2 09:46:09 2025 -0400 visit.h: removed include libcitadel.h, it isn't needed from here ----------------------------------------------------------------------- Summary of changes: citadel/server/visit.h | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518824Thu, 01 May 2025 18:17:37 +05002099518824@Uncensored Date: Thu May 1 18:17:34 2025 -0400 More of the war against nested includes. commit ae604bc9c3112f969bf834c6cf332e801cbf4e24 Author: Art Cancro Date: Thu May 1 17:50:40 2025 -0400 citserver.h: continued war on nested includes ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 1 + citadel/server/citserver.c | 1 + citadel/server/citserver.h | 5 +---- citadel/server/default_timezone.c | 1 + citadel/server/euidindex.c | 1 + citadel/server/internet_addressing.c | 1 + citadel/server/ldap.c | 1 + citadel/server/modules/autocompletion/serv_autocompletion.c | 1 + citadel/server/modules/blog/serv_blog.c | 1 + citadel/server/modules/checkpoint/serv_checkpoint.c | 2 +- citadel/server/modules/clamav/serv_virus.c | 2 +- citadel/server/modules/ctdlproto/serv_ctdlproto.c | 2 ++ citadel/server/modules/ctdlproto/serv_messages.c | 1 + citadel/server/modules/ctdlproto/serv_rooms.c | 1 + citadel/server/modules/ctdlproto/serv_session.c | 1 + citadel/server/modules/expire/serv_expire.c | 4 ++-- citadel/server/modules/fulltext/ft_wordbreaker.c | 3 ++- citadel/server/modules/fulltext/serv_fulltext.c | 3 ++- citadel/server/modules/imap/imap_acl.c | 4 ++-- citadel/server/modules/imap/imap_fetch.c | 1 + citadel/server/modules/imap/imap_list.c | 2 +- citadel/server/modules/imap/imap_metadata.c | 2 +- citadel/server/modules/imap/imap_misc.c | 2 +- citadel/server/modules/imap/imap_search.c | 4 ++-- citadel/server/modules/imap/imap_store.c | 3 ++- citadel/server/modules/imap/imap_tools.c | 2 +- citadel/server/modules/imap/serv_imap.c | 2 +- citadel/server/modules/inboxrules/serv_inboxrules.c | 2 +- citadel/server/modules/inetcfg/serv_inetcfg.c | 1 + citadel/server/modules/instmsg/serv_instmsg.c | 1 + citadel/server/modules/listdeliver/serv_listdeliver.c | 2 +- citadel/server/modules/listsub/serv_listsub.c | 2 +- citadel/server/modules/nntp/serv_nntp.c | 2 +- citadel/server/modules/notes/serv_notes.c | 2 +- citadel/server/modules/pop3/serv_pop3.c | 2 +- citadel/server/modules/pop3client/serv_pop3client.c | 2 +- citadel/server/modules/roomchat/serv_roomchat.c | 2 +- citadel/server/modules/rssclient/serv_rssclient.c | 2 +- citadel/server/modules/rwho/serv_rwho.c | 4 +++- citadel/server/modules/smtp/dkim_bindings.c | 1 + citadel/server/modules/smtp/serv_smtp.c | 3 ++- citadel/server/modules/smtp/serv_smtpclient.c | 2 +- citadel/server/modules/smtp/smtp_util.c | 2 +- citadel/server/modules/spam/serv_spam.c | 2 +- citadel/server/modules/upgrade/serv_upgrade.c | 4 ++-- citadel/server/modules/vcard/serv_vcard.c | 2 +- citadel/server/modules/wiki/serv_wiki.c | 2 +- citadel/server/modules/xmpp/serv_xmpp.c | 1 + citadel/server/modules/xmpp/xmpp_messages.c | 2 ++ citadel/server/modules/xmpp/xmpp_presence.c | 1 + citadel/server/modules/xmpp/xmpp_query_namespace.c | 1 + citadel/server/modules/xmpp/xmpp_queue.c | 1 + citadel/server/modules/xmpp/xmpp_sasl_service.c | 1 + citadel/server/msgbase.c | 1 + citadel/server/room_ops.c | 2 +- citadel/server/serv_extensions.c | 2 ++ citadel/server/server_main.c | 1 + citadel/server/support.c | 1 + citadel/server/sysdep.c | 1 + citadel/server/user_ops.c | 2 ++ citadel/server/usetable.c | 2 +- citadel/server/visit.c | 3 +++ 62 files changed, 78 insertions(+), 40 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518819Thu, 01 May 2025 17:45:39 +05002099518819@Uncensored Date: Thu May 1 17:45:36 2025 -0400 ctdl_module.h: continued war on nested includes ----------------------------------------------------------------------- Summary of changes: citadel/server/clientsocket.c | 1 + citadel/server/control.c | 1 + citadel/server/ctdl_module.h | 2 -- citadel/server/housekeeping.c | 1 + citadel/server/modules/autocompletion/serv_autocompletion.c | 3 ++- citadel/server/modules/bio/serv_bio.c | 1 + citadel/server/modules/calendar/serv_calendar.c | 6 +++--- citadel/server/modules/ctdlproto/serv_file.c | 1 + citadel/server/modules_init.c | 1 + 9 files changed, 11 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518814Thu, 01 May 2025 17:28:03 +05002099518814@Uncensored Date: Thu May 1 17:28:00 2025 -0400 config.h: remove headers included from other headers ----------------------------------------------------------------------- Summary of changes: citadel/server/config.h | 11 ++++------ citadel/server/internet_addressing.h | 40 +++++++++++++++++------------------- citadel/server/support.h | 2 +- 3 files changed, 24 insertions(+), 29 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518809Thu, 01 May 2025 17:11:00 +05002099518809@Uncensored Date: Thu May 1 17:10:58 2025 -0400 Function prototypes are not documentation. ----------------------------------------------------------------------- Summary of changes: citadel/server/context.h | 4 ++-- citadel/server/serv_extensions.h | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518807Thu, 01 May 2025 17:03:45 +05002099518807@Uncensored Date: Thu May 1 17:03:40 2025 -0400 This is why we can't have nice things. ----------------------------------------------------------------------- Summary of changes: citadel/server/context.h | 68 +++++++++++++++++++++----------------------- citadel/server/locate_host.c | 1 + 2 files changed, 33 insertions(+), 36 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518743Thu, 01 May 2025 08:57:40 +05002099518743@Uncensored Date: Thu May 1 08:57:30 2025 -0400 Moved stuff around ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/html2html.c | 53 ++++++++++++++++++++++++-------------------- webcit-ng/server/request.c | 43 +++++++++++++++++------------------ webcit-ng/server/webcit.h | 5 +++-- webcit-ng/server/webserver.c | 9 ++++---- 4 files changed, 59 insertions(+), 51 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518663Wed, 30 Apr 2025 15:51:48 +05002099518663@Uncensored Date: Wed Apr 30 12:50:26 2025 -0700 ctdlload.c: don't add message #0 on an empty msglist or fulltext record. This behavior was harmless, but it caused the ctdldumploadtest to fail. ----------------------------------------------------------------------- Summary of changes: citadel/utils/ctdlload.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518610Wed, 30 Apr 2025 12:14:32 +05002099518610@Uncensored Date: Wed Apr 30 12:14:30 2025 -0400 more cleanup of headers commit 9d91bd9f728f0542e705333b222442fe61cc2672 Author: Art Cancro Date: Wed Apr 30 11:57:43 2025 -0400 ctdl_module.h: continue removing variable names from function prototypes ----------------------------------------------------------------------- Summary of changes: citadel/server/ctdl_module.h | 2 +- citadel/server/sysdep.h | 24 +++++++----------------- 2 files changed, 8 insertions(+), 18 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518596Wed, 30 Apr 2025 11:56:03 +05002099518596@Uncensored Date: Wed Apr 30 11:56:01 2025 -0400 ctdl_module.h: continue removing variable names from function prototypes ----------------------------------------------------------------------- Summary of changes: citadel/server/ctdl_module.h | 52 ++++++++++++++++++++++---------------------- 1 file changed, 26 insertions(+), 26 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518594Wed, 30 Apr 2025 11:49:41 +05002099518594@Uncensored Date: Wed Apr 30 11:49:39 2025 -0400 ctdl_module.h: began removing variable names from function prototypes ----------------------------------------------------------------------- Summary of changes: citadel/server/ctdl_module.h | 65 +++++++++++++++----------------------------- citadel/server/room_ops.c | 3 +- 2 files changed, 23 insertions(+), 45 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518410Mon, 28 Apr 2025 23:46:48 +05002099518410@Uncensored Date: Mon Apr 28 23:46:45 2025 -0400 add the boxes and buttons for add/remove ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518407Mon, 28 Apr 2025 23:31:29 +05002099518407@Uncensored Date: Mon Apr 28 23:31:25 2025 -0400 Move access control buttons adjacent to the lists they affect. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 54 +++++++++++++++++++++++++--------------- 1 file changed, 34 insertions(+), 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518404Mon, 28 Apr 2025 23:12:29 +05002099518404@Uncensored Date: Mon Apr 28 23:12:25 2025 -0400 Add mailing list add/remove API commands ----------------------------------------------------------------------- Summary of changes: citadel/docs/netconfigs.txt | 35 +++++-------------- citadel/server/citadel_dirs.h | 5 --- citadel/server/modules/smtp/dkim.c | 2 +- citadel/server/room_ops.c | 1 - citadel/utils/ctdldump.c | 2 +- citadel/utils/ctdlload.c | 2 +- webcit-ng/docs/api.txt | 18 ++++++---- webcit-ng/server/room_functions.c | 70 ++++++++++++++++++++++++++++++++++++++ webcit-ng/static/js/edit_room.js | 2 +- 9 files changed, 94 insertions(+), 43 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518241Sun, 27 Apr 2025 17:24:31 +05002099518241@Uncensored Date: Sun Apr 27 17:24:28 2025 -0400 CtdlDoIHavePermissionToDeleteMessagesFromThisRoom() now accepts a CitContext instead of assuming CC ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/calendar/serv_calendar.c | 2 +- citadel/server/modules/ctdlproto/serv_messages.c | 2 +- citadel/server/modules/imap/imap_store.c | 2 +- citadel/server/room_ops.c | 4 ++-- citadel/server/room_ops.h | 2 +- citadel/server/sysdep.c | 3 +-- 6 files changed, 7 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518238Sun, 27 Apr 2025 17:10:37 +05002099518238@Uncensored Date: Sun Apr 27 17:10:33 2025 -0400 client_close() now accepts a 'struct CitContext *' to work with. This is the proper way to avoid repeating calls to 'CC' instead of trying to cache it at the top of the function. ----------------------------------------------------------------------- Summary of changes: citadel/server/citserver.c | 3 +++ citadel/server/context.c | 2 +- citadel/server/context.h | 1 + citadel/server/sysdep.c | 46 +++++++++++++++++++++---------------------- citadel/server/sysdep_decls.h | 1 - 5 files changed, 27 insertions(+), 26 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518045Fri, 25 Apr 2025 16:59:22 +05002099518045@Uncensored Date: Fri Apr 25 16:59:19 2025 -0400 Cleaned up years of technical debt regarding which includes were included and where they were included from and in what order. I probably broke FreeBSD again. Will need to check on that. Expecting future changes to be easier though. ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 5 +- citadel/server/backends/common/database.c | 3 +- citadel/server/citserver.c | 1 + citadel/server/clientsocket.c | 1 + citadel/server/config.c | 5 +- citadel/server/context.c | 5 + citadel/server/control.c | 1 + citadel/server/default_timezone.c | 4 +- citadel/server/domain.c | 12 +- citadel/server/euidindex.c | 7 +- citadel/server/genstamp.c | 6 +- citadel/server/housekeeping.c | 3 + citadel/server/internet_addressing.c | 5 +- citadel/server/journaling.c | 6 +- citadel/server/ldap.c | 7 +- citadel/server/locate_host.c | 13 +- citadel/server/makeuserkey.c | 1 + .../modules/autocompletion/serv_autocompletion.c | 3 + citadel/server/modules/bio/serv_bio.c | 11 +- citadel/server/modules/blog/serv_blog.c | 5 +- citadel/server/modules/calendar/serv_calendar.c | 3 + .../server/modules/checkpoint/serv_checkpoint.c | 5 +- citadel/server/modules/clamav/serv_virus.c | 5 +- citadel/server/modules/crypto/serv_crypto.c | 4 - citadel/server/modules/ctdlproto/serv_ctdlproto.c | 2 + citadel/server/modules/ctdlproto/serv_file.c | 12 +- citadel/server/modules/ctdlproto/serv_messages.c | 4 + citadel/server/modules/ctdlproto/serv_rooms.c | 2 + citadel/server/modules/ctdlproto/serv_session.c | 4 + citadel/server/modules/ctdlproto/serv_syscmds.c | 4 + citadel/server/modules/ctdlproto/serv_user.c | 6 + citadel/server/modules/expire/expire_policy.c | 5 +- citadel/server/modules/expire/serv_expire.c | 5 +- citadel/server/modules/fulltext/ft_wordbreaker.c | 5 +- citadel/server/modules/fulltext/serv_fulltext.c | 5 +- citadel/server/modules/image/serv_image.c | 16 ++- citadel/server/modules/imap/imap_acl.c | 5 +- citadel/server/modules/imap/imap_fetch.c | 5 +- citadel/server/modules/imap/imap_list.c | 5 +- citadel/server/modules/imap/imap_metadata.c | 5 +- citadel/server/modules/imap/imap_misc.c | 5 +- citadel/server/modules/imap/imap_search.c | 7 +- citadel/server/modules/imap/imap_store.c | 6 +- citadel/server/modules/imap/imap_tools.c | 2 + citadel/server/modules/imap/serv_imap.c | 5 +- .../server/modules/inboxrules/serv_inboxrules.c | 5 +- citadel/server/modules/inetcfg/serv_inetcfg.c | 5 +- citadel/server/modules/instmsg/serv_instmsg.c | 3 + .../server/modules/listdeliver/serv_listdeliver.c | 5 +- citadel/server/modules/listsub/serv_listsub.c | 5 +- citadel/server/modules/nntp/serv_nntp.c | 7 +- citadel/server/modules/notes/serv_notes.c | 7 +- citadel/server/modules/pop3/serv_pop3.c | 5 +- .../server/modules/pop3client/serv_pop3client.c | 2 + citadel/server/modules/roomchat/serv_roomchat.c | 5 +- citadel/server/modules/rssclient/serv_rssclient.c | 2 + citadel/server/modules/rwho/serv_rwho.c | 5 +- citadel/server/modules/smtp/dkim.c | 4 +- citadel/server/modules/smtp/dkim_bindings.c | 2 + citadel/server/modules/smtp/serv_smtp.c | 5 +- citadel/server/modules/smtp/serv_smtpclient.c | 4 +- citadel/server/modules/smtp/smtp_util.c | 5 +- citadel/server/modules/spam/serv_spam.c | 5 +- citadel/server/modules/test/serv_test.c | 16 +-- citadel/server/modules/upgrade/serv_upgrade.c | 5 +- citadel/server/modules/vcard/serv_vcard.c | 5 +- citadel/server/modules/wiki/serv_wiki.c | 5 +- citadel/server/modules/xmpp/serv_xmpp.c | 7 +- citadel/server/modules/xmpp/xmpp_messages.c | 5 +- citadel/server/modules/xmpp/xmpp_presence.c | 5 +- citadel/server/modules/xmpp/xmpp_query_namespace.c | 5 +- citadel/server/modules/xmpp/xmpp_queue.c | 5 +- citadel/server/modules/xmpp/xmpp_sasl_service.c | 5 +- citadel/server/modules_init.c | 3 + citadel/server/msgbase.c | 4 + citadel/server/netconfig.c | 7 +- citadel/server/parsedate.c | 155 +++++++++------------ citadel/server/parsedate.y | 15 +- citadel/server/room_ops.c | 5 + citadel/server/server_main.c | 2 + citadel/server/support.c | 10 +- citadel/server/sysdep.c | 7 +- citadel/server/sysdep.h | 2 - citadel/server/threads.c | 5 +- citadel/server/user_ops.c | 4 + citadel/server/usetable.c | 2 + citadel/server/visit.c | 11 +- 87 files changed, 397 insertions(+), 215 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518014Fri, 25 Apr 2025 16:04:10 +05002099518014@Uncensored Date: Fri Apr 25 16:04:08 2025 -0400 Don't include system headers from our header files. ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_dirs.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518013Fri, 25 Apr 2025 16:03:31 +05002099518013@Uncensored Date: Fri Apr 25 16:03:28 2025 -0400 Don't include system headers from our header files. ----------------------------------------------------------------------- Summary of changes: citadel/server/context.h | 4 +--- citadel/server/makeuserkey.c | 3 ++- citadel/server/sysdep_decls.h | 2 +- citadel/server/user_ops.h | 5 +---- 4 files changed, 5 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518012Fri, 25 Apr 2025 15:53:29 +05002099518012@Uncensored Date: Fri Apr 25 15:53:26 2025 -0400 And another one gone, and another one gone, two more header files bite the dust ----------------------------------------------------------------------- Summary of changes: citadel/server/domain.h | 2 - .../server/modules/pop3client/serv_pop3client.c | 1 - citadel/server/modules/smtp/serv_smtpclient.c | 1 - citadel/server/sysconfig.h | 53 ----------- citadel/server/sysdep.h | 102 ++++++++++++++++++++- citadel/server/typesize.h | 58 ------------ 6 files changed, 100 insertions(+), 117 deletions(-) delete mode 100644 citadel/server/sysconfig.h delete mode 100644 citadel/server/typesize.h -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518007Fri, 25 Apr 2025 15:48:40 +05002099518007@Uncensored Date: Fri Apr 25 15:48:38 2025 -0400 More header consolidation ----------------------------------------------------------------------- Summary of changes: citadel/server/sysdep.h | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518006Fri, 25 Apr 2025 15:39:31 +05002099518006@Uncensored Date: Fri Apr 25 15:39:29 2025 -0400 Merge citadel_defs.h into sysdep.h commit df62a39ed2477d550c7c129486bdfeccaf5c0b58 Author: Art Cancro Date: Fri Apr 25 15:37:19 2025 -0400 consolidate part 1 ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 273 ------------------- citadel/server/citadel_dirs.c | 1 - citadel/server/default_timezone.c | 1 - citadel/server/domain.c | 1 - citadel/server/internet_addressing.c | 1 - citadel/server/modules/blog/serv_blog.c | 1 - .../server/modules/checkpoint/serv_checkpoint.c | 1 - citadel/server/modules/clamav/serv_virus.c | 1 - citadel/server/modules/crypto/serv_crypto.c | 1 - citadel/server/modules/expire/expire_policy.c | 1 - citadel/server/modules/expire/serv_expire.c | 1 - citadel/server/modules/fulltext/ft_wordbreaker.c | 1 - citadel/server/modules/fulltext/serv_fulltext.c | 1 - citadel/server/modules/imap/imap_acl.c | 1 - citadel/server/modules/imap/imap_fetch.c | 1 - citadel/server/modules/imap/imap_list.c | 1 - citadel/server/modules/imap/imap_metadata.c | 1 - citadel/server/modules/imap/imap_misc.c | 1 - citadel/server/modules/imap/imap_search.c | 1 - citadel/server/modules/imap/imap_store.c | 1 - citadel/server/modules/imap/imap_tools.c | 1 - citadel/server/modules/imap/serv_imap.c | 1 - .../server/modules/inboxrules/serv_inboxrules.c | 1 - citadel/server/modules/inetcfg/serv_inetcfg.c | 1 - citadel/server/modules/instmsg/serv_instmsg.c | 1 - .../server/modules/listdeliver/serv_listdeliver.c | 1 - citadel/server/modules/listsub/serv_listsub.c | 1 - citadel/server/modules/nntp/serv_nntp.c | 1 - citadel/server/modules/notes/serv_notes.c | 1 - citadel/server/modules/pop3/serv_pop3.c | 1 - .../server/modules/pop3client/serv_pop3client.c | 1 - citadel/server/modules/roomchat/serv_roomchat.c | 1 - citadel/server/modules/rssclient/serv_rssclient.c | 1 - citadel/server/modules/rwho/serv_rwho.c | 1 - citadel/server/modules/smtp/serv_smtp.c | 1 - citadel/server/modules/smtp/serv_smtpclient.c | 1 - citadel/server/modules/smtp/smtp_util.c | 1 - citadel/server/modules/spam/serv_spam.c | 1 - citadel/server/modules/upgrade/serv_upgrade.c | 1 - citadel/server/modules/vcard/serv_vcard.c | 1 - citadel/server/modules/wiki/serv_wiki.c | 1 - citadel/server/modules/xmpp/serv_xmpp.c | 1 - citadel/server/modules/xmpp/xmpp_messages.c | 1 - citadel/server/modules/xmpp/xmpp_presence.c | 1 - citadel/server/modules/xmpp/xmpp_query_namespace.c | 1 - citadel/server/modules/xmpp/xmpp_queue.c | 1 - citadel/server/modules/xmpp/xmpp_sasl_service.c | 1 - citadel/server/support.c | 1 - citadel/server/sysdep.h | 291 ++++++++++++++++++++- citadel/utils/chkpw.c | 1 - citadel/utils/chkpwd.c | 1 - citadel/utils/citmail.c | 1 - citadel/utils/ctdldump.c | 1 - citadel/utils/ctdlload.c | 1 - citadel/utils/dbnothing.c | 1 - citadel/utils/loadtest.c | 1 - citadel/utils/sendcommand.c | 1 - citadel/utils/setup.c | 1 - 58 files changed, 290 insertions(+), 330 deletions(-) delete mode 100644 citadel/server/citadel_defs.h -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099518002Fri, 25 Apr 2025 15:32:50 +05002099518002@Uncensored Date: Fri Apr 25 15:32:48 2025 -0400 Consolidated sysedep.h and server.h ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 1 - citadel/server/citadel_dirs.c | 5 +- citadel/server/context.h | 1 - citadel/server/ctdl_module.h | 5 +- citadel/server/default_timezone.c | 3 +- citadel/server/internet_addressing.c | 1 - citadel/server/internet_addressing.h | 1 - citadel/server/ldap.c | 2 + citadel/server/modules/blog/serv_blog.c | 10 +- .../server/modules/checkpoint/serv_checkpoint.c | 1 - citadel/server/modules/clamav/serv_virus.c | 6 +- citadel/server/modules/crypto/serv_crypto.c | 1 - citadel/server/modules/ctdlproto/serv_ctdlproto.c | 6 +- citadel/server/modules/ctdlproto/serv_messages.c | 2 + citadel/server/modules/ctdlproto/serv_rooms.c | 3 +- citadel/server/modules/ctdlproto/serv_session.c | 2 + citadel/server/modules/ctdlproto/serv_syscmds.c | 13 +- citadel/server/modules/expire/expire_policy.c | 1 - citadel/server/modules/expire/serv_expire.c | 1 - citadel/server/modules/fulltext/ft_wordbreaker.c | 4 +- citadel/server/modules/fulltext/serv_fulltext.c | 1 - citadel/server/modules/imap/imap_acl.c | 8 +- citadel/server/modules/imap/imap_fetch.c | 5 +- citadel/server/modules/imap/imap_list.c | 23 +-- citadel/server/modules/imap/imap_metadata.c | 26 +-- citadel/server/modules/imap/imap_misc.c | 1 - citadel/server/modules/imap/imap_search.c | 5 +- citadel/server/modules/imap/imap_store.c | 6 +- citadel/server/modules/imap/imap_tools.c | 4 +- citadel/server/modules/imap/serv_imap.c | 1 - .../server/modules/inboxrules/serv_inboxrules.c | 1 - citadel/server/modules/inetcfg/serv_inetcfg.c | 4 +- citadel/server/modules/instmsg/serv_instmsg.c | 1 - .../server/modules/listdeliver/serv_listdeliver.c | 3 +- citadel/server/modules/listsub/serv_listsub.c | 3 +- citadel/server/modules/nntp/serv_nntp.c | 6 +- citadel/server/modules/notes/serv_notes.c | 4 +- citadel/server/modules/pop3/serv_pop3.c | 3 +- .../server/modules/pop3client/serv_pop3client.c | 10 +- citadel/server/modules/roomchat/serv_roomchat.c | 1 - citadel/server/modules/rssclient/serv_rssclient.c | 8 +- citadel/server/modules/rwho/serv_rwho.c | 3 +- citadel/server/modules/smtp/dkim_bindings.c | 4 +- citadel/server/modules/smtp/serv_smtp.c | 1 - citadel/server/modules/smtp/serv_smtpclient.c | 5 +- citadel/server/modules/smtp/smtp_util.c | 1 - citadel/server/modules/spam/serv_spam.c | 8 +- citadel/server/modules/upgrade/serv_upgrade.c | 1 - citadel/server/modules/vcard/serv_vcard.c | 11 +- citadel/server/modules/wiki/serv_wiki.c | 3 +- citadel/server/modules/xmpp/serv_xmpp.c | 1 - citadel/server/modules/xmpp/xmpp_messages.c | 3 +- citadel/server/modules/xmpp/xmpp_presence.c | 1 - citadel/server/modules/xmpp/xmpp_query_namespace.c | 1 - citadel/server/modules/xmpp/xmpp_queue.c | 3 +- citadel/server/modules/xmpp/xmpp_sasl_service.c | 7 +- citadel/server/room_ops.c | 2 + citadel/server/serv_extensions.c | 4 +- citadel/server/serv_extensions.h | 1 - citadel/server/server.h | 193 -------------------- citadel/server/server_main.c | 2 + citadel/server/sysdep.h | 195 ++++++++++++++++++++- citadel/server/usetable.c | 2 + citadel/server/visit.c | 4 +- citadel/server/visit.h | 13 +- citadel/utils/chkpw.c | 6 +- citadel/utils/chkpwd.c | 8 +- citadel/utils/citmail.c | 3 +- citadel/utils/ctdldump.c | 3 +- citadel/utils/ctdlload.c | 3 +- citadel/utils/dbnothing.c | 3 +- citadel/utils/loadtest.c | 5 +- citadel/utils/sendcommand.c | 5 +- citadel/utils/setup.c | 5 +- 74 files changed, 301 insertions(+), 402 deletions(-) delete mode 100644 citadel/server/server.h -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517987Fri, 25 Apr 2025 15:06:42 +05002099517987@Uncensored Date: Fri Apr 25 15:06:38 2025 -0400 berkeley_db.c: reorder includes ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517904Thu, 24 Apr 2025 23:12:28 +05002099517904@Uncensored Date: Thu Apr 24 20:12:26 2025 -0700 More shuffling of headers around ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 2 +- citadel/server/citadel_defs.h | 8 ++------ citadel/server/citserver.c | 2 +- citadel/server/context.c | 2 +- citadel/server/euidindex.c | 2 +- citadel/server/housekeeping.c | 6 +----- citadel/server/locate_host.h | 3 +++ citadel/server/modules/checkpoint/serv_checkpoint.c | 7 ++----- citadel/server/modules/crypto/serv_crypto.c | 2 +- citadel/server/modules/ctdlproto/serv_user.c | 11 +---------- citadel/server/msgbase.c | 2 +- citadel/server/room_ops.c | 2 +- citadel/server/serv_extensions.c | 2 +- citadel/server/server.h | 2 +- citadel/server/support.h | 4 +--- citadel/server/sysdep.c | 2 +- citadel/server/threads.c | 2 +- citadel/server/user_ops.c | 2 +- citadel/server/usetable.c | 2 +- 19 files changed, 23 insertions(+), 42 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517898Thu, 24 Apr 2025 22:57:19 +05002099517898@Uncensored Date: Thu Apr 24 19:57:17 2025 -0700 threads.h: don't include includes ----------------------------------------------------------------------- Summary of changes: citadel/server/threads.h | 8 -------- 1 file changed, 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517897Thu, 24 Apr 2025 22:54:44 +05002099517897@Uncensored Date: Thu Apr 24 19:54:42 2025 -0700 includes including other includes is non-inclusive. ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 9 +++++++++ citadel/server/citserver.c | 1 + citadel/server/config.c | 1 + citadel/server/context.c | 1 + citadel/server/control.c | 1 + citadel/server/euidindex.c | 1 + citadel/server/housekeeping.c | 1 + citadel/server/modules/checkpoint/serv_checkpoint.c | 1 + citadel/server/modules/ctdlproto/serv_messages.c | 1 + citadel/server/modules/ctdlproto/serv_rooms.c | 1 + citadel/server/modules/ctdlproto/serv_user.c | 1 + citadel/server/msgbase.c | 1 + citadel/server/room_ops.c | 1 + citadel/server/serv_extensions.c | 3 ++- citadel/server/sysdep.c | 1 + citadel/server/sysdep_decls.h | 10 ---------- citadel/server/threads.c | 7 ++++--- citadel/server/user_ops.c | 1 + citadel/server/usetable.c | 1 + 19 files changed, 30 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517675Tue, 22 Apr 2025 23:32:36 +05002099517675@Uncensored Date: Tue Apr 22 23:32:34 2025 -0400 worked on listserv panel ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 8 ++++---- webcit-ng/static/js/edit_room.js | 18 +++++++++++------- 2 files changed, 15 insertions(+), 11 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517672Tue, 22 Apr 2025 23:09:14 +05002099517672@Uncensored Date: Tue Apr 22 23:09:11 2025 -0400 Cribbed more messages from the webcit-classic catalog, so as to not lose the translations. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 17 +++++++++++++++++ webcit/po/webcit/ar.po | 8 ++++---- webcit/po/webcit/bg.po | 8 ++++---- webcit/po/webcit/cs.po | 8 ++++---- webcit/po/webcit/da.po | 8 ++++---- webcit/po/webcit/de.po | 8 ++++---- webcit/po/webcit/el.po | 8 ++++---- webcit/po/webcit/en_GB.po | 16 ++++++++-------- webcit/po/webcit/es.po | 8 ++++---- webcit/po/webcit/et.po | 8 ++++---- webcit/po/webcit/fi.po | 8 ++++---- webcit/po/webcit/fr.po | 8 ++++---- webcit/po/webcit/he.po | 8 ++++---- webcit/po/webcit/hu.po | 8 ++++---- webcit/po/webcit/it.po | 8 ++++---- webcit/po/webcit/kk.po | 8 ++++---- webcit/po/webcit/ko.po | 8 ++++---- webcit/po/webcit/nl.po | 8 ++++---- webcit/po/webcit/pl.po | 8 ++++---- webcit/po/webcit/pt_BR.po | 8 ++++---- webcit/po/webcit/ro.po | 8 ++++---- webcit/po/webcit/ru.po | 8 ++++---- webcit/po/webcit/sl.po | 8 ++++---- webcit/po/webcit/sv.po | 8 ++++---- webcit/po/webcit/tr.po | 8 ++++---- webcit/po/webcit/webcit.pot | 8 ++++---- webcit/po/webcit/zh.po | 8 ++++---- webcit/static/t/room/edit/tab_listserv.html | 2 +- 28 files changed, 126 insertions(+), 109 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517663Tue, 22 Apr 2025 22:03:38 +05002099517663@Uncensored Date: Tue Apr 22 22:01:43 2025 -0400 sendcommand: accept new '-r' option to run in a specific room ----------------------------------------------------------------------- Summary of changes: citadel/utils/sendcommand.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517650Tue, 22 Apr 2025 18:22:20 +05002099517650@Uncensored/listrecp webcit-ng: room deletion now uses a prompt that is already in the message catalog. Release version 1011 generated by do-release.sh Harlow Solutions (1): Add error checking to locate_host() and return truncated host name rather than blank. ----------------------------------------------------------------------- -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517649Tue, 22 Apr 2025 18:22:19 +05002099517649@Uncensored Date: Tue Apr 22 18:22:18 2025 -0400 Release version 1011 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517557Mon, 21 Apr 2025 23:47:28 +05002099517557@Uncensored Date: Mon Apr 21 23:47:26 2025 -0400 webcit-ng: room deletion now uses a prompt that is already in the message catalog. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517554Mon, 21 Apr 2025 23:27:50 +05002099517554@Uncensored Date: Mon Apr 21 23:27:48 2025 -0400 webcit-ng: new API call /ctdl/r//listrecp This produces a JSON-formatted array of email addresses which are subscribed to the room as a mailing list. commit 2cf452d22586cbf6331dea5646d0517c1f23b45a Author: Art Cancro Date: Mon Apr 21 22:58:52 2025 -0400 Remove the digest dialog from room edit ----------------------------------------------------------------------- Summary of changes: citadel/server/netconfig.c | 2 ++ webcit-ng/docs/api.txt | 2 +- webcit-ng/server/room_functions.c | 34 +++++++++++++++++++++++++++++ webcit/static/t/room/edit/tab_listserv.html | 28 +++++------------------- 4 files changed, 42 insertions(+), 24 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517550Mon, 21 Apr 2025 22:50:40 +05002099517550@Uncensored Date: Mon Apr 21 22:50:38 2025 -0400 netconfig.c: auto-convert the obsolete 'digestrecp' key to 'listrecp' ----------------------------------------------------------------------- Summary of changes: citadel/server/netconfig.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517546Mon, 21 Apr 2025 22:23:13 +05002099517546@Uncensored Date: Mon Apr 21 22:23:11 2025 -0400 webcit-classic: removed 'participate' mode from config screen. This mode doesn't exist anymore, and the regular mode actually works better for the intended purpose. ----------------------------------------------------------------------- Summary of changes: webcit/static/t/room/edit/tab_listserv.html | 27 --------------------------- 1 file changed, 27 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517393Sun, 20 Apr 2025 18:14:59 +05002099517393@Uncensored Date: Sun Apr 20 18:14:57 2025 -0400 Moved legacy RoomNetCfg types from libcitadel into webcit-classic. These represent a programming style we don't use in this project anymore, and they were only used in webcit-classic, so we moved them there to die when webcit-classic is retired. ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/libcitadel.c | 19 +------------------ libcitadel/lib/libcitadel.h | 15 --------------- webcit-ng/docs/api.txt | 1 + webcit/roomlist.c | 41 +++++++++++++++++++++-------------------- webcit/roomops.h | 16 ++++++++++++++++ 5 files changed, 39 insertions(+), 53 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517136Fri, 18 Apr 2025 22:05:22 +05002099517136@Uncensored Date: Fri Apr 18 22:05:18 2025 -0400 Began work on mailing list config screen ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 4 +++- webcit-ng/static/js/edit_room.js | 13 ++++++++++--- 2 files changed, 13 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517127Fri, 18 Apr 2025 20:51:57 +05002099517127@Uncensored Date: Fri Apr 18 20:51:54 2025 -0400 Removed unimplemented option 'moderated mailing list' Why did we even have that? We've never had that feature but it's offered in the room flags and in every client. ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/libcitadel.h | 4 ++-- textclient/rooms.c | 4 ++-- webcit-ng/server/room_functions.c | 2 +- webcit-ng/static/js/edit_room.js | 19 +++++++++++++++++++ webcit/roomops.c | 22 ++++++++-------------- webcit/static/t/room/edit/tab_listserv.html | 5 +++-- 6 files changed, 35 insertions(+), 21 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099517109Fri, 18 Apr 2025 18:58:48 +05002099517109@Uncensored Date: Fri Apr 18 18:58:45 2025 -0400 Random acts of cleanup ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/imap/imap_fetch.c | 14 ++++---------- citadel/server/modules/listsub/serv_listsub.c | 14 ++------------ citadel/server/modules/smtp/smtp_util.c | 9 ++------- citadel/server/modules/xmpp/xmpp_messages.c | 27 ++++++--------------------- citadel/server/netconfig.c | 3 +-- 5 files changed, 15 insertions(+), 52 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516786Wed, 16 Apr 2025 14:20:27 +05002099516786@Uncensored Date: Wed Apr 16 14:20:25 2025 -0400 cmd_snet() now sanitizes input for valid config key types too. ----------------------------------------------------------------------- Summary of changes: citadel/server/netconfig.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516774Wed, 16 Apr 2025 12:53:05 +05002099516774@Uncensored Date: Wed Apr 16 12:53:03 2025 -0400 ENCODE NULL TERMINATOR IDIOT ----------------------------------------------------------------------- Summary of changes: citadel/server/netconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516770Wed, 16 Apr 2025 12:17:58 +05002099516770@Uncensored Date: Wed Apr 16 12:17:56 2025 -0400 Last bit of sanitization. Always null terminate! ----------------------------------------------------------------------- Summary of changes: citadel/server/netconfig.c | 44 ++++++++++++++++++++++++++------------------ 1 file changed, 26 insertions(+), 18 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516762Wed, 16 Apr 2025 11:37:38 +05002099516762@Uncensored Date: Wed Apr 16 11:37:36 2025 -0400 cmd_gnet() still tokenizes and outputs one line at a time now. Even though it doesn't have to, we've already written the tokenizer and doing it this way is more consistent with the rest of the protocol. ----------------------------------------------------------------------- Summary of changes: citadel/server/netconfig.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516761Wed, 16 Apr 2025 11:35:56 +05002099516761@Uncensored Date: Wed Apr 16 11:35:53 2025 -0400 Move netconfig sanitizer to LoadRoomNetConfigFile() ----------------------------------------------------------------------- Summary of changes: citadel/server/netconfig.c | 50 ++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 42 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516758Wed, 16 Apr 2025 11:15:43 +05002099516758@Uncensored Date: Wed Apr 16 11:15:40 2025 -0400 cmd_gnet() : filter out lines with invalid key names ----------------------------------------------------------------------- Summary of changes: citadel/server/netconfig.c | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516695Tue, 15 Apr 2025 19:47:39 +05002099516695@Uncensored Date: Tue Apr 15 19:47:37 2025 -0400 CtdlGetCurrentMessageNumber() - removed. No longer used anywhere. ----------------------------------------------------------------------- Summary of changes: citadel/server/control.c | 11 ----------- citadel/server/ctdl_module.h | 9 --------- 2 files changed, 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516694Tue, 15 Apr 2025 19:44:22 +05002099516694@Uncensored Date: Tue Apr 15 19:44:20 2025 -0400 Removed support for upgrading Citadel databases earlier than version 901. This is consistent with our policy of supporting the upgrade of Citadel versions up to ten years old. Beyond that, you'll have to step up through a few older versions, which seems reasonable now that we're leaving older versions in Docker Hub. Or you can pull old versions from git and build them. If you're so lazy that you can't do an upgrade in more than ten years, I'll do it for a fee. It won't be cheap. :) Since the server will now refuse to start if the existing database is older than version 901, we have now removed the following data conversion processes: 1. System configuration stored in a citadel.config file 2. Control records stored in a citadel.control file 3. Room networking configurations stored in files in netconfig/ directory It's all in the database now. And since the database is now so yummy, we should all be happy about that. ----------------------------------------------------------------------- Summary of changes: citadel/server/citserver.c | 1 - citadel/server/config.c | 104 +------------------------- citadel/server/config.h | 87 +-------------------- citadel/server/control.c | 44 +---------- citadel/server/control.h | 3 +- citadel/server/modules/upgrade/serv_upgrade.c | 8 +- 6 files changed, 6 insertions(+), 241 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516691Tue, 15 Apr 2025 19:27:24 +05002099516691@Uncensored Date: Tue Apr 15 19:27:21 2025 -0400 netconfig.c: remove support for converting legacy netconfig files ----------------------------------------------------------------------- Summary of changes: citadel/server/netconfig.c | 52 ++--------------------------- webcit/po/webcit/ar.po | 2 +- webcit/po/webcit/bg.po | 2 +- webcit/po/webcit/cs.po | 2 +- webcit/po/webcit/da.po | 2 +- webcit/po/webcit/de.po | 2 +- webcit/po/webcit/el.po | 2 +- webcit/po/webcit/en_GB.po | 2 +- webcit/po/webcit/es.po | 2 +- webcit/po/webcit/et.po | 2 +- webcit/po/webcit/fi.po | 2 +- webcit/po/webcit/fr.po | 2 +- webcit/po/webcit/he.po | 2 +- webcit/po/webcit/hu.po | 2 +- webcit/po/webcit/it.po | 2 +- webcit/po/webcit/kk.po | 2 +- webcit/po/webcit/ko.po | 2 +- webcit/po/webcit/nl.po | 2 +- webcit/po/webcit/pl.po | 2 +- webcit/po/webcit/pt_BR.po | 2 +- webcit/po/webcit/ro.po | 2 +- webcit/po/webcit/ru.po | 2 +- webcit/po/webcit/sl.po | 2 +- webcit/po/webcit/sv.po | 2 +- webcit/po/webcit/tr.po | 2 +- webcit/po/webcit/webcit.pot | 2 +- webcit/po/webcit/zh.po | 2 +- webcit/static/t/room/edit/tab_listserv.html | 2 +- 28 files changed, 29 insertions(+), 77 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516539Mon, 14 Apr 2025 13:53:48 +05002099516539@Uncensored Date: Mon Apr 14 13:53:45 2025 -0400 The helpful Citadel Aide now posts a message to alert the administrator of software upgrades. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/upgrade/serv_upgrade.c | 29 ++++++++++++--------------- 1 file changed, 13 insertions(+), 16 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516451Sun, 13 Apr 2025 23:15:37 +05002099516451@Uncensored Date: Sun Apr 13 23:15:35 2025 -0400 Refuse to accept new messages if there is less than 100 MB free on disk ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/common/database.c | 37 ++++++++++++++++++++++- citadel/server/citserver.c | 4 +++ citadel/server/database.h | 4 +-- citadel/server/modules/ctdlproto/serv_messages.c | 14 +++++---- citadel/server/modules/fulltext/serv_fulltext.c | 14 ++++++--- citadel/server/modules/rssclient/serv_rssclient.c | 16 ++++++---- citadel/server/modules/smtp/serv_smtp.c | 8 ++++- libcitadel/lib/libcitadel.h | 1 + 8 files changed, 77 insertions(+), 21 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516084Thu, 10 Apr 2025 22:46:02 +05002099516084@Uncensored Date: Thu Apr 10 22:45:55 2025 -0400 Reactivate TLS to the server if possible, also changed Encrypted/Unencrypted in the status bar to lock/unlock unicode icons. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099516082Thu, 10 Apr 2025 22:35:56 +05002099516082@Uncensored Date: Thu Apr 10 19:35:52 2025 -0700 citserver: default TLS cipher list is now DEFAULT ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/crypto/serv_crypto.c | 7 +++---- citadel/server/modules/crypto/serv_crypto.h | 7 +++---- webcit/crypto.c | 3 +-- 3 files changed, 7 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515712Tue, 08 Apr 2025 17:15:49 +05002099515712@Uncensored Date: Tue Apr 8 14:15:46 2025 -0700 imap_misc.c: update to current style guidelines ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/imap/imap_misc.c | 130 +++++++++++--------------------- 1 file changed, 46 insertions(+), 84 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515711Tue, 08 Apr 2025 17:10:58 +05002099515711@Uncensored Date: Tue Apr 8 14:10:55 2025 -0700 serv_imap.h: update to current style guidelines ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/imap/serv_imap.h | 62 ++++++++++++++------------------- 1 file changed, 27 insertions(+), 35 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515710Tue, 08 Apr 2025 17:07:44 +05002099515710@Uncensored Date: Tue Apr 8 14:07:40 2025 -0700 serv_imap.c: update to current style guidelines ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/imap/serv_imap.c | 119 ++++++++++---------------------- 1 file changed, 38 insertions(+), 81 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515597Mon, 07 Apr 2025 23:27:03 +05002099515597@Uncensored Date: Mon Apr 7 23:27:00 2025 -0400 Room config accordion now works clicking anywhere on the legend. It was definitely annoying to have to sharpshoot the little + or - box on the left side of the legend, and since we now implement the more traditional style of automatically closing all other boxes when a new one is opened, it made more sense to do it this way. Click on any legend and it will open that dialog, closing all the other ones. I expect we'll use this in several other places. And tomorrow I'll probably discover that there's now a makeIntoAccordion() method that's been built into the browsers for the last few years. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 62 ++++++++++++++++++---------------------- 1 file changed, 28 insertions(+), 34 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515537Mon, 07 Apr 2025 13:16:00 +05002099515537@Uncensored Date: Mon Apr 7 13:15:49 2025 -0400 you have to read this commit to find out what's in it ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 48 +++++++++++------------ citadel/server/user_ops.c | 20 +++------- 2 files changed, 30 insertions(+), 38 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515469Mon, 07 Apr 2025 01:30:52 +05002099515469@Uncensored Date: Mon Apr 7 01:30:23 2025 -0400 Add error checking to locate_host() and return truncated host name rather than blank. Encountered core dump from getnameinfo() during DOS attack. From dump, looked like getpeername() must have errored and address data was corupted. When the return buffer for getnameinfo() is too small or errors, the function does not put anything into the buffer. Switched to using a large buffer and then copying so it should never truncate and am able to copy truncated name. ----------------------------------------------------------------------- Summary of changes: citadel/server/context.c | 1 - citadel/server/locate_host.c | 20 ++++++++++++++++---- 2 files changed, 16 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515303Sat, 05 Apr 2025 12:38:32 +05002099515303@Uncensored Date: Sat Apr 5 12:38:30 2025 -0400 webcit-ng room access invite/kick complete! ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 9 +++++++-- webcit-ng/server/http.c | 8 ++++---- webcit-ng/server/request.c | 2 +- webcit-ng/server/room_functions.c | 33 +++++++++++++++++++++++++++++++++ webcit-ng/server/webcit.h | 1 + webcit-ng/server/webserver.c | 14 +++++++------- webcit-ng/static/js/edit_room.js | 30 ++++++++++++++++++++++-------- 7 files changed, 75 insertions(+), 22 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515172Fri, 04 Apr 2025 11:21:55 +05002099515172@Uncensored Date: Fri Apr 4 11:21:52 2025 -0400 serv_roomchat.c: update to current coding style ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/roomchat/serv_roomchat.c | 58 +++++++------------------ 1 file changed, 15 insertions(+), 43 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515171Fri, 04 Apr 2025 11:18:12 +05002099515171@Uncensored Date: Fri Apr 4 11:17:48 2025 -0400 serv_instmsg.c ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/instmsg/serv_instmsg.c | 37 ++++++++++++--------------- 1 file changed, 17 insertions(+), 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515165Fri, 04 Apr 2025 11:13:54 +05002099515165@Uncensored Date: Fri Apr 4 11:13:52 2025 -0400 serv_session.c: updated to current coding standards ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/ctdlproto/serv_session.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515164Fri, 04 Apr 2025 11:12:22 +05002099515164@Uncensored Date: Fri Apr 4 11:12:20 2025 -0400 serv_user.c: removed an old style comment ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/ctdlproto/serv_user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515163Fri, 04 Apr 2025 11:11:17 +05002099515163@Uncensored Date: Fri Apr 4 11:11:14 2025 -0400 crc16.c: update to current coding standards ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/fulltext/crc16.c | 225 +++++++++++++++----------------- 1 file changed, 102 insertions(+), 123 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515158Fri, 04 Apr 2025 11:05:00 +05002099515158@Uncensored Date: Fri Apr 4 11:04:58 2025 -0400 smtp_util.c: updated to current coding standards ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/smtp/smtp_util.c | 50 ++++++++++++--------------------- 1 file changed, 18 insertions(+), 32 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515157Fri, 04 Apr 2025 11:01:32 +05002099515157@Uncensored Date: Fri Apr 4 11:01:28 2025 -0400 xmpp_presence.c: updated to current coding standards ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/xmpp/xmpp_presence.c | 157 +++++++++++----------------- 1 file changed, 59 insertions(+), 98 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515154Fri, 04 Apr 2025 10:17:13 +05002099515154@Uncensored Date: Fri Apr 4 10:17:11 2025 -0400 serv_rooms.c: update to current coding style commit c33c929fe8e430ea9d0b0b0d6fc5a1231fb5bcd2 Author: Art Cancro Date: Fri Apr 4 10:05:11 2025 -0400 xmpp_query_namespace.c: convert to C99 comment style ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/ctdlproto/serv_rooms.c | 97 ++++++++++------------ citadel/server/modules/xmpp/xmpp_query_namespace.c | 69 +++++---------- do-release.sh | 3 +- 3 files changed, 68 insertions(+), 101 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099515016Thu, 03 Apr 2025 13:29:40 +05002099515016@Uncensored Date: Thu Apr 3 13:29:38 2025 -0400 Skeleton code for invite/kick room access. Selected users are now passed to functions which will implement this. I am also noticing that there are some javascript/html escape issues that need to be addressed and working on that. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 31 ++++++++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099514769Tue, 01 Apr 2025 23:52:06 +05002099514769@Uncensored Date: Tue Apr 1 23:52:04 2025 -0400 edit_room.js: began populating the invite/kick dialog. I'm importing the text and labels from WebCit Classic because they're already translated. Sometimes they don't apply perfectly but we'll fix that after flag day by changing both the program text and the translate keys, so the translators can tune it up. Also I'm aware that there are people following the commit logs now, so hello and a big shout out to you all! ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 4 ++-- webcit-ng/static/js/edit_room.js | 49 +++++++++++++++++++++++++++++++++------- 2 files changed, 43 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099513769Mon, 24 Mar 2025 23:19:18 +05002099513769@Uncensored Date: Mon Mar 24 23:19:16 2025 -0400 Room edit is now a true accordion where expanding one block collapses all the others. This required some ugly code and if we end up doing an accordion anywhere else I'm going to have to put some work in to abstract it so we can DRY the code. But for now it works and it looks good and I'm moving on. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099513765Mon, 24 Mar 2025 22:55:46 +05002099513765@Uncensored Date: Mon Mar 24 22:55:44 2025 -0400 When expanding one of the room edit panels, scroll it into view as much as possible. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 1 + 1 file changed, 1 insertion(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099513762Mon, 24 Mar 2025 22:42:56 +05002099513762@Uncensored Date: Mon Mar 24 22:42:52 2025 -0400 New subclass 'ctdl-formgrid-fieldset-stdwidth' to use when you have more than one of them on the same screen and it looks funny when they are all different widths. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 4 ++++ webcit-ng/static/js/edit_room.js | 14 +++++++------- 2 files changed, 11 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099513749Mon, 24 Mar 2025 18:50:03 +05002099513749@Uncensored Date: Mon Mar 24 18:50:00 2025 -0400 room_functions.c: completed the /ctdl/r/xxx/access API function ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099513745Mon, 24 Mar 2025 18:29:51 +05002099513745@Uncensored Date: Mon Mar 24 18:29:36 2025 -0400 USERNAME_SIZE is 64 bytes. Found some places where the constant 64 was used and replaced with USERNAME_SIZE ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 6 +++++- webcit-ng/server/webcit.h | 3 ++- 2 files changed, 7 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099513734Mon, 24 Mar 2025 18:04:43 +05002099513734@Uncensored Date: Mon Mar 24 18:04:39 2025 -0400 textclient: uniform color across the status line ----------------------------------------------------------------------- Summary of changes: textclient/screen.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099513328Thu, 20 Mar 2025 23:15:43 +05002099513328@Uncensored Date: Thu Mar 20 23:15:41 2025 -0400 All references to a username field now use USERNAME_SIZE. There were a few places that still had a numeric value. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/inboxrules/serv_inboxrules.c | 4 ++-- citadel/server/modules/smtp/serv_smtp.c | 2 +- textclient/textclient.h | 2 +- textclient/user_functions.c | 2 +- webcit-ng/docs/api.txt | 1 + webcit-ng/server/request.c | 16 +++++++--------- webcit-ng/server/room_functions.c | 21 +++++++++++++++++++++ 7 files changed, 34 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099513323Thu, 20 Mar 2025 22:54:06 +05002099513323@Uncensored Date: Thu Mar 20 22:54:03 2025 -0400 serv_rooms.c: added an option to the WHOK server command to have it show both users who do AND do not have access to the room. This will be used for the access control screen in webcit-ng ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/ctdlproto/serv_rooms.c | 126 +++++++++++++------------- 1 file changed, 61 insertions(+), 65 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099512437Thu, 13 Mar 2025 13:55:24 +05002099512437@Uncensored Date: Thu Mar 13 13:55:21 2025 -0400 webcit-ng: cleaned up OpenSSL error handling. This started as a verification that the SSL problem we fixed in webcit-classic didn't also exist here. It didn't. Then it turned into an effort to try and figure out why the browsers are trying to send client certificates even though we're not requesting them. We didn't figure that out either. But at least we cleaned up error handling. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/tls.c | 35 ++++++++++++++++++++++------------- 1 file changed, 22 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099511939Mon, 10 Mar 2025 14:27:36 +05002099511939@Uncensored Date: Mon Mar 10 11:27:34 2025 -0700 webcit-ng: brought the new OpenSSL error handler over from webcit-classic ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/tls.c | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099511725Sat, 08 Mar 2025 09:28:52 +05002099511725@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099511724Sat, 08 Mar 2025 09:28:52 +05002099511724@Uncensored Date: Sat Mar 8 09:28:51 2025 -0500 Release version 1010 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099511663Fri, 07 Mar 2025 18:27:45 +05002099511663@Uncensored Date: Fri Mar 7 18:27:43 2025 -0500 webcit-classic: eliminated several conditions that could make webcit unresponsive. ----------------------------------------------------------------------- Summary of changes: webcit/context_loop.c | 2 - webcit/crypto.c | 58 ++++---- webcit/mainmenu.c | 2 +- webcit/sockets.c | 38 ----- webcit/sysdep.c | 377 ++++++++++++-------------------------------------- webcit/webserver.c | 22 +-- 6 files changed, 119 insertions(+), 380 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099511446Thu, 06 Mar 2025 12:00:26 +05002099511446@Uncensored Date: Thu Mar 6 12:00:23 2025 -0500 webcit classic: in HTTPS mode, fail the entire connection if SSL negotiation fails. ----------------------------------------------------------------------- Summary of changes: webcit/crypto.c | 23 ++++++++++------------- webcit/gettext.c | 1 - webcit/sockets.c | 32 +++++++++++++------------------- webcit/webcit.h | 1 + 4 files changed, 24 insertions(+), 33 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099511114Tue, 04 Mar 2025 11:15:17 +05002099511114@Uncensored Date: Tue Mar 4 11:15:14 2025 -0500 Trying to sort out stuck webcit-https processes, but ended up reformatting some really funky source code ----------------------------------------------------------------------- Summary of changes: webcit/context_loop.c | 157 +++++++++++++++++++++++--------------------------- webcit/sysdep.c | 117 ++++++++++++++++--------------------- webcit/webcit.h | 2 + 3 files changed, 125 insertions(+), 151 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099508691Sat, 15 Feb 2025 22:59:14 +05002099508691@Uncensored Date: Sat Feb 15 22:59:02 2025 -0500 webcit-ng: completed room expire policy dialog ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/expire/expire_policy.c | 14 +- citadel/server/modules/expire/serv_expire.c | 2 - citadel/server/modules_init.c | 5 +- citadel/server/modules_init.h | 3 +- webcit-ng/Makefile | 2 +- webcit-ng/docs/api.txt | 24 +-- webcit-ng/server/room_functions.c | 214 ++++++++++++++------------ webcit-ng/static/js/edit_room.js | 84 ++++++---- 8 files changed, 203 insertions(+), 145 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099508585Fri, 14 Feb 2025 21:48:15 +05002099508585@Uncensored

 

Thu Feb 13 2025 23:50:13 UTCfrom IGnatius T Foobar Subject: Re: External encryption plugin?

Interesting. Are you looking to add message encryption right into the server via plugins?

 

Yes.

 

3. Set up the external encryption providers as microservices and connect to them over a socket, like we currently do with SpamAssassin and ClamAV.

 

This sounds sensible. Thanks for the pointers.

By the way, we don't really use a lot of the C99 extensions, mainly just the comment style.

Good to know! I'll look at the code and see what I can figure out.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099508446Thu, 13 Feb 2025 18:50:13 +05002099508446@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099508408Thu, 13 Feb 2025 13:45:47 +05002099508408@Uncensored

Greetings, all!

I'm a fairly new initiate to the Citadel ecosystem and I'd like to bring to light a potential problem with licensing and non-GNU encryption algorithms.

The Citadel server is GPL 3 licensed which requires patent permission to be public when using patented code with it. GNU-PG seems to be the only encryption utility I know of that satisfies the license terms. If a potential user needed something stronger or otherwise patented, it would not be possible in the present configuration.

My proposed solution to this dilemma is to take advantage of the fact that GNU-PG can function as a POSIX filter, accepting input via STDIN and sending output via STDOUT, with the exceptional case of an error code being returned that is logged from STDERR. Each of these can be redirected from another filter stream to chain filters end-to-end with pipes. This would allow the output of BZip2 or XZ compression to be piped through the encryption almost transparently with an external script.

In this configuration, neither the encryption nor the compression need to be GPL 3 license compatible since they are now external programs with their own separate licensing terms. This alleviates the problem of license compatibility and patent sharing required by version 3 of the GPL. Is this the type of solution that would be welcome here?

I'm quite fluent in C90 and should be able to navigate around C99 and newer extensions with some determination. I'm willing to commit some time to make the plugin system a reality for my own use and would love to keep this in the mainline as well.

Thanks for reading this. I hope to be in touch with you and address any concerns.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099507385Thu, 06 Feb 2025 19:25:01 +05002099507385@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099507384Thu, 06 Feb 2025 19:24:51 +05002099507384@Uncensored Date: Thu Feb 6 19:24:40 2025 -0500 Release version 1009 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/roomops.c | 10 +++++++--- webcit/webcit.h | 2 +- 6 files changed, 12 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506973Mon, 03 Feb 2025 22:59:46 +05002099506973@Uncensored Date: Mon Feb 3 22:59:34 2025 -0500 webcit-classic: still fiddling with the language selector trying to return it to its original functionality ----------------------------------------------------------------------- Summary of changes: webcit/context_loop.c | 45 ++++++++++++++---------------------- webcit/static.c | 12 +++++----- webcit/webcit.c | 63 ++++++++++++++++----------------------------------- webcit/webcit.h | 1 - webcit/webserver.c | 2 -- 5 files changed, 42 insertions(+), 81 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506969Mon, 03 Feb 2025 22:38:18 +05002099506969@Uncensored Date: Mon Feb 3 22:38:05 2025 -0500 I have a problem where I cannot work on a source file without updating its coding style to current standards first. ----------------------------------------------------------------------- Summary of changes: webcit/webcit.c | 308 +++++++++++++++++++++++--------------------------------- webcit/webcit.h | 5 - 2 files changed, 124 insertions(+), 189 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506940Mon, 03 Feb 2025 16:35:36 +05002099506940@Uncensored Date: Mon Feb 3 16:35:24 2025 -0500 html2html.c: code review ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/html2html.c | 150 ++++++++++++++++++++++--------------------- 1 file changed, 78 insertions(+), 72 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506634Fri, 31 Jan 2025 16:31:38 +05002099506634@Uncensored Date: Fri Jan 31 16:31:35 2025 -0500 Killing time, because it has fewer consequences than killing people. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/wiki/serv_wiki.c | 248 ++++++++++++++------------------ textclient/sysutil.c | 6 +- 2 files changed, 107 insertions(+), 147 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506532Thu, 30 Jan 2025 20:01:47 +05002099506532@Uncensored Date: Thu Jan 30 20:01:44 2025 -0500 serv_xmpp.c: modernized style (didn't need much) ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/xmpp/serv_xmpp.c | 185 +++++++++++--------------------- 1 file changed, 62 insertions(+), 123 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506365Wed, 29 Jan 2025 11:49:58 +05002099506365@Uncensored Date: Wed Jan 29 11:49:57 2025 -0500 webcit-ng: remove superfluous parentheses in return statements ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/caldav_reports.c | 8 ++++---- webcit-ng/server/forum_view.c | 2 +- webcit-ng/server/html2html.c | 4 ++-- webcit-ng/server/http.c | 14 +++++++------- webcit-ng/server/messages.c | 6 +++--- webcit-ng/server/room_functions.c | 6 +++--- webcit-ng/server/tcp_sockets.c | 4 ++-- webcit-ng/server/text2html.c | 10 +++++----- webcit-ng/server/tls.c | 4 ++-- webcit-ng/server/upload.c | 2 +- webcit-ng/server/util.c | 6 +++--- 11 files changed, 33 insertions(+), 33 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506363Wed, 29 Jan 2025 11:41:33 +05002099506363@Uncensored Date: Wed Jan 29 11:41:30 2025 -0500 icontheme.c (webcit-classic) : style cleanup ----------------------------------------------------------------------- Summary of changes: webcit/icontheme.c | 124 ++++++++++++++++++++++++----------------------------- 1 file changed, 55 insertions(+), 69 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506317Tue, 28 Jan 2025 23:21:54 +05002099506317@Uncensored Date: Tue Jan 28 23:21:52 2025 -0500 i18n working now, just need to document it ----------------------------------------------------------------------- Summary of changes: webcit/gettext.c | 2 -- webcit/webcit.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506314Tue, 28 Jan 2025 23:09:12 +05002099506314@Uncensored Date: Tue Jan 28 23:09:10 2025 -0500 webcit-classic: more tinkering trying to figure out why gettext() is not translating ----------------------------------------------------------------------- Summary of changes: webcit/gettext.c | 1 + webcit/ical_dezonify.c | 8 ++++---- webcit/webcit.h | 38 ++++++++++++++++++-------------------- 3 files changed, 23 insertions(+), 24 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506294Tue, 28 Jan 2025 22:20:01 +05002099506294@Uncensored

Thank you!  I have added it to the logo page at https://www.citadel.org/citadel_logo.html

I'm not sure why the designer didn't include that in the first place.  Lots of software can display native SVG now.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506093Sun, 26 Jan 2025 18:12:20 +05002099506093@Uncensored

I've imported the PDF logo into Inkscape and exported it to a plain SVG if anybody is interested. The image is above.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506040Sat, 25 Jan 2025 19:15:14 +05002099506040@Uncensored Date: Sat Jan 25 19:15:12 2025 -0500 webcit-classic: remove the empty boxes and vestigial code for social logins ----------------------------------------------------------------------- Summary of changes: webcit/configure.ac | 4 +- webcit/gettext.c | 173 ++++++++++++++++--------------------- webcit/static/authmethods.js | 4 - webcit/static/styles/webcit.css | 4 +- webcit/static/t/get_logged_in.html | 76 ++-------------- 5 files changed, 81 insertions(+), 180 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099506031Sat, 25 Jan 2025 18:22:22 +05002099506031@Uncensored Date: Sat Jan 25 18:22:20 2025 -0500 skeleton code for expire policy config ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 62 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 56 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099505887Fri, 24 Jan 2025 13:09:22 +05002099505887@Uncensored Date: Fri Jan 24 13:09:20 2025 -0500 Made some old code more readable ----------------------------------------------------------------------- Summary of changes: citadel/server/internet_addressing.c | 47 ++++++++++++++++++++++-------------- 1 file changed, 29 insertions(+), 18 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099505436Tue, 21 Jan 2025 07:13:46 +05002099505436@Uncensored

22 is open from here.. 

( web is not, but may not supposed to be anyway )

Tue Jan 21 2025 02:26:58 UTC from IGnatius T Foobar Subject: Re: Database Deadlock Handling

I tried to access test.citadel.org and it cannot connect.  I cannot
access as mail server or ssh.  Am I missing something?

I don't think so ... the IPv4 address is 72.0.224.94 and the IPv6 address is 2606:8800:21:12::4800:e05e

And the log is full of bad password attempts from the usual roaming gangs of bad people, so the SSH port is definitely open.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099505392Mon, 20 Jan 2025 22:04:26 +05002099505392@Uncensored Date: Mon Jan 20 22:04:24 2025 -0500 Removed spurious calls to stty_ctdl(SB_CHARMODE); they were making the status line go blank ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 5 ----- 1 file changed, 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099505370Mon, 20 Jan 2025 21:26:58 +05002099505370@UncensoredI tried to access test.citadel.org and it cannot connect.  I cannot >access as mail server or ssh.  Am I missing something? I don't think so ... the IPv4 address is 72.0.224.94 and the IPv6 address is 2606:8800:21:12::4800:e05e And the log is full of bad password attempts from the usual roaming gangs ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099505346Mon, 20 Jan 2025 18:00:15 +05002099505346@Uncensored Date: Mon Jan 20 18:00:11 2025 -0500 Room edit screen: expand and collapse buttons for all sections ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 8 +++++ webcit-ng/static/js/edit_room.js | 70 ++++++++++++++++++++++++++++++++-------- 2 files changed, 65 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099505227Mon, 20 Jan 2025 00:27:09 +05002099505227@Uncensored Date: Mon Jan 20 00:27:07 2025 -0500 CSS changes to make the room edit screen fieldsets collapsible (kind of like an accordion dialog) ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 29 +++++++++++++++++++++++++---- webcit-ng/static/js/edit_room.js | 6 +++++- 2 files changed, 30 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099505191Sun, 19 Jan 2025 19:37:15 +05002099505191@Uncensored

Compared the Makefiles and only optimization.  Copied yours and still deadlocks...  When I get access to test, I should be able to figure out if it is my system or something else

Mon Jan 20 2025 00:03:34 UTC from HarlowSolutions Subject: Re: Database Deadlock Handling

Sorry for the delay.  H have family in Los Angeles and have been distracted.  Actually in LA now.  Family and residence ok.

I tried to access test.citadel.org and it cannot connect.  I cannot access as mail server or ssh.  Am I missing something?

Wed Jan 15 2025 03:21:48 UTC from IGnatius T Foobar Subject: Re: Database Deadlock Handling

I am still really interested in why they run differently.  Since some of the Makefiles are created with autoconfig, maybe there is a difference in the Makefiles.  Can you give me the following Makefiles from your system so I can compare to mine:

• db-18.1.40/build_unix/Makefile
• libcitadel/lib/xdgmime/Makefile
• libcitadel/Makefile
• citadel/Makefile

Ok, here are the makefiles (attached).

I've also set up a Rocky Linux 9 at test.citadel.org.  I copied over your account name and hashed password from www.citadel.org so you should be able to log in.  Let me know if that works.

 

 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099505185Sun, 19 Jan 2025 19:12:51 +05002099505185@Uncensored

That is good everyone is ok.  

Mon Jan 20 2025 00:03:34 UTC from HarlowSolutions Subject: Re: Database Deadlock Handling

Sorry for the delay.  H have family in Los Angeles and have been distracted.  Actually in LA now.  Family and residence ok.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099505183Sun, 19 Jan 2025 19:03:34 +05002099505183@Uncensored

Sorry for the delay.  H have family in Los Angeles and have been distracted.  Actually in LA now.  Family and residence ok.

I tried to access test.citadel.org and it cannot connect.  I cannot access as mail server or ssh.  Am I missing something?

Wed Jan 15 2025 03:21:48 UTC from IGnatius T Foobar Subject: Re: Database Deadlock Handling

I am still really interested in why they run differently.  Since some of the Makefiles are created with autoconfig, maybe there is a difference in the Makefiles.  Can you give me the following Makefiles from your system so I can compare to mine:

• db-18.1.40/build_unix/Makefile
• libcitadel/lib/xdgmime/Makefile
• libcitadel/Makefile
• citadel/Makefile

Ok, here are the makefiles (attached).

I've also set up a Rocky Linux 9 at test.citadel.org.  I copied over your account name and hashed password from www.citadel.org so you should be able to log in.  Let me know if that works.

 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504812Thu, 16 Jan 2025 22:27:23 +05002099504812@UncensoredIn the process of looking at other bindings for the Citadel protocol, I >wanted to look at the 3rd party code >at https://bitbucket.org/pystew/citadel but the code is not public or >visible any more. Does somebody have an updated link? I know that did exist at one time but I haven't looked at it in ages. I do a fair bit of Python programming but none of it is on the Citadel project. Unfortunately it's probably safe to assume that this went unmaintained and eventually went away. Looks like it's been gone for a while, too ... archive.org's oldest archive is June 2020 and it's a blank page, after that it goes to the not-found screen. I'll go through the list of third party contributions on the web site and ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504729Thu, 16 Jan 2025 11:57:32 +05002099504729@Uncensoreduote and

rint use the new scr_redir api html_to_ascii() accept screenwidth=0 to suppress soft line breaks in conversion Merge branch 'master' into console_rework Phasing out fmout() fmout() subst mode is long gone, remove the param war on fmout() read_one_message() now converts legacy message format to unwrapped lines. Let the screen.c renderer handle soft line wrap. footprint-reduced fmout() that is only needed until we rewrite the message editor suppress the paginator when redirecting output to a memory buffer Minor string formatting changes Editing system banners now requires an external editor (for now). textclient.h: much cleanup, see description below. Replace non-obvious 'mode' variable with 'editor_mode' and enum'ed options strproc() is now sanitize_string() and has improved badassery ka_system() is no longer called by anything. Removed. messages.c: war on goto statements continued, this time in the editor save options loop Newfangled string traversal process_quote() cleanup. second tempfile is far more ephemeral now and no longer a global variable. <.E>nter scii now converts CRLF to LF, avoids unwanted double-spacing Please forgive my frequent small commits. They are probably annoying. Replaced most of the error messages with a new macro call scr_perror() Rewrote the built in editor. replace size_t with int where signed comparisons are needed Saving my work because I'm about to try something citedit: rely on screen.c to tell us what column we're actually in. messages.c: more fine tuning of the editor. Moar editor tweaks Consolidating terminal stuff into screen.c screen.c: more simplification of stty_ctdl() initial go at restoring the status line messages.c: dial back word wrap by one more column disable debug bar Completed the return of the status line. Merge branch 'console_rework' msgbase.c: editor display/edit modes Oops! My attempt to DRY the null termination created a bug. Reversed that. Oops, I left the debug bar in. Let's tuck that away. Mac OS Terminal sucks Skeleton screen for room edit WebCit Classic: fixed improper English in room edit screens. tcp_sockets.c: eliminate unix domain socket server - never used in WebCit-NG edit_room.js: set up the formgrids and fieldsets We do have 'Save changes' in our message catalog. Use that. New function do_whatever_seems_sensible_upon_landing() Support DELETE method to delete a room. Delete Room operation is working in webcit-ng Rendered the rest of the admin box. Also fixed some spelling errors in webcit.pot (and corresponding in all .po files referencing it) idle terminal adjustment document the DELETE method for a room Completed the screens to edit a room banner. Both versions of webcit - change 'room info file' to 'room banner' Random acts of style cleanup Display room icon in the banner icon upload screen ... started ctdl-formgrid-fieldset-stealth class to hide extra borders More options for the uploader. Did the JS side of 'save room icon' Update banners for 2025 Replace room icon: complete Blowing off steam because I am explosively angry right now. More changing of 'aide' to 'administrator' in message catalog. Populate the room edit screen's floor selector with the actual floors available. /ctdl/r//config now returns all the GETR attributes. Continued fleshing out the 'Edit room' screen. Add -b (big message) and -w (write only) switches to loadtest ipcdef.h is superfluous, all these defs are in libcitadel.h libcitadel.h: random acts of style cleanup QR_INUSE flag is no longer relevant. Removed it. Revert "QR_INUSE flag is no longer relevant. Removed it." Add remaining QR2_ flags to json api configuration screen complete (but not fully populated yet) edit_room.js: populate remaining config options with data loadtest: make sure test messages are never zero length. Parse POST of application/x-www-form-urlencoded identically to query parameters. /ctdl/a/login now uses application/x-www-form-urlencoded query parameters. screen.c: use ESC 7 (DECSC) and ESC 8 (DECRC) to save/restore cursor position. room edit: saving of flags is now complete Finished the string room parameters. Room config: move save/cancel buttons inside config panel Don't try to set dkim_from_domain if fromaddr is empty Comment out opencmd in stock citadel.rc Release version 1008 generated by do-release.sh Harlow Solutions (10): Lock mutexes were never initialized. Implemented proper initialization and added error checking to initialization, lock and unlock. msgbase.c: Sending message without locking caused deadlock coredump. msgbase.c: Fixing room locking bug when saving message. msgbase.c: When saving message, switch from locking room to regular lock. msgbase.c: Fixing room locking bug when saving message. msgbase.c: When saving message, switch from locking room to regular lock. serv_inboxrules.c: Make global array of users (users_requiring_inbox_processing[]) thread safe. Fix coredumps caused by context cleanups at shutdown Shutdown the worker threads a little faster. Stop indexing messages on shutdown ----------------------------------------------------------------------- -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504728Thu, 16 Jan 2025 11:57:31 +05002099504728@Uncensored Date: Thu Jan 16 11:57:30 2025 -0500 Release version 1008 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504727Thu, 16 Jan 2025 11:57:09 +05002099504727@Uncensored Date: Thu Jan 16 11:57:07 2025 -0500 Comment out opencmd in stock citadel.rc ----------------------------------------------------------------------- Summary of changes: textclient/citadel.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504724Thu, 16 Jan 2025 11:54:45 +05002099504724@Uncensored Date: Thu Jan 16 11:54:43 2025 -0500 Don't try to set dkim_from_domain if fromaddr is empty ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/smtp/serv_smtpclient.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504595Wed, 15 Jan 2025 15:48:56 +05002099504595@Uncensored

In the process of looking at other bindings for the Citadel protocol, I wanted to look at the 3rd party code at https://bitbucket.org/pystew/citadel but the code is not public or visible any more. Does somebody have an updated link?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504513Tue, 14 Jan 2025 23:05:39 +05002099504513@Uncensored Date: Tue Jan 14 23:05:37 2025 -0500 Room config: move save/cancel buttons inside config panel ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504510Tue, 14 Jan 2025 22:37:58 +05002099504510@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504507Tue, 14 Jan 2025 22:21:48 +05002099504507@Uncensored

I am still really interested in why they run differently.  Since some of the Makefiles are created with autoconfig, maybe there is a difference in the Makefiles.  Can you give me the following Makefiles from your system so I can compare to mine:

• db-18.1.40/build_unix/Makefile
• libcitadel/lib/xdgmime/Makefile
• libcitadel/Makefile
• citadel/Makefile

Ok, here are the makefiles (attached).

I've also set up a Rocky Linux 9 at test.citadel.org.  I copied over your account name and hashed password from www.citadel.org so you should be able to log in.  Let me know if that works.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504429Mon, 13 Jan 2025 23:20:42 +05002099504429@Uncensored Date: Mon Jan 13 23:20:35 2025 -0500 Finished the string room parameters. commit 6f89a801eb3dc0d7f69b0ecd47a6a6ef4737e23a Author: Art Cancro Date: Fri Jan 10 00:16:32 2025 -0500 room edit: saving of flags is now complete ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 160 +++++++++++++++++++++++++------------- webcit-ng/server/webcit.h | 4 +- webcit-ng/static/js/edit_room.js | 25 +++--- 3 files changed, 126 insertions(+), 63 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504416Mon, 13 Jan 2025 19:07:36 +05002099504416@Uncensored

I run Rocky in a VirtualBox machine.

The deadlocks seem to be intermittent.  I was testing for a while and never had a deadlock, and then all of a sudden, I get them all the time.

Recovering from deadlocks requires some code which I have written, but if it is not occurring for others, I am hesitant to check it in.  The existing code will coredump on the next DB operation.

I am interested in getting to the root cause of why my system is showing this issue, so if you can recreate, great.  Still if you can send me the makefiles, I am curious if there is a difference that may change timing or something and help figure out the root cause.

I have been able to avoid all the deadlocks by locking around all the database operations for MSGMAIN and BIGMSGS.  It does not negatively affect performance and is fairly simple.  I think it is worth checking in because it will avoid deadlocks if they show up even on other systems and would need to be included if we do decide to implement deadlock recovery because it is more efficient than the database trying to recover.

I have crated branch BDB_Message_Lock which implements just the locks.  The only big thing in implementing it was I had to move the mutex locking to libcitadel because the BDB code is used externally and cannot access the begin and end critical section calls.  The critical section code is still in threads.c, but it uses the new library functions to actually lock/unlock.  I added the new locks to the end of tools.c  I implemented more generically so it can be used by any app and have  lot of error checking just in case.

If you think it is worth it you can test and just merge it into master.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504401Mon, 13 Jan 2025 17:08:05 +05002099504401@Uncensored

I run Rocky in a VirtualBox machine.

The deadlocks seem to be intermittent.  I was testing for a while and never had a deadlock, and then all of a sudden, I get them all the time.

Recovering from deadlocks requires some code which I have written, but if it is not occurring for others, I am hesitant to check it in.  The existing code will coredump on the next DB operation.

I am interested in getting to the root cause of why my system is showing this issue, so if you can recreate, great.  Still if you can send me the makefiles, I am curious if there is a difference that may change timing or something and help figure out the root cause.

I have been able to avoid all the deadlocks by locking around all the database operations for MSGMAIN and BIGMSGS.  It does not negatively affect performance and is fairly simple.  I think it is worth checking in because it will avoid deadlocks if they show up even on other systems and would need to be included if we do decide to implement deadlock recovery because it is more efficient than the database trying to recover.

I have crated branch BDB_Message_Lock which implements just the locks.  The only big thing in implementing it was I had to move the mutex locking to libcitadel because the BDB code is used externally and cannot access the begin and end critical section calls.  The critical section code is still in threads.c, but it uses the new library functions to actually lock/unlock.  I added the new locks to the end of tools.c  I implemented more generically so it can be used by any app and have  lot of error checking just in case.

If you think it is worth it you can test and just merge it into master.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504398Mon, 13 Jan 2025 16:43:01 +05002099504398@Uncensored Date: Mon Jan 13 16:39:12 2025 -0500 Implemented mutex locks around all Berkeley DB operations to avoid deadlocks. Mutex lock all database operations to MSGMAIN and BIGMSGS to avoid Berkeley DB operations internally deadlocking. Moved mutex locking from threads.c in citserver to tools.c in libcitadel so Berkley DB code can perform locks in citserver and utility programs. begin and end critical sections still in threads.c, but now use libcitadel locking. No performance impact detected. commit a8eac13dee85a8a84c4235e3b7c4c9c7c79bf861 Author: Harlow Solutions Date: Sun Jan 12 20:43:57 2025 -0500 ----------------------------------------------------------------------- -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504368Mon, 13 Jan 2025 10:08:42 +05002099504368@Uncensored

I have been thinking about this and I can switch to a different Linux if that will make it more stable.  I just used Rocky because I used CentOS at work for a long time so using it was just easy.  What Linux do you recommend?

That depends on how much patience you have  :)

If there is a bug that only manifests on Rocky Linux, then it's still a bug and I'd like to get it fixed.  Perhaps I can get a Rocky Linux installation going over here and we can try to reproduce the problem again.  I could even copy over a known working test database just to make sure.  Are you running Rocky in a virtual machine, in a container, or on bare metal?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504315Sun, 12 Jan 2025 20:46:17 +05002099504315@Uncensored Date: Sun Jan 12 20:43:57 2025 -0500 Stop indexing messages on shutdown ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/fulltext/serv_fulltext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504186Fri, 10 Jan 2025 18:14:05 +05002099504186@Uncensored

I have been thinking about this and I can switch to a different Linux if that will make it more stable.  I just used Rocky because I used CentOS at work for a long time so using it was just easy.  What Linux do you recommend?

I am still really interested in why they run differently.  Since some of the Makefiles are created with autoconfig, maybe there is a difference in the Makefiles.  Can you give me the following Makefiles from your system so I can compare to mine:

• db-18.1.40/build_unix/Makefile
• libcitadel/lib/xdgmime/Makefile
• libcitadel/Makefile
• citadel/Makefile

 

Thu Jan 09 2025 00:52:48 UTC from HarlowSolutions Subject: Re: Database Deadlock Handling

It baffles me too.  I just assumed it was my load testing that made it show up but when I deleted all the directories, and downloaded/ran easyinstall and loadtest caused the deadlock, became very confused.  What really confuses me is while I have been working on deadlock recovery, the problem switched from deadlocking on MSGMAIN to BIGMSGS.  I have a headache....

I am running Rocky Linux 9.5 (Blue Onyx) 5.14.0-503.19.1.el9_5.x86_64

My data filesystem is ext4

Other than I have disabled SELinux, it is pretty much out of the box.

The only thing I can think of is a difference in timing may be throwing off the database code.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504165Fri, 10 Jan 2025 15:18:11 +05002099504165@Uncensored

I thought the site was down, but it looks like the SSL port is not listening or firewalled.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099504037Thu, 09 Jan 2025 12:01:28 +05002099504037@Uncensored Date: Thu Jan 9 12:00:35 2025 -0500 screen.c: use ESC 7 (DECSC) and ESC 8 (DECRC) to save/restore cursor position. These are older sequences that might work on more terminals. Anyone got a Mac to try this on? ----------------------------------------------------------------------- Summary of changes: textclient/screen.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503976Wed, 08 Jan 2025 19:52:48 +05002099503976@Uncensored

It baffles me too.  I just assumed it was my load testing that made it show up but when I deleted all the directories, and downloaded/ran easyinstall and loadtest caused the deadlock, became very confused.  What really confuses me is while I have been working on deadlock recovery, the problem switched from deadlocking on MSGMAIN to BIGMSGS.  I have a headache....

I am running Rocky Linux 9.5 (Blue Onyx) 5.14.0-503.19.1.el9_5.x86_64

My data filesystem is ext4

Other than I have disabled SELinux, it is pretty much out of the box.

The only thing I can think of is a difference in timing may be throwing off the database code.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503898Tue, 07 Jan 2025 23:10:50 +05002099503898@Uncensored Date: Tue Jan 7 23:10:47 2025 -0500 /ctdl/a/login now uses application/x-www-form-urlencoded query parameters. It was just a dumb delimited string before. Now it's prim and proper. Makes sense, I guess. This was the very first API call we built and I was just figuring things out. What we've got now is actually a very elegantly designed application server. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/admin_functions.c | 8 +++----- webcit-ng/static/js/login.js | 38 ++++++++++++++++++++++---------------- 2 files changed, 25 insertions(+), 21 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503895Tue, 07 Jan 2025 22:45:21 +05002099503895@Uncensored Date: Tue Jan 7 22:45:18 2025 -0500 Parse POST of application/x-www-form-urlencoded identically to query parameters. Also added the post side of saving room config parameters. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/http.c | 47 +++++++++++++++--------- webcit-ng/server/room_functions.c | 33 +++++++++++++++-- webcit-ng/server/webcit.h | 4 +-- webcit-ng/static/js/edit_room.js | 76 +++++++++++++++++++++++---------------- 4 files changed, 110 insertions(+), 50 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503849Tue, 07 Jan 2025 17:13:53 +05002099503849@Uncensored Date: Tue Jan 7 17:13:50 2025 -0500 loadtest: make sure test messages are never zero length. ----------------------------------------------------------------------- Summary of changes: citadel/utils/loadtest.c | 6 ++++- webcit-ng/docs/api.txt | 4 ++++ webcit-ng/server/room_functions.c | 11 +++++++++ webcit-ng/static/js/edit_room.js | 47 ++++++++++++++++++++++++++++++--------- 4 files changed, 56 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503826Tue, 07 Jan 2025 14:40:44 +05002099503826@Uncensored

As always if you need an extra sandbox, just yell.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503810Tue, 07 Jan 2025 14:13:12 +05002099503810@UncensoredI ran the code from master (no changes) against loadtest (no >parameters, >so 10 threads) and I get a coredump within 30 seconds. > >   citserver[43011]: bdb: bdb_delete(00): BDB0068 DB_LOCK_DEADLOCK: >Locker killed to resolve a deadlock Ok, so stock citserver and stock loadtest are doing that on your machine, with no modifications to either one? If that is the case, there's something very weird going on and we're probably both barking up the wrong tree. There are countless thousands of Citadel Server instances in use around the world and this problem ought to be endemic if it is in the mainline code. So let's figure out what's different here. Let me reiterate that I completely believe what you're saying and I want to help develop a solution. But right now I'm baffled. Let's start with the basics. May I assume that you are running a mainstream Linux distribution on either AMD64 or ARM64 architecture? What filesystem is in use? Anything else special or unusual? If we can't figure out the difference then my next step might be to set up ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503790Tue, 07 Jan 2025 10:53:46 +05002099503790@Uncensored

Same results with a fresh easyinstall of v1007.

Tue Jan 07 2025 05:10:21 UTC from HarlowSolutions Subject: Re: Database Deadlock Handling

I ran the code from master (no changes) against loadtest (no parameters, so 10 threads) and I get a coredump within 30 seconds.

   citserver[43011]: bdb: bdb_delete(00): BDB0068 DB_LOCK_DEADLOCK: Locker killed to resolve a deadlock

I will have to try again with a clean easyinstall just in case my build environment is causing something different.  Can you try again and look in the system log for "DEADLOCK" or "Core Dump".

As a side note, when I run loadtest, I get a bunch of error messages in the system log from citserver about NULL bodies.  I don't think they are related to the deadlocks, but not sure why I am getting them.  Do you get this too?

   msgbase: ERROR; attempt to save message with NULL body

 

 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503755Tue, 07 Jan 2025 00:10:21 +05002099503755@Uncensored

I ran the code from master (no changes) against loadtest (no parameters, so 10 threads) and I get a coredump within 30 seconds.

   citserver[43011]: bdb: bdb_delete(00): BDB0068 DB_LOCK_DEADLOCK: Locker killed to resolve a deadlock

I will have to try again with a clean easyinstall just in case my build environment is causing something different.  Can you try again and look in the system log for "DEADLOCK" or "Core Dump".

As a side note, when I run loadtest, I get a bunch of error messages in the system log from citserver about NULL bodies.  I don't think they are related to the deadlocks, but not sure why I am getting them.  Do you get this too?

   msgbase: ERROR; attempt to save message with NULL body

 

Mon Jan 06 2025 05:06:01 UTC from HarlowSolutions Subject: Re: Database Deadlock Handling

I will try loadtest and see if I can recreate.  If not I will see about modifying it to make it recreate.

As for the configuration settings, the workers are started and added in threads.c  I think it looks at the upper limit, but does not do anything with a lower limit.  Both are probably useful.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503723Mon, 06 Jan 2025 13:21:05 +05002099503723@Uncensored Date: Mon Jan 6 13:21:03 2025 -0500 edit_room.js: populate remaining config options with data ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503653Mon, 06 Jan 2025 00:06:01 +05002099503653@Uncensored

I will try loadtest and see if I can recreate.  If not I will see about modifying it to make it recreate.

As for the configuration settings, the workers are started and added in threads.c  I think it looks at the upper limit, but does not do anything with a lower limit.  Both are probably useful.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503648Sun, 05 Jan 2025 20:51:53 +05002099503648@Uncensored Date: Sun Jan 5 20:51:50 2025 -0500 configuration screen complete (but not fully populated yet) ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 81 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 73 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503585Sat, 04 Jan 2025 19:53:33 +05002099503585@UncensoredRevert "QR_INUSE flag is no longer relevant. Removed it." Geez. That was quite the fail. QR_INUSE was a holdover from the days between 1987 and 1998, when the rooms table was a flat file containing a fixed number of records. QR_INUSE meant that a particular slot in the file held an active record; its absence meant that a new room could be stored there. That isn't really needed anymore because when we remove a record (from any table) it is simply deleted from the database, so there's no longer any reason to have a flag that says "yes, this is a real record and not empty space." I thought I removed it properly, but a little while later, half of my test system vanished. I still don't know exactly why, but it's definitely something in that commit. So it's back for now. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503579Sat, 04 Jan 2025 19:37:26 +05002099503579@Uncensored Date: Sat Jan 4 19:37:24 2025 -0500 Add remaining QR2_ flags to json api ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/expire/serv_expire.c | 9 ++------- webcit-ng/server/room_functions.c | 5 +++++ 2 files changed, 7 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503578Sat, 04 Jan 2025 19:34:19 +05002099503578@Uncensored Date: Sat Jan 4 19:33:46 2025 -0500 Revert "QR_INUSE flag is no longer relevant. Removed it." This reverts commit 2832f788f938b3d68074dd46ce8db81a529ba270. ----------------------------------------------------------------------- Summary of changes: citadel/server/housekeeping.c | 8 +++++++- citadel/server/modules/ctdlproto/serv_rooms.c | 27 +++++++++++++++++---------- citadel/server/room_ops.c | 8 +++++--- webcit-ng/server/room_functions.c | 5 ----- 4 files changed, 29 insertions(+), 19 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503571Sat, 04 Jan 2025 16:56:17 +05002099503571@Uncensored Date: Sat Jan 4 16:56:15 2025 -0500 QR_INUSE flag is no longer relevant. Removed it. ----------------------------------------------------------------------- Summary of changes: citadel/server/housekeeping.c | 8 +------- citadel/server/modules/ctdlproto/serv_rooms.c | 27 ++++++++++----------------- citadel/server/room_ops.c | 8 +++----- webcit-ng/server/room_functions.c | 5 +++++ 4 files changed, 19 insertions(+), 29 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503568Sat, 04 Jan 2025 16:34:17 +05002099503568@Uncensored Date: Sat Jan 4 16:34:14 2025 -0500 libcitadel.h: random acts of style cleanup ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/libcitadel.h | 272 +++++++++++++++++++------------------------- 1 file changed, 117 insertions(+), 155 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503565Sat, 04 Jan 2025 16:18:16 +05002099503565@Uncensored Date: Sat Jan 4 16:18:14 2025 -0500 ipcdef.h is superfluous, all these defs are in libcitadel.h ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 1 - citadel/server/ipcdef.h | 82 ---------------------------------------- webcit-ng/static/js/edit_room.js | 9 +++++ 3 files changed, 9 insertions(+), 83 deletions(-) delete mode 100644 citadel/server/ipcdef.h -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503558Sat, 04 Jan 2025 15:29:59 +05002099503558@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503557Sat, 04 Jan 2025 15:28:26 +05002099503557@UncensoredI run 50 threads, each sending 50 messages each (Total: 2500 messages). > >Each message has 80000 characters in the body. Check the latest version of loadtest, I added two new options: -b Big message mode. Posts 80000 byte printer test style messages instead of lipsum. -w Write-only mode. All threads hammer a single room with writes instead of random operations. My test was ./loadtest -b -n80 -w but unfortunately I was still not able to make it deadlock. I also noticed that we have configuration settings "c_min_workers" and "c_max_workers" to control the size of the thread pool, and we don't actually do anything with those settings. They might have been removed at some point. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503554Sat, 04 Jan 2025 15:21:09 +05002099503554@Uncensored Date: Sat Jan 4 12:21:05 2025 -0800 Add -b (big message) and -w (write only) switches to loadtest ----------------------------------------------------------------------- Summary of changes: citadel/utils/loadtest.c | 69 ++++++++++++++++++++++++++++++++++-------------- 1 file changed, 49 insertions(+), 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503503Fri, 03 Jan 2025 22:57:44 +05002099503503@Uncensored Date: Fri Jan 3 22:57:41 2025 -0500 Continued fleshing out the 'Edit room' screen. Continued wishing an excruciating death upon the person who wronged me. Die die die. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 42 +++++++++++----- webcit-ng/static/js/edit_room.js | 101 +++++++++++++++++++++++++++++++++++++-- 2 files changed, 127 insertions(+), 16 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503481Fri, 03 Jan 2025 18:46:38 +05002099503481@Uncensored Date: Fri Jan 3 18:46:36 2025 -0500 /ctdl/r//config now returns all the GETR attributes. May the enemy still on my mind suffer slowly and die painfully. ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 1 + webcit-ng/server/room_functions.c | 72 +++++++++++++++++++++++++++++++++++++-- 2 files changed, 70 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503477Fri, 03 Jan 2025 18:21:12 +05002099503477@Uncensored Date: Fri Jan 3 18:21:10 2025 -0500 Populate the room edit screen's floor selector with the actual floors available. Also, continuing to dwell on how much I seriously want a single specific person to get stabbed in the face with my truck. Die, asshole. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 13 +++++++++++++ webcit-ng/static/js/roomlist.js | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503469Fri, 03 Jan 2025 17:12:48 +05002099503469@Uncensored Date: Fri Jan 3 17:12:46 2025 -0500 More changing of 'aide' to 'administrator' in message catalog. Also, I am still explosively angry. May the person who made me this angry die immediately and painfully. You know who you are, but you're definitely not reading this because you're too stupid to be part of an open source project. I hope you suffer greatly. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 6 +++++- webcit/po/webcit/ar.po | 10 +++++----- webcit/po/webcit/bg.po | 10 +++++----- webcit/po/webcit/cs.po | 10 +++++----- webcit/po/webcit/da.po | 10 +++++----- webcit/po/webcit/de.po | 10 +++++----- webcit/po/webcit/el.po | 10 +++++----- webcit/po/webcit/en_GB.po | 20 ++++++++++---------- webcit/po/webcit/es.po | 10 +++++----- webcit/po/webcit/et.po | 10 +++++----- webcit/po/webcit/fi.po | 10 +++++----- webcit/po/webcit/fr.po | 10 +++++----- webcit/po/webcit/he.po | 10 +++++----- webcit/po/webcit/hu.po | 10 +++++----- webcit/po/webcit/it.po | 10 +++++----- webcit/po/webcit/kk.po | 10 +++++----- webcit/po/webcit/ko.po | 10 +++++----- webcit/po/webcit/nl.po | 10 +++++----- webcit/po/webcit/pl.po | 10 +++++----- webcit/po/webcit/pt_BR.po | 10 +++++----- webcit/po/webcit/ro.po | 10 +++++----- webcit/po/webcit/ru.po | 10 +++++----- webcit/po/webcit/sl.po | 10 +++++----- webcit/po/webcit/sv.po | 10 +++++----- webcit/po/webcit/tr.po | 10 +++++----- webcit/po/webcit/webcit.pot | 10 +++++----- webcit/po/webcit/zh.po | 10 +++++----- webcit/static/t/aide/display_aliases.html | 2 +- webcit/static/t/aide/display_sitewide_config.html | 2 +- webcit/static/t/aide/edituser/select.html | 2 +- webcit/static/t/aide/siteconfig/tab_access.html | 6 +++--- webcit/static/t/room/edit/tab_config.html | 2 +- 32 files changed, 147 insertions(+), 143 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503464Fri, 03 Jan 2025 16:59:36 +05002099503464@Uncensored Date: Fri Jan 3 16:59:34 2025 -0500 Blowing off steam because I am explosively angry right now. ----------------------------------------------------------------------- Summary of changes: webcit/siteconfig.c | 118 ++++++++++++++++++++-------------------------------- 1 file changed, 46 insertions(+), 72 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503374Thu, 02 Jan 2025 23:50:54 +05002099503374@Uncensored Date: Thu Jan 2 23:50:51 2025 -0500 Replace room icon: complete ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/request.c | 11 ++++++-- webcit-ng/server/room_functions.c | 54 +++++++++++++++++++++++++++++++++++++-- webcit-ng/server/upload.c | 16 ++++++------ webcit-ng/static/js/edit_room.js | 3 ++- 4 files changed, 71 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503302Thu, 02 Jan 2025 09:47:33 +05002099503302@Uncensored Date: Thu Jan 2 09:47:31 2025 -0500 Update banners for 2025 ----------------------------------------------------------------------- Summary of changes: citadel/server/server_main.c | 6 +- ctdlsh/config.c | 26 +++---- ctdlsh/datetime.c | 13 ++-- ctdlsh/export.c | 9 +-- ctdlsh/mailq.c | 31 ++++---- ctdlsh/main.c | 52 ++++++------- ctdlsh/main.c~ | 175 ------------------------------------------- ctdlsh/passwd.c | 9 +-- ctdlsh/shutdown.c | 9 +-- ctdlsh/sockets.c | 95 +++++++++-------------- ctdlsh/who.c | 13 ++-- webcit-ng/server/main.c | 4 +- webcit/webserver.c | 4 +- 13 files changed, 110 insertions(+), 336 deletions(-) delete mode 100644 ctdlsh/main.c~ -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503133Tue, 31 Dec 2024 12:55:39 +05002099503133@Uncensored Date: Tue Dec 31 12:47:11 2024 -0500 Did the JS side of 'save room icon' ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 2 +- webcit-ng/server/room_functions.c | 22 ++++++++++++---------- webcit-ng/static/js/edit_room.js | 21 +++++++++++++++++++++ 3 files changed, 34 insertions(+), 11 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099503044Mon, 30 Dec 2024 14:12:40 +05002099503044@Uncensored Date: Mon Dec 30 14:12:20 2024 -0500 Shutdown the worker threads a little faster. ----------------------------------------------------------------------- Summary of changes: citadel/server/sysdep.c | 57 +++++++++++++++++++++++++++++++++++++------------ 1 file changed, 43 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502977Mon, 30 Dec 2024 08:31:42 +05002099502977@Uncensored

I found that I can reproduce with 10 threads.  You do need to patch threads.c to open more than 10 workers so they do not get serialized.  Eventually a running server would increase the number of workers, so just adding them at the start to reproduce faster is a valid test.  You also have to remove the S_SAVE_THIS_MSG locks to reproduce reliably.  In my testing, I would get intermittent deadlocks even with the S_SAVE_THIS_MSG locks from other database accesses, so the S_SAVE_THIS_MSG gets rid of most of the conflicts.

Sun Dec 29 2024 22:29:09 UTC from HarlowSolutions Subject: Re: Database Deadlock Handling

I can reproduce it consistently.  You just have to run a test program with a good number of threads that each send multiple large messages in SMTP.  Here is what I am running with to benchmark that will cause deadlocks without locks.  The current master code has a lock around the stores in save_this_message, so you may want to remove those to force more deadlocks.  Those locks worked until I really stressed it and found that they only avoided the main deadlocking.

I initially create 100 workers at startup in thread.c.  You should be able to deadlock a lot more if you do not do this, but a lot of threads will time out.

I run 50 threads, each sending 50 messages each (Total: 2500 messages).

Each message has 80000 characters in the body.

Again, this is not a realistic test case, I am just stressing the server to find areas that need hardening.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502901Sun, 29 Dec 2024 17:29:09 +05002099502901@Uncensored

I can reproduce it consistently.  You just have to run a test program with a good number of threads that each send multiple large messages in SMTP.  Here is what I am running with to benchmark that will cause deadlocks without locks.  The current master code has a lock around the stores in save_this_message, so you may want to remove those to force more deadlocks.  Those locks worked until I really stressed it and found that they only avoided the main deadlocking.

I initially create 100 workers at startup in thread.c.  You should be able to deadlock a lot more if you do not do this, but a lot of threads will time out.

I run 50 threads, each sending 50 messages each (Total: 2500 messages).

Each message has 80000 characters in the body.

Again, this is not a realistic test case, I am just stressing the server to find areas that need hardening.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502897Sun, 29 Dec 2024 16:44:29 +05002099502897@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502883Sun, 29 Dec 2024 10:36:17 +05002099502883@Uncensored

You can decide if you want to add the code or not.  I am still developing and testing.  Here are the details for what I have learned/completed:

The deadlocks affect several database calls beyond bdb_store.  The database calls put, del, get, c_get and truncate all can deadlock.  This affects bdb_store, bdb_delete, bdb_fetch, bdb_next_item and bdb_trunc.  I had to implement deadlock recovery for all of them.

I did confirm that the database is causing the deadlocks, not our code.  Berkeley uses page based locking and when a store is running, it locks a couple of pages internally.  Other messages being stored can try to lock the same pages and it results in a deadlock.

I tested the performance of recovering the deadlocks vs adding mutex locks around the database calls to MSGMAIN.  With message loads that will not deadlock, the time to send all the messages are the same.  For message loads that will cause deadlocks, the mutex locks increased the time to send a message by about 3 times.  Without the mutex locks, the deadlock recovery took about 10 times longer for each message.

From these results, the proper way to implement is to add both deadlock recovery and mutex locks.  This will ensure that heavy server use will protect message handing from failing.

I have only tested receiving messages (SMTP) which causes the deadlocks in MSGMAIN only, so I only lock accesses to that.  I still need to implement the citserver code that has to retry the external transactions it creates  Then I need to stress test IMAP/POP sending messages.

Since deadlocking may not apply to other databases, I implemented the locking in the Berkeley code so the citserver code does not have to change except for the external retry code which I will add, but it will be transparent to other database code.  I had to move the mutex lock code from citserver to libcitadel since the Berkley code is used in external utilities.  All the changes are not a huge amount of code, but it is not trivial.  With testing, I do not think it is a high risk, but we gain significant hardening.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502831Sat, 28 Dec 2024 18:04:10 +05002099502831@Uncensored Date: Sat Dec 28 18:04:08 2024 -0500 More options for the uploader. Allow or disallow the upload window to be opened or closed. If it is attachments to an email for example, we want to be able to call up and dismiss the uploads window. For an explicit upload dialog, we want it to stay. Allow or disallow multiple files to be uploaded. Sometimes we want exactly one file, sometimes we can have as many as the user wants. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 8 ++++++-- webcit-ng/static/js/upload.js | 28 +++++++++++++++++++--------- webcit-ng/static/js/view_mail.js | 8 ++++++-- 3 files changed, 31 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502741Fri, 27 Dec 2024 22:32:09 +05002099502741@Uncensored Date: Fri Dec 27 22:32:08 2024 -0500 ctdl-formgrid-fieldset-stealth class to hide extra borders ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 5 +++++ webcit-ng/static/js/edit_room.js | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502735Fri, 27 Dec 2024 22:08:46 +05002099502735@Uncensored Date: Fri Dec 27 22:08:44 2024 -0500 icon upload screen ... started ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 30 +++++++++++++++++++++++++++++- webcit-ng/static/js/upload.js | 19 +++++++++++++++---- webcit-ng/static/js/view_mail.js | 4 ++-- 3 files changed, 46 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502719Fri, 27 Dec 2024 20:53:32 +05002099502719@Uncensored Date: Fri Dec 27 20:53:30 2024 -0500 Display room icon in the banner ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 2 ++ webcit-ng/server/room_functions.c | 58 +++++++++++++++++++++++++++++++++++++++ webcit-ng/server/user_functions.c | 4 +-- webcit-ng/static/index.html | 2 ++ webcit-ng/static/js/edit_room.js | 1 - webcit-ng/static/js/main.js | 12 +++++++- 6 files changed, 75 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502639Fri, 27 Dec 2024 14:48:51 +05002099502639@Uncensored Date: Fri Dec 27 11:48:48 2024 -0800 Random acts of style cleanup ----------------------------------------------------------------------- Summary of changes: citadel/server/msgbase.c | 148 +++++++++++++++++++++++++++-------------------- 1 file changed, 84 insertions(+), 64 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502625Fri, 27 Dec 2024 11:07:25 +05002099502625@UncensoredI have implemented aborting and recovering the transactions that are >created in the BDB code and it is working very well.  I have removed As you've undoubtedly discovered, most of the time cdb_store() opens and closes a transaction on its own, because the caller doesn't bother. That's obviously going to be an easy change, just end the transaction, begin a new one, and try again. Things get more complicated with the indexer and the auto-purger, which do open transactions on their own because they are requesting some amount of atomicity in the things they're writing to the database, a group of writes that need to be done all together or not at all. I wonder if those operations could be refactored to not need that. Simplicity is the name of the game. We try not to do anything excessively clever, not because we are simpletons but because we have code that literally runs for decades between maintenance activities and the next person who comes along must be able to understand it without help from the last one. Anyway, like I said before, if you're getting deadlocks and a good fix then run it up the flagpole, just be careful to honor the layering of the backend interface so that no ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502590Thu, 26 Dec 2024 22:22:35 +05002099502590@Uncensored Date: Thu Dec 26 19:22:32 2024 -0800 Both versions of webcit - change 'room info file' to 'room banner' ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 3 + webcit-ng/static/js/edit_room.js | 7 +- webcit/po/webcit/ar.po | 6063 ++++++++++++++++---------------- webcit/po/webcit/bg.po | 4292 ++++++++++++----------- webcit/po/webcit/cs.po | 6071 ++++++++++++++++----------------- webcit/po/webcit/da.po | 6029 ++++++++++++++++---------------- webcit/po/webcit/de.po | 6070 ++++++++++++++++---------------- webcit/po/webcit/el.po | 4525 ++++++++++++------------ webcit/po/webcit/en_GB.po | 5934 ++++++++++++++++---------------- webcit/po/webcit/es.po | 5920 ++++++++++++++++---------------- webcit/po/webcit/et.po | 5796 ++++++++++++++++--------------- webcit/po/webcit/fi.po | 4822 +++++++++++++------------- webcit/po/webcit/fr.po | 6057 ++++++++++++++++---------------- webcit/po/webcit/he.po | 4364 ++++++++++++------------ webcit/po/webcit/hu.po | 5851 ++++++++++++++++--------------- webcit/po/webcit/it.po | 5998 ++++++++++++++++---------------- webcit/po/webcit/kk.po | 4234 ++++++++++++----------- webcit/po/webcit/ko.po | 4244 ++++++++++++----------- webcit/po/webcit/nl.po | 6070 ++++++++++++++++---------------- webcit/po/webcit/pl.po | 6017 ++++++++++++++++---------------- webcit/po/webcit/pt_BR.po | 6038 ++++++++++++++++---------------- webcit/po/webcit/ro.po | 5336 ++++++++++++++--------------- webcit/po/webcit/ru.po | 5539 +++++++++++++++--------------- webcit/po/webcit/sl.po | 4234 ++++++++++++----------- webcit/po/webcit/sv.po | 4504 ++++++++++++------------ webcit/po/webcit/tr.po | 4300 ++++++++++++----------- webcit/po/webcit/webcit.pot | 4234 ++++++++++++----------- webcit/po/webcit/zh.po | 6054 ++++++++++++++++---------------- webcit/static/t/room/create_blog.html | 2 +- webcit/static/t/room/edit_info.html | 2 +- 30 files changed, 69008 insertions(+), 69602 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502587Thu, 26 Dec 2024 22:00:51 +05002099502587@Uncensored Date: Thu Dec 26 19:00:48 2024 -0800 Completed the screens to edit a room banner. ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 1 + webcit-ng/server/http.c | 1 + webcit-ng/server/room_functions.c | 38 ++++++++++++++++- webcit-ng/server/util.c | 35 ++++++++++++++++ webcit-ng/server/webcit.h | 9 ++-- webcit-ng/static/js/edit_room.js | 82 +++++++++++++++++++++++++++++++++---- webcit/po/webcit/ar.po | 2 +- webcit/po/webcit/bg.po | 2 +- webcit/po/webcit/cs.po | 2 +- webcit/po/webcit/da.po | 2 +- webcit/po/webcit/de.po | 2 +- webcit/po/webcit/el.po | 2 +- webcit/po/webcit/en_GB.po | 2 +- webcit/po/webcit/es.po | 2 +- webcit/po/webcit/et.po | 2 +- webcit/po/webcit/fi.po | 2 +- webcit/po/webcit/fr.po | 2 +- webcit/po/webcit/he.po | 2 +- webcit/po/webcit/hu.po | 2 +- webcit/po/webcit/it.po | 2 +- webcit/po/webcit/kk.po | 2 +- webcit/po/webcit/ko.po | 2 +- webcit/po/webcit/nl.po | 2 +- webcit/po/webcit/pl.po | 2 +- webcit/po/webcit/pt_BR.po | 2 +- webcit/po/webcit/ro.po | 2 +- webcit/po/webcit/ru.po | 2 +- webcit/po/webcit/sl.po | 2 +- webcit/po/webcit/sv.po | 2 +- webcit/po/webcit/tr.po | 2 +- webcit/po/webcit/webcit.pot | 2 +- webcit/po/webcit/zh.po | 2 +- webcit/static/t/room/edit_info.html | 2 +- webcit/static/t/user/edit_bio.html | 2 +- 34 files changed, 181 insertions(+), 41 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502533Thu, 26 Dec 2024 13:07:34 +05002099502533@Uncensored Date: Thu Dec 26 13:07:32 2024 -0500 document the DELETE method for a room ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/api.txt | 1 + 1 file changed, 1 insertion(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502430Tue, 24 Dec 2024 14:45:37 +05002099502430@Uncensored

The deadlock detection is coming from the Berkeley libraries.  I have stared at too many dumps and I do not see actual deadlocks.  The Berkeley documentation says that the deadlock detection can produce false positives when the locks get complicated and you still have to handle them.  My testing is catching edge cases probably, but they could show up anytime resulting in core dumps.

The existing code loops trying the command again.  The documentation says that you have to abort the transaction and close any cursors, start new ones and then retry the operations that you performed in the transaction.  If you just retry the command or most other DB operations, the transaction is corrupted and will core dump or return errors which we core dump on.

My original fix of adding mutex locks to the save message code worked to a point, but did not eliminate the issue with further, harder testing.  I think it just helped the database not get flooded with store requests that it had to handle.

I have implemented aborting and recovering the transactions that are created in the BDB code and it is working very well.  I have removed the locks I added and see a lot more deadlock recoveries occurring.  I may end up leaving them in just to help the database.  The stores end up blocking in the database anyway.

I am starting to look at the transactions created outside of the database code and I have a way to implement that will not break non-Berkeley databases.  There are not many and might as well harden them too.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502395Mon, 23 Dec 2024 23:18:54 +05002099502395@Uncensored Date: Mon Dec 23 23:18:52 2024 -0500 idle terminal adjustment ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502382Mon, 23 Dec 2024 18:36:33 +05002099502382@Uncensored Date: Mon Dec 23 18:36:31 2024 -0500 Rendered the rest of the admin box. Also fixed some spelling errors in webcit.pot (and corresponding in all .po files referencing it) ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 25 ++++++++++++++++++++++++- webcit/po/webcit/ar.po | 2 +- webcit/po/webcit/bg.po | 2 +- webcit/po/webcit/cs.po | 2 +- webcit/po/webcit/da.po | 4 ++-- webcit/po/webcit/de.po | 2 +- webcit/po/webcit/el.po | 2 +- webcit/po/webcit/en_GB.po | 4 ++-- webcit/po/webcit/es.po | 4 ++-- webcit/po/webcit/et.po | 4 ++-- webcit/po/webcit/fi.po | 2 +- webcit/po/webcit/fr.po | 4 ++-- webcit/po/webcit/he.po | 2 +- webcit/po/webcit/hu.po | 4 ++-- webcit/po/webcit/it.po | 2 +- webcit/po/webcit/kk.po | 2 +- webcit/po/webcit/ko.po | 2 +- webcit/po/webcit/nl.po | 2 +- webcit/po/webcit/pl.po | 2 +- webcit/po/webcit/pt_BR.po | 2 +- webcit/po/webcit/ro.po | 4 ++-- webcit/po/webcit/ru.po | 2 +- webcit/po/webcit/sl.po | 2 +- webcit/po/webcit/sv.po | 2 +- webcit/po/webcit/tr.po | 2 +- webcit/po/webcit/webcit.pot | 2 +- webcit/po/webcit/zh.po | 2 +- webcit/preferences.c | 2 +- 28 files changed, 58 insertions(+), 35 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502374Mon, 23 Dec 2024 16:12:44 +05002099502374@Uncensored Date: Mon Dec 23 16:12:44 2024 -0500 Delete Room operation is working in webcit-ng ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502370Mon, 23 Dec 2024 16:07:14 +05002099502370@Uncensored Date: Mon Dec 23 16:07:12 2024 -0500 Support DELETE method to delete a room. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/room_functions.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502354Mon, 23 Dec 2024 11:11:22 +05002099502354@Uncensored Date: Mon Dec 23 11:11:20 2024 -0500 New function do_whatever_seems_sensible_upon_landing() This abstracts the idea of going to a landing page. It was isolated out of the login process so we can call it elsewhere. Added this action as what happens when we delete the current room and it no longer exists. In the past we simply went to the Lobby (via _BASEROOM_ macro) but that may or may not be the correct action in the near future. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 31 +++++++++++++++++++++++++++++++ webcit-ng/static/js/main.js | 20 +++++++++++++------- 2 files changed, 44 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502325Mon, 23 Dec 2024 00:08:31 +05002099502325@Uncensored Date: Mon Dec 23 00:08:29 2024 -0500 We do have 'Save changes' in our message catalog. Use that. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/edit_room.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502321Mon, 23 Dec 2024 00:01:50 +05002099502321@Uncensored Date: Mon Dec 23 00:01:48 2024 -0500 edit_room.js: set up the formgrids and fieldsets ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 5 ++++ webcit-ng/static/js/edit_room.js | 63 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 67 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502307Sun, 22 Dec 2024 19:46:48 +05002099502307@Uncensored Date: Sun Dec 22 19:46:45 2024 -0500 tcp_sockets.c: eliminate unix domain socket server - never used in WebCit-NG ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/tcp_sockets.c | 46 ------------------------------------------ webcit-ng/server/webcit.h | 1 - 2 files changed, 47 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502306Sun, 22 Dec 2024 19:43:32 +05002099502306@Uncensored Date: Sun Dec 22 19:43:28 2024 -0500 WebCit Classic: fixed improper English in room edit screens. Also made corresponding changes in .po and .pot files to avoid breaking translations. Figured I'd do this before copying the messages over to WebCit-NG. ----------------------------------------------------------------------- Summary of changes: webcit/feed_generator.c | 2 +- webcit/po/webcit/ar.po | 8 ++++---- webcit/po/webcit/bg.po | 8 ++++---- webcit/po/webcit/cs.po | 8 ++++---- webcit/po/webcit/da.po | 8 ++++---- webcit/po/webcit/de.po | 8 ++++---- webcit/po/webcit/el.po | 8 ++++---- webcit/po/webcit/en_GB.po | 16 ++++++++-------- webcit/po/webcit/es.po | 8 ++++---- webcit/po/webcit/et.po | 8 ++++---- webcit/po/webcit/fi.po | 8 ++++---- webcit/po/webcit/fr.po | 8 ++++---- webcit/po/webcit/he.po | 8 ++++---- webcit/po/webcit/hu.po | 8 ++++---- webcit/po/webcit/it.po | 8 ++++---- webcit/po/webcit/kk.po | 8 ++++---- webcit/po/webcit/ko.po | 8 ++++---- webcit/po/webcit/nl.po | 8 ++++---- webcit/po/webcit/pl.po | 8 ++++---- webcit/po/webcit/pt_BR.po | 8 ++++---- webcit/po/webcit/ro.po | 8 ++++---- webcit/po/webcit/ru.po | 8 ++++---- webcit/po/webcit/sl.po | 8 ++++---- webcit/po/webcit/sv.po | 8 ++++---- webcit/po/webcit/tr.po | 8 ++++---- webcit/po/webcit/webcit.pot | 8 ++++---- webcit/po/webcit/zh.po | 8 ++++---- webcit/static/t/room/edit/tab_admin.html | 4 ++-- webcit/static/t/room/edit/tab_config.html | 2 +- webcit/static/t/room/edit/tab_listserv.html | 2 +- 30 files changed, 113 insertions(+), 113 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502302Sun, 22 Dec 2024 19:13:40 +05002099502302@Uncensored

The other is the deadlock handling.  Since the deadlock code had been there for a while, I assume that we have not gotten any deadlocks in normal operation.  Since all the other database code Linux aborts on something bad, I just concentrated on avoiding the lock instead.

Ok, so you're talking about native Berkeley DB deadlocks, rather than the general condition where two or more threads are holding mutexes while trying to acquire mutexes belonging to other threads.

So from berkeley_db.c around line 392:

do {
        ret = bdb_table[cdb]->put(
        bdb_table[cdb],                 // db
        TSD->tid,                       // transaction ID
        &dkey,                          // key
        &ddata,                         // data
        0                               // flags
        );
        if ((ret != 0) && (ret != DB_LOCK_DEADLOCK)) {
                syslog(LOG_ERR, "bdb: bdb_store(%02x): error %d: %s", cdb, ret, 
                db_strerror(ret));
                bdb_abort();
        }
        if (ret == DB_LOCK_DEADLOCK) {
                syslog(LOG_DEBUG, "bdb: bdb_store(%02x): would deadlock, trying again", cdb);
        }
} while (ret == DB_LOCK_DEADLOCK);

I don't quite remember what we were doing here, nor do I remember whether this was the way LS originally wrote it or if I made some changes (`git blame` shows it as me since I shuffled everything around in a refactor) but ... if I remember correctly, the ass-umption was that a deadlock should normally never happen here since we lock entire tables by acquiring a mutex associated with the act of writing to them.  Therefore, simply coming back around and trying again was thought to be good enough.

Are you seeing the "would deadlock, trying again" message?

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502211Sat, 21 Dec 2024 12:28:50 +05002099502211@Uncensored Date: Sat Dec 21 12:04:04 2024 -0500 Skeleton screen for room edit ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 3 ++- webcit-ng/static/js/edit_room.js | 8 ++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 webcit-ng/static/js/edit_room.js -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502133Fri, 20 Dec 2024 15:13:06 +05002099502133@Uncensored Date: Fri Dec 20 15:13:04 2024 -0500 Mac OS Terminal sucks ----------------------------------------------------------------------- Summary of changes: textclient/citadel.rc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099502007Thu, 19 Dec 2024 19:02:02 +05002099502007@Uncensored

I probably need to explain my thoughts and provide a little more detail so you can give the proper guidance of how to proceed.  Yes, this is too long :-)

The underling issue is what is deadlocking and why.  When I originally got a deadlock, I saw two save messages running, so I thought that the save message store’s occurring at the same time was causing the deadlock, so I added the locking.  When I got the deadlock, the code core dumped (SEGV) on the deadlock retry of the put.  When I looked at the code and read up on the Berkeley expected handling of any deadlock (abort the transaction and retry if you want), I realized that the retry in the code is what caused the core dump since it never should have tried the put again without aborting the transaction and creating a new one.

The locks seem to have avoided the dead lock issue, so I did not bother with the dead lock handling since you should never get a deadlock ideally.

This time I got the deadlock on the save message store, but only one thread was running save message (rest blocked by my lock) which was put’ing on the message base (CDB_MSGMAIN).  There were two other threads running commands against the message base database, a fetch and a store (GetMetaData() and SetMetaData()) so I think the save and one or both of the meta data calls are actually deadlocking.

I now have more information on what was deadlocking and that it is not isolated to the save message, so that is one thing I am working on.

The other is the deadlock handling.  Since the deadlock code had been there for a while, I assume that we have not gotten any deadlocks in normal operation.  Since all the other database code Linux aborts on something bad, I just concentrated on avoiding the lock instead.

Now that I see that there could be more deadlocks in the future, minimally, it should not SEGV, but rather do a Linux abort or do a proper retry and log it.  Since the existing code actually tried to retry, I assume that we wanted the server to try, so that is why I was going to retry which means the any of the code outside of the database routines that begin a transaction would have to handle the retry.

I would probably implement the retry by adding a new function to the database code that does not have to be implemented.  If it is not, then the code just aborts on deadlock.  If it is implemented, it returns if the last fetch/store needs to be retried.  Something like that.  Have to think a little on that.

So that means two tasks:

1. Find the deadlock between save message and meta updates (a must).

2. Either retry deadlocks or just Linux abort so we don’t try to run any more commands against the database with a corrupted transaction.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501964Thu, 19 Dec 2024 13:29:01 +05002099501964@UncensoredAfter implementing this, I will try removing the locks I had added and >see if they are needed anymore.  If the number of deadlocks increases >significantly without them, even though it may not fail, I  will >probably leave them in just to reduce the number of times we encounter >deadlocks and need to retry. > >Sound like a plan? I'm interested in understanding why you're having locking problems that no one else seems to be having. If it is a defect in the software then I want to understand what conditions you are supplying to the system that are making it fail for you and not for me or (to our knowledge) anyone else. If you've found a use case that reliably exposes a locking bug, and you're willing and capable of supplying a fix, then yes by all means do so. I would advise doing the following: 1. If this work is experimental, do it in a git branch rather than in master. We use master as the release branch and will probably have a new version published soon. 2. Make sure you stay inside the mindset of doing locking in a way that is not specific to Berkeley DB. Although BDB is the only backend available now, there *will* be others in the future. All that pluggable backend stuff you ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501963Thu, 19 Dec 2024 13:21:01 +05002099501963@UncensoredA note on the calendar system, I tried to hack it up once to support >Outlook as a Internet Calendar (did not work well because of Outlook >authentication and did not have time to complete), but I did find that >there were some errors in the ics that it generated.  I traced it down We're going to continue using libical for that -- but keep in mind there are actually TWO libraries called libical: 1. There's the original C implementation, which is used in all currently published Citadel software. Interesting history about that -- Eric Busboom wrote the original implementation, and it got forked into a bunch of different places. I got together with Andy Winters of KDE and we worked really hard for a couple of years to un-diaspora it and get all of the forks merged back into a single distribution. That's what is available today. 2. There is a much newer Javascript implementation by Philipp Kewisch, that seems to have found its way into Thunderbird and a bunch of other "web native" software. That's being used in WebCit-NG. In any case ... the ical objects that are emitted by Citadel are generated inside one libical or the other. Citadel considers the wire format to be opaque and just sends along wat the library supplies to it. So if it's doing something Outlook-hostile ... sure, go ahead and work on it if you think you can improve the compatibility or standards compliance. But if you do so you'll be working on libical, not on Citadel. So basically what I'm saying is, it's not that I don't care, but it's not ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501909Thu, 19 Dec 2024 09:16:01 +05002099501909@Uncensored Date: Thu Dec 19 09:15:58 2024 -0500 Oops, I left the debug bar in. Let's tuck that away. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501885Thu, 19 Dec 2024 02:10:18 +05002099501885@Uncensored

I think I have a little project to work on.  I think I found the root cause of the issues when saving messages, which I thought I fixed by locking the section that updated the messages.  I have been testing with more workers, I discovered that we are getting database deadlocks.  I think the locks I added to the save message only reduced the probability of them happening.  With a small number of workers, it does not seem to occur, but the issue is there.

The problem is that the current deadlock handling is not recovering properly.  It currently loops on trying the operation again.  For deadlocks, you need to abort the transaction and then retry everything in the transaction again.  Most of the database commands create/commit/end a transaction on each command so easy to abort, begin a new transaction and retry.  I found that luckily there are only a few places in the main citserver code that start their own transactions and do a block of work and expect them to be committed all together.  For these, I will have to return something to let them know that they will have to go back and begin a new transaction and retry everything they executed the first time.

After implementing this, I will try removing the locks I had added and see if they are needed anymore.  If the number of deadlocks increases significantly without them, even though it may not fail, I  will probably leave them in just to reduce the number of times we encounter deadlocks and need to retry.

Sound like a plan?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501851Wed, 18 Dec 2024 17:18:08 +05002099501851@Uncensored

I reactivated the text indexing and it looks like the changes I made to the shutdown fixed the issue (or is doing a good job of hiding it).

On the RBLs, I tried to turn that on a long time ago and had issues, so I implemented my own to keep my server up.  I will have to try it again now that it is not critical and see if it works.

A note on the calendar system, I tried to hack it up once to support Outlook as a Internet Calendar (did not work well because of Outlook authentication and did not have time to complete), but I did find that there were some errors in the ics that it generated.  I traced it down to the actual iCal library generating non-compliant info.  It has been so long, I cannot remember any of the specifics, but you should run things through a validator during development to ensure proper compliance.

 

Tue Dec 17 2024 03:23:41 UTC from IGnatius T Foobar Subject: Re: Thread management question

I am going to turn text indexing back on and see if it works now.  If
not, I will dig into it.  I have resolved all the other threading
issues that I have been running into, so I think it is stable for now. 
The more I have gotten into the code, you have done a very good job!

Sure thing, and when there's time we can run Uncensored on it for a bit and see if it exposes any weird behaviors. As for the SMTP attackers, may I assume you've at least enabled all of the common RBL's to make connections from them go away? Overloading the server is the reason I added the option to blow them away by printing a negative greeting banner instead of waiting for them to try to send a message. It gets rid of them a lot faster.

It's a good time for someone to be playing around in that part of the code because no one else is doing anything else in there right now. The server core is generally "stable" right now so it's in good shape for experimenting with improvements.
I promised myself that I wouldn't go on any more side quests until WebCit-NG was finished, but when the whims hit I tend to do it anyway. So I've been off in text client land rewriting all the ugly parts that haven't gotten enough attention in many years. At some point I'll be satisfied and merge it back in an

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501850Wed, 18 Dec 2024 17:11:27 +05002099501850@Uncensored Date: Wed Dec 18 17:11:25 2024 -0500 Oops! My attempt to DRY the null termination created a bug. Reversed that. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 4 ++++ 1 file changed, 4 insertions(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501845Wed, 18 Dec 2024 17:07:40 +05002099501845@Uncensored Date: Wed Dec 18 17:07:37 2024 -0500 msgbase.c: editor display/edit modes ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501830Wed, 18 Dec 2024 13:34:10 +05002099501830@Uncensored Date: Wed Dec 18 13:34:00 2024 -0500 Merge branch 'console_rework' commit 63b58db3b17a3cfd291c2ac2d61d9ae787a38ff1 Author: Art Cancro Date: Wed Dec 18 11:56:52 2024 -0500 Completed the return of the status line. commit 6bd79e0a46de1d8c4e64c955d7b221babc720110 Author: Art Cancro Date: Wed Dec 18 11:23:00 2024 -0500 disable debug bar commit e76cee338cbb83bc79cc44259a333cb6746720a2 Author: Art Cancro Date: Wed Dec 18 11:18:49 2024 -0500 messages.c: dial back word wrap by one more column commit cb74f52cc79de47d86b65a4f8ea812e22b275a04 Author: Art Cancro Date: Tue Dec 17 23:35:04 2024 -0500 initial go at restoring the status line commit cabf2fc5c9e798dcb73278d97dc027fd69039004 Author: Art Cancro Date: Tue Dec 17 22:48:38 2024 -0500 screen.c: more simplification of stty_ctdl() commit 733cb9052f4234e78f4f6420a77236be4c9a5951 Author: Art Cancro Date: Tue Dec 17 16:02:54 2024 -0500 Consolidating terminal stuff into screen.c commit 5ef507b6a1810abeb2d8a68e84aaa55197129b5f Author: Art Cancro Date: Mon Dec 16 23:10:09 2024 -0500 Moar editor tweaks commit f3ca6700ae5be09b6f7be8adfdd6df2979c7577f Author: Art Cancro Date: Mon Dec 16 22:35:14 2024 -0500 messages.c: more fine tuning of the editor. commit 29b9fda56bf174aec9c6ff1771cb6eec8d3a36d5 Author: Art Cancro Date: Mon Dec 16 21:49:39 2024 -0500 citedit: rely on screen.c to tell us what column we're actually in. commit f9ddb6d7eca99723a23e5de150b2c42b66b6e7dd Author: Art Cancro Date: Mon Dec 16 21:41:54 2024 -0500 Saving my work because I'm about to try something commit 14f70eb44053cb8b9e9743343b8a0e82d0b3eb87 Author: Art Cancro Date: Mon Dec 16 16:39:04 2024 -0500 replace size_t with int where signed comparisons are needed commit ca4328a16f2ed94dbfff1fcbf6d48bccbd0924fa Author: Art Cancro Date: Sun Dec 15 21:51:20 2024 -0500 Rewrote the built in editor. commit cc780532a61477e440039509eb217ac9e0c5b025 Author: Art Cancro Date: Thu Dec 12 11:55:09 2024 -0500 Replaced most of the error messages with a new macro call scr_perror() This simply displays the function name from __func__ along with strerror(errno) which turns out to be a perfectly serviceable error message 99% of the time. commit ac426ad9af512f1b043aa87ad9f17ed8ac7beef2 Author: Art Cancro Date: Wed Dec 11 22:39:19 2024 -0500 Please forgive my frequent small commits. They are probably annoying. commit 0ee2bd4eba7aaab42cf7f0d63cccf0dfddce327d Author: Art Cancro Date: Wed Dec 11 16:13:14 2024 -0500 <.E>nter scii now converts CRLF to LF, avoids unwanted double-spacing commit 18c0d770db4aa85a7048b2554434130703378188 Author: Art Cancro Date: Wed Dec 11 16:00:04 2024 -0500 process_quote() cleanup. second tempfile is far more ephemeral now and no longer a global variable. commit 39d21684f9573388b831d29d3ef5253e5395df22 Author: Harlow Solutions Date: Tue Dec 10 16:43:29 2024 -0500 msgbase.c: When saving message, switch from locking room to regular lock. Originally thought locking room was the proper solution when writing to database. Found that emails from unauthenticated users result in an blank room, so not a solution for all cases. Switched to using critical section locks for all saves. commit baf0e38c626c6fa7c3f1e8fcfaac6d1b373d6c1c Author: Harlow Solutions Date: Mon Dec 9 23:30:12 2024 -0500 msgbase.c: Fixing room locking bug when saving message. CtdlSubmitMsg() change locked room. After further testing in production, found that messages from Gmail (and probably others) resulted in blank room names. Changed so if a lock does not work, still go ahaed and save teh message. Will need to debug more to determine how to lock all rooms. This fix at least fix some possible deadlocks. commit 2e569e9c557e01f7916abb732b1dd6a7e3c842f4 Author: Art Cancro Date: Wed Dec 11 15:17:48 2024 -0500 Newfangled string traversal commit eaae0f70b7a1972b5661d87a4f60bd683b5bd3f8 Author: Art Cancro Date: Tue Dec 10 23:29:08 2024 -0500 messages.c: war on goto statements continued, this time in the editor save options loop commit 57207c7066b7feeacdf6ee79fefbeed0cf58f2f4 Author: Art Cancro Date: Tue Dec 10 16:18:54 2024 -0500 ka_system() is no longer called by anything. Removed. commit ff5c0bcb9695a8c285d3a7cabbe8e347de6a852f Author: Art Cancro Date: Tue Dec 10 16:08:41 2024 -0500 strproc() is now sanitize_string() and has improved badassery commit 51dd799abf232a021f586805d18b6943e23e3c01 Author: Art Cancro Date: Tue Dec 10 15:01:26 2024 -0500 Replace non-obvious 'mode' variable with 'editor_mode' and enum'ed options commit 89a841ffc79e2c9e1c25c022001ea7dc8044f989 Author: Art Cancro Date: Tue Dec 10 13:41:56 2024 -0500 textclient.h: much cleanup, see description below. There is a lot of very old code in here, some of it as much as 37 years old. To understand why it is as messy as it is in places, one must understand that the text client is actually the remnant of the old monolithic Citadel BBS program after the back end code was moved to a dedicated server. Most of it was left in its existing form for decades because it was working fine and it contained no interesting problems to solve. Currently, there are people who are finding the text client to be an attractive place to tinker. This seems to be a combination of interest in retro style interaction and an increase in the deployment of Citadel on high latency links such as darknets and digital radio modes. Because of this interest, my current whim is to clean up the text client and make it an easier platform to hack. The current commit mostly focuses on making the textclient.h header file more sensible to navigate. It began as a concatenation of multiple header files but makes more sense this way. Those following the commit log will have noticed that there was much duplication of effort in externs and function prototypes appearing redundantly all over the system. This has been cleaned up quite a bit. My coding style in 1987 was quite atrocious and overused the 'goto' statement, which is considered poor form in C language. Although this practice has been corrected throughout most of the system, there are still a few sections remaining in which the use of 'goto' is heavily entrenched. These have either been recently corrected or are in the process of being replaced. Another regrettable anti-pattern in the client is the overuse of temporary files. These seemed to make sense at the time, particularly for anything that held a message being composed or quoted. This may have been excusable on a small system in 1987 but it no longer makes sense in the modern era when there is both ample system memory and a universe of documentation on how to perform these functions using in-memory buffers. In particular, we are refactoring the code in preparation for a complete rewrite of the message composition editor (which, coincidentally, now has the largest remaining density of 'goto' statements). Finally, there is the classic Citadel behavior of formatting all messages to the reader's screen width. This behavior was mostly implemented in the message output routines and in the message editor. Inspired by a recent read through of Jeff Prothero's 1981 Citadel CP/M code, I have extended the scr_printf() and its companion functions written by Michael Hampton in the early 2000's to handle soft word wrapping at that layer. He originally wrote scr_printf() and the rest of screen.c to implement an ncurses-based output mode, which we later abandoned in favor of just-plain-ANSI because there are no longer any non-ANSI terminals in use. Owing to the fact that ALL client output now goes through this layer, we are able to handle soft word wrap in a single location, eliminating the need for other functions to handle it and making all code more simple and understandable. This is all taking place in the 'console_rework' git branch, which will be merged back to git master once it has achieved feature parity. For those of you who want to tinker with it: happy hacking. commit 576644c2e7b98098d8bdb0b9e5af282293790d9e Author: Art Cancro Date: Tue Dec 10 10:51:45 2024 -0500 Editing system banners now requires an external editor (for now). This was done because I'm going to rewrite the built in message editor and that means citedit() is going away. It will return in some form later. commit af4d80deb41fab1ed79b18c78a42b702f2ff09c2 Author: Art Cancro Date: Mon Dec 9 22:50:29 2024 -0500 Minor string formatting changes commit eccb8be585ff8b4943ccb7b01b231d1c62be50c1 Author: Art Cancro Date: Mon Dec 9 21:48:22 2024 -0500 suppress the paginator when redirecting output to a memory buffer commit ab967efb000b7c6f3a9c12a98b62718a1f6dc584 Author: Art Cancro Date: Mon Dec 9 21:00:36 2024 -0500 footprint-reduced fmout() that is only needed until we rewrite the message editor commit ccc0a990c54508d6e094ec6457b1ccf90ab8fa32 Author: Art Cancro Date: Mon Dec 9 20:53:54 2024 -0500 read_one_message() now converts legacy message format to unwrapped lines. Let the screen.c renderer handle soft line wrap. commit 3453113e509db29b5a42fb61a861b68ecba91b29 Author: Art Cancro Date: Mon Dec 9 20:30:18 2024 -0500 war on fmout() commit a405fdfc4614dc28ed2d6fe3087eab3f91f5d018 Author: Art Cancro Date: Mon Dec 9 19:19:59 2024 -0500 fmout() subst mode is long gone, remove the param commit 5140871a40c75aaa33ed0a3514351abd766b9007 Author: Art Cancro Date: Mon Dec 9 19:12:40 2024 -0500 Phasing out fmout() commit 27025f5e6c4e1f7406aa49224b7254ef866aade1 Merge: eb5462577 aede97e50 Author: Art Cancro Date: Mon Dec 9 18:46:43 2024 -0500 Merge branch 'master' into console_rework commit eb54625772088f9bfcd836e220de9b8f10f4c914 Author: Art Cancro Date: Mon Dec 9 18:40:48 2024 -0500 uote and

rint use the new scr_redir api commit 977bbc133019a1f094fd5a7ebf2f7ac0796f56e9 Author: Art Cancro Date: Mon Dec 9 17:59:18 2024 -0500 Added scr_ functions to redirect output to a memory buffer commit c7e36a0155fab4d583371552e2b4e1c297068bf0 Author: Art Cancro Date: Mon Dec 9 17:16:27 2024 -0500 Removed unused parameter to scr_getc() commit 567ad9024f479d23f067cf006c8636e2898084ac Author: Art Cancro Date: Mon Dec 9 14:52:10 2024 -0500 scr_printf() dynamic buffer and don't mangle it commit 587b4944a5716d2469d8f6c0dc306255f48364f5 Author: Art Cancro Date: Mon Dec 9 14:05:38 2024 -0500 character loop output instead of printf commit 28c9ce73afacd91fc08081197a44c51d268de9cf Author: Art Cancro Date: Mon Dec 9 11:27:56 2024 -0500 fmout() use global screenwidth instead of as a parameter commit a99b76253acf923a3575e61eefdc0e2c54e325db Author: Art Cancro Date: Sun Dec 8 22:18:17 2024 -0500 moved things commit f2de8e1d26a1a79dd9c31a4b9a8d43a992b10797 Author: Art Cancro Date: Sun Dec 8 22:09:04 2024 -0500 screen.c: moved other screen handling functions into this file commit d3469dc1e69e49e4129b5e0c199b1290ef537e67 Author: Art Cancro Date: Sun Dec 8 21:13:34 2024 -0500 Initial go at the console rework ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 4 +- textclient/citadel.c | 54 +-- textclient/citadel.rc | 4 +- textclient/client_chat.c | 4 +- textclient/commands.c | 1130 ++++++++++++++++--------------------------- textclient/file_transfer.c | 18 +- textclient/messages.c | 939 ++++++++++++++--------------------- textclient/rooms.c | 28 +- textclient/screen.c | 564 ++++++++++++++++----- textclient/sysutil.c | 24 +- textclient/tcpclient.c | 2 +- textclient/textclient.h | 129 ++--- textclient/tuiconfig.c | 6 +- textclient/user_functions.c | 11 +- textclient/utilfunc.c | 48 +- textclient/wcwidth.c | 309 ++++++++++++ 16 files changed, 1670 insertions(+), 1604 deletions(-) create mode 100644 textclient/wcwidth.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501819Wed, 18 Dec 2024 11:56:53 +05002099501819@Uncensored Date: Wed Dec 18 11:56:52 2024 -0500 Completed the return of the status line. ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 1 + textclient/screen.c | 13 +++++++++++++ textclient/textclient.h | 1 + 3 files changed, 15 insertions(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501809Wed, 18 Dec 2024 11:23:02 +05002099501809@Uncensored Date: Wed Dec 18 11:23:00 2024 -0500 disable debug bar ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 8 ++++---- textclient/screen.c | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501806Wed, 18 Dec 2024 11:18:51 +05002099501806@Uncensored Date: Wed Dec 18 11:18:49 2024 -0500 messages.c: dial back word wrap by one more column ----------------------------------------------------------------------- Summary of changes: textclient/citadel.rc | 2 +- textclient/messages.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501765Tue, 17 Dec 2024 23:35:06 +05002099501765@Uncensored Date: Tue Dec 17 23:35:04 2024 -0500 initial go at restoring the status line ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 2 +- textclient/screen.c | 31 ++++++++++++++++++++++++++++++- 2 files changed, 31 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501762Tue, 17 Dec 2024 22:48:43 +05002099501762@Uncensored Date: Tue Dec 17 22:48:38 2024 -0500 screen.c: more simplification of stty_ctdl() ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 12 +++++------- textclient/citadel.rc | 4 ++-- textclient/commands.c | 24 +++++++++++++++--------- textclient/file_transfer.c | 10 +++++----- textclient/messages.c | 24 ++++++++++++------------ textclient/rooms.c | 4 ++-- textclient/screen.c | 35 +++++++++++++++++++++++++---------- textclient/sysutil.c | 8 ++++---- textclient/tcpclient.c | 2 +- textclient/textclient.h | 8 +++----- textclient/tuiconfig.c | 4 ++-- 11 files changed, 76 insertions(+), 59 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501738Tue, 17 Dec 2024 16:02:56 +05002099501738@Uncensored Date: Tue Dec 17 16:02:54 2024 -0500 Consolidating terminal stuff into screen.c ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 3 +- textclient/commands.c | 133 +++--------------------------------------------- textclient/rooms.c | 8 ++- textclient/screen.c | 125 +++++++++++++++++++++++++++++++++++++++++++-- textclient/textclient.h | 2 +- 5 files changed, 135 insertions(+), 136 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501660Mon, 16 Dec 2024 23:10:11 +05002099501660@Uncensored Date: Mon Dec 16 23:10:09 2024 -0500 Moar editor tweaks ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 6 +++--- textclient/screen.c | 8 +++++--- 2 files changed, 8 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501654Mon, 16 Dec 2024 22:35:16 +05002099501654@Uncensored Date: Mon Dec 16 22:35:14 2024 -0500 messages.c: more fine tuning of the editor. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501651Mon, 16 Dec 2024 22:23:41 +05002099501651@UncensoredI am going to turn text indexing back on and see if it works now.  If >not, I will dig into it.  I have resolved all the other threading >issues that I have been running into, so I think it is stable for now.  >The more I have gotten into the code, you have done a very good job! Sure thing, and when there's time we can run Uncensored on it for a bit and see if it exposes any weird behaviors. As for the SMTP attackers, may I assume you've at least enabled all of the common RBL's to make connections from them go away? Overloading the server is the reason I added the option to blow them away by printing a negative greeting banner instead of waiting for them to try to send a message. It gets rid of them a lot faster. It's a good time for someone to be playing around in that part of the code because no one else is doing anything else in there right now. The server core is generally "stable" right now so it's in good shape for experimenting with improvements. I promised myself that I wouldn't go on any more side quests until WebCit-NG was finished, but when the whims hit I tend to do it anyway. So I've been off in text client land rewriting all the ugly parts that haven't gotten enough attention in many years. At some point I'll be satisfied and merge it back in and then get back to work on the most tedious part of WebCit-NG -- the calendar system. So I'm thrilled that someone with both interest and skill has arrived to poke around in the server core ... and more than a little flattered ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501645Mon, 16 Dec 2024 21:49:41 +05002099501645@Uncensored Date: Mon Dec 16 21:49:39 2024 -0500 citedit: rely on screen.c to tell us what column we're actually in. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501642Mon, 16 Dec 2024 21:41:56 +05002099501642@Uncensored Date: Mon Dec 16 21:41:54 2024 -0500 Saving my work because I'm about to try something ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 8 ++++---- textclient/textclient.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501602Mon, 16 Dec 2024 16:39:07 +05002099501602@Uncensored Date: Mon Dec 16 16:39:04 2024 -0500 replace size_t with int where signed comparisons are needed ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 74 +++++++++++++++++++++++++++++++-------------------- 1 file changed, 45 insertions(+), 29 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501502Mon, 16 Dec 2024 07:41:24 +05002099501502@Uncensored

Since you have tried different implementations, best to leave it as is.  I have attackers that were opening SMTP sessions at a ridiculous rate and trying brute force account/password attacks which I think caused coredumps from the things that I have fixed now.  I implemented a blocking scheme that keeps track of the IPs and closes them before they even get a session, which stopped them and saved the server.  The blocking is really strict and not suitable for an email server in general, but it kept my server alive.

I went ahead and checked in the reworked worker code.  It looks like a big change in diff, but I really did not change anything except using do {} whiles in a couple of places.

The non-goto code is part of the latest check-in.  This one was killing me because it was core dumping in different places when I shutdown and there were workers still running.  Even under low loads on my production server it would coredump on shutdown occasionally.  I was debugging the socket code when I realized that the contexts had been freed while the workers were blocked and when the connections were closed, the reads unblocking and were corrupting memory and all sorts of stuff.  I decided that implementing a clean shutdown of the workers before cleaning up the contexts was the best solution.  Even with tons of workers running, it only takes a couple of seconds to stop them gracefully.

I am going to turn text indexing back on and see if it works now.  If not, I will dig into it.  I have resolved all the other threading issues that I have been running into, so I think it is stable for now.  The more I have gotten into the code, you have done a very good job!

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501492Mon, 16 Dec 2024 05:16:32 +05002099501492@Uncensored Date: Mon Dec 16 05:15:26 2024 -0500 Fix coredumps caused by context cleanups at shutdown During shutdown cleanup, contexts were removed while worker threads were blocked on sockets. When removing the context, the worker I/O would unblock and return to freed context buffers and coredump. Fixed by adding a worker cleanup that closes the sockets which unblocks the workers so they can process the shutdown request and exit. Reworked the sysdep.c worker code to remove the gotos and added some more comments. Lots of diff changes, but the funtionality is the same as before with a few tweaks for the shutdown detection. ----------------------------------------------------------------------- Summary of changes: citadel/server/citserver.c | 7 +- citadel/server/sysdep.c | 370 ++++++++++++++++++++++++++------------------- citadel/server/sysdep.h | 2 + 3 files changed, 224 insertions(+), 155 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501471Sun, 15 Dec 2024 21:51:22 +05002099501471@Uncensored Date: Sun Dec 15 21:51:20 2024 -0500 Rewrote the built in editor. ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 8 ++- textclient/messages.c | 172 ++++++++++++++++++++++++------------------------ textclient/rooms.c | 2 +- textclient/screen.c | 2 +- textclient/textclient.h | 2 +- 5 files changed, 96 insertions(+), 90 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501467Sun, 15 Dec 2024 21:42:58 +05002099501467@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501240Fri, 13 Dec 2024 17:33:28 +05002099501240@Uncensored

Thanks for the history and overview.  It did not sink in while I was going through the code that only one worker was listening to the main socket at a time.  Now I realize more about my failures and looked closer.  They all fail on connect because all the workers are processing existing connections.  Two different client timeouts (connect and receive).

Unless someone complains about the server timing out connections or send/receives, "if it ain't broke, don't fix it".

1. The only "improvement" I can think of to be more preemptive in avoiding send/receive timeouts has to do with the workers picking the session to work on that has input waiting.  The existing workers choose the first session that it finds in the list.  This is nice because it starts working on it faster, but it gives priority to the first ones in the list and the latter ones will sit longer waiting for all the others to be serviced and could time out on the client side.  Since the list is constantly changing, I think adding a timestamp of when a worker last finished processing a session to the context and have a worker go through all of the selected sockets and pick the oldest one rather than just picking the first one it finds might balance some of the load.  Just a thought.

2. Side question, for the global variables in threads.h, is there a reason that they are protected in the code by locks rather than just declaring volatile?

3. While going through the worker code in sysdep.c, I saw that you were trying to get rid of gotos in the code, so I took the worker code while I was working, commented a little more as I was figuring it out and used do/while {} to reimplement.  I can check it in if you like.  Since there are no errors in the code and it is code that no one really gets into, it may not be worth the risk of changing.  I have over 40yrs programming experience and I still make mistakes :-)  Still bugs me that my missing return and the uninitialized mutexes never errored or caused a core dump.  Scary or I am completely missing something about the modern compliers.  I miss programming in assembly.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501152Fri, 13 Dec 2024 08:38:46 +05002099501152@Uncensored

For starters, I'm assuming that you're talking about incoming messages, with the knowledge that outgoing messages are always handled by a single thread (the housekeeping thread) as just one of the activities that it handles as part of not being associated with any particular user session.

And it's always good to have a fresh pair of eyes on things like this, to have a new perspective on things that have been a certain way for a long time and maybe could use a different perspective.  So what I'll start with is some history of what has been tried before:

* The original implementation simply created a new thread for each incoming connection and kept it bound until the client disconnected.  This worked well enough, but there were choruses of "this won't scale" and I suppose that was true with the size of the computers we ran it on in the late 1990s.

* For a while, we did have code to both increase and decrease the size of the thread pool.  Eventually, we had a developer on the team who made the thread handling code so complex that he basically built the equivalent of an operating system thread scheduler inside Citadel Server.  This got really complex and difficult to maintain.

* Later on, I ripped most of the complexity out.  I don't remember when, probably over 10 years ago at this point.  And at that point we did make the decision to only increase, never decrease, the thread pool (within pre-set high and low limits, of course).  The rationale is that an extra thread handle is only consuming at most a few kilobytes of system memory (which probably got swapped out anyway) and practically zero of real CPU time, so it's better to just let them sit there instead of adding the complexity of reaping idle threads.

You're correct in observing that the current implementation adds worker threads whenever it finds that all the existing ones are bound to active sessions.  It is a naive implementation but it does work.  If you're getting timeouts on unusually heavy client traffic, then maybe it's worth revisiting.  Obviously only one thread can handle new incoming sessions, because only one thread can listen on the master socket at a time.   At that point, it creates a new session and binds to it, and another thread can take its place.  The operating system ought to be maintaining a queue of incoming connections on the master socket (or more specifically, on the master sockets for each protocol it can handle).  I wonder if you could extract the queue length and pre-create the correct number of threads to make up the deficit?

In summary, if you're getting timeouts then it might be worth experimenting with finding a way to pre-create enough threads to get ahead of it, and see what the benefit might look like.  On the other hand, while I'm not violently opposed to shutting down threads when too many are idle, I think it's probably fine to leave them idle based on the fact that the resources they consume are so small.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501122Thu, 12 Dec 2024 22:19:48 +05002099501122@Uncensored

I have been doing a lot of testing with asynchronous mail messages and fixing some locking issues.  I found that when I send hundreds of messages, I get failures due to timeouts.  This is because the server only has a few workers for handling messages.  This testing is probably not realistic, but I am just wondering if you think that reworking the worker handling is worth implementing.  Has anyone had reported issues of comm failures with a heavy mail load?

The current worker thread system starts with two workers at initialization.  Every second, the main thread adds a new worker if all the workers are processing. If you have a lot of mail incoming, it takes a very long time before it opens enough workers to handle them and the sockets can timeout.  Also, it never releases any workers, so if the load drops, there are a lot of workers just idling.

If you think it is worth it, I think the worker handling can be changed to the following to increase quickly to handle a surge of messages and then free up resources when the load is lower:

Have the workers save the number of waiting sockets.  Every second, the main thread can create new workers all at once to handle the increase in demand and then after demand does not increase after a timeout (5 min?) it can free up workers down to close to the current demand.  Make the system more dynamic.  It has to create and remove threads more than the current scheme, but avoids breaking client communications.

Thoughts?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501043Thu, 12 Dec 2024 11:55:12 +05002099501043@Uncensored Date: Thu Dec 12 11:55:09 2024 -0500 Replaced most of the error messages with a new macro call scr_perror() This simply displays the function name from __func__ along with strerror(errno) which turns out to be a perfectly serviceable error message 99% of the time. ----------------------------------------------------------------------- Summary of changes: textclient/file_transfer.c | 8 +- textclient/messages.c | 228 +++++++++++---------------------------------- textclient/rooms.c | 4 +- textclient/sysutil.c | 2 +- textclient/textclient.h | 1 + textclient/tuiconfig.c | 2 +- 6 files changed, 61 insertions(+), 184 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099501005Thu, 12 Dec 2024 09:10:20 +05002099501005@Uncensored Date: Thu Dec 12 09:09:25 2024 -0500 serv_inboxrules.c: Make global array of users (users_requiring_inbox_processing[]) thread safe. ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 1 + citadel/server/modules/inboxrules/serv_inboxrules.c | 17 ++++++++++------- 2 files changed, 11 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500946Wed, 11 Dec 2024 22:39:23 +05002099500946@Uncensored Date: Wed Dec 11 22:39:19 2024 -0500 Please forgive my frequent small commits. They are probably annoying. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500907Wed, 11 Dec 2024 16:13:17 +05002099500907@Uncensored Date: Wed Dec 11 16:13:14 2024 -0500 <.E>nter scii now converts CRLF to LF, avoids unwanted double-spacing ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500901Wed, 11 Dec 2024 16:00:41 +05002099500901@Uncensored Date: Wed Dec 11 16:00:04 2024 -0500 process_quote() cleanup. second tempfile is far more ephemeral now and no longer a global variable. commit 39d21684f9573388b831d29d3ef5253e5395df22 Author: Harlow Solutions Date: Tue Dec 10 16:43:29 2024 -0500 msgbase.c: When saving message, switch from locking room to regular lock. Originally thought locking room was the proper solution when writing to database. Found that emails from unauthenticated users result in an blank room, so not a solution for all cases. Switched to using critical section locks for all saves. commit baf0e38c626c6fa7c3f1e8fcfaac6d1b373d6c1c Author: Harlow Solutions Date: Mon Dec 9 23:30:12 2024 -0500 msgbase.c: Fixing room locking bug when saving message. CtdlSubmitMsg() change locked room. After further testing in production, found that messages from Gmail (and probably others) resulted in blank room names. Changed so if a lock does not work, still go ahaed and save teh message. Will need to debug more to determine how to lock all rooms. This fix at least fix some possible deadlocks. ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 1 + citadel/server/msgbase.c | 13 +++++-------- textclient/citadel.c | 3 --- textclient/messages.c | 41 +++++++++++++++++++++-------------------- textclient/textclient.h | 1 - 5 files changed, 27 insertions(+), 32 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500889Wed, 11 Dec 2024 15:17:50 +05002099500889@Uncensored Date: Wed Dec 11 15:17:48 2024 -0500 Newfangled string traversal ----------------------------------------------------------------------- Summary of changes: textclient/utilfunc.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500800Tue, 10 Dec 2024 23:29:10 +05002099500800@Uncensored Date: Tue Dec 10 23:29:08 2024 -0500 messages.c: war on goto statements continued, this time in the editor save options loop ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 225 ++++++++++++++++++++++++++------------------------ textclient/rooms.c | 5 +- 2 files changed, 120 insertions(+), 110 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500766Tue, 10 Dec 2024 16:44:13 +05002099500766@Uncensored Date: Tue Dec 10 16:43:29 2024 -0500 msgbase.c: When saving message, switch from locking room to regular lock. Originally thought locking room was the proper solution when writing to database. Found that emails from unauthenticated users result in an blank room, so not a solution for all cases. Switched to using critical section locks for all saves. ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 1 + citadel/server/msgbase.c | 14 ++++---------- 2 files changed, 5 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500762Tue, 10 Dec 2024 16:18:56 +05002099500762@Uncensored Date: Tue Dec 10 16:18:54 2024 -0500 ka_system() is no longer called by anything. Removed. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 30 ------------------------------ 1 file changed, 30 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500759Tue, 10 Dec 2024 16:08:43 +05002099500759@Uncensored Date: Tue Dec 10 16:08:41 2024 -0500 strproc() is now sanitize_string() and has improved badassery ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 8 ++++---- textclient/textclient.h | 2 +- textclient/utilfunc.c | 34 +++++++++++++++------------------- 3 files changed, 20 insertions(+), 24 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500748Tue, 10 Dec 2024 15:01:28 +05002099500748@Uncensored Date: Tue Dec 10 15:01:26 2024 -0500 Replace non-obvious 'mode' variable with 'editor_mode' and enum'ed options ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 59 ++++++++++++++++++++++++++----------------------- textclient/textclient.h | 6 ++--- 2 files changed, 34 insertions(+), 31 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500728Tue, 10 Dec 2024 13:41:59 +05002099500728@Uncensored Date: Tue Dec 10 13:41:56 2024 -0500 textclient.h: much cleanup, see description below. There is a lot of very old code in here, some of it as much as 37 years old. To understand why it is as messy as it is in places, one must understand that the text client is actually the remnant of the old monolithic Citadel BBS program after the back end code was moved to a dedicated server. Most of it was left in its existing form for decades because it was working fine and it contained no interesting problems to solve. Currently, there are people who are finding the text client to be an attractive place to tinker. This seems to be a combination of interest in retro style interaction and an increase in the deployment of Citadel on high latency links such as darknets and digital radio modes. Because of this interest, my current whim is to clean up the text client and make it an easier platform to hack. The current commit mostly focuses on making the textclient.h header file more sensible to navigate. It began as a concatenation of multiple header files but makes more sense this way. Those following the commit log will have noticed that there was much duplication of effort in externs and function prototypes appearing redundantly all over the system. This has been cleaned up quite a bit. My coding style in 1987 was quite atrocious and overused the 'goto' statement, which is considered poor form in C language. Although this practice has been corrected throughout most of the system, there are still a few sections remaining in which the use of 'goto' is heavily entrenched. These have either been recently corrected or are in the process of being replaced. Another regrettable anti-pattern in the client is the overuse of temporary files. These seemed to make sense at the time, particularly for anything that held a message being composed or quoted. This may have been excusable on a small system in 1987 but it no longer makes sense in the modern era when there is both ample system memory and a universe of documentation on how to perform these functions using in-memory buffers. In particular, we are refactoring the code in preparation for a complete rewrite of the message composition editor (which, coincidentally, now has the largest remaining density of 'goto' statements). Finally, there is the classic Citadel behavior of formatting all messages to the reader's screen width. This behavior was mostly implemented in the message output routines and in the message editor. Inspired by a recent read through of Jeff Prothero's 1981 Citadel CP/M code, I have extended the scr_printf() and its companion functions written by Michael Hampton in the early 2000's to handle soft word wrapping at that layer. He originally wrote scr_printf() and the rest of screen.c to implement an ncurses-based output mode, which we later abandoned in favor of just-plain-ANSI because there are no longer any non-ANSI terminals in use. Owing to the fact that ALL client output now goes through this layer, we are able to handle soft word wrap in a single location, eliminating the need for other functions to handle it and making all code more simple and understandable. This is all taking place in the 'console_rework' git branch, which will be merged back to git master once it has achieved feature parity. For those of you who want to tinker with it: happy hacking. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 10 +++--- textclient/messages.c | 18 ++++++----- textclient/textclient.h | 86 +++++++++++++++---------------------------------- 3 files changed, 41 insertions(+), 73 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500709Tue, 10 Dec 2024 10:51:47 +05002099500709@Uncensored Date: Tue Dec 10 10:51:45 2024 -0500 Editing system banners now requires an external editor (for now). This was done because I'm going to rewrite the built in message editor and that means citedit() is going away. It will return in some form later. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 5 ++++- textclient/sysutil.c | 14 ++++---------- textclient/textclient.h | 1 - 3 files changed, 8 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500691Tue, 10 Dec 2024 10:17:00 +05002099500691@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500647Mon, 09 Dec 2024 23:49:19 +05002099500647@Uncensored

Oh, locking was working, even without initializing.  I am guessing that the memory state of the mutex array must have looked enough like the static initializer that it initialized itself on the first lock.  The only code I found for initializing the mutexes was in thread.c and was never called by anyone.

I figured I might as well implement the recommended initialization scheme and while I was there, add error checking.  I have been tracking down some weird things when I send tons of asynchronous mail messages at the server.

On a different note, you will see I checked in a fix for the send mail room locking I committed before.  I tested it on my test system a lot, but when I put it on my production server, it was rejecting mail.  I found that when I tried sending mail from Gmail, the room lock errored.  I found that the QRname for the current room was blank, so I guess some rooms cannot be locked or I am getting the wrong name.  I will have to debug this to figure out what I am missing about the room, but I wanted to get a quick fix in so it will not break anyone else for now.  I can only debug in production, so may take a bit.  In any case, it is probably better that it still locks some rooms compared to none before :-)

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500644Mon, 09 Dec 2024 23:30:55 +05002099500644@Uncensored Date: Mon Dec 9 23:30:12 2024 -0500 msgbase.c: Fixing room locking bug when saving message. CtdlSubmitMsg() change locked room. After further testing in production, found that messages from Gmail (and probably others) resulted in blank room names. Changed so if a lock does not work, still go ahaed and save teh message. Will need to debug more to determine how to lock all rooms. This fix at least fix some possible deadlocks. ----------------------------------------------------------------------- Summary of changes: citadel/server/msgbase.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500641Mon, 09 Dec 2024 22:50:32 +05002099500641@Uncensored Date: Mon Dec 9 22:50:29 2024 -0500 Minor string formatting changes ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500628Mon, 09 Dec 2024 21:48:24 +05002099500628@Uncensored Date: Mon Dec 9 21:48:22 2024 -0500 suppress the paginator when redirecting output to a memory buffer ----------------------------------------------------------------------- Summary of changes: textclient/screen.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500618Mon, 09 Dec 2024 21:00:38 +05002099500618@Uncensored Date: Mon Dec 9 21:00:36 2024 -0500 footprint-reduced fmout() that is only needed until we rewrite the message editor ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 132 ------------------------------------------------ textclient/messages.c | 29 ++++++++++- textclient/textclient.h | 1 - 3 files changed, 27 insertions(+), 135 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500615Mon, 09 Dec 2024 20:53:56 +05002099500615@Uncensored Date: Mon Dec 9 20:53:54 2024 -0500 read_one_message() now converts legacy message format to unwrapped lines. Let the screen.c renderer handle soft line wrap. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 67 +++++++++++++++------------------------------------ 1 file changed, 19 insertions(+), 48 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500611Mon, 09 Dec 2024 20:30:30 +05002099500611@Uncensored Date: Mon Dec 9 20:30:18 2024 -0500 war on fmout() ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500604Mon, 09 Dec 2024 19:20:01 +05002099500604@Uncensored Date: Mon Dec 9 19:19:59 2024 -0500 fmout() subst mode is long gone, remove the param ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 2 +- textclient/commands.c | 3 +-- textclient/messages.c | 6 +++--- textclient/textclient.h | 2 +- 4 files changed, 6 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500603Mon, 09 Dec 2024 19:12:42 +05002099500603@Uncensored Date: Mon Dec 9 19:12:40 2024 -0500 Phasing out fmout() commit 27025f5e6c4e1f7406aa49224b7254ef866aade1 Merge: eb5462577 aede97e50 Author: Art Cancro Date: Mon Dec 9 18:46:43 2024 -0500 Merge branch 'master' into console_rework commit aede97e50f1129407279ce1a8874dc5613849446 Author: Art Cancro Date: Mon Dec 9 18:46:34 2024 -0500 html_to_ascii() accept screenwidth=0 to suppress soft line breaks in conversion ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/html_to_ascii.c | 8 +- textclient/citadel.c | 2 +- textclient/commands.c | 787 ++++++++++++++++++++--------------------- textclient/messages.c | 12 +- textclient/rooms.c | 2 +- textclient/textclient.h | 2 +- 6 files changed, 389 insertions(+), 424 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500596Mon, 09 Dec 2024 18:46:36 +05002099500596@Uncensored Date: Mon Dec 9 18:46:34 2024 -0500 html_to_ascii() accept screenwidth=0 to suppress soft line breaks in conversion ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/html_to_ascii.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500595Mon, 09 Dec 2024 18:40:52 +05002099500595@Uncensored Date: Mon Dec 9 18:40:48 2024 -0500 uote and

rint use the new scr_redir api ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 16 +-- textclient/citadel.rc | 2 +- textclient/messages.c | 253 +++++++++++++++--------------------------------- textclient/textclient.h | 2 +- 4 files changed, 89 insertions(+), 184 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500590Mon, 09 Dec 2024 17:59:20 +05002099500590@Uncensored Date: Mon Dec 9 17:59:18 2024 -0500 Added scr_ functions to redirect output to a memory buffer ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 2 +- textclient/screen.c | 105 +++++++++++++++++++++++++++++++++++++++--------- textclient/textclient.h | 2 + 3 files changed, 90 insertions(+), 19 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500586Mon, 09 Dec 2024 17:16:29 +05002099500586@Uncensored Date: Mon Dec 9 17:16:27 2024 -0500 Removed unused parameter to scr_getc() ----------------------------------------------------------------------- Summary of changes: textclient/client_chat.c | 2 +- textclient/commands.c | 10 ++++------ textclient/screen.c | 2 +- textclient/textclient.h | 4 +--- 4 files changed, 7 insertions(+), 11 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500563Mon, 09 Dec 2024 14:52:15 +05002099500563@Uncensored Date: Mon Dec 9 14:52:10 2024 -0500 scr_printf() dynamic buffer and don't mangle it ----------------------------------------------------------------------- Summary of changes: textclient/screen.c | 57 ++++++++++++++++++++++++++--------------------------- 1 file changed, 28 insertions(+), 29 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500548Mon, 09 Dec 2024 14:05:40 +05002099500548@Uncensored Date: Mon Dec 9 14:05:38 2024 -0500 character loop output instead of printf ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 2 +- textclient/screen.c | 16 ++++++++++------ textclient/textclient.h | 14 +++++++------- 3 files changed, 18 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500505Mon, 09 Dec 2024 11:27:59 +05002099500505@Uncensored Date: Mon Dec 9 11:27:56 2024 -0500 fmout() use global screenwidth instead of as a parameter ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 2 +- textclient/commands.c | 22 ++++++++++++---------- textclient/messages.c | 6 +++--- textclient/rooms.c | 2 +- textclient/textclient.h | 2 +- 5 files changed, 18 insertions(+), 16 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500406Sun, 08 Dec 2024 22:18:19 +05002099500406@Uncensored Date: Sun Dec 8 22:18:17 2024 -0500 moved things ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500405Sun, 08 Dec 2024 22:09:06 +05002099500405@Uncensored Date: Sun Dec 8 22:09:04 2024 -0500 screen.c: moved other screen handling functions into this file ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 40 ------------------------------ textclient/messages.c | 15 ++++++------ textclient/rooms.c | 3 +-- textclient/screen.c | 60 +++++++++++++++++++++++++++++++++++++++++---- textclient/textclient.h | 2 ++ textclient/user_functions.c | 10 ++------ 6 files changed, 68 insertions(+), 62 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500383Sun, 08 Dec 2024 21:13:36 +05002099500383@Uncensored Date: Sun Dec 8 21:13:34 2024 -0500 Initial go at the console rework ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 2 +- textclient/client_chat.c | 2 +- textclient/commands.c | 14 +- textclient/messages.c | 8 +- textclient/screen.c | 238 ++++++++++++++++++++-------------- textclient/textclient.h | 7 +- textclient/user_functions.c | 3 +- textclient/wcwidth.c | 309 ++++++++++++++++++++++++++++++++++++++++++++ 8 files changed, 469 insertions(+), 114 deletions(-) create mode 100644 textclient/wcwidth.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500235Sun, 08 Dec 2024 00:14:48 +05002099500235@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500216Sat, 07 Dec 2024 22:06:14 +05002099500216@Uncensored

 

Sun Dec 08 2024 03:03:08 UTC from HarlowSolutions Subject: Re: Core dumping on shutdown due to Full Text Indexing

I'm assuming you're testing it under load.

Yes.  Heavy asynchronous SMTP mail sends.

Should have mentioned that all the mail had been sent and processed by the server by the time the coredump occurred.  The indexing runs for a very long time after my test program completes.  Never timed it, but I have seen about 15-30min indexing.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500215Sat, 07 Dec 2024 22:03:08 +05002099500215@Uncensored

I'm assuming you're testing it under load.

Yes.  Heavy asynchronous SMTP mail sends.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500214Sat, 07 Dec 2024 22:01:10 +05002099500214@Uncensored

Luck I guess.  In threads.c, InitializeSemaphores() was never called by anyone which initialized the mutexes.  The mutexes were never set to PTHREAD_MUTEX_INITIALIZER, so static initialization would not initialize them either.  Not sure how they did not get errors on lock/unlock.

I went ahead and used pthread_once() to initalize them before they are used.  I thought I only needed to call the init when go_threading() started, but in debug, I found that something else was using locks before threading, so I just called the init check before each mutex use.

I had some coredumps in database and memory during testing by opening hundreds of threads to send mail to the server and was going through a lot of lock and database code.  That's were I found the mutexes were not getting initialized and the send message not locking the room before writing to the database.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500163Sat, 07 Dec 2024 18:42:39 +05002099500163@Uncensored Date: Sat Dec 7 18:41:06 2024 -0500 back() is now scr_back() and used everywhere it can be ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 14 ++++---------- textclient/messages.c | 16 ++++------------ textclient/screen.c | 8 ++++++++ textclient/textclient.h | 4 ++-- textclient/utilfunc.c | 11 ----------- 5 files changed, 18 insertions(+), 35 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500162Sat, 07 Dec 2024 18:41:08 +05002099500162@Uncensored Date: Sat Dec 7 18:41:06 2024 -0500 back() is now scr_back() and used everywhere it can be ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 14 ++++---------- textclient/messages.c | 16 ++++------------ textclient/screen.c | 8 ++++++++ textclient/textclient.h | 4 ++-- textclient/utilfunc.c | 11 ----------- 5 files changed, 18 insertions(+), 35 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500154Sat, 07 Dec 2024 18:26:18 +05002099500154@Uncensored Date: Sat Dec 7 16:59:47 2024 -0500 view_calendar.js: handle non-inclusive DTEND properly See https://www.rfc-editor.org/rfc/rfc5545#section-3.6.1 to understand the "non inclusive end of the event". This basically means that if DTSTART/DTEND are both the same day, it is an event that is "on that day" but does not span the entire day (like a birthday or anniversary for example). A true "all day event" has a DTEND set to the day *after* it ends. WebCit displays events of both types the same way but must calculate the proper columns. commit b6a10306e6380d9bc85dffb56fa66951c00fb786 Author: Harlow Solutions Date: Sat Dec 7 16:24:00 2024 -0500 msgbase.c: Sending message without locking caused deadlock coredump. CtdlSubmitMsg() processing did not lock room when writing message using send_message() resulting in deadlock coredump. Now save_this_message() does. ----------------------------------------------------------------------- -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500135Sat, 07 Dec 2024 17:06:40 +05002099500135@UncensoredLock mutexes were never initialized. Implemented proper initialization and added error checking to initialization, lock and un >lock. Tell me more about that please. Have we just been really lucky all this time and not getting obvious corruption? ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500134Sat, 07 Dec 2024 17:05:19 +05002099500134@UncensoredWhen shutdown closes the database, I get a coredump because >do_fulltext_indexing() is still running and issues a fetch and dies. Interesting. I haven't seen that. Normally it should detect that the server_shutting_down global has been set, and do the right thing. I'm assuming you're testing it under load. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500131Sat, 07 Dec 2024 17:00:43 +05002099500131@Uncensored Date: Sat Dec 7 16:59:47 2024 -0500 view_calendar.js: handle non-inclusive DTEND properly See https://www.rfc-editor.org/rfc/rfc5545#section-3.6.1 to understand the "non inclusive end of the event". This basically means that if DTSTART/DTEND are both the same day, it is an event that is "on that day" but does not span the entire day (like a birthday or anniversary for example). A true "all day event" has a DTEND set to the day *after* it ends. WebCit displays events of both types the same way but must calculate the proper columns. ----------------------------------------------------------------------- Summary of changes: textclient/screen.c | 2 -- webcit-ng/static/js/view_calendar.js | 12 +++++++++++- 2 files changed, 11 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500126Sat, 07 Dec 2024 16:24:53 +05002099500126@Uncensored Date: Sat Dec 7 16:24:00 2024 -0500 msgbase.c: Sending message without locking caused deadlock coredump. CtdlSubmitMsg() processing did not lock room when writing message using send_message() resulting in deadlock coredump. Now save_this_message() does. CtdlSubmitMsg()->send_message()->CtdlSaveThisMessage()->bdb_store() Changed name of CtdlSaveThisMessage() to save_this_message() since local. ----------------------------------------------------------------------- Summary of changes: citadel/server/msgbase.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099500072Sat, 07 Dec 2024 02:59:56 +05002099500072@Uncensored Date: Sat Dec 7 02:58:14 2024 -0500 Lock mutexes were never initialized. Implemented proper initialization and added error checking to initialization, lock and unlock. ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 1 + citadel/server/sysdep.c | 12 +++---- citadel/server/threads.c | 77 ++++++++++++++++++++++++++++++++++++++----- citadel/server/threads.h | 6 ---- 4 files changed, 75 insertions(+), 21 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499896Thu, 05 Dec 2024 23:31:34 +05002099499896@Uncensored Date: Thu Dec 5 23:31:32 2024 -0500 view_calendar.js: top-align the date labels, remove debugs ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 1 + webcit-ng/static/js/view_calendar.js | 14 ++------------ 2 files changed, 3 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499887Thu, 05 Dec 2024 20:54:51 +05002099499887@Uncensored Date: Thu Dec 5 20:54:48 2024 -0500 view_calendar.js: make the top labels line up with the columns (HACK) The HACK was to insert a div on each side of the labels, with six   characters on the left and two on the right. This somehow makes it render pixel perfect with the columns below them even though the flow rules are different. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499732Wed, 04 Dec 2024 23:27:28 +05002099499732@Uncensored Date: Wed Dec 4 23:27:26 2024 -0500 view_calendar.js: display all day events up top near the labels ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 11 ++++++--- webcit-ng/static/js/view_calendar.js | 48 +++++++++++++++++++++++++----------- 2 files changed, 41 insertions(+), 18 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499726Wed, 04 Dec 2024 22:51:42 +05002099499726@Uncensored Date: Wed Dec 4 22:51:40 2024 -0500 webcit.css: calendar headings/content use flexbox properly instead of static sizing ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499602Tue, 03 Dec 2024 23:24:37 +05002099499602@Uncensored Date: Tue Dec 3 23:24:32 2024 -0500 Identify point-in-time and all-day events, they need to be rendered differently ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 5 ++--- webcit-ng/static/js/view_calendar.js | 17 ++++++++++++++--- 2 files changed, 16 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499374Mon, 02 Dec 2024 01:35:28 +05002099499374@Uncensored

I ran into this on my production server a few times and I was finally able to reproduce it on a test system.  I can try to trace the issue down, but I wanted to see if anyone had seen this also.

When shutdown closes the database, I get a coredump because do_fulltext_indexing() is still running and issues a fetch and dies.

I assume the solution is to stop the indexing in progress when shutting down or have the bdb code return errors when shutdown it active.  Without looking at a lot of code in shutdown and fulltext, I am not sure what the best approach is.  Anyone have any tips or should I just dig into it when I have time?  I turned off indexing, so I do not have the error anymore. It may be an easy code fix for someone else, since I cannot seem to even put returns into functions :-)

The way I recreated it was to send the server a bunch of mail and then shutdown.  The indexing runs for a very long time after the email has been delivered and if you shutdown before it completes, you get the coredump.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499369Mon, 02 Dec 2024 00:27:33 +05002099499369@Uncensored

I guess the programming gods felt sorry for my crappy programming.  I have no clue how it worked.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499281Sat, 30 Nov 2024 23:25:19 +05002099499281@Uncensored Date: Sat Nov 30 23:25:12 2024 -0500 textclient: disable SIGWINCH during terminal capability detect. Discovered that telnetd will often choose to alert the client of the terminal window size via a SIGWINCH during the sleep between terminal enquiry and reading the terminal answerback. This was causing the sleep() or nanosleep() system call to be interupted, resulting in either the answerback appearing at the username prompt, or a zombie telnetd process to be left behind. Disabling SIGWINCH during the nanosleep() call fixes the problem. We will perform an ioctl to get the terminal window size afterwards anyway. If the user subsequently resizes the terminal, SIGWINCH will be properly caught and the client will react. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 3 --- textclient/commands.c | 11 +++++++++-- textclient/screen.c | 1 + 3 files changed, 10 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499141Fri, 29 Nov 2024 00:30:48 +05002099499141@Uncensored Date: Fri Nov 29 00:30:46 2024 -0500 calendar_edit.js: start/end time editing now loads and saves correctly. Time zones are the bane of the calendar software developer's existence. libical does a pretty good job of automating away the component and property format manipulation, but we still have a lot of work to do. Whenever the browser detects that the user changed the start or end time of an event, we load up the DTSTART/DTEND properties, copy in new values from the web form, and then store them back into the component. Vile, sleazy hacks are required to preserve these properties in their original time zones. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499009Wed, 27 Nov 2024 23:52:15 +05002099499009@Uncensored

This was a weird one.  Not that the bug itself was weird, it was obvious once found.  What I'm wondering is how it ever could have possibly worked in the first place.  CtdlVisitCreateEmpty() was allocating memory, initializing it with some default values, and then ... exiting the function without returning the new object.

It's been working fine on most systems all this time, including mine.  How?  Some sort of side effect that left the correct pointer in the correct location on some systems?  I don't get it.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499007Wed, 27 Nov 2024 23:45:24 +05002099499007@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499006Wed, 27 Nov 2024 23:45:23 +05002099499006@Uncensored Date: Wed Nov 27 23:45:23 2024 -0500 Release version 1007 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499005Wed, 27 Nov 2024 23:41:28 +05002099499005@Uncensored Date: Wed Nov 27 23:41:26 2024 -0500 CtdlVisitCreateEmpty() now actually returns the object that was created. How did this ever work? ----------------------------------------------------------------------- Summary of changes: citadel/server/visit.c | 2 ++ 1 file changed, 2 insertions(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099499002Wed, 27 Nov 2024 23:35:48 +05002099499002@Uncensored Date: Wed Nov 27 23:35:45 2024 -0500 raspberry pi troubleshoot ----------------------------------------------------------------------- Summary of changes: citadel/server/visit.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498983Wed, 27 Nov 2024 22:08:09 +05002099498983@Uncensored Date: Wed Nov 27 22:08:08 2024 -0500 setup: restart citserver using systemctl instead of server cmd ----------------------------------------------------------------------- Summary of changes: citadel/utils/setup.c | 46 ++++------------------------------------------ 1 file changed, 4 insertions(+), 42 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498601Mon, 25 Nov 2024 10:33:45 +05002099498601@Uncensored Date: Mon Nov 25 10:33:42 2024 -0500 client: more cleanup! ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 6 ---- textclient/commands.c | 3 -- textclient/messages.c | 80 +++++++++---------------------------------------- textclient/rooms.c | 3 -- textclient/sysutil.c | 46 ++++++++++++++++++++++++++++ textclient/textclient.h | 8 +++++ textclient/utilfunc.c | 3 -- 7 files changed, 68 insertions(+), 81 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498527Sun, 24 Nov 2024 12:05:43 +05002099498527@Uncensored void getmime(const char *filename, char *mimebuf, const int sizeof_mimebuf) { const char *magic_full; magic_t magic_cookie; const char default_mime_type[] = "application/octet-stream"; int i; /*MAGIC_MIME requests mimetype info*/ magic_cookie = magic_open(MAGIC_MIME); if(magic_cookie == NULL) { //magic cookie failed snprintf(mimebuf, sizeof_mimebuf, "%s", default_mime_type); return; } /*loading default magic database NOTE: performance hit*/ if(magic_load(magic_cookie, NULL) != 0) { //cannot load snprintf(mimebuf, sizeof_mimebuf, "%s", default_mime_type); magic_close(magic_cookie); return; } magic_full = magic_file(magic_cookie, filename); snprintf(mimebuf, sizeof_mimebuf, "%s", magic_full); /*just a homebrew strcspn(), cutting off everything after ';' char */ for(i=0; mimebuf[i] != '\0'; i++) if(mimebuf[i] == ';') break; mimebuf[i] = '\0'; /*libmagic(3) : magic_close() deallocates any resources used.*/ magic_close(magic_cookie); } /*getmime()*/ ``` In serv_rooms.c into cmd_rdir() using this helper to autodetect each file prior displaying it to the user. Results: * end-user sees correct mime type during the directory listing (RDIR only) Problems: * performance hit! Each time RDIR is invoked getmime() is called per each file into the directory (there should be smarter ways of doing this :) * introducing new dependency for citserver: -lmagic (libmagic.so) . This means additional maintenance, increased attack surface, etc. etc. Notes: * libmagic is thread safe as long as there are multiple libmagic instances, one for each thread, see: => https://stackoverflow.com/questions/10654371/is-lib-magic-thread-safe ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498500Sat, 23 Nov 2024 23:23:02 +05002099498500@Uncensored Date: Sat Nov 23 23:22:59 2024 -0500 citadel.c: removed ALL remaining gotos! ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 179 +++++++++++++++++++++++++-------------------------- 1 file changed, 89 insertions(+), 90 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498437Sat, 23 Nov 2024 18:38:00 +05002099498437@Uncensored Date: Sat Nov 23 18:37:58 2024 -0500 citadel.c: using the magic of loops, eliminated a bunch of gotos ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 268 +++++++++++++++++++++++++----------------------- textclient/rooms.c | 24 ++--- textclient/textclient.h | 6 +- 3 files changed, 152 insertions(+), 146 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498432Sat, 23 Nov 2024 17:56:19 +05002099498432@Uncensored Date: Sat Nov 23 17:56:17 2024 -0500 citadel.c: modernized old and crappy code ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 111 +++++++++++----------- textclient/citadel.rc | 1 - textclient/citadel_ipc.c | 178 +++++++++++++++++++---------------- textclient/commands.c | 6 -- textclient/textclient.h | 3 - webcit-ng/static/js/calendar_edit.js | 12 ++- 6 files changed, 156 insertions(+), 155 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498282Fri, 22 Nov 2024 17:15:06 +05002099498282@Uncensored Date: Fri Nov 22 17:15:04 2024 -0500 Set up the screen AFTER connecting to the server. This seems to correct the problem with telnetd throwing away the delay between sending the terminal enquiry and waiting for the answerback. I don't know why. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498175Thu, 21 Nov 2024 22:10:53 +05002099498175@Uncensored Date: Thu Nov 21 22:10:51 2024 -0500 fixed rc_ansi_color bug ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 5 ----- textclient/commands.c | 4 ++-- textclient/textclient.h | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498127Thu, 21 Nov 2024 14:31:27 +05002099498127@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099498108Thu, 21 Nov 2024 10:47:23 +05002099498108@Uncensored

I had a coredump on my production system that I cannot reproduce.  I am not that familiar with SSL, but it looks like we may need a little more error handling in the Crypto code, even if it isn't the root cause of the coredump.  I lost the core file but it said that it was trying to free an unallocated address.  Probably needs someone with more SSL experience than me.

The dump was in serv_crypto.c endtls().  It died in endtls().  I did some reading on SSL_shutdown() and there are a lot of conditions that it can error on.  We are not looking at the return code and just calling SSL_free().  Could a bad connection cause issues with SSL_shutdown() and result in corrupting something?

 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099497742Mon, 18 Nov 2024 23:17:09 +05002099497742@Uncensored Date: Mon Nov 18 23:17:07 2024 -0500 calendar_edit.js: more of it ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 42 +++++++++++++++++++++++++----------- webcit-ng/static/js/view_calendar.js | 4 ++++ 2 files changed, 33 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099497585Sun, 17 Nov 2024 22:51:43 +05002099497585@Uncensored Date: Sun Nov 17 22:51:39 2024 -0500 calendar_edit.js: toggle between date and date/time ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099497422Sat, 16 Nov 2024 14:18:28 +05002099497422@Uncensored Date: Sat Nov 16 14:18:26 2024 -0500 Include the correct algorithm to beat the Kobayashi Maru ----------------------------------------------------------------------- Summary of changes: citadel/server/server_main.c | 3 +-- citadel/server/sysdep.c | 16 ++++++---------- textclient/client_passwords.c | 12 +++++++----- textclient/rooms.c | 32 ++++++++++++-------------------- textclient/tuiconfig.c | 6 ++---- 5 files changed, 28 insertions(+), 41 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099497208Thu, 14 Nov 2024 16:51:16 +05002099497208@Uncensored Date: Thu Nov 14 16:51:08 2024 -0500 Clarify rc_mail_command failure message. It isn't a "check mail" command, it's an "alert about new mail" command. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496954Wed, 13 Nov 2024 11:20:24 +05002099496954@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496953Wed, 13 Nov 2024 11:20:24 +05002099496953@Uncensored Date: Wed Nov 13 11:20:23 2024 -0500 Release version 1006 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496952Wed, 13 Nov 2024 11:20:16 +05002099496952@Uncensored Date: Wed Nov 13 11:20:11 2024 -0500 file_transfer.c: added ----------------------------------------------------------------------- Summary of changes: textclient/file_transfer.c | 216 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 216 insertions(+) create mode 100644 textclient/file_transfer.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496949Wed, 13 Nov 2024 11:12:18 +05002099496949@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496948Wed, 13 Nov 2024 11:12:18 +05002099496948@Uncensored Date: Wed Nov 13 11:12:17 2024 -0500 Release version 1005 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496889Tue, 12 Nov 2024 22:47:06 +05002099496889@Uncensored Date: Tue Nov 12 22:47:02 2024 -0500 inboxrules: load message headers if not present before doing reject ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- .../server/modules/inboxrules/serv_inboxrules.c | 105 ++++++++++++--------- 2 files changed, 59 insertions(+), 48 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496859Tue, 12 Nov 2024 21:27:32 +05002099496859@Uncensored Date: Tue Nov 12 21:27:30 2024 -0500 WebCit Classic: mail compose subject now allows up to 256 characters ----------------------------------------------------------------------- Summary of changes: webcit/static/t/edit/message.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496703Mon, 11 Nov 2024 19:12:27 +05002099496703@Uncensored Date: Mon Nov 11 19:12:24 2024 -0500 Connecting host in wholist is now only visible to admins. Culture change by popular demand. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/rwho/serv_rwho.c | 19 ++--- textclient/user_functions.c | 35 --------- webcit/who.c | 129 +++++++++++++++----------------- 3 files changed, 68 insertions(+), 115 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496683Mon, 11 Nov 2024 14:56:44 +05002099496683@Uncensored Date: Mon Nov 11 14:56:42 2024 -0500 rblcheck: by removing timing diag we can remove gotos ----------------------------------------------------------------------- Summary of changes: citadel/server/locate_host.c | 39 +++++++++++++-------------------------- 1 file changed, 13 insertions(+), 26 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496486Sat, 09 Nov 2024 18:58:20 +05002099496486@Uncensored Date: Sat Nov 9 18:58:19 2024 -0500 stty_ctdl() modernized ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 19 +++++++++++-------- textclient/messages.c | 11 +++++------ textclient/sysutil.c | 4 ++-- textclient/textclient.h | 13 ++++++++----- textclient/tuiconfig.c | 2 +- 5 files changed, 27 insertions(+), 22 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496483Sat, 09 Nov 2024 18:42:22 +05002099496483@Uncensored Date: Sat Nov 9 18:42:20 2024 -0500 screen.c: style cleanup. More comments here about how my coding style in the late 1980s was absolute crap and is still reflected in the text client. Style cleanup is easy; getting rid of the metric crapton of global variables is a bit harder. ----------------------------------------------------------------------- Summary of changes: textclient/screen.c | 89 ++++++++++++++++++++--------------------------------- 1 file changed, 33 insertions(+), 56 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496480Sat, 09 Nov 2024 18:31:12 +05002099496480@Uncensored Date: Sat Nov 9 18:31:09 2024 -0500 routines.c is finally gone! The actual utility functions have been moved to a new file utilfunc.c User editing related functions have been moved to user_functions.c ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 2 +- textclient/routines.c | 525 -------------------------------------------- textclient/user_functions.c | 337 ++++++++++++++++++++++++++++ textclient/utilfunc.c | 186 ++++++++++++++++ 4 files changed, 524 insertions(+), 526 deletions(-) delete mode 100644 textclient/routines.c create mode 100644 textclient/utilfunc.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496475Sat, 09 Nov 2024 18:22:14 +05002099496475@Uncensored Date: Sat Nov 9 18:22:11 2024 -0500 ipc_c_tcp.c: renamed to tcpclient.c ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 2 +- textclient/{ipc_c_tcp.c => tcpclient.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename textclient/{ipc_c_tcp.c => tcpclient.c} (100%) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496472Sat, 09 Nov 2024 18:13:38 +05002099496472@Uncensored Date: Sat Nov 9 18:13:36 2024 -0500 textclient: moved all extern defs to textclient.h ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 8 +----- textclient/client_chat.c | 1 - textclient/commands.c | 2 -- textclient/messages.c | 23 +--------------- textclient/rooms.c | 20 -------------- textclient/routines.c | 6 ----- textclient/screen.c | 6 +---- textclient/textclient.h | 70 ++++++++++++++++++++++++++++++++++-------------- textclient/tuiconfig.c | 10 ------- 9 files changed, 53 insertions(+), 93 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496335Fri, 08 Nov 2024 11:35:34 +05002099496335@Uncensored Date: Fri Nov 8 11:35:30 2024 -0500 rooms.c: extern declarations moved to textclient.h ----------------------------------------------------------------------- Summary of changes: textclient/rooms.c | 6 ------ textclient/textclient.h | 1 + 2 files changed, 1 insertion(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496334Fri, 08 Nov 2024 11:33:26 +05002099496334@Uncensored Date: Fri Nov 8 11:33:23 2024 -0500 routines2.c is now gone. All functions moved to more appropriate locations. Honestly, that was a really stupid name for a source code file. ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 2 +- textclient/routines2.c | 177 -------------------------------------------- textclient/user_functions.c | 165 ++++++++++++++++++++++++++++++++++++++++- 3 files changed, 162 insertions(+), 182 deletions(-) delete mode 100644 textclient/routines2.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496331Fri, 08 Nov 2024 11:27:52 +05002099496331@Uncensored Date: Fri Nov 8 11:20:26 2024 -0500 textclient: began organizing functions in files more purposefully. Yeah. It's time to erase some of this 35+ year old technical debt. ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 2 +- textclient/citadel.c | 32 +++- textclient/commands.c | 11 ++ textclient/messages.c | 1 - textclient/rooms.c | 1 - textclient/routines2.c | 363 +------------------------------------------- textclient/sysutil.c | 19 +++ textclient/textclient.h | 5 +- textclient/tuiconfig.c | 1 - textclient/user_functions.c | 99 ++++++++++++ 10 files changed, 163 insertions(+), 371 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496214Thu, 07 Nov 2024 13:51:15 +05002099496214@Uncensored Date: Thu Nov 7 13:51:09 2024 -0500 Documented the ipc_for_signal_handlers kludge now that I understand it. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 13 ++++++++----- textclient/commands.c | 1 - textclient/messages.c | 1 - textclient/textclient.h | 3 +++ 4 files changed, 11 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099496211Thu, 07 Nov 2024 13:39:10 +05002099496211@Uncensored Date: Thu Nov 7 13:39:07 2024 -0500 citadel.c: move command loop into a separate function ----------------------------------------------------------------------- Summary of changes: citadel/docs/delivery-list.txt | 10 - citadel/server/modules/smtp/dkim.c | 5 +- citadel/server/modules/smtp/dkim_bindings.c | 2 - citadel/server/modules/smtp/serv_smtpclient.c | 13 +- textclient/citadel.c | 750 +++++++++++++------------- 5 files changed, 387 insertions(+), 393 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099495847Mon, 04 Nov 2024 09:57:49 +05002099495847@Uncensored Date: Mon Nov 4 09:57:46 2024 -0500 idle style cleanup ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099495545Fri, 01 Nov 2024 21:51:21 +05002099495545@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099495529Fri, 01 Nov 2024 20:24:54 +05002099495529@Uncensored Date: Fri Nov 1 20:24:52 2024 -0400 Wait two seconds instead of one for terminal detect ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099495526Fri, 01 Nov 2024 20:08:15 +05002099495526@Uncensored Date: Fri Nov 1 20:08:13 2024 -0400 When closing the databases, call our own bdb_checkpoint() Just another exercise in DRY ----------------------------------------------------------------------- Summary of changes: citadel/server/backends/berkeley_db/berkeley_db.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099495464Fri, 01 Nov 2024 13:47:48 +05002099495464@UncensoredBefore that, and working out a better blocking algorithm, Citadel crash >and the database was corupted and I was having to reload from backups.  There's so much garbage traffic out there, and it's an issue for everyone on all software, so I think as an industry we'll figure it out eventually. It's frustrating though. Over the last couple of months we've made a couple of changes that make things more resilient in the face of repeated knocking on the door by misbehaving connections. We'll keep doing that. I am happy to hear that your database is holding up better now. Are you not getting the crashes at all, or are you still getting crashes but it recovers cleanly? I'm still incredibly amazed at what a difference those changes made. It took the entire summer of 2023 to clean up but it was worth it. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099495460Fri, 01 Nov 2024 13:36:03 +05002099495460@UncensoredI don't think we could do much with the room gen number even before the >new Visit.  The room gen is between the room number and the user id in >the database index, so we are stuck unless we convert the entire >database.  Right. The time for me to have realized that the room gen was superfluous was in 1998. It isn't hurting anything for it to be there. It just isn't necessary anymore. Perhaps someday we'll find some other use for it. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099495219Wed, 30 Oct 2024 17:46:06 +05002099495219@Uncensored

The email makes sense.  I saw that code, but wondered if alias needed to be supported.

The attacks are a pain, but I have a pretty good custom solution in place.  The Citadel blocking and firewall blocking just did not work for me.  I use a virtual machine and the attacks eventually mess up the network interface and the attackers rotate through thousands of IP addresses which my firewall just could not handle.  I now reset the network interface periodically and drop socket connections as soon as Citadel opens the socket and sees that the IP is supposed to be blocked.  The biggest improvement you made was updating the database.  Before that, and working out a better blocking algorithm, Citadel crash and the database was corupted and I was having to reload from backups.  Ugh.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099495217Wed, 30 Oct 2024 17:33:26 +05002099495217@Uncensored

Glad you figured it out.  The builds are tricky.

I don't think we could do much with the room gen number even before the new Visit.  The room gen is between the room number and the user id in the database index, so we are stuck unless we convert the entire database.  In my first go round with Visit when you found it took so long to convert the database, I had moved the user id to the beginning of the index, so we could load just based on user and speed up purging a user's Visit records.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494936Tue, 29 Oct 2024 11:25:39 +05002099494936@Uncensored Date: Tue Oct 29 11:25:25 2024 -0400 dbnothing: fix banner ----------------------------------------------------------------------- Summary of changes: citadel/utils/dbnothing.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494882Mon, 28 Oct 2024 22:20:48 +05002099494882@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494851Mon, 28 Oct 2024 17:45:21 +05002099494851@Uncensored CtdlIPC *ipc textclient: build without .d files calendar_week_view.txt: added. calendar_week_view.txt: small change text client: generic command now uses the API tui: move a few functions to sysutil.c tui: began converting do_edit() to api Discovered an awful bug and squashed it client_chat.c: began converting to client lib client_chat.c: converted all remaining CtdlIPC_chat_send() and CtdlIPC_chat_recv() calls to CtdlIPCGenericCommand() textclient: greatly simplified the keepalive loop. Moved read of greeting banner into protocol library. Rewrote userlist() and moved it to a separate file moved who_is_online and companions to user_functions.c citadel.c: change all comments to C99 style Idling away time in the airport Suppress newline+tab from being added to calendar event description when editing Skeleton code for conversion to/from all day events CtdlEncodeBase64() clear output buffer if input is empty ctdldump: do not dump user records if username is empty or user number is less than 1 Release version 1004 generated by do-release.sh Harlow Solutions (5): Clean up compiler warnings. Small code and buffer changes. Depricated readdir_r only warnings. Fix possible memory overrun for bad partial in BODY[] Hardcode Visit legacy record sizes so will not change if defines change Fix possible memory overrun when processing recp lists Webcit reports all messages read when room has no messages read. ----------------------------------------------------------------------- -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494850Mon, 28 Oct 2024 17:45:21 +05002099494850@Uncensored Date: Mon Oct 28 17:45:20 2024 -0400 Release version 1004 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494849Mon, 28 Oct 2024 17:44:47 +05002099494849@Uncensored Date: Mon Oct 28 17:44:45 2024 -0400 ctdldump: do not dump user records if username is empty or user number is less than 1 ----------------------------------------------------------------------- Summary of changes: citadel/utils/ctdldump.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494843Mon, 28 Oct 2024 16:53:05 +05002099494843@Uncensored Date: Mon Oct 28 16:53:01 2024 -0400 CtdlEncodeBase64() clear output buffer if input is empty commit 83e1e42151ddfc15533ea1653a8148067ec7b1f8 Author: Art Cancro Date: Mon Oct 28 13:56:25 2024 -0400 Skeleton code for conversion to/from all day events ----------------------------------------------------------------------- Summary of changes: citadel/utils/ctdldump.c | 2 +- citadel/utils/ctdlload.c | 35 ++++++++++++++++++++++++----------- libcitadel/lib/base64.c | 4 ++++ webcit-ng/static/js/calendar_edit.js | 18 +++++++++++++++++- 4 files changed, 46 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494805Mon, 28 Oct 2024 13:53:37 +05002099494805@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494804Mon, 28 Oct 2024 13:47:51 +05002099494804@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494787Mon, 28 Oct 2024 13:13:02 +05002099494787@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494781Mon, 28 Oct 2024 12:50:12 +05002099494781@Uncensorednoticed that Citadel allows users to log in with their user name or an >alias for the user.  Should aliases be allowed for logging in? This is done so that a user can log in to IMAP or whatever with their email address. I do realize that it creates a slightly larger attack surface but it is a feature that was requested by the user community. Damn brute force lowlifes ... put any service online and they're going to attack pretty much nonstop. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494779Mon, 28 Oct 2024 12:47:37 +05002099494779@UncensoredCan you give me a sample Visit dump record?  Should look something like >this: visit|1|1728342664|2|0|4|0|*:0||||| Sure, I'm already headed down that road, here's a sample record from Uncensored: visit|253737|1340313804|1|2099356758|4|1|2099356744:2099493821|||2099493821|| It looks correct, but your idea about the generation number being wrong is an interesting one and I'll check that too. The funny thing is, after all this time I've just realized that it took me about 25 years to realize that the generation number shouldn't exist anymore. From 1981-1999 or so, a room's "number" was implicit by its row number in the flat file. The generation number existed so that if a room was deleted and a new one was created in the same position in the file, it wouldn't be treated as the same room. When we converted from flat files to a database, we stopped reusing room numbers. Go figure. I wish I'd realized this before we reworked the visits file. :( ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494610Sat, 26 Oct 2024 22:18:34 +05002099494610@Uncensored

My server has been under constant attack by brute force user/password login attempts.  I have my own blocking in place, but in the attacks, I noticed that Citadel allows users to log in with their user name or an alias for the user.  Should aliases be allowed for logging in?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494607Sat, 26 Oct 2024 22:12:48 +05002099494607@Uncensored

Can you give me a sample Visit dump record?  Should look something like this: visit|1|1728342664|2|0|4|0|*:0|||||

The only thing I can think of that might be an issue in the dump/load would be the third field (room gen).  If the gen number is big enough, it might be the root cause.  If you search the dump file, you should find a room with the matching number, so if it does not exist, the visit value is the issue.

If that does not show what is wrong, I will create a 32-bit VM and try to debug it.

 

Fri Oct 25 2024 23:42:23 EDT from IGnatius T Foobar Subject: New results from Uncensored import -- concerns about visit records

As I might have mentioned before, Uncensored is still running on 32-bit Linux and I've been procrastinating for a long time over getting it converted to 64-bit, partially because until this year it was running on really crappy hardware and the dump/load would take forever. This week I finally did a test run, exporting from a snapshot of the production system and importing on the target 64-bit container. Here are some results:

* The dump took about 8 minutes during a period of normal load and consists of 776153 rows consuming 15 GB.
* Loading that dump onto a new environment took about 23 minutes and loaded all but 4 rows. All of the bad rows were user records, and they're probably junk anyway.

* And now the issue: it appears that the visit records did not import properly at all. When I logged in, all messages were new in all rooms. I also noticed that mailboxes were appearing with the forum view instead of the mailbox view, also indicating a visi

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099494535Fri, 25 Oct 2024 23:42:23 +05002099494535@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493766Sat, 19 Oct 2024 18:21:19 +05002099493766@Uncensored Date: Sat Oct 19 18:21:17 2024 -0400 Suppress newline+tab from being added to calendar event description when editing ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493654Fri, 18 Oct 2024 14:23:42 +05002099493654@Uncensored Date: Fri Oct 18 14:23:39 2024 -0400 Idling away time in the airport ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 40 ++++++++++++++------------------- textclient/tuiconfig.c | 60 +++++++++++++++++++++++++++----------------------- 2 files changed, 49 insertions(+), 51 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493650Fri, 18 Oct 2024 13:55:52 +05002099493650@Uncensored Date: Fri Oct 18 13:55:49 2024 -0400 citadel.c: change all comments to C99 style ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 167 ++++++++++++++++++++++++--------------------------- 1 file changed, 79 insertions(+), 88 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493639Fri, 18 Oct 2024 13:41:51 +05002099493639@Uncensored Date: Fri Oct 18 13:41:49 2024 -0400 moved who_is_online and companions to user_functions.c citadel.c was once the entire Citadel program and it's still too big ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 232 ------------------------------------------- textclient/textclient.h | 1 + textclient/user_functions.c | 234 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 235 insertions(+), 232 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493638Fri, 18 Oct 2024 13:36:56 +05002099493638@Uncensored Date: Fri Oct 18 13:36:54 2024 -0400 Rewrote userlist() and moved it to a separate file ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 2 +- textclient/citadel.c | 36 ------------------------------------ textclient/textclient.h | 1 + textclient/user_functions.c | 38 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 40 insertions(+), 37 deletions(-) create mode 100644 textclient/user_functions.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493627Fri, 18 Oct 2024 13:08:47 +05002099493627@Uncensored Date: Fri Oct 18 13:08:44 2024 -0400 Moved read of greeting banner into protocol library. This is the last of the things that used CtdlIPC_chat_send() and CtdlIPC_chat_recv(), and those functions have now been removed! This completes the work required to permit the client to use other transports in the future simply by swapping out the transport library. Future transports may include UDP, I2P SAM, HTTP, packet radio, who knows! ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 6 ------ textclient/citadel_ipc.c | 25 +++++++++++++------------ textclient/textclient.h | 6 ------ 3 files changed, 13 insertions(+), 24 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493571Fri, 18 Oct 2024 00:31:59 +05002099493571@Uncensored Date: Fri Oct 18 00:31:56 2024 -0400 textclient: greatly simplified the keepalive loop. I promised myself no more side quests but here I am again. :( As it turns out, the conversion of the chat protocol (which was YEARS ago) was the last step in making all client operations completely atomic. I looked through the client code and found no remaining places where keepalives were either disabled or set to half (no response) mode. So I ripped all of the complexity out and it now just does the standard NOOP and response every 30 seconds no matter what. All operations are atomic. This removes the last remaining uses of the chat_send and chat_recv functions except for the one that reads the initial server greeting, and that can probably get moved into the client library. ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 59 +++++++++++++++++---------------------------------- 1 file changed, 19 insertions(+), 40 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493567Fri, 18 Oct 2024 00:09:43 +05002099493567@Uncensored Date: Fri Oct 18 00:09:40 2024 -0400 client_chat.c: converted all remaining CtdlIPC_chat_send() and CtdlIPC_chat_recv() calls to CtdlIPCGenericCommand() ----------------------------------------------------------------------- Summary of changes: textclient/client_chat.c | 82 ++++++++++++++++++++---------------------------- 1 file changed, 34 insertions(+), 48 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493439Wed, 16 Oct 2024 23:30:45 +05002099493439@Uncensored Date: Wed Oct 16 23:30:42 2024 -0400 client_chat.c: began converting to client lib ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 8 +++----- textclient/citadel_ipc.c | 18 ++++++++++++------ textclient/client_chat.c | 14 +++++++------- 3 files changed, 22 insertions(+), 18 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493249Mon, 14 Oct 2024 23:39:40 +05002099493249@Uncensored Date: Mon Oct 14 23:39:37 2024 -0400 Discovered an awful bug and squashed it ----------------------------------------------------------------------- Summary of changes: textclient/citadel.rc | 2 +- textclient/citadel_ipc.c | 88 ++++++++++++++++++-------------------------- textclient/sysutil.c | 96 +++++++++++++++++++++++------------------------- textclient/textclient.h | 2 +- 4 files changed, 84 insertions(+), 104 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493232Mon, 14 Oct 2024 20:11:35 +05002099493232@Uncensored Date: Mon Oct 14 20:11:33 2024 -0400 tui: began converting do_edit() to api ----------------------------------------------------------------------- Summary of changes: textclient/sysutil.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493227Mon, 14 Oct 2024 19:53:33 +05002099493227@Uncensored Date: Mon Oct 14 19:53:31 2024 -0400 tui: move a few functions to sysutil.c ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 2 +- textclient/messages.c | 1 - textclient/rooms.c | 91 ------------------------------------ textclient/routines.c | 19 -------- textclient/sysutil.c | 119 ++++++++++++++++++++++++++++++++++++++++++++++++ textclient/textclient.h | 1 + 6 files changed, 121 insertions(+), 112 deletions(-) create mode 100644 textclient/sysutil.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493214Mon, 14 Oct 2024 17:51:58 +05002099493214@Uncensored Date: Mon Oct 14 17:51:55 2024 -0400 text client: generic command now uses the API I implemented a couple of things using CtdlIPC_chat_send() and CtdlIPC_chat_recv() instead of properly extending the internal API. Now I am fixing that mistake, because I have some ideas about making the text client use several different transports. We own port 504/udp so we could do a connectionless mode. Native I2P is also a possibility, and even just using HTTP through a modified WebCit could work. ----------------------------------------------------------------------- Summary of changes: textclient/citadel_ipc.c | 3 +-- textclient/routines.c | 30 ++++++++++++------------------ 2 files changed, 13 insertions(+), 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493207Mon, 14 Oct 2024 17:23:18 +05002099493207@Uncensored Date: Mon Oct 14 17:23:11 2024 -0400 calendar_week_view.txt: small change ----------------------------------------------------------------------- Summary of changes: webcit-ng/docs/calendar_week_view.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099493032Sat, 12 Oct 2024 15:19:54 +05002099493032@Uncensored Date: Sat Oct 12 15:18:35 2024 -0400 Webcit reports all messages read when room has no messages read. Fixed by setting message set to *:0 when Visit message set is empty. ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/hash.c | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492748Thu, 10 Oct 2024 15:48:23 +05002099492748@Uncensored Date: Thu Oct 10 15:48:21 2024 -0400 calendar_week_view.txt: added. This is a box-drawing diagram of the paper sketch I've had on my desk for too long and want to discard. It's a description of the hierarchy of divs in the calendar week view. ----------------------------------------------------------------------- Summary of changes: webcit-ng/{ => docs}/api.txt | 0 webcit-ng/docs/calendar_week_view.txt | 39 +++++++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+) rename webcit-ng/{ => docs}/api.txt (100%) create mode 100644 webcit-ng/docs/calendar_week_view.txt -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492707Thu, 10 Oct 2024 10:03:56 +05002099492707@Uncensored Date: Thu Oct 10 10:03:54 2024 -0400 textclient: build without .d files ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 4 ---- 1 file changed, 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492703Thu, 10 Oct 2024 09:58:53 +05002099492703@Uncensored Date: Thu Oct 10 09:58:37 2024 -0400 CtdlIPC * ipc --> CtdlIPC *ipc ----------------------------------------------------------------------- Summary of changes: textclient/client_passwords.c | 2 +- textclient/commands.c | 4 ++-- textclient/ipc_c_tcp.c | 2 +- textclient/rooms.c | 52 +++++++++++++++++++++---------------------- textclient/routines2.c | 22 +++++++++--------- textclient/tuiconfig.c | 12 +++++----- 6 files changed, 47 insertions(+), 47 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492343Mon, 07 Oct 2024 22:57:37 +05002099492343@Uncensored Date: Mon Oct 7 22:57:35 2024 -0400 render_event_editor() re-render option ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492325Mon, 07 Oct 2024 22:21:40 +05002099492325@Uncensored Date: Mon Oct 7 22:21:38 2024 -0400 is_room_aide() - removed CC macro (I need to stop doing this) ----------------------------------------------------------------------- Summary of changes: citadel/server/makeuserkey.c | 1 + citadel/server/modules/ctdlproto/serv_user.c | 2 +- citadel/server/modules/expire/expire_policy.c | 2 +- citadel/server/modules/imap/imap_fetch.c | 4 ++-- citadel/server/modules/imap/imap_metadata.c | 2 +- citadel/server/msgbase.c | 6 +++--- citadel/server/room_ops.c | 2 +- citadel/server/user_ops.c | 8 ++++---- citadel/server/user_ops.h | 2 +- 9 files changed, 15 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492320Mon, 07 Oct 2024 22:15:04 +05002099492320@Uncensored Date: Mon Oct 7 22:15:02 2024 -0400 more removal of unused globals ----------------------------------------------------------------------- Summary of changes: citadel/server/citserver.c | 1 - citadel/server/room_ops.c | 12 ++++-------- citadel/server/sysdep.c | 1 - 3 files changed, 4 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492319Mon, 07 Oct 2024 22:10:25 +05002099492319@Uncensored Date: Mon Oct 7 22:10:23 2024 -0400 Removed unused global 'panic_fd' ----------------------------------------------------------------------- Summary of changes: citadel/server/citserver.c | 1 - citadel/server/citserver.h | 1 - 2 files changed, 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492289Mon, 07 Oct 2024 17:25:33 +05002099492289@Uncensored Date: Mon Oct 7 17:25:12 2024 -0400 CtdlDoIHavePermissionToPostInThisRoom() local CC ----------------------------------------------------------------------- Summary of changes: citadel/server/internet_addressing.c | 1 + citadel/server/modules/ctdlproto/serv_messages.c | 1 + citadel/server/modules/expire/expire_policy.c | 1 + citadel/server/modules/imap/imap_misc.c | 2 +- citadel/server/modules/wiki/serv_wiki.c | 2 +- citadel/server/room_ops.c | 12 ++++++------ citadel/server/room_ops.h | 2 +- 7 files changed, 12 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492282Mon, 07 Oct 2024 16:41:03 +05002099492282@UncensoredI did it by adding a macro call at the beginning of each function that >used TSD which adds a local variable and then changed the TSD macro to >have all the calls use it, so minimal code change.  I can flip back and >forth with the original code by just changing the macro definitions so >it was easy to try some different implementations. That's similar to what we had in the past. Sample function: void do_something(int blah, char *foo) { struct CitContext *CCC = CC; do_something_with(CCC); CCC->blah = baz; etc. } The idea was that it would grab the session context from the thread specific data once, at the top of the function, and then it would have it cached (CachedCitContext) in its local stack for the remainder of the function's execution. It worked, but as I said, once it became pervasive it started to get really ugly as a design pattern. However, if you need to reference that pointer more than once or twice -- for example, if you're referencing it inside a loop -- it might make sense to keep a local copy of the pointer. To answer your question, though: no, we generally do not change threads in the middle of a function. The only exception, of course, is the obvious one: at the beginning of a server command when we first bind a worker thread to a session. Once it's bound, it remains bound until the server command has completed and the thread is released back into the pool. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492273Mon, 07 Oct 2024 16:15:59 +05002099492273@Uncensored

I only got into the backend code because I wanted to see the timing of the IMAP and SMTP code without the database accesses.  I am impressed by the current code, because the thread routines are really very good.  I go back to the days of when even function calls were not great for performance and when I saw the number of times that the function was called and it was in the top timing, I took a look at it.  I tried to change the code to check the thread id and only get the thread data when it changed, but that took longer than the existing code.  The only improvement I could make was to only get the data once a function which assumes the thread does not change during the processing of the function.

I did it by adding a macro call at the beginning of each function that used TSD which adds a local variable and then changed the TSD macro to have all the calls use it, so minimal code change.  I can flip back and forth with the original code by just changing the macro definitions so it was easy to try some different implementations.

For changing code to support things, I tend to use macros like Citadel has for CC and TSD.  CC crosses threads enough that if it is a little less efficient to keep it thread safe, it makes up for it in not making cross thread mistakes in all the supporting code which is more important.  I also like to use macros for implementing code outside of the repository, like my profiler, memory checker and IP blocker to stop DOS and brute force password attempts. It helps when I merge with the repository to minimize the complexity of the merge so I can upgrade without reimplementing.  Macros can be very powerful in testing and not affect production code.

If anyone is looking at memory in the future, it may be good to go back and free up the memory at shutdown for testing, but compile it out on production.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492245Mon, 07 Oct 2024 13:21:52 +05002099492245@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492243Mon, 07 Oct 2024 13:11:52 +05002099492243@Uncensored Date: Mon Oct 7 13:10:39 2024 -0400 CtdlDoIHavePermissionToReadMessagesInThisRoom() This function now accepts a "struct CitContext *" as an argument. This is an example of how to reduce our reliance on thread-local global variables, one function at a time. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/expire/serv_expire.c | 1 + citadel/server/modules/wiki/serv_wiki.c | 4 ++-- citadel/server/msgbase.c | 2 +- citadel/server/room_ops.c | 6 +++--- citadel/server/room_ops.h | 2 +- 5 files changed, 8 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492203Mon, 07 Oct 2024 11:05:03 +05002099492203@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492153Sun, 06 Oct 2024 19:33:31 +05002099492153@Uncensored

Good to know about performance and memory.

While I was checking performance of the IMAP and SMTP, I noticed that the backend database code calls bdb_get_tsd() for every TSD reference and gets the thread specific structure each time.  Does the Berkley database ever switch threads when calling the Berkley API?  I played with it and did not see it switch threads in any of my testing.  If we assume that it does not switch threads, and only call bdb_get_tsd() once a function call, I showed about an 8% improvement in performance in receiving test emails.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492147Sun, 06 Oct 2024 19:08:58 +05002099492147@Uncensored Date: Sun Oct 6 19:08:56 2024 -0400 Change labels based on is_date ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492143Sun, 06 Oct 2024 19:02:01 +05002099492143@Uncensored Date: Sun Oct 6 19:00:56 2024 -0400 Temporary button to dump vCalendar to console ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 39 +++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099492020Sat, 05 Oct 2024 10:46:56 +05002099492020@Uncensored

Hmm, I don't remember what I might have been saying about performance.  About 15 years ago I had the chance to sit with real users at a place where Citadel was getting adopted in a big way, and the biggest complaint they had regarding IMAP was that any operation requiring the manipulation of a sequence set was taking way too long.  There was a lot of unpacking things onto the whiteboard and figuring out the Big O Notation of those operations.  What's in there now is the result of figuring out which parts of the code took the most time and running them as few times as possible.

Memory management and leak avoidance is largely credited to a developer who spent a good deal of time running everything inside of Valgrind.  At the time, he was able to get Citadel Server to exit with just about zero outstanding mallocs.  At the time we did free everything during exit, but the side effect was that the server took too long to shut down and often the operating system (or the user) would kill it before we were done.  So now we still do occasional memory profiling, but when it's time to exit we close the databases immediately and then just let the OS do the rest.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491965Fri, 04 Oct 2024 23:16:06 +05002099491965@Uncensored Date: Fri Oct 4 23:16:04 2024 -0400 Renamed top_level_component to vcalendar_being_edited. This was done to avoid any possible conflict with variables in other webcit modules. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 39 +++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491961Fri, 04 Oct 2024 22:29:36 +05002099491961@Uncensored Date: Fri Oct 4 22:29:34 2024 -0400 Location and Description fields are now live. In other words their values are committed to the calendar object when their values are modified, and therefore written back to the server when the event is saved. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491926Fri, 04 Oct 2024 19:47:56 +05002099491926@Uncensored Date: Fri Oct 4 19:45:11 2024 -0400 "YES! I AM INVINCIBLE!!" --Boris Grishenko Actually no, but that's how I feel right now after taking a long time to get this just the way I wanted it. When the user edits the "Summary" field of a calendar event on the screen, it immediately saves the modified field right back to the icalendar component in memory. Now when the user selects "Save" it is ready to be sent back to the server in its current form. This is only the first field of many, but the design pattern is now established. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491921Fri, 04 Oct 2024 18:51:27 +05002099491921@Uncensored Date: Fri Oct 4 18:50:50 2024 -0400 Better handling of socket timeouts during TLS ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/tls.c | 40 ++++++++++++++++++++++---------------- webcit-ng/server/webcit.h | 5 +++-- webcit-ng/server/webserver.c | 46 +++++++++++++++++++++++--------------------- 3 files changed, 50 insertions(+), 41 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491908Fri, 04 Oct 2024 16:53:44 +05002099491908@Uncensored

It wasn't dumb :-)  I just thought Out of the Box/Struct.  It just wasn't scalable, so I had to come up with something to add all the new ones.

On the email address ideas, I looked at changing the email address buffering to their own defines, but it really was messy.  Probably just better to see if we want to change the limitation and reimplement it then.  If it ain't broke, don't mess with it.

You had mentioned something about performance a while back.  What specifically were you trying to improve?  I have my own home grown profiling and memory checking modules that I have implemented on Citadel in my personal branch.

I found the GNU profiler useless because it is sample based and does not include I/O.  Mine requires adding a macro to the beginning of each function and a macro for each return, for the functions I want to report on, but it gives me accurate info with a little overhead in testing and compiles out for production.  If you have an area you are interested in, I can take a look.

My memory checker does not require an source changes, just including a header and module in the library.  It macros the malloc(), etc into my library and then I can do anything I want.  Currently I track all the allocations and frees and report whatever it left over at shutdown.  It only is good in testing since it does add a good amount of overhead checking.  I have not found any leaks, overruns or underruns in the code yet :-) 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491832Fri, 04 Oct 2024 10:22:01 +05002099491832@UncensoredHardcode Visit legacy record sizes so will not change if defines change Oh my ... if we ever changed SIZ to something other than 4096 there would probably be so many side effects it would collapse the entire space-time continuum. :) But yes, putting not one but two of those in a database record was a pretty dumb move on my part. If you look closely you'll even find the part where I tried to make up for it by zeroing out the unused parts of the buffers and then compressing the records before writing them. Your solution was better :) ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491726Thu, 03 Oct 2024 16:07:55 +05002099491726@Uncensored Date: Thu Oct 3 16:07:31 2024 -0400 Fix possible memory overrun when processing recp lists ----------------------------------------------------------------------- Summary of changes: citadel/server/internet_addressing.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491677Thu, 03 Oct 2024 12:08:36 +05002099491677@Uncensored Date: Thu Oct 3 12:07:42 2024 -0400 Hardcode Visit legacy record sizes so will not change if defines change ----------------------------------------------------------------------- Summary of changes: citadel/server/visit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491311Mon, 30 Sep 2024 22:02:57 +05002099491311@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491249Mon, 30 Sep 2024 11:07:56 +05002099491249@Uncensored Date: Mon Sep 30 11:07:47 2024 -0400 remove temp file during build ----------------------------------------------------------------------- Summary of changes: citadel/configure | 1 + citadel/server/modules/smtp/serv_smtp.c | 41 +++++++++++++++++---------------- 2 files changed, 22 insertions(+), 20 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491103Sat, 28 Sep 2024 18:10:31 +05002099491103@Uncensored

Was not able to reproduce the coredump, but the only thing that it could have been was a bad memory copy.  The BODY partial parsing and computation did not error check the syntax or if the start of the partial was past the end of the string the math was bad for unsigned variables.  Bad syntax would probably do some very unpredictable things and if the start was past the end, the unsigned logic would make the length huge.  Fixed both.

I am going to work on some tests to try to automate my testing so I can test some of the bigger changes.  I will also check out some of the clients you mentioned.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491085Sat, 28 Sep 2024 16:09:09 +05002099491085@Uncensored Date: Sat Sep 28 16:08:52 2024 -0400 Fix possible memory overrun for bad partial in BODY[] ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/imap/imap_fetch.c | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099491043Sat, 28 Sep 2024 10:48:24 +05002099491043@Uncensored

Back when the IMAP server was in initial development it was tested with a lot of different clients ------- Pine, Mutt, Outlook, Eudora, Evolution, all of the "oh, I remember that!" ones you don't think about anymore.  Nowadays I just test with Thunderbird and whatever is on my phone.  Eventually the IMAP scene reached a maturity level where no one is really making significant changes to the baseline protocol behavior anymore, so the days of waking up to a new batch of weird protocol mismatches to work around are thankfully behind us.

That having been said, if you found an issue then by all means let's get it fixed.  If you get stuck post a stack trace and we'll work it out.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099490524Tue, 24 Sep 2024 23:07:14 +05002099490524@Uncensored

Interesting history.  I kind of wondered because most people do not follow the old standard when writing C and use some of the C++ features.  I like the old.

I think I will go ahead and set a define for the max email address size, and update the code to use that as the limit, but not actually increase the current limits.  Later we can increase it and test with different mail clients.  I know that when I tested against Outlook with a ridiculously sized email address, it had problems displaying it, but did not harm anything.  What clients do you test against?

I will do this after I fix a bug in the IMAP code.  I update my server to the latest and everything looked great and within a day it core dumped.  Turns out it had nothing to do with any of the recent changes.  It was very old code processing the BODY statement partial specification.  I was not able to reproduce it, but looking at the code, if someone passed some bad start/length, it does some bad math with unsigned integers which is probably what caused it to try to copy a bunch of characters from an empty string and dumped.

I am looking forward to the new WebCit.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099490332Mon, 23 Sep 2024 12:19:24 +05002099490332@Uncensored Date: Mon Sep 23 09:14:32 2024 -0700 Remove calls to pthread_setstacksize() everywhere. All operating systems on which we currently build have a larger default thread stack size now. We aren't actually "increasing" it anymore. ----------------------------------------------------------------------- Summary of changes: citadel/server/sysconfig.h | 5 +---- citadel/server/threads.c | 3 +-- citadel/utils/loadtest.c | 3 +-- webcit-ng/server/webserver.c | 3 +-- webcit/sysdep.c | 9 --------- 5 files changed, 4 insertions(+), 19 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099490277Sun, 22 Sep 2024 23:40:50 +05002099490277@Uncensored Date: Sun Sep 22 20:40:48 2024 -0700 more of that ugly client code ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099490276Sun, 22 Sep 2024 23:33:23 +05002099490276@Uncensored Date: Sun Sep 22 20:33:21 2024 -0700 citadel.c: gotofloorstep() no longer uses a goto command ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 70 +++++++++++++++++++++++++++------------------------- 1 file changed, 37 insertions(+), 33 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099490262Sun, 22 Sep 2024 23:07:27 +05002099490262@Uncensored Date: Sun Sep 22 23:06:12 2024 -0400 Clean up compiler warnings. Small code and buffer changes. Depricated readdir_r only warnings. ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/tools.c | 2 +- libcitadel/lib/xdgmime/xdgmime.c | 3 ++- webcit/availability.c | 4 ++-- webcit/calendar_tools.c | 3 +++ webcit/context_loop.c | 3 ++- webcit/event.c | 4 ++-- webcit/messages.c | 6 +++--- webcit/sieve.c | 4 ++-- webcit/sockets.c | 3 ++- webcit/sysdep.c | 4 ++-- webcit/vcard_edit.c | 9 ++------- webcit/webcit.c | 6 +++--- 12 files changed, 26 insertions(+), 25 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099490255Sun, 22 Sep 2024 22:58:32 +05002099490255@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099490231Sun, 22 Sep 2024 21:07:00 +05002099490231@Uncensored

I wanted to bounce a couple of things off of you to see if there are any down sides my implementing any of these.

Systemd Changes

===========

Recommend changing citadel service configuration "After" to use "network-online.target" instead of "network.target".  "network.target" does not wait for the network to actually be operational and I have run into race conditions on startup.

Recommend changing webcit service configuration "After" to use "citadel.service" instead of "citadel.target".

 

Limits on Email Addresses

================

The code is not consistent on what size the email addresses can be in message.  Early on, I ran into Citadel core dumping on iCloud addresses.  It doe not seem to create such long ones now, but a year or two ago, they would create addresses even longer than 256 characters (the standard recommendation).  The standard also says that allowing longer ones is up to the server, but may be a goo idea.

I had changed the code to accept very long addresses, and check more, but not to truncate/reject addresses or recipient lists.  There was a comment in the code when truncating the recipient list to about 1000 characters that it was so that the library function would not choke on it.  When I increased the buffer sizes, and allowed very long addresses, I did not seem to have any issues.  Is there an issue with the libraries anymore?  I found that Outlook does have some display issues with very long addresses, but my thought is if the user has long addresses in email, it is up to the client to handle them, not the server.

Recommendations:

---------------------

Create a new define specifically for the max length of an email address and recipient list.  Even if we decide to limit an address to 256 and recipient list to 1K, the code should use a define to check and limit.

Either remove the limits or make the defined limits very large.  The buffers dealing with the addresses and list are mostly just local variables, so only stack memory is used so no real memory overhead like malloc(), so just setting a large limit and ensuring all the code validates it should be enough. 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099490224Sun, 22 Sep 2024 20:38:44 +05002099490224@Uncensored

Your changes are fine.  I had the hardest time originally when I was trying to develop the flagging stuff with all the changes going on.  The changes required a lot of updates to make performance optimal and constantly integrating the changes was very time consuming as to not break the code.  Git merge is doing a good job now of integrating the changes.

As for returning structures, I too was programming back in the late 70's, but did not really start heavily into C until the mid-80's, so a lot of the limitations were changed.  I still like C because it is efficient and flexible.  It is very powerful for good programmers and makes bad programmers worse :-)  I rarely return structures because it requires copying all the data on return, but in this case, it was cleaner than all the pointer parameters and easier to expand later.  I normally just have the caller pass a pointer to a structure, but the structure was so small, I had fun.  I had noticed that a lot of the calls just wanted to switch rooms and did not use the metrics, so I just went and changed all the calls.

When you want to support IMAP4rev2, let me know.  It is going to require some work to integrate and test.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099490134Sat, 21 Sep 2024 23:04:10 +05002099490134@Uncensored Date: Sat Sep 21 23:02:33 2024 -0400 imap_roomname() now returns a "struct irret" This is me seeing an internal utility function that returned a bunch of things in a complicated way and thinking, "Now that I know C can return a struct, I can make this cleaner!" A day later I'm done, and no one will ever know. Unless it has new bugs. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/imap/imap_tools.c | 159 +++++++++++++++---------------- citadel/server/modules/imap/imap_tools.h | 10 +- citadel/server/modules/imap/serv_imap.c | 132 ++++++++++--------------- citadel/server/modules/imap/serv_imap.h | 4 - citadel/server/modules/pop3/serv_pop3.c | 48 ++++------ 5 files changed, 155 insertions(+), 198 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489869Thu, 19 Sep 2024 23:02:50 +05002099489869@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489868Thu, 19 Sep 2024 22:49:42 +05002099489868@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489859Thu, 19 Sep 2024 22:47:21 +05002099489859@Uncensored Date: Thu Sep 19 22:46:51 2024 -0400 visit.c: updated to the style guide Sorry, I can't help myself :( ----------------------------------------------------------------------- Summary of changes: citadel/server/visit.c | 140 ++++++++++++++++++++++--------------------------- 1 file changed, 62 insertions(+), 78 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489858Thu, 19 Sep 2024 22:40:01 +05002099489858@Uncensorednter message begins a new thread. changed some variable names Release version 1003 generated by do-release.sh Harlow Solutions (2): Re-implemented all Visit support functions to add support for more flags and optimize database record size Fix Visit IMAP not to return error on empty flags specification ----------------------------------------------------------------------- -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489857Thu, 19 Sep 2024 22:40:00 +05002099489857@Uncensored Date: Thu Sep 19 22:40:00 2024 -0400 Release version 1003 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489856Thu, 19 Sep 2024 22:39:53 +05002099489856@Uncensored Date: Thu Sep 19 22:39:50 2024 -0400 changed some variable names ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/imap/serv_imap.h | 8 ++------ citadel/server/modules/wiki/serv_wiki.c | 6 +++--- citadel/server/msgbase.c | 11 ++++++----- 3 files changed, 11 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489677Wed, 18 Sep 2024 19:59:40 +05002099489677@Uncensored Date: Wed Sep 18 19:58:09 2024 -0400 textclient: nter message begins a new thread. It already began a new thread, but now it tells the user that they are beginning a new thread and prompts for a subject. eply does not; it simply copies the subject from the parent message. ----------------------------------------------------------------------- Summary of changes: textclient/citadel_ipc.c | 23 ++++++++++------------- textclient/client_chat.c | 4 ++-- textclient/messages.c | 39 +++++++++++++++++---------------------- textclient/textclient.h | 7 +++---- 4 files changed, 32 insertions(+), 41 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489644Wed, 18 Sep 2024 12:36:43 +05002099489644@UncensoredFix Visit IMAP not to return error on empty flags specification Oops, I didn't realize you were still in there tuning it up. I hope my style cleanup patches aren't interfering with your development. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489633Wed, 18 Sep 2024 11:46:35 +05002099489633@Uncensored Date: Wed Sep 18 11:46:17 2024 -0400 Oops, I looked at IMAP, now style cleanup ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/imap/imap_tools.c | 349 +++++++++++-------------------- citadel/server/modules/imap/serv_imap.c | 270 +++++++++--------------- 2 files changed, 213 insertions(+), 406 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489503Tue, 17 Sep 2024 16:21:51 +05002099489503@Uncensored Date: Tue Sep 17 16:21:15 2024 -0400 Fix Visit IMAP not to return error on empty flags specification ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/imap/imap_misc.c | 36 ++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 16 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489496Tue, 17 Sep 2024 15:14:57 +05002099489496@Uncensored Date: Tue Sep 17 15:14:55 2024 -0400 Suppress automatic conversion of events to QP ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 1 + 1 file changed, 1 insertion(+) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489467Tue, 17 Sep 2024 13:11:56 +05002099489467@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489464Tue, 17 Sep 2024 12:57:55 +05002099489464@Uncensored Date: Tue Sep 17 12:54:19 2024 -0400 "Save" button in calendar editor now does DAV PUT. This is probably the final form of the "Save" operation, since it takes the top-level iCalendar component stored in the browser's memory and writes it back to the server calendar, and then returns the user back to the calendar view, just like "Cancel" does without saving. The remaining work on the editor now needs to focus on *modifying* that component in memory whenever the user makes a change to the fields on the screen. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 50 +++++++++++++++++++++++++++++------- 1 file changed, 41 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489329Mon, 16 Sep 2024 14:51:31 +05002099489329@Uncensored Date: Mon Sep 16 14:51:29 2024 -0400 Scolding my 1987 self for writing such ugly code. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 111 ++++++++++++++++++++++------------------------- textclient/citadel_ipc.c | 5 ++- 2 files changed, 56 insertions(+), 60 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489144Sat, 14 Sep 2024 23:17:45 +05002099489144@Uncensored Date: Sat Sep 14 23:17:18 2024 -0400 Made some code in the text client more readable. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/ctdlproto/serv_messages.c | 2 +- textclient/citadel.c | 223 +++++++++++------------ textclient/citadel.rc | 8 +- textclient/citadel_ipc.c | 12 +- textclient/messages.c | 50 ++--- textclient/routines.c | 52 +++--- textclient/routines2.c | 119 ++++++------ 7 files changed, 234 insertions(+), 232 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099489050Fri, 13 Sep 2024 22:32:48 +05002099489050@Uncensored

Thanks for catching that.  You were right that I was thinking IMAP new messages when I was updating the goto code.  I forgot the original code was based on Seen.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488820Thu, 12 Sep 2024 18:21:19 +05002099488820@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488819Thu, 12 Sep 2024 18:19:10 +05002099488819@Uncensored Date: Thu Sep 12 18:18:55 2024 -0400 Restored the "new messages" count in GOTO command. ----------------------------------------------------------------------- Summary of changes: citadel/server/room_ops.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488814Thu, 12 Sep 2024 18:11:39 +05002099488814@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488805Thu, 12 Sep 2024 18:00:01 +05002099488805@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488796Thu, 12 Sep 2024 17:53:25 +05002099488796@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488782Thu, 12 Sep 2024 15:40:15 +05002099488782@Uncensored

It worked.  Excellent.  The code is committed.  If you find any issues, let me know.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488735Thu, 12 Sep 2024 12:02:11 +05002099488735@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488730Thu, 12 Sep 2024 11:32:13 +05002099488730@Uncensored

That worked a lot better :-)  I should have though of that.  I was so www based, I was trying everything relative to that.  ssh is actual filesystem path.   Duh.

Now the the next hiccup.  Tried to push and get errors that I cannot write to ./objects

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488723Thu, 12 Sep 2024 10:44:24 +05002099488723@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488670Wed, 11 Sep 2024 23:35:57 +05002099488670@Uncensored

When pushing, I keep getting 403 errors from the URL https://code.citadel.org/citadel.git  I have tried adding the user and password to the URL but get the same thing.

I also tried to switch to ssh, but I cannot seem to get the repository path right in the URL and it always returns an error. :citadel.git or :/citadel.git or :citadel/citadel.git or anything else I have tried always returns "does not appear to be a git repository".

 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488565Wed, 11 Sep 2024 10:31:14 +05002099488565@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488480Tue, 10 Sep 2024 20:51:49 +05002099488480@Uncensored

I am ready to push my commit to the repository.  Problem is I cannot figure out the right origin to use or I am just messing up the command (I really do not use git much :-P )  What arguments do I use for git push to push my cloned master to the repository?

Mon Sep 09 2024 14:01:59 EDT from IGnatius T Foobar Subject: Re: Back after a long time. Want to add the support for IMAP flags

Ok, your login should be ready to go. I am out of town this week (in fact, I'm writing this from an airport) so there is little chance of me writing conflicting changes. Actually I might get bored and start coding ... but I'll stick to webcit-ng :)

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488275Mon, 09 Sep 2024 14:01:59 +05002099488275@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488240Mon, 09 Sep 2024 11:32:34 +05002099488240@Uncensored

The only thing I need to do is remove the support for the old version in ctdlload.  I still have to check the field count (v1001 has fixed 9 fields which newer versions will never have) so it will just return failure rather than converting a couple of the fields.

I actually did my implementation against v1001 so I had a stable version to test against.  I pulled master a few days ago and ported the code there and that is what I am testing.  I updated master last night so my code has all of your cleanup.  I will send you my login info so I can check the code in.

 

Sun Sep 08 2024 18:40:01 EDT from IGnatius T Foobar Subject: Re: Back after a long time. Want to add the support for IMAP flags

I implemented everything on the v1001 tag.  I have pulled the latest in

git and am creating a local branch with my updates.  Should I commit
the code to master after I finish testing?

I have this annoying habit of going through code and doing syntax and style cleanup when I am attending boring meetings at work but can't commit to focusing on real development. The result is that if you have a patch it might not apply cleanly because it might be against code where I changed "return(1);" to "return 1;" or something silly like that.

I'll stop doing that now that I know you have stuff coming in. Please sync up with git master and then if everything is working then yes, it would be easiest if you could just commit to the main line. Please PM me with your desired username and password because we're not using GitLab-CE anymore -- it was just consuming too many resources so I switched back to regular `git` with the `cgit` web front end. So when we create your account it'll just be an ordinary account on the server with permission to write to the repository.

It sounds like we're in agreement on what it has to do:
* The server must be able to read records in old o

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488187Sun, 08 Sep 2024 18:40:01 +05002099488187@UncensoredI implemented everything on the v1001 tag.  I have pulled the latest in >git and am creating a local branch with my updates.  Should I commit >the code to master after I finish testing? I have this annoying habit of going through code and doing syntax and style cleanup when I am attending boring meetings at work but can't commit to focusing on real development. The result is that if you have a patch it might not apply cleanly because it might be against code where I changed "return(1);" to "return 1;" or something silly like that. I'll stop doing that now that I know you have stuff coming in. Please sync up with git master and then if everything is working then yes, it would be easiest if you could just commit to the main line. Please PM me with your desired username and password because we're not using GitLab-CE anymore -- it was just consuming too many resources so I switched back to regular `git` with the `cgit` web front end. So when we create your account it'll just be an ordinary account on the server with permission to write to the repository. It sounds like we're in agreement on what it has to do: * The server must be able to read records in old or new format * The server will always write in the new format * ctdldump must be able to read in old or new format, but always dumps in new format * ctdlload understands the new format only I like what you're doing. The purpose of the 'visit' record is to identify the relationship between a user and a room, and with these extensions it will more clearly identify the relationship between a user and messages within the room. As the Citadel System evolves, the concept of a "room" will begin to fade for users on the web UI, but it will still be the primary internal representation. So the more flexibility we have, the more useful it will be. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488121Sat, 07 Sep 2024 23:15:40 +05002099488121@Uncensored

When I reimplemented, I did 1 and 2.  I also changed ctdldump and ctdlload and they seem to work well.  ctdldump writes the new format for all records.  I was not sure about supporting old versions, so I did.  I made ctdlload support the old and new formats. The new format always has more fields than the previous format (fixed) because of the added flags, so it was easy to support.

I did a few things to improve View performance overall and as the records are saved in the new format, we should see some reduction in the database size.

I implemented everything on the v1001 tag.  I have pulled the latest in git and am creating a local branch with my updates.  Should I commit the code to master after I finish testing?

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488118Sat, 07 Sep 2024 22:23:15 +05002099488118@Uncensored Date: Sat Sep 7 22:23:11 2024 -0400 Continue removing parentheses from return statements unless the returned value is an expression ----------------------------------------------------------------------- Summary of changes: citadel/server/clientsocket.c | 4 ++-- citadel/server/config.c | 2 +- citadel/server/control.c | 6 +++--- citadel/server/domain.c | 10 +++++----- citadel/server/euidindex.c | 6 +++--- citadel/server/internet_addressing.c | 38 +++++++++++++++++++----------------- citadel/server/ldap.c | 23 ++++++++++------------ citadel/server/msgbase.c | 36 +++++++++++++++++++--------------- citadel/server/room_ops.c | 18 ++++++++--------- citadel/server/sysdep.c | 6 +++--- citadel/server/user_ops.c | 32 ++++++++++++++++++------------ citadel/server/usetable.c | 4 ++-- 12 files changed, 98 insertions(+), 87 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488115Sat, 07 Sep 2024 22:15:20 +05002099488115@Uncensored Date: Sat Sep 7 22:15:18 2024 -0400 citmail.c still exists? Oh well, someone somewhere might be using it. ----------------------------------------------------------------------- Summary of changes: citadel/utils/citmail.c | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488109Sat, 07 Sep 2024 19:18:14 +05002099488109@Uncensored Date: Sat Sep 7 16:18:12 2024 -0700 Fleshed out the terminal detect a bit more ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 2 +- textclient/commands.c | 18 +++++++++++------- 2 files changed, 12 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488100Sat, 07 Sep 2024 18:42:46 +05002099488100@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488099Sat, 07 Sep 2024 18:42:45 +05002099488099@Uncensored Date: Sat Sep 7 18:42:45 2024 -0400 Release version 1002 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488098Sat, 07 Sep 2024 18:41:47 +05002099488098@Uncensored Date: Sat Sep 7 18:41:43 2024 -0400 Reworked detect_terminal_capabilities() ...which was formerly look_for_ansi(). Generalized the interface and also changed it from select() to poll(). I believe I've eliminated the possibility of it getting stuck in an active loop, which seems to be happening a lot lately on my system. Undoubtedly some lowlife from across the pond is spamming port 23 and making that happen. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 85 +++++++++++++++++++----------------- textclient/citadel.rc | 8 ++-- textclient/citadel_ipc.c | 4 +- textclient/commands.c | 111 +++++++++++++++++++---------------------------- textclient/routines.c | 4 -- textclient/screen.c | 4 +- textclient/textclient.h | 4 +- 7 files changed, 99 insertions(+), 121 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488091Sat, 07 Sep 2024 16:35:42 +05002099488091@Uncensored Date: Sat Sep 7 16:35:40 2024 -0400 commands.c: remove unused function was_a_key_pressed() ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 28 ---------------------------- 1 file changed, 28 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488082Sat, 07 Sep 2024 16:04:11 +05002099488082@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099488020Fri, 06 Sep 2024 23:53:34 +05002099488020@Uncensored

I was swallowed up by life for a long time.  I am back now and want to help develop in Citadel.

Last time, I created a version to support the addition of the Flagged, Draft, Recent and Deleted flags and also reworked the Visit support to allow any size message sets while reducing the record size dramatically.  Problem was when you tested it, converting all the Visit records during upgrade took forever.  I have rewritten it to convert the records on the fly to the new version and have designed the structure to be expanded and changed much more easily.

I removed the support for Recent.  Did a lot of research on it before and it was not implemented properly and nobody really uses it.  It is not a flag at the message level, but at the room level.  Has to be maintained in it's own database record.  Since IMAP4rev2 has deprecated the flag, and it is a lot of work to maintain, it is not worth the effort.  IMAP4rev2 says you can output RECENT to stay compatible to IMAP4rrev1, just assume zero recent, so that is what I implemented.

I can create a patch and submit for review/testing if that is the best way to do this.  I don't have large databases to test against or test suites to cover everything.

Let me know how you want me to submit it.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099487994Fri, 06 Sep 2024 15:08:25 +05002099487994@Uncensored Date: Fri Sep 6 15:08:15 2024 -0400 calendar.md: added commit 90c448db2e533a4fa8c97c1fddc050829c8d0f9a Author: Art Cancro Date: Fri Sep 6 15:08:10 2024 -0400 calendar.md: added ----------------------------------------------------------------------- Summary of changes: citadel/docs/calendar.md | 81 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 81 insertions(+) create mode 100644 citadel/docs/calendar.md -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099487983Fri, 06 Sep 2024 13:22:58 +05002099487983@Uncensored Date: Fri Sep 6 13:22:55 2024 -0400 Confirmed that Bill Gates really DID say "640K ought to be enough for anyone". He cannot deny it. He does, but he is a liar. ----------------------------------------------------------------------- Summary of changes: webcit/calendar.c | 45 +++++++++++++++++---------------------------- webcit/calendar_view.c | 5 +---- webcit/context_loop.c | 8 +------- webcit/cookie_conversion.c | 9 +-------- webcit/dav_delete.c | 8 +------- webcit/dav_get.c | 10 +--------- webcit/dav_main.c | 10 +--------- webcit/dav_options.c | 10 +--------- webcit/dav_propfind.c | 8 +------- webcit/dav_put.c | 10 +--------- webcit/dav_report.c | 10 +--------- webcit/downloads.c | 9 +-------- webcit/event.c | 10 +--------- webcit/feed_generator.c | 12 ++---------- webcit/fmt_date.c | 9 +-------- webcit/gettext.c | 9 +-------- webcit/graphics.c | 10 +--------- 17 files changed, 34 insertions(+), 158 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099487597Tue, 03 Sep 2024 16:54:59 +05002099487597@Uncensored Date: Tue Sep 3 16:54:51 2024 -0400 hidden fields ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099487144Fri, 30 Aug 2024 15:20:39 +05002099487144@Uncensored Date: Fri Aug 30 15:20:37 2024 -0400 date vs datetime for all day events ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099486992Thu, 29 Aug 2024 17:54:11 +05002099486992@Uncensored Date: Thu Aug 29 17:53:44 2024 -0400 Number of days to display is now a select box ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/request.c | 4 ++-- webcit-ng/static/index.html | 2 +- webcit-ng/static/js/view_calendar.js | 20 ++++++++++++++------ webcit-ng/static/js/view_forum.js | 9 ++++++--- 4 files changed, 23 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099486788Wed, 28 Aug 2024 12:18:54 +05002099486788@Uncensored Date: Wed Aug 28 12:18:50 2024 -0400 Change all Font Awesome 'fa' to 'fas' ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 14 ++++++------- webcit-ng/static/js/calendar_edit.js | 12 ++++++------ webcit-ng/static/js/login.js | 2 +- webcit-ng/static/js/main.js | 8 ++++---- webcit-ng/static/js/upload.js | 2 +- webcit-ng/static/js/user_profile.js | 2 +- webcit-ng/static/js/view_forum.js | 38 ++++++++++++++++++------------------ webcit-ng/static/js/view_mail.js | 22 ++++++++++----------- 8 files changed, 50 insertions(+), 50 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099486781Wed, 28 Aug 2024 12:09:15 +05002099486781@Uncensored Date: Wed Aug 28 12:09:11 2024 -0400 Indicate when a message is null ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 24 ++---------------------- webcit-ng/static/index.html | 4 ++-- webcit-ng/static/js/calendar_edit.js | 32 +++++++++++++++++++++++++++----- webcit-ng/static/js/view_forum.js | 9 +++++++-- 4 files changed, 38 insertions(+), 31 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099486056Thu, 22 Aug 2024 15:20:47 +05002099486056@Uncensored Date: Thu Aug 22 15:20:20 2024 -0400 More removal of parentheses from return statements ----------------------------------------------------------------------- Summary of changes: citadel/server/clientsocket.c | 12 ++--- citadel/server/config.c | 4 +- citadel/server/control.c | 6 +-- citadel/server/domain.c | 8 +-- citadel/server/euidindex.c | 20 +++---- citadel/server/internet_addressing.c | 52 +++++++++--------- citadel/server/ldap.c | 30 +++++------ citadel/server/locate_host.c | 18 +++---- citadel/server/modules/blog/serv_blog.c | 4 +- .../server/modules/calendar/ical_ctdl_is_overlap.c | 16 +++--- citadel/server/modules/calendar/serv_calendar.c | 20 +++---- citadel/server/modules/clamav/serv_virus.c | 6 +-- citadel/server/modules/crypto/serv_crypto.c | 6 +-- citadel/server/modules/fulltext/ft_wordbreaker.c | 12 ++--- citadel/server/modules/fulltext/serv_fulltext.c | 8 +-- citadel/server/modules/imap/imap_misc.c | 8 +-- citadel/server/modules/imap/imap_search.c | 2 +- citadel/server/modules/imap/imap_tools.c | 22 ++++---- citadel/server/modules/imap/serv_imap.c | 6 +-- .../server/modules/inboxrules/serv_inboxrules.c | 20 +++---- citadel/server/modules/inetcfg/serv_inetcfg.c | 8 +-- citadel/server/modules/nntp/serv_nntp.c | 6 +-- citadel/server/modules/notes/serv_notes.c | 8 +-- citadel/server/modules/pop3/serv_pop3.c | 2 +- citadel/server/modules/smtp/dkim.c | 6 +-- citadel/server/modules/smtp/serv_smtpclient.c | 2 +- citadel/server/modules/spam/serv_spam.c | 6 +-- citadel/server/modules/vcard/serv_vcard.c | 34 ++++++------ citadel/server/modules/wiki/serv_wiki.c | 18 +++---- citadel/server/modules/xmpp/serv_xmpp.c | 2 +- citadel/server/modules/xmpp/xmpp_presence.c | 6 +-- citadel/server/modules/xmpp/xmpp_sasl_service.c | 4 +- citadel/server/msgbase.c | 12 ++--- citadel/server/room_ops.c | 44 +++++++-------- citadel/server/serv_extensions.c | 6 +-- citadel/server/sysdep.c | 38 ++++++------- citadel/server/user_ops.c | 62 +++++++++++----------- citadel/tests/dkimtester/dkimtester.c | 2 +- citadel/utils/auth.c | 8 +-- citadel/utils/chkpw.c | 6 +-- citadel/utils/chkpwd.c | 4 +- citadel/utils/citmail.c | 2 +- citadel/utils/ctdlload.c | 42 +++++++-------- citadel/utils/loadtest.c | 8 +-- citadel/utils/sendcommand.c | 6 +-- citadel/utils/setup.c | 4 +- 46 files changed, 313 insertions(+), 313 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099486007Thu, 22 Aug 2024 12:01:30 +05002099486007@Uncensored Date: Thu Aug 22 12:00:59 2024 -0400 Removing parentheses on return statements. C hasn't required these in quite some time now. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 20 ++++++------ textclient/citadel_ipc.c | 12 ++++---- textclient/client_chat.c | 22 ++++++-------- textclient/client_passwords.c | 2 -- textclient/commands.c | 38 +++++++++++------------ textclient/messages.c | 54 ++++++++++++++++----------------- webcit-ng/server/caldav_reports.c | 12 ++++---- webcit-ng/server/ctdlclient.c | 26 ++++++++-------- webcit-ng/server/http.c | 6 ++-- webcit-ng/server/ical_ctdl_is_overlap.c | 16 +++++----- webcit-ng/server/main.c | 2 +- webcit-ng/server/messages.c | 2 +- webcit-ng/server/room_functions.c | 8 ++--- webcit-ng/server/tcp_sockets.c | 20 ++++++------ webcit-ng/server/tls.c | 6 ++-- webcit-ng/server/webserver.c | 4 +-- 16 files changed, 122 insertions(+), 128 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485802Wed, 21 Aug 2024 13:12:55 +05002099485802@Uncensored Date: Wed Aug 21 13:12:48 2024 -0400 Making the license declarations identical everywhere. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/admin_functions.c | 6 +-- webcit-ng/server/caldav_reports.c | 2 +- webcit-ng/server/ctdl_commands.c | 3 +- webcit-ng/server/ctdlclient.c | 4 +- webcit-ng/server/ctdlfunctions.c | 4 +- webcit-ng/server/floor_functions.c | 4 +- webcit-ng/server/forum_view.c | 3 +- webcit-ng/server/html2html.c | 3 +- webcit-ng/server/http.c | 4 +- webcit-ng/server/ical_ctdl_is_overlap.c | 76 ++++++++++++++++++++++++++++++++- webcit-ng/server/main.c | 6 +-- webcit-ng/server/messages.c | 4 +- webcit-ng/server/request.c | 3 +- webcit-ng/server/room_functions.c | 4 +- webcit-ng/server/static.c | 4 +- webcit-ng/server/tcp_sockets.c | 4 +- webcit-ng/server/text2html.c | 4 +- webcit-ng/server/tls.c | 2 +- webcit-ng/server/upload.c | 4 +- webcit-ng/server/user_functions.c | 4 +- webcit-ng/server/util.c | 2 +- webcit-ng/server/webcit.h | 5 +-- webcit-ng/server/webserver.c | 10 ++--- webcit-ng/static/js/util.js | 38 ----------------- webcit-ng/static/js/view_mail.js | 4 +- webcit-ng/static/js/views.js | 3 +- 26 files changed, 105 insertions(+), 105 deletions(-) mode change 120000 => 100644 webcit-ng/server/ical_ctdl_is_overlap.c -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485788Wed, 21 Aug 2024 11:28:42 +05002099485788@Uncensored Date: Wed Aug 21 11:28:39 2024 -0400 Typed things on keyboard effecting changes in code ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 2 +- webcit-ng/static/js/calendar_edit.js | 13 ++++++------- webcit-ng/static/js/mail_folder_list.js | 5 +---- webcit-ng/static/js/main.js | 4 +--- webcit-ng/static/js/roomlist.js | 4 +--- webcit-ng/static/js/upload.js | 3 +-- webcit-ng/static/js/user_profile.js | 4 +--- webcit-ng/static/js/util.js | 4 +--- webcit-ng/static/js/view_calendar.js | 3 +-- webcit-ng/static/js/view_contacts.js | 7 ++----- webcit-ng/static/js/view_forum.js | 5 +---- webcit-ng/static/js/view_mail.js | 5 +---- webcit-ng/static/js/views.js | 5 ++--- 13 files changed, 20 insertions(+), 44 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485718Tue, 20 Aug 2024 22:16:29 +05002099485718@Uncensored Date: Tue Aug 20 22:16:27 2024 -0400 Experimenting with some layouts for attendees ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 4 ++-- webcit-ng/static/js/calendar_edit.js | 8 +++++++- webcit-ng/static/js/view_forum.js | 6 +++--- webcit-ng/static/js/view_mail.js | 8 ++++---- 4 files changed, 16 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485715Tue, 20 Aug 2024 21:51:52 +05002099485715@Uncensored Date: Tue Aug 20 21:51:50 2024 -0400 Style buttons ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 35 ++++++++++++++++++++++++++++------- webcit-ng/static/js/calendar_edit.js | 6 ++++++ 2 files changed, 34 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485702Tue, 20 Aug 2024 17:41:54 +05002099485702@Uncensored Date: Tue Aug 20 17:41:52 2024 -0400 Commit your code with this one weird trick! ----------------------------------------------------------------------- Summary of changes: citadel/Makefile | 3 +-- citadel/configure | 3 +-- citadel/server/backends/berkeley_db/berkeley_db.c | 5 +--- citadel/server/citadel_defs.h | 28 ++++++++++------------- citadel/server/citadel_dirs.h | 5 +--- citadel/server/citadel_ldap.h | 10 +------- citadel/server/citserver.h | 4 +--- citadel/server/clientsocket.h | 5 +--- citadel/server/config.h | 4 +--- citadel/server/control.h | 4 +--- citadel/server/database.h | 6 ++--- citadel/server/domain.h | 4 +--- citadel/server/modules_init.h | 5 +--- citadel/server/server.h | 5 +--- citadel/server/user_ops.h | 10 +------- citadel/utils/ctdldump.c | 4 +++- citadel/utils/ctdlload.c | 7 ++---- citadel/utils/guesstimezone.sh | 15 +----------- 18 files changed, 33 insertions(+), 94 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485592Tue, 20 Aug 2024 09:25:09 +05002099485592@Uncensored Date: Tue Aug 20 09:25:07 2024 -0400 Mindless tweaking of comments. ----------------------------------------------------------------------- Summary of changes: citadel/utils/chkpw.c | 3 +-- citadel/utils/citmail.c | 3 +-- citadel/utils/ctdldump.c | 5 +---- citadel/utils/ctdlload.c | 5 +---- 4 files changed, 4 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485473Mon, 19 Aug 2024 18:03:41 +05002099485473@Uncensored Date: Mon Aug 19 18:03:37 2024 -0400 Remember the bad old days, when only the MS-DOS kids got to use the cool line drawing characters? Well those days are over! Now that we have unicode everywhere, we're going to use them, and use them good. Also, Richard Stallman is a jerk, but not for the reason the social justice warriors think. Actually, they have a lot in common with each other. They're both far-left busybodies who just need to mind their own business. ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_dirs.c | 5 +---- citadel/server/citserver.c | 5 +---- citadel/server/clientsocket.c | 3 +-- citadel/server/config.c | 5 +---- citadel/server/context.c | 3 +-- citadel/server/control.c | 11 +++-------- citadel/server/ldap.c | 3 +-- citadel/server/server_main.c | 2 +- citadel/server/usetable.c | 10 ++-------- citadel/utils/auth.c | 7 ++----- citadel/utils/dbnothing.c | 9 ++++----- citadel/utils/loadtest.c | 14 ++++++-------- citadel/utils/sendcommand.c | 7 ++----- citadel/utils/setup.c | 7 ++----- 14 files changed, 28 insertions(+), 63 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485455Mon, 19 Aug 2024 16:44:15 +05002099485455@Uncensored Date: Mon Aug 19 16:44:12 2024 -0400 Tale as old as time, song as old as rhyme, doing style cleanup when I should be working. ----------------------------------------------------------------------- Summary of changes: citadel/server/makeuserkey.c | 5 +- citadel/server/netconfig.c | 7 +-- citadel/server/room_ops.c | 103 ++++++++++++++++++++------------------- citadel/server/serv_extensions.c | 60 +++++++++++------------ citadel/server/server_main.c | 65 ++++++++++++------------ citadel/server/support.c | 28 ++--------- citadel/server/support.h | 3 +- citadel/server/sysconfig.h | 13 ++--- citadel/server/sysdep.c | 78 +++++++++++++++-------------- citadel/server/threads.c | 21 +------- citadel/server/user_ops.c | 16 ++---- 11 files changed, 174 insertions(+), 225 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485445Mon, 19 Aug 2024 14:56:27 +05002099485445@Uncensored Date: Mon Aug 19 14:56:24 2024 -0400 I miss my Z-19 but we are not 80 columns anymore. ----------------------------------------------------------------------- Summary of changes: citadel/server/default_timezone.c | 9 ++-- citadel/server/domain.c | 29 ++++------- citadel/server/euidindex.c | 22 +++----- citadel/server/genstamp.c | 15 +++--- citadel/server/housekeeping.c | 9 ++-- citadel/server/internet_addressing.c | 31 +++++------- citadel/server/journaling.c | 28 +++++------ citadel/server/locate_host.c | 31 ++++-------- citadel/server/modules_init.c | 7 +-- citadel/server/msgbase.c | 98 +++++++++++++++++------------------- webcit/autocompletion.c | 20 ++------ 11 files changed, 119 insertions(+), 180 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485433Mon, 19 Aug 2024 11:03:57 +05002099485433@Uncensored Date: Mon Aug 19 11:03:54 2024 -0400 random acts of cleanup ----------------------------------------------------------------------- Summary of changes: libcitadel/COPYING | 4 - libcitadel/lib/base64.c | 13 ++- libcitadel/lib/json.c | 8 +- webcit/blogview_renderer.c | 203 +++++++++++++++++---------------------------- 4 files changed, 83 insertions(+), 145 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485390Sun, 18 Aug 2024 23:18:17 +05002099485390@Uncensored Date: Sun Aug 18 23:18:16 2024 -0400 something ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485127Fri, 16 Aug 2024 16:13:35 +05002099485127@Uncensored Date: Fri Aug 16 16:10:13 2024 -0400 More formgrid tuning. We will use this a lot. * Legend is always centered, with a bit of space on left and right. * Font is consistent. * Font is declared the same for both fields and their labels. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 22 ++++++++++++++++------ webcit-ng/static/js/calendar_edit.js | 24 ++++-------------------- webcit-ng/static/js/login.js | 4 ++-- 3 files changed, 22 insertions(+), 28 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485094Fri, 16 Aug 2024 13:57:18 +05002099485094@Uncensored Date: Fri Aug 16 13:56:08 2024 -0400 Display dtstart/dtend in editor in local time zone HACK: take advantage of the fact that Sweden uses a local date/time format that is exactly like ISO8601, but in the local time zone. This gives us yyyy-mm-ddThh:mm in local time. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485067Fri, 16 Aug 2024 12:06:48 +05002099485067@Uncensored Date: Fri Aug 16 12:06:45 2024 -0400 Several changes: 1. Switch cookie from 'Expires=' to 'Max-Age=' This eliminates the need to calculate the expiration date. 2. ical.es5.cjs has been renamed to ical.js We get the correct content-type now. 3. Began working on getting the dtstart and dtend loaded into the event editor. Still need to handle time zone conversion correctly. These are three completely unrelated changes in the same commit. I don't care. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/request.c | 4 +--- webcit-ng/static/index.html | 2 +- webcit-ng/static/js/calendar_edit.js | 17 ++++++++++++----- webcit-ng/static/js/{ical.es5.cjs => ical.js} | 0 4 files changed, 14 insertions(+), 9 deletions(-) rename webcit-ng/static/js/{ical.es5.cjs => ical.js} (100%) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099485059Fri, 16 Aug 2024 11:02:19 +05002099485059@Uncensored Date: Fri Aug 16 11:00:45 2024 -0400 Set ctdl-formgrid-fieldset to min-width:50em This makes it look pretty on a wide screen but can still expand if it needs to. Also set max-width:99% to keep it from overflowing the div. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 3 ++- webcit-ng/static/js/calendar_edit.js | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484901Thu, 15 Aug 2024 09:26:38 +05002099484901@Uncensored Date: Thu Aug 15 09:26:36 2024 -0400 Populate day column: cleaner logic ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484845Wed, 14 Aug 2024 17:40:11 +05002099484845@Uncensored Date: Wed Aug 14 17:40:08 2024 -0400 Handle events that start before today and end after today. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484843Wed, 14 Aug 2024 17:31:57 +05002099484843@Uncensored Date: Wed Aug 14 17:31:55 2024 -0400 Add some more elements to calendar edit. There is Date, and there is Starting/Ending date/time, but these need to be shown or hidden depending on whether we are editing an All Day Event. Started adding some more fields as well. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 6 +++++- webcit-ng/static/js/calendar_edit.js | 41 +++++++++++++++++++++--------------- 2 files changed, 29 insertions(+), 18 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484824Wed, 14 Aug 2024 15:15:43 +05002099484824@Uncensored Date: Wed Aug 14 15:15:40 2024 -0400 Bring in the date/time picker ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 58 +++++++++++++----------------------- webcit-ng/static/css/webcit.css | 4 +++ webcit-ng/static/js/calendar_edit.js | 6 ++++ 3 files changed, 31 insertions(+), 37 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484765Wed, 14 Aug 2024 11:47:20 +05002099484765@Uncensored Date: Wed Aug 14 11:46:38 2024 -0400 idle style cleanup ----------------------------------------------------------------------- Summary of changes: textclient/Makefile | 14 +- textclient/citadel_ipc.c | 26 +-- textclient/textclient.h | 421 +++++++++++++++++++++++------------------------ 3 files changed, 216 insertions(+), 245 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484706Tue, 13 Aug 2024 23:16:09 +05002099484706@Uncensored Date: Tue Aug 13 23:15:52 2024 -0400 Reworked font sizes for responsive rendering. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 20 +++++++++++--------- webcit-ng/static/index.html | 7 +++++-- 2 files changed, 16 insertions(+), 11 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484664Tue, 13 Aug 2024 18:12:11 +05002099484664@Uncensored Date: Tue Aug 13 18:12:09 2024 -0400 More fiddling around with fieldset ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 6 ++++++ webcit-ng/static/js/calendar_edit.js | 10 +++++----- 2 files changed, 11 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484533Tue, 13 Aug 2024 10:36:41 +05002099484533@Uncensored Date: Tue Aug 13 10:36:25 2024 -0400 More tuning of THE FIELDSET EXPERIENCE ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 17 +++++------------ webcit-ng/static/js/login.js | 2 +- 2 files changed, 6 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484439Mon, 12 Aug 2024 18:14:12 +05002099484439@Uncensored Date: Mon Aug 12 18:14:04 2024 -0400 Login modal now uses formgrid ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 10 +++++----- webcit-ng/static/js/login.js | 34 ++++++++++++++++------------------ 2 files changed, 21 insertions(+), 23 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484432Mon, 12 Aug 2024 17:41:35 +05002099484432@Uncensored Date: Mon Aug 12 17:41:07 2024 -0400 Grid layout for forms - testing with calendar edit ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/tls.c | 8 +-- webcit-ng/static/css/webcit.css | 107 ++++++++++++++++++++++++++++++++++- webcit-ng/static/js/calendar_edit.js | 51 ++++++++++++++++- 3 files changed, 157 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484431Mon, 12 Aug 2024 17:37:38 +05002099484431@Uncensored Date: Mon Aug 12 17:37:29 2024 -0400 Removed a goto! ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/html2html.c | 381 ++++++++++++++++++++++--------------------- 1 file changed, 191 insertions(+), 190 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484174Fri, 09 Aug 2024 21:14:07 +05002099484174@Uncensored Date: Fri Aug 9 21:13:42 2024 -0400 messages.c: lined up comments in the same column. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 67 +++++++++++++++++++++++++-------------------------- 1 file changed, 33 insertions(+), 34 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099484153Fri, 09 Aug 2024 18:22:02 +05002099484153@Uncensored Date: Fri Aug 9 18:21:59 2024 -0400 citadel_ipc.c: cleaned up for future improvements. * Style cleanup (C99 comments, new style indentation, etc.) * Removed support for commands no longer in the server * Documented the various protocol modes more clearly I'm also trying to verify that EVERY server transaction goes through CtdlIPCGenericCommand(). If it does, this makes it easier to add more transports in the future. We could potentially emcapsulate Citadel protocol commands inside UDP datagrams (roaming is all the rage these days) or HTTP transactions. citadel_ipc.c was written in the early 2000's by Michael Hampton (IO ERROR) and is finally starting to demonstrate what a good idea it was. Rest in peace, Mike. ----------------------------------------------------------------------- Summary of changes: textclient/citadel_ipc.c | 805 +++++++++++++++++------------------ webcit-ng/static/js/calendar_edit.js | 10 +- 2 files changed, 397 insertions(+), 418 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099483788Tue, 06 Aug 2024 22:10:20 +05002099483788@Uncensored Date: Tue Aug 6 22:09:18 2024 -0400 loadtest: capitalize and punctuate dummy lipsum ----------------------------------------------------------------------- Summary of changes: citadel/utils/loadtest.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099483639Mon, 05 Aug 2024 23:37:09 +05002099483639@Uncensored Date: Mon Aug 5 23:37:07 2024 -0400 Found another main() to convert to int main() ----------------------------------------------------------------------- Summary of changes: citadel/server/parsedate.c | 273 +++++++++++++++++++++++---------------------- citadel/server/parsedate.y | 11 +- 2 files changed, 142 insertions(+), 142 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099483636Mon, 05 Aug 2024 23:25:06 +05002099483636@Uncensored Date: Mon Aug 5 23:23:05 2024 -0400 Several small changes to calendar editor. "Save" and "Cancel" buttons appear next to each other Editor window is centered ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 36 +++++++++++++++++++++++++----------- 1 file changed, 25 insertions(+), 11 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099483630Mon, 05 Aug 2024 22:58:57 +05002099483630@Uncensored Date: Mon Aug 5 22:58:44 2024 -0400 Make the entire edit_calendar_event function async ----------------------------------------------------------------------- Summary of changes: webcit-ng/README.md | 11 ++++++----- webcit-ng/static/js/calendar_edit.js | 21 +++++++++------------ 2 files changed, 15 insertions(+), 17 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099483161Fri, 02 Aug 2024 16:29:22 +05002099483161@Uncensored Date: Fri Aug 2 16:29:19 2024 -0400 Bring data into calendar editor ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 42 +++++++++++++++++++++++++++++++++--- webcit-ng/static/js/view_calendar.js | 17 ++++++++------- 2 files changed, 48 insertions(+), 11 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099483138Fri, 02 Aug 2024 13:46:06 +05002099483138@Uncensored Date: Fri Aug 2 13:46:03 2024 -0400 Moved caldav client to its own js module ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 6 ++-- webcit-ng/static/index.html | 1 + webcit-ng/static/js/caldav_client.js | 68 ++++++++++++++++++++++++++++++++++++ webcit-ng/static/js/view_calendar.js | 63 +-------------------------------- 4 files changed, 73 insertions(+), 65 deletions(-) create mode 100644 webcit-ng/static/js/caldav_client.js -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482971Thu, 01 Aug 2024 10:43:16 +05002099482971@Uncensored Date: Thu Aug 1 10:43:14 2024 -0400 Open edit screen, add link to return to calendar screen ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482855Wed, 31 Jul 2024 15:59:50 +05002099482855@Uncensored Date: Wed Jul 31 15:59:48 2024 -0400 Return to the calendar view after edit ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/calendar_edit.js | 6 +++++- webcit-ng/static/js/view_calendar.js | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482852Wed, 31 Jul 2024 15:48:24 +05002099482852@Uncensored Date: Wed Jul 31 15:48:22 2024 -0400 Skeleton calendar event edit ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 1 + webcit-ng/static/js/calendar_edit.js | 11 +++++++++++ webcit-ng/static/js/view_calendar.js | 5 ++--- 3 files changed, 14 insertions(+), 3 deletions(-) create mode 100644 webcit-ng/static/js/calendar_edit.js -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482803Wed, 31 Jul 2024 11:57:25 +05002099482803@Uncensored Date: Wed Jul 31 11:57:23 2024 -0400 Fire a JS event when user clicks a calendar item ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 1 + webcit-ng/static/js/view_calendar.js | 21 ++++++++++++++------- 2 files changed, 15 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482592Tue, 30 Jul 2024 01:01:45 +05002099482592@Uncensored

 

Mon Jul 29 2024 22:23:51 EDT from IGnatius T Foobar

please watch the progress in this room and test the build from git if you are willing.

What C compiler are you using?

 sure and none of my patches are compiler specific. but if you're interested in a specific one, i have access to pretty much all compilers except for hp-ux's acc.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482562Mon, 29 Jul 2024 22:30:14 +05002099482562@Uncensored Date: Mon Jul 29 22:20:12 2024 -0400 Applied more UFarx configure patches commit e8f7782a1961d3f45aaa5a62a3e962096df82fda Author: Art Cancro Date: Mon Jul 29 22:08:02 2024 -0400 webcit classic: replace main() with int main() where needed commit 3f134ff1b1c45ee0e66f29d90fface497c61de6e Author: Art Cancro Date: Mon Jul 29 22:03:39 2024 -0400 citadel server: replace main() with int main() where needed commit dc28d3d4ce8945c86cc7ca45d29da1ebf6a3df57 Author: Art Cancro Date: Mon Jul 29 22:01:19 2024 -0400 libcitadel: replace main() with int main() where needed ----------------------------------------------------------------------- Summary of changes: citadel/configure | 6 +- citadel/utils/chkpwd.c | 9 +- libcitadel/configure.ac | 4 +- libcitadel/configure~ | 21691 ------------------------------------ libcitadel/conftools/config.guess | 7 +- webcit/config.guess | 2 +- webcit/configure.ac | 4 +- webcit/missing | 4 +- 8 files changed, 15 insertions(+), 21712 deletions(-) delete mode 100755 libcitadel/configure~ -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482561Mon, 29 Jul 2024 22:23:51 +05002099482561@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482555Mon, 29 Jul 2024 21:55:33 +05002099482555@Uncensored Date: Mon Jul 29 21:55:31 2024 -0400 random comment and style cleanup no big deal ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/tools.c | 5 ++- textclient/routines.c | 92 +++++++++++++++++---------------------- webcit-ng/server/caldav_reports.c | 3 +- 3 files changed, 43 insertions(+), 57 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482369Mon, 29 Jul 2024 00:55:30 +05002099482369@Uncensored

and the last one:

webcit's configure script does not use -liconv when checking for libcitadel. so if libcitadel was built with libiconv the check fails.
i didn't patch that properly but just hardcoded -liconv. it would probably make sense to have 2 checks of which one tries with -liconv.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482368Mon, 29 Jul 2024 00:49:59 +05002099482368@Uncensored

the textclient's build system still has the same problems as i reported last year: http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353108#2099353108

here is a patch for that.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482367Mon, 29 Jul 2024 00:47:14 +05002099482367@Uncensored

here is the patch to what i reported there: http://uncensored.citadel.org/readfwd?go=Citadel%20Support?start_reading_at=2099481915#2099481915

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482327Sun, 28 Jul 2024 15:55:24 +05002099482327@Uncensored Date: Sun Jul 28 15:55:04 2024 -0400 mini_2047_decode() now handles both qp and b64. This makes Base64-encoded Subject lines appear properly in the text client. ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 83 +++++++++++++++++++++++------------- webcit-ng/server/caldav_reports.c | 11 ++++- webcit-ng/static/css/webcit.css | 3 +- webcit-ng/static/js/view_calendar.js | 27 +++++------- 4 files changed, 75 insertions(+), 49 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482089Fri, 26 Jul 2024 11:04:48 +05002099482089@Uncensored Date: Fri Jul 26 11:04:46 2024 -0400 Made the use of template literals for ctdl-dal-day consistent. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099482082Fri, 26 Jul 2024 09:17:55 +05002099482082@Uncensored Date: Fri Jul 26 09:17:53 2024 -0400 This is it! All events being rendered properly. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481999Thu, 25 Jul 2024 17:55:37 +05002099481999@Uncensored Date: Thu Jul 25 17:55:35 2024 -0400 Rendering in the correct column and with the correct data. Just need to set the start and end time correctly. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481997Thu, 25 Jul 2024 17:44:51 +05002099481997@Uncensored Date: Thu Jul 25 17:44:48 2024 -0400 Finished the logic to figure out which column to render an event in. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 55 +++++++++++++++++++++++++----------- 1 file changed, 38 insertions(+), 17 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481964Thu, 25 Jul 2024 13:01:35 +05002099481964@Uncensored Date: Thu Jul 25 13:01:33 2024 -0400 DRY the function to render one event ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481957Thu, 25 Jul 2024 12:00:36 +05002099481957@Uncensored Date: Thu Jul 25 12:00:34 2024 -0400 Fixed the display range logic. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 39 ++++++++++++++++++++---------------- 1 file changed, 22 insertions(+), 17 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481945Thu, 25 Jul 2024 09:59:24 +05002099481945@Uncensored Date: Thu Jul 25 09:59:20 2024 -0400 Amazing change of indentation of comments! ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/upload.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481895Wed, 24 Jul 2024 23:57:17 +05002099481895@Uncensored Date: Wed Jul 24 23:57:15 2024 -0400 CalDAV: handle qp and b64 encoded calendar objects ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/caldav_reports.c | 18 ++++++++++++++++++ webcit-ng/static/js/view_calendar.js | 3 ++- 2 files changed, 20 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481880Wed, 24 Jul 2024 22:44:39 +05002099481880@Uncensored Date: Wed Jul 24 22:44:37 2024 -0400 Solved the duration problem. ICAL.Time.clone() is what we needed. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481711Tue, 23 Jul 2024 14:57:06 +05002099481711@Uncensored Date: Tue Jul 23 14:57:03 2024 -0400 Obnoxious commit log comment. I hope it offends you. ----------------------------------------------------------------------- Summary of changes: libcitadel/lib/tools.c | 81 ++++++++++++++++++-------------------------------- 1 file changed, 29 insertions(+), 52 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481708Tue, 23 Jul 2024 14:47:37 +05002099481708@Uncensored Date: Tue Jul 23 14:47:34 2024 -0400 Encrypted password exchanges are stupid. Just encrypt the whole session, dummy. ----------------------------------------------------------------------- Summary of changes: webcit-ng/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481477Sun, 21 Jul 2024 22:48:11 +05002099481477@Uncensored Date: Sun Jul 21 22:48:08 2024 -0400 trying to work around flimsy javascript scope problems ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 38 ++++++++++++++++++++++-------------- 1 file changed, 23 insertions(+), 15 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481447Sun, 21 Jul 2024 16:58:59 +05002099481447@Uncensored Date: Sun Jul 21 16:57:10 2024 -0400 Send CalDAV query for the correct date range. That about wraps it up for getting the right events. Recurrence even seems to be correct now. We are finally ready to slot the events onto the screen. I also repaired a garage door opener but this is not reflected in the code. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/caldav_reports.c | 1 - webcit-ng/static/js/view_calendar.js | 13 ++++++------- 2 files changed, 6 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481426Sun, 21 Jul 2024 14:53:44 +05002099481426@Uncensored Date: Sun Jul 21 14:53:42 2024 -0400 Add time-range to caldav query ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/caldav_reports.c | 1 + webcit-ng/static/js/view_calendar.js | 14 +++++++++++--- 2 files changed, 12 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481366Sun, 21 Jul 2024 11:35:48 +05002099481366@Uncensored Date: Sun Jul 21 08:35:46 2024 -0700 Saving my work to move to a different computer ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481359Sun, 21 Jul 2024 10:30:47 +05002099481359@Uncensored Date: Sun Jul 21 07:30:36 2024 -0700 Recur expansion looks decent now ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 61 +++++++++++++++++++++--------------- 1 file changed, 36 insertions(+), 25 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481252Sat, 20 Jul 2024 18:20:13 +05002099481252@Uncensored Date: Sat Jul 20 15:18:13 2024 -0700 begin work on recur ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481237Sat, 20 Jul 2024 17:11:15 +05002099481237@Uncensored Date: Sat Jul 20 14:10:50 2024 -0700 Calibrate nuclear toaster oven ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/crypto/serv_crypto.c | 26 ++++++++++++-------------- webcit-ng/static/js/view_calendar.js | 3 ++- 2 files changed, 14 insertions(+), 15 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099481208Sat, 20 Jul 2024 13:17:03 +05002099481208@Uncensored Date: Sat Jul 20 13:08:18 2024 -0400 smtps,pop3s,imaps,nntps now disabled by default. Generally most clients are using the STARTTLS commands on the regular ports anyway, and the usual menagerie of douchebags across the pond are jamming up the "s" ports. So we're disabling them in the default install by setting the default port numbers to "-1". Any site administrator who needs these ports can re-enable them. ----------------------------------------------------------------------- Summary of changes: citadel/server/config.c | 18 +++++++++--------- citadel/server/modules/upgrade/serv_upgrade.c | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099480747Wed, 17 Jul 2024 14:30:36 +05002099480747@Uncensored Date: Wed Jul 17 11:29:47 2024 -0700 Separate creation and population of day columns into separate functions ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 118 ++++++++++++++++++----------------- 1 file changed, 62 insertions(+), 56 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099480585Tue, 16 Jul 2024 22:32:46 +05002099480585@Uncensored Date: Tue Jul 16 19:32:43 2024 -0700 Finally add correct HREF to REPORT multigets. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/caldav_reports.c | 49 +++++++++++++++++++++++++-------------- webcit-ng/server/webcit.h | 8 +------ 2 files changed, 32 insertions(+), 25 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099480473Tue, 16 Jul 2024 10:20:54 +05002099480473@Uncensored Date: Tue Jul 16 07:20:48 2024 -0700 Minor tweaks to sample events ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099480413Mon, 15 Jul 2024 22:28:27 +05002099480413@Uncensored Date: Mon Jul 15 19:28:24 2024 -0700 Reduced experimental code to clean production code. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 39 ++++++++++++++++-------------------- webcit-ng/static/js/views.js | 4 ++++ 2 files changed, 21 insertions(+), 22 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099480369Mon, 15 Jul 2024 16:00:19 +05002099480369@Uncensored Date: Mon Jul 15 13:00:16 2024 -0700 As usual, it works perfectly once I understand its model. You have to register any supplied vtimezone components with the timezone service and then it will automatically convert any supplied timestamps once it knows about them. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099480366Mon, 15 Jul 2024 15:50:02 +05002099480366@Uncensored Date: Mon Jul 15 12:49:59 2024 -0700 saving my work before trying something ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099480351Mon, 15 Jul 2024 13:42:50 +05002099480351@Uncensored Date: Mon Jul 15 10:42:45 2024 -0700 Initial success at timezone conversion. Found some examples and fiddled with them until I got it to display the DTSTART as a JSdate in the browser's local time zone. But it is assuming that the supplied VTIMEZONE is the one used for all dates, which is probably correct 99.9% of the time but is not a safe assumption. ----------------------------------------------------------------------- Summary of changes: webcit-ng/README.md | 2 + webcit-ng/static/js/view_calendar.js | 76 +++++++++++++++++++++++------------- 2 files changed, 50 insertions(+), 28 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099480212Sun, 14 Jul 2024 17:33:22 +05002099480212@Uncensored Date: Sun Jul 14 14:33:19 2024 -0700 view_calendar.js: reduce overuse of let vs var ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 105 +++++++++++++++++++---------------- 1 file changed, 57 insertions(+), 48 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099479583Tue, 09 Jul 2024 18:40:07 +05002099479583@Uncensored Date: Tue Jul 9 15:40:04 2024 -0700 Implement as shorthand for document.getElementById() ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/defs.js | 2 ++ webcit-ng/static/js/login.js | 10 +++--- webcit-ng/static/js/mail_folder_list.js | 10 +++--- webcit-ng/static/js/main.js | 24 +++++++------- webcit-ng/static/js/roomlist.js | 10 +++--- webcit-ng/static/js/upload.js | 32 +++++++++--------- webcit-ng/static/js/user_profile.js | 2 +- webcit-ng/static/js/view_calendar.js | 32 +++++++++--------- webcit-ng/static/js/view_contacts.js | 2 +- webcit-ng/static/js/view_forum.js | 58 ++++++++++++++++----------------- webcit-ng/static/js/view_mail.js | 58 ++++++++++++++++----------------- webcit-ng/static/js/views.js | 29 ++++++++--------- 12 files changed, 134 insertions(+), 135 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099478699Tue, 02 Jul 2024 23:31:56 +05002099478699@Uncensored Date: Tue Jul 2 20:31:54 2024 -0700 Temporarily spew the parsed calendar data directly to the screen, erasing the pretty calendar, to make a point of the fact that we aren't yet handling timezones or recurrences yet. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 48 +++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 22 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099478503Mon, 01 Jul 2024 23:33:04 +05002099478503@Uncensored Date: Mon Jul 1 20:31:51 2024 -0700 First go at parsing the ical data and printing it. Library seems to work and the timezone handling appears to be doing the correct thing. Now we have to sort the data into the right boxes and also handle recurring events. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099478500Mon, 01 Jul 2024 23:10:05 +05002099478500@Uncensored Date: Mon Jul 1 20:09:51 2024 -0700 Integrated Philipp Kewisch's javascript libical ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 1 + webcit-ng/static/js/ical.es5.cjs | 9361 ++++++++++++++++++++++++++++++++++ webcit-ng/static/js/view_calendar.js | 2 +- 3 files changed, 9363 insertions(+), 1 deletion(-) create mode 100644 webcit-ng/static/js/ical.es5.cjs -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099478402Mon, 01 Jul 2024 16:00:24 +05002099478402@Uncensored Date: Mon Jul 1 13:00:22 2024 -0700 SetYear() is deprecated, replace with SetFullYear() ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099478389Mon, 01 Jul 2024 14:34:46 +05002099478389@Uncensored Date: Mon Jul 1 11:34:44 2024 -0700 Returning data from CalDAV to the caller. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 76 ++++++++++++++++++------------------ 1 file changed, 37 insertions(+), 39 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099478258Sun, 30 Jun 2024 17:45:36 +05002099478258@Uncensored Date: Sun Jun 30 14:45:32 2024 -0700 Finished the code to extract XML CalDAV elements. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099478253Sun, 30 Jun 2024 17:00:26 +05002099478253@Uncensored Date: Sun Jun 30 14:00:24 2024 -0700 Started working out the DOM XML PARSER And let me tell you, XML parsing in JavaScript is even uglier than Big Mike. Ok, that's an exaggeration. Nothing is uglier than Big Mike. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099478242Sun, 30 Jun 2024 15:48:19 +05002099478242@Uncensored Date: Sun Jun 30 12:48:17 2024 -0700 Big Mike is VERY ugly ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 8 +++++--- webcit-ng/static/js/views.js | 8 ++++---- 2 files changed, 9 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099478216Sun, 30 Jun 2024 11:54:49 +05002099478216@Uncensored Date: Sun Jun 30 08:54:47 2024 -0700 The -d flag isn't there anymore, don't offer it ----------------------------------------------------------------------- Summary of changes: citadel/server/server_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099477903Fri, 28 Jun 2024 21:39:15 +05002099477903@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099477902Fri, 28 Jun 2024 21:39:14 +05002099477902@Uncensored Date: Fri Jun 28 21:39:14 2024 -0400 Release version 1001 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel_defs.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099477901Fri, 28 Jun 2024 21:39:06 +05002099477901@Uncensored Date: Fri Jun 28 21:35:57 2024 -0400 webcit-classic: rework confusing LDAP settings. Somehow we ended up with WebCit-classic warning all site operators that their Citadel software was built without LDAP support. This is impossible because LDAP support is now a mandatory part of the build. Removed the warning message entirely along with the (broken) detection logic. Also moved the option for selecting authentication mode (self contained, system, standard LDAP, or M$ LDAP) from the "Access" tab to the "LDAP" tab, because it seems to make more sense there now. ----------------------------------------------------------------------- Summary of changes: webcit/serv_func.c | 13 ++----------- webcit/static/t/aide/siteconfig/tab_access.html | 8 -------- webcit/static/t/aide/siteconfig/tab_directory.html | 11 +++++++++-- webcit/webcit.h | 1 - 4 files changed, 11 insertions(+), 22 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099477669Thu, 27 Jun 2024 23:11:23 +05002099477669@Uncensored Date: Thu Jun 27 23:11:20 2024 -0400 fetching a command from the server, but not doing much yet ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099477536Thu, 27 Jun 2024 11:56:47 +05002099477536@Uncensored Date: Thu Jun 27 11:56:35 2024 -0400 Determine days to be loaded from server. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099476229Tue, 18 Jun 2024 15:10:26 +05002099476229@Uncensored Date: Tue Jun 18 12:06:45 2024 -0700 Removed accidental double declarations in CSS. I know what you're thinking, punk. Did he declare "width" two times, or only once? Now to tell you the truth, in all this excitement, I've kinda lost track myself. But being as this is HTML5, the most powerful DOM level in the world, and only the last declaration is the one that is accepted, you've got to ask yourself one question: "Do I feel lucky?" Well, do ya ... punk? ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 8 +------- webcit-ng/static/js/view_calendar.js | 10 +++++----- 2 files changed, 6 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099476196Tue, 18 Jun 2024 11:28:05 +05002099476196@Uncensored Date: Tue Jun 18 08:25:38 2024 -0700 Add the ability to zoom to a given range of hours. The entire day is rendered. The start hour is moved to the top of the screen by scrolling, and the end hour is moved to the bottom of the screen by zooming. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 4 ++-- webcit-ng/static/js/view_calendar.js | 22 +++++++++++++++------- 2 files changed, 17 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099476119Mon, 17 Jun 2024 17:56:06 +05002099476119@Uncensored Date: Mon Jun 17 17:56:04 2024 -0400 Push a little whitespace into the top left box ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 14 +++++++++++++- webcit-ng/static/js/view_calendar.js | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099476114Mon, 17 Jun 2024 17:47:32 +05002099476114@Uncensored Date: Mon Jun 17 17:47:30 2024 -0400 Simpler way to make it scrollable ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 6 ------ webcit-ng/static/js/view_calendar.js | 2 -- 2 files changed, 8 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099476113Mon, 17 Jun 2024 17:46:07 +05002099476113@Uncensored Date: Mon Jun 17 17:46:05 2024 -0400 make the calendar section scrollable ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 11 ++++++++++- webcit-ng/static/js/view_calendar.js | 2 ++ 2 files changed, 12 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099475950Sat, 15 Jun 2024 22:46:39 +05002099475950@Uncensored Date: Sat Jun 15 22:46:37 2024 -0400 This commit adds the adorable little half hour lines. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 14 +++++++++++++- webcit-ng/static/js/view_calendar.js | 12 ++++++++---- 2 files changed, 21 insertions(+), 5 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099475682Fri, 14 Jun 2024 00:10:50 +05002099475682@Uncensored Date: Fri Jun 14 00:10:47 2024 -0400 Added horizontal rules for each hour. Also got the hour rules on the left to line up nicely. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 15 +++++++++++++-- webcit-ng/static/js/view_calendar.js | 27 +++++++++++++++++---------- 2 files changed, 30 insertions(+), 12 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099475677Thu, 13 Jun 2024 23:42:12 +05002099475677@Uncensored Date: Thu Jun 13 23:41:03 2024 -0400 Set event style modifications inline. We were using javascript to set them after-the-fact but this is faster and better. Remember, nothing good EVER happens on Facebook and you should delete your account if you have one. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 41 +++++++++++++++++++++++------------- 1 file changed, 26 insertions(+), 15 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099475641Thu, 13 Jun 2024 18:07:16 +05002099475641@Uncensored Date: Thu Jun 13 18:05:30 2024 -0400 Calendar items are now properly positioned in day. Start and end hour now line up properly, overlapping events do not reposition to a different time, and browser resizing does the right thing. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 12 +++++++----- webcit-ng/static/js/view_calendar.js | 5 +++-- 2 files changed, 10 insertions(+), 7 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099475583Thu, 13 Jun 2024 11:54:17 +05002099475583@Uncensored Date: Thu Jun 13 11:54:15 2024 -0400 JavaScript template literals are awesome for this type of development and everyone should use them all the time. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 2 ++ webcit-ng/static/js/view_calendar.js | 65 +++++++++++++++++++----------------- 2 files changed, 36 insertions(+), 31 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099475256Tue, 11 Jun 2024 00:25:59 +05002099475256@Uncensored Date: Tue Jun 11 00:25:28 2024 -0400 NAILED IT! Position calendar events within day. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 11 +++++++ webcit-ng/static/js/mail_folder_list.js | 2 +- webcit-ng/static/js/view_calendar.js | 55 ++++++++++++++++++++++++++++++++- 3 files changed, 66 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099475237Mon, 10 Jun 2024 17:49:39 +05002099475237@Uncensored Date: Mon Jun 10 17:49:23 2024 -0400 Began work on dividing days into 24 hours ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 16 +++++++++++++--- webcit-ng/static/js/view_calendar.js | 2 +- 2 files changed, 14 insertions(+), 4 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474542Tue, 04 Jun 2024 20:09:55 +05002099474542@Uncensored Date: Tue Jun 4 20:09:53 2024 -0400 Fix ansi auto-detect ----------------------------------------------------------------------- Summary of changes: textclient/messages.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474538Tue, 04 Jun 2024 19:51:51 +05002099474538@Uncensored Date: Tue Jun 4 19:51:44 2024 -0400 Cleaned up ANSI Detect code. I was actually planning to go in and write this, only to find out that it was already written exactly as I had planned, a long time ago, by Michael Hampton (IO ERROR). Rest in peace, buddy. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.rc | 2 +- textclient/commands.c | 77 +++++++++++++++++++++++++++------------------------ 2 files changed, 42 insertions(+), 37 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474443Mon, 03 Jun 2024 23:12:40 +05002099474443@Uncensored Date: Mon Jun 3 23:12:36 2024 -0400 Now there are labels at the top. Ho-ho-ho. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 34 +++++++++++++++++++++++++++++++++- webcit-ng/static/js/view_calendar.js | 33 +++++++++++++++++++++++++-------- 2 files changed, 58 insertions(+), 9 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474417Mon, 03 Jun 2024 17:33:28 +05002099474417@Uncensored Date: Mon Jun 3 17:33:25 2024 -0400 Temp nav now includes view select. The temporary navigation buttons can now select a day view, three day view, five day (work week) view, or seven day (week) view. Month view is not included because that will be a different renderer. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 46 +++++++++++++++++++++++------------- 1 file changed, 30 insertions(+), 16 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474410Mon, 03 Jun 2024 17:07:23 +05002099474410@Uncensored Date: Mon Jun 3 17:04:47 2024 -0400 Finally got the calendar navigation logic correct. Something about the javascript date object makes instances of it persist even when it goes out of scope and is reinitialized in the next call. I had to try a bunch of different methods before I found one that went out of scope correctly. But now it's working properly. All of the temporary nav buttons ←Y | ←M | ←W | ←D | today | D→ | W→ | M→ | Y→ are doing what they are expected to do. Next steps will be to pretty up the view and then populate it with calendar data. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474305Sun, 02 Jun 2024 23:53:11 +05002099474305@Uncensored Date: Sun Jun 2 23:53:08 2024 -0400 Getting navigation in place for week view. Week View is actually also Day View, because it's using a flexbox and can display a arbitrary number of day columns. So we will use 1 column for day view, 5 columns for work week view, and 7 columns for week view. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_calendar.js | 64 ++++++++++++++++++++++-------------- 1 file changed, 39 insertions(+), 25 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474290Sun, 02 Jun 2024 21:09:47 +05002099474290@Uncensored Date: Mon Jun 3 01:09:42 2024 +0000 Initial commit for calendar week view flexbox. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 25 ++++++++++++++++++++ webcit-ng/static/index.html | 1 + webcit-ng/static/js/view_calendar.js | 45 +++++++++++++++++++++++++----------- webcit-ng/static/js/views.js | 2 +- 4 files changed, 58 insertions(+), 15 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474286Sun, 02 Jun 2024 20:55:42 +05002099474286@Uncensored Date: Sun Jun 2 20:55:38 2024 -0400 Reduced hi_from_stu.wav by -20db ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/sounds/hi_from_stu.wav | Bin 77226 -> 67532 bytes 1 file changed, 0 insertions(+), 0 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474246Sun, 02 Jun 2024 15:55:16 +05002099474246@Uncensored

But, we are here and do read.

Sun Jun 02 2024 15:47:41 EDT from IGnatius T Foobar Subject: Re: Really just a commit test.

Ok there we go. I know only a few people read this room 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474243Sun, 02 Jun 2024 15:47:41 +05002099474243@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099474239Sun, 02 Jun 2024 15:42:35 +05002099474239@Uncensored Date: Sun Jun 2 19:42:33 2024 +0000 Really just a commit test. I'm going to try to put commit messages back into the Citadel Development room now that the communists at Google have stopped throwing them into the spam bucket. But I didn't like the format that the RSS feed was using so I'm trying out my own commit hook. ----------------------------------------------------------------------- Summary of changes: textclient/citadel_ipc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099471566Thu, 16 May 2024 13:15:00 +05002099471566@Uncensored

I added my goostapo mail account as a mailing list recipient for this room.

If I get the message, it ought to have the "One Click Unsubscribe" button available, because we generate those headers now, and they are DKIM-signed.

In general, Uncensored seems to be out of the "reject completely" filter and now simply in the "spam" inbox.  This is definitely because we started DKIM-signing messages today.

May those responsible at Goolag experience immense suffering as punishment for holding the world's mail hostage.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099469073Sat, 04 May 2024 19:26:31 +05002099469073@UncensoredStrBufReplaceToken() set the null terminator correctly

https://code.citadel.org?p=citadel.git;a=commitdiff;h=8ba44734a2550abbb8064727f720e34d511e422b ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099466169Fri, 26 Apr 2024 00:03:41 +05002099466169@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099466159Fri, 19 Apr 2024 11:06:05 +05002099466159@UncensoredMailing list header changes (fuck you Google)

https://code.citadel.org?p=citadel.git;a=commitdiff;h=99efe55958ebc96ab99b052dc67864ea1db64a62 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099465025Thu, 18 Apr 2024 22:45:52 +05002099465025@UncensoredChanged how Message-ID RFC2822 field is generated

https://code.citadel.org?p=citadel.git;a=commitdiff;h=605133afb3d87139c657794d647c3a49df8b6a47 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099464630Tue, 16 Apr 2024 23:44:07 +05002099464630@Uncensoredsome work on calendar

https://code.citadel.org?p=citadel.git;a=commitdiff;h=e8e6d8ec8decd3c161a1a78273b1538fe8bdb88b ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099464621Tue, 16 Apr 2024 19:25:41 +05002099464621@UncensoredCalendar view: initial call of REPORT method.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=fd9570c14521f696cccaaf8b8e7e0fa75cfddc2a ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099464524Tue, 16 Apr 2024 15:20:35 +05002099464524@Uncensoredmore noodling on backend detection

https://code.citadel.org?p=citadel.git;a=commitdiff;h=74104e1f70c837bfeec6e957ce7f84a4f969a0ed ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099464423Tue, 16 Apr 2024 11:20:56 +05002099464423@UncensoredTest for existing BDB files (not used yet)

https://code.citadel.org?p=citadel.git;a=commitdiff;h=892419cf4747c1c0abea8d1e9bed8ca692aed8eb ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099448568Tue, 02 Apr 2024 18:39:30 +05002099448568@UncensoredBegan adding support for stanzas.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=fba52410c164f3bf45b35c1f34ad2d640ff5350e ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099448567Fri, 12 Apr 2024 12:15:57 +05002099448567@UncensoredFixed parsing of message-id angle brackets

https://code.citadel.org?p=citadel.git;a=commitdiff;h=2e8a881302b3abfd12512e76fd122d0ef915feb1 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099448566Fri, 12 Apr 2024 12:19:44 +05002099448566@UncensoredRelease version 999 generated by do-release.sh

https://code.citadel.org?p=citadel.git;a=commitdiff;h=541605cdd0604341440beaef64676bc9f8052b58 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378897Thu, 28 Mar 2024 20:04:52 +05002099378897@UncensoredEveryone who designed CalDAV deserves torture and ultra-violent death.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=c5b99d2f192b2e157e1591c18042f9fdd37996f2 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378830Wed, 27 Mar 2024 16:24:04 +05002099378830@Uncensoredmoved whitespace around

https://code.citadel.org?p=citadel.git;a=commitdiff;h=7df04bd286205d65e4a6f872dfddc0b8a519db32 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378823Wed, 27 Mar 2024 16:09:55 +05002099378823@Uncensoredinternet_addressing.c: minor cleanups

https://code.citadel.org?p=citadel.git;a=commitdiff;h=7cfac6940174927086a09b6e3b243b97e4be7128 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378822Wed, 27 Mar 2024 16:14:41 +05002099378822@Uncensoredserv_notes.c: cleanup

https://code.citadel.org?p=citadel.git;a=commitdiff;h=94267831ba06be96909f10cb64541a80ee93fc90 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378817Wed, 27 Mar 2024 15:43:06 +05002099378817@UncensoredREPORT namespace output uses declaration defined on top

https://code.citadel.org?p=citadel.git;a=commitdiff;h=cf535e06bb503583c301683ea885220df1b276d5 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378816Wed, 27 Mar 2024 15:56:30 +05002099378816@Uncensoredvalidate_recipients() - completed removal of unused param

https://code.citadel.org?p=citadel.git;a=commitdiff;h=1d8bbd8d311dc3f70985d9087df4b499db9c4327 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378789Wed, 27 Mar 2024 11:47:55 +05002099378789@Uncensoredvalidate_recipients() remove extra copy of recipients

https://code.citadel.org?p=citadel.git;a=commitdiff;h=724bf4e35d6067c6646430953d685931b5f16b0c ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378738Mon, 25 Mar 2024 16:04:23 +05002099378738@UncensoredHandle start and end times together

https://code.citadel.org?p=citadel.git;a=commitdiff;h=683446d905326f7d23de2c902880bc9fa8ef7d74 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378645Mon, 25 Mar 2024 15:27:27 +05002099378645@Uncensoredmake it pretty

https://code.citadel.org?p=citadel.git;a=commitdiff;h=dc7628bd87467c18ac7c4a7e241d536a1d0ffb22 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378634Mon, 25 Mar 2024 13:58:29 +05002099378634@UncensoredCompleted time range search of recurring events.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=3369975ea949c33c3eeb4a4668d5af402cb8781a ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378484Fri, 22 Mar 2024 16:19:15 +05002099378484@Uncensoredxmpp_sasl_service.c: style cleanup

https://code.citadel.org?p=citadel.git;a=commitdiff;h=0b83ae50f5442c82dc8fb11ad3322d90383e34d5 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378466Fri, 22 Mar 2024 13:12:38 +05002099378466@UncensoredMade this code more brief

https://code.citadel.org?p=citadel.git;a=commitdiff;h=473c0f696929fd377c125443fd92b1df65ddbc61 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378455Fri, 22 Mar 2024 11:28:34 +05002099378455@UncensoredTook ical_dezonify.c back out of WebCit-NG

https://code.citadel.org?p=citadel.git;a=commitdiff;h=b0ea3f3bd48ceacbd2cd254c84b4173dea2b6bfc ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378408Thu, 21 Mar 2024 17:49:36 +05002099378408@UncensoredDefined 19010101T010101Z-99991231T235959Z consts.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=41966209672df12d0de6bcf5ec38628170f6c82a ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378386Thu, 21 Mar 2024 14:50:21 +05002099378386@Uncensoredical_ctdl_is_overlap.c: cleaned it up

https://code.citadel.org?p=citadel.git;a=commitdiff;h=cf62d75a721b553e35bcbcc040dde194d69b87be ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378384Thu, 21 Mar 2024 14:56:45 +05002099378384@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378381Thu, 21 Mar 2024 14:30:29 +05002099378381@UncensoredDo not convert compared times to UTC.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=a0bffa36078be5c70149923399fba348494d8e5c ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378377Thu, 21 Mar 2024 13:57:36 +05002099378377@UncensoredCompare after convert works. Saving.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=40a364d8cd88d0f2966b89a4ba618987485fddf1 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378372Thu, 21 Mar 2024 13:11:36 +05002099378372@UncensoredWARNING NOT Y10K COMPLIANT

https://code.citadel.org?p=citadel.git;a=commitdiff;h=601d4c8f9e3fc42b74beb2e16d94a7e4a995aa1f ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378356Thu, 21 Mar 2024 11:54:37 +05002099378356@UncensoredChanged "supplied_xxx" to "xxx_in" when we modify.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=fc3a564c7bba86a29503b39bdd8512801116e70e ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378277Wed, 20 Mar 2024 15:56:01 +05002099378277@Uncensoredical_ctdl_is_overlap() is now symlinked 3 places.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=3292f7f60e2f42173b0b233e019ddc0df72d38fa ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378171Tue, 19 Mar 2024 19:44:05 +05002099378171@UncensoredIn webcit-classic, include webserver.h from webcit.h.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=8b3b916db46e22d83ba2740d4c09ef8c967263b2 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099378170Tue, 19 Mar 2024 19:56:32 +05002099378170@UncensoredBring ical_dezonify() into caldav_reports.c

https://code.citadel.org?p=citadel.git;a=commitdiff;h=a88a550cf8b88924645686b5c2fea78c4e0bcb66 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376859Thu, 07 Mar 2024 11:29:15 +05002099376859@Uncensoredmisc style cleanup

https://code.citadel.org?p=citadel.git;a=commitdiff;h=2bf4ae9ae7e2c80380b4c8369754b2b5fa455e52 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376696Mon, 04 Mar 2024 17:14:05 +05002099376696@UncensoredOnly calculate ops/sec if time>0

https://code.citadel.org?p=citadel.git;a=commitdiff;h=d0fa5441a64b2ce2be78b3a72e726fa6b0c416cd ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376693Mon, 04 Mar 2024 16:13:15 +05002099376693@UncensoredMade a note to fix a divide-by-zero problem.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=65a7033e4687ea08debbacd1d83a9d566c6796ab ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376600Sat, 02 Mar 2024 19:02:46 +05002099376600@Uncensoredcal_zone means "calendar timezone" also "calzone"

https://code.citadel.org?p=citadel.git;a=commitdiff;h=16408b0a369aa1c0645079ab40135306c6c9d551 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376599Sat, 02 Mar 2024 19:13:17 +05002099376599@UncensoredMoved default_zone_name declaration to webcit.h

https://code.citadel.org?p=citadel.git;a=commitdiff;h=fe30785de2bb95829282525296016d3783e51d8f ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376581Sat, 02 Mar 2024 16:36:54 +05002099376581@UncensoredSmuggled classified secrets into this repository.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=16c0a868a43e20d7172692cda62d35f5100ac58e ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376316Tue, 27 Feb 2024 11:16:56 +05002099376316@UncensoredSkeleton code for time-range test (section 9.9)

https://code.citadel.org?p=citadel.git;a=commitdiff;h=29d91a0edee2565fd59b5b5a20963e73d528a5cf ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376283Mon, 26 Feb 2024 23:42:46 +05002099376283@UncensoredI hope letitia james and arthur engoron get run over by a truck

https://code.citadel.org?p=citadel.git;a=commitdiff;h=2c1cfe66047a3a6618812688b8c43769602d48a9 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376276Mon, 26 Feb 2024 22:41:45 +05002099376276@Uncensoredadded more trace messages

https://code.citadel.org?p=citadel.git;a=commitdiff;h=02bffe90aa686b47878c060af52fd6da66721d9e ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376275Mon, 26 Feb 2024 22:50:32 +05002099376275@UncensoredCount nesting level only for comp-filters

https://code.citadel.org?p=citadel.git;a=commitdiff;h=59cf6823582d86ea826d3ed9625791da13d6f92b ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376245Mon, 26 Feb 2024 18:00:19 +05002099376245@UncensoredRefining XML rules

https://code.citadel.org?p=citadel.git;a=commitdiff;h=9b800a70df384d28b050391002f53061ba824043 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099376238Mon, 26 Feb 2024 17:37:20 +05002099376238@UncensoredXML is like violence: if it doesn't work, you're not using enough.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=747c2d11b3641e4dc4cc0033e96bb0266e074446 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375951Thu, 22 Feb 2024 16:28:00 +05002099375951@UncensoredUpdated the text client command set help

https://code.citadel.org?p=citadel.git;a=commitdiff;h=ff8b822cefb034b780dc3c8b1f2c679191a168d9 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375904Wed, 21 Feb 2024 20:56:43 +05002099375904@UncensoredCompleted the first two filter tests.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=9053e2d882352050a3fd443ccfbaf321a0222b93 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375881Wed, 21 Feb 2024 14:49:17 +05002099375881@UncensoredMade the log easier to read

https://code.citadel.org?p=citadel.git;a=commitdiff;h=c6d2ec50d042dc1eee0944350694ff3510e5a606 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375871Wed, 21 Feb 2024 12:28:11 +05002099375871@UncensoredTry new strategy for CalDAV report filter parsing.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=44f538295c25a95abe146d64cecc321432170722 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375831Wed, 21 Feb 2024 00:08:57 +05002099375831@UncensoredI wish much death and suffering to Cyrus Daboo, Lisa M. Dusseault, and Bernard Desrui...

https://code.citadel.org?p=citadel.git;a=commitdiff;h=2262587ffce0e5e41fa8daa09449c3cc0f7de3d1 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375828Tue, 20 Feb 2024 23:43:13 +05002099375828@UncensoredShorthand for the XML namespace

https://code.citadel.org?p=citadel.git;a=commitdiff;h=ab43dc8da7d977206827b0f7a5ebcbbbedb2d557 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375780Tue, 20 Feb 2024 10:15:57 +05002099375780@UncensoredSkeleton code for filters.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=6f4c0c2ce695e96011b2a61815e25d16ebbffa85 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375398Wed, 14 Feb 2024 13:16:33 +05002099375398@UncensoredCompleted framework for caldav_apply_one_filter()

https://code.citadel.org?p=citadel.git;a=commitdiff;h=b71f6ba27ff81252619feaea6c5046e4502403df ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375394Wed, 14 Feb 2024 12:03:02 +05002099375394@UncensoredFilters defined in RFC4791 9.7.1-9.7.5: DRY ingest

https://code.citadel.org?p=citadel.git;a=commitdiff;h=3a673adcc2ffde7ae38f14677efa288c4173d159 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375296Tue, 13 Feb 2024 17:31:28 +05002099375296@UncensoredYet another attempted framework for caldav filters.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=f6edf9b754dcd04e8eab7fa53dc62b57ad5b14cc ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375190Mon, 12 Feb 2024 14:41:12 +05002099375190@UncensoredFinal changes to XML parser trace logging.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=a58a2ebc498fe473e72adc8d544162bb3be16d64 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375175Mon, 12 Feb 2024 11:09:23 +05002099375175@Uncensoredmore logging and chardata stuff

https://code.citadel.org?p=citadel.git;a=commitdiff;h=a39d89c87050f78dc04cf39c1d886d64abb7788a ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375099Sun, 11 Feb 2024 00:47:21 +05002099375099@Uncensoredbetter logging presentation of chardata

https://code.citadel.org?p=citadel.git;a=commitdiff;h=8a7c7e5bd5d65ec34b665579b1577be51fdde285 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375057Sat, 10 Feb 2024 14:17:33 +05002099375057@UncensoredImproved logging of XML parse

https://code.citadel.org?p=citadel.git;a=commitdiff;h=2d5504af09fb903b0a9bbd105481ba67c309d34d ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099375008Fri, 09 Feb 2024 16:52:29 +05002099375008@UncensoredSolved P=NP

https://code.citadel.org?p=citadel.git;a=commitdiff;h=eab56df5d120be5d474378f8536837d0abd43214 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374953Thu, 08 Feb 2024 14:39:59 +05002099374953@UncensoredUnified multistatus output for all REPORT outputs.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=dd9248637b2d2d26c30ace03a97b2877c49af399 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374865Tue, 06 Feb 2024 20:43:19 +05002099374865@UncensoredMoved multiget output into its own function.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=20f4dc22b7a4100cb1cda8aaa9e8678bdffa58e3 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374815Tue, 06 Feb 2024 11:10:06 +05002099374815@Uncensoredctdldump/ctdlload: add version number to banner

https://code.citadel.org?p=citadel.git;a=commitdiff;h=f6a999b21a38678a1771eb5ba50d2912582acf30 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374792Mon, 05 Feb 2024 22:41:52 +05002099374792@UncensoredAdded context state to output of RWHO command.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=9a1be8e36d2c3398ebe4b2958beb9d7192d05503 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374789Mon, 05 Feb 2024 22:19:05 +05002099374789@UncensoredRelease version 998 generated by do-release.sh

https://code.citadel.org?p=citadel.git;a=commitdiff;h=1f7b5e2f17d283971f718eced9fa83534c2a6c5d ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374768Tue, 30 Jan 2024 21:59:50 +05002099374768@UncensoredGiving up on doing citserver-side REPORT parsing.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=c552978c0ea0ab081a32d7c29ba62d4c0e8aad60 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374767Mon, 05 Feb 2024 17:46:34 +05002099374767@UncensoredAwesome sauce, read description below for details.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=9f197d0b63b09d6cc295051016a5b549a65e8588 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374766Mon, 05 Feb 2024 17:53:23 +05002099374766@Uncensoredadd a comment to the previous thing

https://code.citadel.org?p=citadel.git;a=commitdiff;h=eba76cc4b6dbd7103ac5f5684871eeec5638c373 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374404Tue, 30 Jan 2024 21:12:26 +05002099374404@Uncensoredenabling http debugging because here comes caldav ugh

https://code.citadel.org?p=citadel.git;a=commitdiff;h=88c85ddb9e714faa214de6b103ed5bbf8d0bedea ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374374Tue, 30 Jan 2024 14:07:44 +05002099374374@Uncensored"To hell with cloud. Run Citadel." --Taylor Swift

https://code.citadel.org?p=citadel.git;a=commitdiff;h=b688cac3d673bdc0188107c8ab602ee313a3b792 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374255Tue, 30 Jan 2024 10:26:53 +05002099374255@UncensoredCtdlCheckExpress() now accepts a session context.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=b41aa04a613aab95aa822238ed9671063f72a7b8 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374226Mon, 29 Jan 2024 21:43:56 +05002099374226@Uncensored

Well that's a fine howdy-do, I tagged the release without also mentioning why I pushed it at this time.  This version has the config option to advertise STARTTLS on the public SMTP server.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374214Mon, 29 Jan 2024 18:57:09 +05002099374214@UncensoredRelease version 997 generated by do-release.sh

https://code.citadel.org?p=citadel.git;a=commitdiff;h=05abe4c6adfe1d12af53eba1e57046da8a038a88 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374198Mon, 29 Jan 2024 15:26:37 +05002099374198@UncensoredIndent with tabs, as God intended.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=7508496df78ca5da6d0f8cfb8811cc66620c60bb ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374192Mon, 29 Jan 2024 14:18:34 +05002099374192@Uncensoreddatabaselayout.md: added code blocks

https://code.citadel.org?p=citadel.git;a=commitdiff;h=1f89718b912eed9c18c504ffe83fd890ba8c3673 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374189Mon, 29 Jan 2024 13:58:08 +05002099374189@Uncensoredbinaries.txt: converted to markdown

https://code.citadel.org?p=citadel.git;a=commitdiff;h=865955ca0cfca75548026f3701662b7a7dad6ace ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374179Mon, 29 Jan 2024 11:09:52 +05002099374179@UncensoredCodified plans for world domination

https://code.citadel.org?p=citadel.git;a=commitdiff;h=bcffb8b3fb56f66a0fdc50cf57c4154e8bfb1dd0 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374157Sun, 28 Jan 2024 22:23:03 +05002099374157@UncensoredChanged the BIGMSGS semantics.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=64ad1443540350c9570e98df9236c87c434a3cce ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374069Sat, 27 Jan 2024 12:27:57 +05002099374069@Uncensoredloadtest: default threads now 10

https://code.citadel.org?p=citadel.git;a=commitdiff;h=51c0c7fe81708028e1191bd6149c30707cd4c541 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374048Fri, 26 Jan 2024 19:09:34 +05002099374048@Uncensoredloadtest: added ops/sec meter

https://code.citadel.org?p=citadel.git;a=commitdiff;h=2cb169cbafa453a5010a26d568bb452bb2f14818 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374027Fri, 26 Jan 2024 16:51:39 +05002099374027@UncensoredAssert that eMessageText MUST be serialized last.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=cd6c194901557e9e068643d01d117a7824d36533 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099374015Fri, 26 Jan 2024 13:14:02 +05002099374015@UncensoredCtdlSerializeMessage() now returns struct smr_ret

https://code.citadel.org?p=citadel.git;a=commitdiff;h=5d3c7139faafbfdc5db4b45bdf9ef7105d4593b1 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373945Thu, 25 Jan 2024 11:37:39 +05002099373945@UncensoredRearranging code to prepare for multiple REPORT types

https://code.citadel.org?p=citadel.git;a=commitdiff;h=bcdcc6d9a5f4d5f1a86d1fc725a2ce787f1d92f8 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373909Wed, 24 Jan 2024 19:26:14 +05002099373909@Uncensoredremove leading/trailing whitespace from hrefs

https://code.citadel.org?p=citadel.git;a=commitdiff;h=d2da635affb615a8687d24ad949b102a218c0762 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373890Wed, 24 Jan 2024 17:19:23 +05002099373890@UncensoredNoodling on calendar query commands.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=3ddecda78a842d669c632d42cc81d987f031d882 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373883Wed, 24 Jan 2024 16:32:07 +05002099373883@UncensoredMade our cproto output even more beautiful

https://code.citadel.org?p=citadel.git;a=commitdiff;h=538a328f269dc13399dfeeb7a0e80a89657aa213 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373875Wed, 24 Jan 2024 15:19:57 +05002099373875@UncensoredBegan refactoring CALDAV REPORT flow of control.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=d837babd310852f5e1360b368fab8d59877939a1 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373828Tue, 23 Jan 2024 20:22:33 +05002099373828@UncensoredDon't bother reading this commit.

https://code.citadel.org?p=citadel.git;a=commitdiff;h=491081a15e7f711852a96cfb9396048b53a23a14 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373792Tue, 23 Jan 2024 11:18:41 +05002099373792@UncensoredBlockquotes are now rendered to console as dim instead of italic

https://code.citadel.org?p=citadel.git;a=commitdiff;h=d383bc5305bc266d8ca34e61753bc47f7a2a83d4 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373596Sat, 20 Jan 2024 11:01:04 +05002099373596@UncensoredNew config option: set smtp_advertise_starttls to nonzero to advertise STARTTLS in...

https://code.citadel.org?p=citadel.git;a=commitdiff;h=ba196da6b1ae7bdd2e72558ff35fe17d8597d141 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373286Wed, 03 Jan 2024 18:58:45 +05002099373286@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373285Thu, 04 Jan 2024 15:54:40 +05002099373285@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373284Thu, 04 Jan 2024 16:32:31 +05002099373284@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373283Thu, 04 Jan 2024 22:44:14 +05002099373283@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373282Thu, 04 Jan 2024 22:47:35 +05002099373282@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373281Thu, 04 Jan 2024 22:51:08 +05002099373281@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373280Fri, 05 Jan 2024 15:33:17 +05002099373280@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373279Fri, 05 Jan 2024 19:44:46 +05002099373279@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373278Fri, 05 Jan 2024 19:52:10 +05002099373278@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373277Fri, 05 Jan 2024 20:22:18 +05002099373277@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373276Fri, 05 Jan 2024 20:49:15 +05002099373276@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373275Fri, 05 Jan 2024 23:47:56 +05002099373275@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373274Fri, 05 Jan 2024 23:51:03 +05002099373274@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373273Fri, 05 Jan 2024 23:56:50 +05002099373273@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373272Sat, 06 Jan 2024 00:01:38 +05002099373272@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373271Mon, 08 Jan 2024 15:19:58 +05002099373271@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373270Mon, 08 Jan 2024 16:57:28 +05002099373270@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373269Mon, 08 Jan 2024 21:29:16 +05002099373269@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373268Wed, 10 Jan 2024 22:20:09 +05002099373268@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373267Sun, 14 Jan 2024 03:04:16 +05002099373267@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373266Tue, 16 Jan 2024 09:53:08 +05002099373266@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099373090Sat, 13 Jan 2024 22:22:18 +05002099373090@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372878Wed, 10 Jan 2024 17:20:09 +05002099372878@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372803Tue, 09 Jan 2024 22:59:22 +05002099372803@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372763Tue, 09 Jan 2024 12:11:06 +05002099372763@Uncensored

Understood, was just a passing thought since i live in the 'big world' and first thought is always scale..  Many of our apps get 100k + connections all day long. 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372752Tue, 09 Jan 2024 11:39:17 +05002099372752@UncensoredThat is a hard one. But keeping them separate might help with >scalability?  That was true for WebCit-classic which contains a server-side user interface. And until a few years ago they could run on separate machines, so you could have multiple WebCit instances running with a load balancer. Today, the hardware is so powerful that this need no longer exists. We added a requirement for Citadel Server and WebCit to run on the same host because it makes TLS easy to deploy. Both programs can point to the same key and certificate files instead of having to get the components to trust each other over the network and then send everything back and forth. This is appreciated by innumerable site operators who "just want it to work" -- sites which actually exist in large numbers. Moving the web API would increase performance and possibly decrease complexity. However, it would be a major refactoring of the server code, which would be another year-long side quest. That's a bad thing when WebCit-NG is already years behind schedule. I've just begun work on the calendar. This is arguably the most logic-intensive part of the system and I want to keep it as DRY as possible. This is involving a lot of contemplation at a time when I really want to just get down to coding. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372704Mon, 08 Jan 2024 16:29:16 +05002099372704@UncensoredThe goal is to provide calendar searches (date range etc) for both WebCit-NG and for CALDAV REPORT method in a DRY way.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372694Mon, 08 Jan 2024 14:19:51 +05002099372694@Uncensored

That is a hard one. But keeping them separate might help with scalability? 

Mon Jan 08 2024 12:42:10 EST from IGnatius T Foobar Subject: Re: START_CHAT_MODE is renamed to SEND_THEN_RECV

I've been thinking lately that it might begin to make sense to put the web server (really, the web API) directly into Citadel Server. Since it's now a web API and no longer a user interface, it could be an improvement.

*shrug*

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372689Mon, 08 Jan 2024 12:42:10 +05002099372689@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372684Mon, 08 Jan 2024 11:57:28 +05002099372684@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372680Mon, 08 Jan 2024 10:19:58 +05002099372680@UncensoredThis protocol mode began almost 30 years ago when we handled real time chat by holding a session open and moving data back and forth until told to stop. We don't do that anymore, but there are several places where a command requires sending long data in both directions. SEND_THEN_RECV is a better name for this.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372557Fri, 05 Jan 2024 19:01:38 +05002099372557@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372547Fri, 05 Jan 2024 18:47:56 +05002099372547@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372546Fri, 05 Jan 2024 18:51:03 +05002099372546@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372545Fri, 05 Jan 2024 18:56:50 +05002099372545@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372535Fri, 05 Jan 2024 15:49:15 +05002099372535@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372531Fri, 05 Jan 2024 15:22:18 +05002099372531@UncensoredIt's fun to watch. It's fun to build on ARM first and try x86 later.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372525Fri, 05 Jan 2024 14:44:46 +05002099372525@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372524Fri, 05 Jan 2024 14:52:10 +05002099372524@UncensoredSeeing this code has really brought me back to the upstairs room in my old house where I wrote most of it back in 2002-2003. I can see the sunlight coming in the windows, the color of the carpet, the little alcove where the computer was, the cat sleeping on top of the big CRT monitor. Hopefully the stuff I need to add to it now will be straightforward since it looks like I really took my time and commented it heavily. It looks pretty clean, especially now that I've reformatted it with the new screen width an C99 comments. It does seem a bit WET though.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372509Fri, 05 Jan 2024 10:33:17 +05002099372509@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372473Thu, 04 Jan 2024 17:47:35 +05002099372473@UncensoredWhen I wrote this stuff I had a 109 column screen. Now our standard is 132 columns. Also we are seeking and destroying any place where spaces were used as indentation. Our code is indented with tabs, the way God intended.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372472Thu, 04 Jan 2024 17:51:08 +05002099372472@UncensoredMany years ago, someone inserted an enum called eMesageText into the code and used it all over the place without correcting the spelling. This commit finally fixes it.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372467Thu, 04 Jan 2024 17:44:14 +05002099372467@UncensoredWhen I wrote this stuff I had a 109 column screen. Now our standard is 132 columns. Also we are seeking and destroying any place where spaces were used as indentation. Our code is indented with tabs, the way God intended.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372446Thu, 04 Jan 2024 11:32:31 +05002099372446@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372440Thu, 04 Jan 2024 10:54:40 +05002099372440@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372384Wed, 03 Jan 2024 13:58:45 +05002099372384@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372377Wed, 03 Jan 2024 13:34:06 +05002099372377@UncensoredThis is what I do when I'm avoiding some other task.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372376Wed, 03 Jan 2024 13:41:16 +05002099372376@UncensoredThis is a testing script intended for developers. The last thing we need is for some dumbass to run it without knowing what it does, and then come to us complaining that it deleted their database.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372371Wed, 03 Jan 2024 13:12:25 +05002099372371@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372370Wed, 03 Jan 2024 13:15:24 +05002099372370@UncensoredMany of the files say "use, duplication, or disclosure ARE subject to..." but the common phrasing of this statement is apparently "use, duplication, or disclosure IS subject to..." We are already taking great delight in the fact that we are using the GPL without using Stallman's preferred declaration of it. And of course we call it open source software. When Steve Jobs died, Richard Stallman said "I'm not glad he's dead, but I'm glad he's gone." I agreed with him. When Richard Stallman dies, I will say "I'm not glad he's dead, but I'm glad he's gone." But when Bill Gates dies, I will be glad he's dead. I will celebrate.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372364Wed, 03 Jan 2024 12:01:44 +05002099372364@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372298Tue, 02 Jan 2024 16:57:06 +05002099372298@UncensoredRemove parameters no longer used

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372297Tue, 02 Jan 2024 17:00:38 +05002099372297@UncensoredBetween its origin as a shitty web application that I built when I had no idea what the hell I was doing, to all of the ways other people fucked it up later, this thing needs to die. As soon as possible.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372293Tue, 02 Jan 2024 16:38:07 +05002099372293@UncensoredUtilities displaying a color banner now use line drawing characters to form a box instead of clearing to the end of the line with the background color. The latter does not have the desired effect on all terminals.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372280Tue, 02 Jan 2024 13:42:38 +05002099372280@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372276Tue, 02 Jan 2024 13:21:39 +05002099372276@UncensoredCLIENT_TIMEOUT was found in the header files but not used anywhere. Removed. dont_term was removed because it was not needed anywhere anymore.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372270Tue, 02 Jan 2024 13:07:33 +05002099372270@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372269Tue, 02 Jan 2024 13:10:18 +05002099372269@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372193Sun, 31 Dec 2023 18:12:54 +05002099372193@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372192Sun, 31 Dec 2023 18:30:07 +05002099372192@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372062Wed, 27 Dec 2023 18:45:03 +05002099372062@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372044Wed, 27 Dec 2023 14:48:52 +05002099372044@UncensoredThis uses "fetch" followed by ".then" etc. etc. etc. and is tuned to be a design pattern for future code

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099372041Wed, 27 Dec 2023 13:53:52 +05002099372041@UncensoredStyle and comments cleanup. Some of this code is going to get copied over to WebCit-NG so we need to bring it up to our current coding standards (K&R, 1TBF, with C99-style comments)

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371762Fri, 22 Dec 2023 18:58:46 +05002099371762@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371734Fri, 22 Dec 2023 11:54:16 +05002099371734@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371731Fri, 22 Dec 2023 11:39:42 +05002099371731@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371727Fri, 22 Dec 2023 11:24:19 +05002099371727@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371723Fri, 22 Dec 2023 11:10:14 +05002099371723@UncensoredPreviously it returned a long* which contained a list of longs. Assembling this required the same allocation logic used in our array class, so now we're just using the array class.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371719Fri, 22 Dec 2023 10:52:57 +05002099371719@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371660Thu, 21 Dec 2023 16:27:31 +05002099371660@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371536Wed, 20 Dec 2023 12:13:03 +05002099371536@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371530Wed, 20 Dec 2023 11:51:12 +05002099371530@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371522Wed, 20 Dec 2023 10:50:53 +05002099371522@Uncensored1TBS is important. People who do not use 1TBS are literally Hitler.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371484Tue, 19 Dec 2023 23:12:38 +05002099371484@UncensoredAnd now that I know how to use them, I will be using more of them.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371483Tue, 19 Dec 2023 23:15:10 +05002099371483@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371479Tue, 19 Dec 2023 23:07:00 +05002099371479@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371447Tue, 19 Dec 2023 17:09:21 +05002099371447@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371301Mon, 18 Dec 2023 14:26:30 +05002099371301@UncensoredThis completes the effort to server-side-preload the attachments from the original message. They appear as attachments in the forwarded copy of the message in the composer, using the same API. A lot of effort went into making the 'attach' and 'forward attachments' functions DRY with respect to each other.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371264Sun, 17 Dec 2023 23:39:00 +05002099371264@UncensoredMostly just made stuff look nice in 132 columns

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371027Thu, 14 Dec 2023 11:30:52 +05002099371027@UncensoredNow we have an API call to load attachments from existing messages instead of from the browser. This is the server side API. Still need to integrate it into the client.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099371021Thu, 14 Dec 2023 10:29:02 +05002099371021@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370980Wed, 13 Dec 2023 17:52:18 +05002099370980@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370976Wed, 13 Dec 2023 17:25:43 +05002099370976@UncensoredAlso documented the JSON return values in api.txt

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370938Wed, 13 Dec 2023 07:49:49 +05002099370938@Uncensored

While most of us like the old interface just fine ( unless we are stuck with a phone, and dont feel like doing imap  ), i know it does turn off some new comers.  Might not hurt to do something like that so they know the future is not vaporware... They might stick around, or at least make plans to come back.

Tue Dec 12 2023 22:50:56 EST from IGnatius T Foobar Subject: Re: view_mail.js: more improvements to mail forwarding

I can add one of those corny "preview our new user experience" buttons. 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370911Tue, 12 Dec 2023 22:50:56 +05002099370911@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370907Tue, 12 Dec 2023 22:15:17 +05002099370907@Uncensored* "Fwd:" instead of "Re:" * The "--- forwarded message ---" po string is carried over from webcit-classic * Make the editor aware that a message is being forwarded * TODO: load attachments from the message being forwarded

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370900Tue, 12 Dec 2023 21:21:19 +05002099370900@UncensoredWhen an attachment is added or removed using the upload window, also update the count in the button.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370897Tue, 12 Dec 2023 21:10:57 +05002099370897@UncensoredActually it's an array of strings, and the upload module will update every div stored in there with the attachment count.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370588Thu, 07 Dec 2023 18:51:32 +05002099370588@UncensoredThis makes the Attachments: counter decrement correctly.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370580Thu, 07 Dec 2023 15:29:18 +05002099370580@Uncensoredis_quoted is now determined by whether quoted_msgnum is nonzero. In mail, we always pull quote for replies.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370486Wed, 06 Dec 2023 16:20:40 +05002099370486@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370409Tue, 05 Dec 2023 15:51:52 +05002099370409@Uncensored= 993 after last summer's effort to make it more robust. I'd be interested in hearing any feedback y'all might have on this. My test systems have been on AMD64 with both Linux and FreeBSD, and on ARM with Linux. Production is 32-bit x86 with Linux, and has also been completely stable. Does anyone have experience to report, either confirming or refuting that we made an improvement? ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370140Fri, 01 Dec 2023 14:15:35 +05002099370140@Uncensoredgit push from an airplane?  showoff Yup. :) Unfortunately I was en route to World Of Crap (AWS re:Invent) while on the plane. As a t-mobile customer I get a lot of free wifi benefits. I think they provide the ground links or something. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370132Thu, 30 Nov 2023 09:07:12 +05002099370132@UncensoredFixed the dedupe so it works before now, and also made it DRY.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099370044Thu, 30 Nov 2023 08:20:09 +05002099370044@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369979Wed, 29 Nov 2023 11:32:02 +05002099369979@UncensoredReply/ReplyAll/Forward need some things that are not strings and the source arrays seem to still be in scope, so we go with that. Need to tune this up some more. Some things are still missing, such as the references and reply msgnum.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369933Tue, 28 Nov 2023 18:52:36 +05002099369933@UncensoredNeeds a lot of work. Currently it is just a reply with no addressees filled in. It needs to not quote the message, and carry over the attachments.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369930Tue, 28 Nov 2023 18:31:41 +05002099369930@UncensoredSomewhere along the line it lost CC and only showed BCC.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369879Tue, 28 Nov 2023 09:17:51 +05002099369879@Uncensored

lol

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369862Tue, 28 Nov 2023 01:13:30 +05002099369862@Uncensored

git push from an airplane?  showoff

Mon Nov 27 2023 11:43:38 EST from rss <> Subject: serv_extensions.c: style cleanup from 30,000 feet

No, I'm not takin a broader view of the code. I'm actually on an airplane.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369836Mon, 27 Nov 2023 11:43:38 +05002099369836@UncensoredNo, I'm not takin a broader view of the code. I'm actually on an airplane.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369471Tue, 21 Nov 2023 18:22:57 +05002099369471@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369470Tue, 21 Nov 2023 18:26:46 +05002099369470@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369460Tue, 21 Nov 2023 17:52:41 +05002099369460@UncensoredAlso do that after rendering the attachments window. Doing it before doesn't work. I don't know why.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369459Tue, 21 Nov 2023 17:55:03 +05002099369459@UncensoredNow I see why he put it there in the first place. Some players (including the one in my browser) cut off the first bit of sound.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369427Tue, 21 Nov 2023 09:41:18 +05002099369427@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369386Mon, 20 Nov 2023 19:00:13 +05002099369386@UncensoredThis is handled the usual way, when we get a successful response from the HTTP DELETE method, it triggers the removal of the list element showing the attachment.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099369308Sun, 19 Nov 2023 13:39:12 +05002099369308@UncensoredMost of this was already in place. We now just run through our upload list and do an async DELETE operation for each one.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368650Thu, 09 Nov 2023 13:44:52 +05002099368650@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368396Mon, 06 Nov 2023 17:57:44 +05002099368396@UncensoredIt had the trailing dashes in it, so it was getting interpreted as the end of the message. Now that's corrected and the parsers of the world are happy. Also, we eliminated the double-nesting thing, and everything is hunky dory now.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368388Mon, 06 Nov 2023 17:51:13 +05002099368388@UncensoredThis allows us to do multipart with attachments without nested encoding.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368381Mon, 06 Nov 2023 16:56:55 +05002099368381@Uncensoredmime_parser() expects HEADERS+CONTENT but our h.request_body only contains CONTENT. The fix: our transaction struct now has h.request_body_with_synth_headers that begins with a synthetic Content-Type: header followed by a blank line and then the request body. h.request_body is now just a pointer into that buffer, starting at the position where the actual body begins. This gives us the ability to supply the body with or without headers, without having to make two copies of it.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368324Mon, 06 Nov 2023 11:48:36 +05002099368324@UncensoredLooks like I need to remove some optimization cancer from mime_parser.c, but first, a bit of style cleanup.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368323Mon, 06 Nov 2023 11:57:37 +05002099368323@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368316Mon, 06 Nov 2023 11:30:08 +05002099368316@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368142Fri, 03 Nov 2023 17:34:07 +05002099368142@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368074Thu, 02 Nov 2023 20:13:46 +05002099368074@UncensoredThe previous code used the JavaScript encoder from the stringbuf library, which is *not* the same encoding. Now it doesn't make the browser's parser barf when it encounters a control character.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099368067Thu, 02 Nov 2023 18:42:28 +05002099368067@UncensoredI really ought to be writing some real code tonight. But I get into a file and I see old style and I want to make it clean and shiny and it's easier than the kind of heavy brain work I should be doing. When faced with a heavy think, I dawdle for a long time before I really get started. I've done this since I was a child.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099367824Mon, 30 Oct 2023 10:05:20 +05002099367824@UncensoredThis is a big one with a lot of outdated style in it. Folded lines which were >80 columns but <132 columns. Add {} braces to single-line conditional blocks. Replaced C89 comments with C99 comments.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099367821Mon, 30 Oct 2023 09:49:24 +05002099367821@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099367670Fri, 27 Oct 2023 12:39:54 +05002099367670@UncensoredThis is what I do when I'm slacking off and should be doing something useful.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099367658Fri, 27 Oct 2023 09:57:43 +05002099367658@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099367293Sat, 21 Oct 2023 08:55:17 +05002099367293@UncensoredNote to self: there is something in the mailbox of admin@dev that is causing the renderer to fail and the javascript console emits unhelpful messages.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366964Mon, 16 Oct 2023 21:22:52 +05002099366964@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366958Mon, 16 Oct 2023 20:53:17 +05002099366958@UncensoredThis is what I was actually trying to accomplish a couple of commits ago. I made a race condition and that's why it was malfunctioning. This way is better and it works. It also once shot a man in Reno just to watch him die.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366954Mon, 16 Oct 2023 20:34:59 +05002099366954@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366937Mon, 16 Oct 2023 07:59:58 +05002099366937@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366936Mon, 16 Oct 2023 13:08:39 +05002099366936@UncensoredThis reverts commit fdd4f303.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366935Mon, 16 Oct 2023 13:14:27 +05002099366935@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366794Fri, 13 Oct 2023 07:45:30 +05002099366794@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366789Fri, 13 Oct 2023 12:32:40 +05002099366789@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366690Wed, 11 Oct 2023 19:55:08 +05002099366690@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366681Wed, 11 Oct 2023 19:36:29 +05002099366681@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366680Wed, 11 Oct 2023 19:44:05 +05002099366680@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366673Wed, 11 Oct 2023 18:58:46 +05002099366673@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366615Wed, 11 Oct 2023 00:18:07 +05002099366615@UncensoredIt causes the attachments window to be saved as part of the message text. Oof.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366611Tue, 10 Oct 2023 23:37:48 +05002099366611@UncensoredAlso switched from a unicode X to a fontawesome rounded-X for the 'remove attachment' button. The unicode one was too big.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366599Tue, 10 Oct 2023 19:56:09 +05002099366599@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366270Fri, 06 Oct 2023 00:31:54 +05002099366270@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366264Fri, 06 Oct 2023 00:20:27 +05002099366264@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366261Fri, 06 Oct 2023 00:10:24 +05002099366261@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366158Wed, 04 Oct 2023 18:34:10 +05002099366158@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366143Wed, 04 Oct 2023 13:49:34 +05002099366143@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366142Wed, 04 Oct 2023 15:55:26 +05002099366142@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366046Tue, 03 Oct 2023 15:26:11 +05002099366046@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366045Tue, 03 Oct 2023 15:35:01 +05002099366045@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099366040Tue, 03 Oct 2023 14:50:06 +05002099366040@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365840Sat, 30 Sep 2023 01:55:54 +05002099365840@UncensoredThis will hopefully discourage people from trying to play stupid tricks involving guessing the filename and trying to escape the containment.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365836Sat, 30 Sep 2023 01:47:08 +05002099365836@UncensoredGood clean separation of functions. This should allow us to handle uploads in lots of different places in the system.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365833Sat, 30 Sep 2023 01:27:35 +05002099365833@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365730Thu, 28 Sep 2023 23:19:43 +05002099365730@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365722Thu, 28 Sep 2023 23:14:24 +05002099365722@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365588Wed, 27 Sep 2023 14:48:29 +05002099365588@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365571Wed, 27 Sep 2023 12:29:16 +05002099365571@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365501Wed, 27 Sep 2023 01:21:39 +05002099365501@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365496Wed, 27 Sep 2023 00:59:43 +05002099365496@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365495Wed, 27 Sep 2023 00:59:55 +05002099365495@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365490Wed, 27 Sep 2023 00:44:05 +05002099365490@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365489Wed, 27 Sep 2023 00:49:53 +05002099365489@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365254Tue, 26 Sep 2023 01:13:35 +05002099365254@Uncensored"Processing dropped files..." is not exactly the right message because the upload message might have been clicked, but I don't want to throw away the translations of that message. Anyway, it's really cool, they appear in the list, and go away when the uploads are complete.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365249Tue, 26 Sep 2023 00:47:52 +05002099365249@Uncensored(They were previously the same names used in the example, natch) Also we're incrementing num_attachments

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365245Tue, 26 Sep 2023 00:35:17 +05002099365245@UncensoredReduce the number of divs and make it more generic. Allow the upload dialog to be attached to any parent div. Make the dialog appear automatically when a file is dragged into the parent div.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365239Mon, 25 Sep 2023 23:44:10 +05002099365239@UncensoredUploads now have their own div in their own separate modal. This is, of course, because I am trying to loosely couple the uploader so that it can be attached to other parts of the system when needed. Also I realized that my div names are ctdl-not ctdl_consistent with each other. Trying to fix that.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365226Mon, 25 Sep 2023 23:13:59 +05002099365226@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365157Mon, 25 Sep 2023 11:57:34 +05002099365157@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365045Sun, 24 Sep 2023 18:00:37 +05002099365045@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365044Sun, 24 Sep 2023 18:07:18 +05002099365044@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099365027Sun, 24 Sep 2023 16:38:48 +05002099365027@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099364817Sat, 23 Sep 2023 17:28:05 +05002099364817@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099364777Sat, 23 Sep 2023 15:30:57 +05002099364777@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099364663Sat, 23 Sep 2023 01:25:41 +05002099364663@Uncensored

FreeBSD's default MTA does appear to support LMTP, but there is no documentation in making it use LMTP as opposed to just writing files to disk.

Sat Sep 23 2023 00:13:27 EDT from IGnatius T Foobar

Ok, so it has to stay, then. Does sendmail not support LMTP?

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099364650Sat, 23 Sep 2023 00:13:27 +05002099364650@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099364353Thu, 21 Sep 2023 11:42:32 +05002099364353@Uncensored

FreeBSD's periodic scripts invoke sendmail.  The sendmail subsystem then invokes some sort of sendmail-like program, by default it's sendmail.  I configured the sendmail subsystem to invoke citmail.  So ya, it's still needed for FreeBSD installations who want their system maintenance scripts to put stuff in Citadel.

Thu Sep 21 2023 10:05:14 EDT from IGnatius T Foobar

*sigh*

Another day, another person who won't listen.

Quick poll for fellow Citerati out there. Does anyone think we still need the `citmail` utility? As a refresher, this program is an MDA, analagous to `procmail` or `maildrop`, that files incoming mail into Citadel mailboxes after it has been received by some third-party MTA such as Postfix or Sendmail.
However, Citadel has for a long time offered an LMTP socket, and I believe all modern MTAs can use LMTP to drop local mail to local users.

So what I'm looking for is someone to say "You're correct about that, IG; spawning a process to invoke the MDA is sooooo 20 years ago and nobody does it that way anymore" so that I can discontinue `citmail` entirely.

(The number of sites using Citadel Server with a third party MTA is vanishingly small to begin with -- but not zero.)

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099364322Thu, 21 Sep 2023 10:05:14 +05002099364322@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099364010Tue, 19 Sep 2023 19:31:15 +05002099364010@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363991Tue, 19 Sep 2023 17:26:13 +05002099363991@UncensoredThis was accomplished by disregarding any REST components to the right of the part number, allowing the filename to be placed there. The filename is sanitized to prevent script injection.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363987Tue, 19 Sep 2023 17:02:38 +05002099363987@UncensoredDisplaying each one as a link definitely makes it stand out from the message text. Display the size of each attachment -- _(bytes) is already in the webcit-classic translations Downloads are working, but the wrong file name is derived

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363946Tue, 19 Sep 2023 13:11:05 +05002099363946@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363941Tue, 19 Sep 2023 12:06:49 +05002099363941@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363848Mon, 18 Sep 2023 23:22:50 +05002099363848@Uncensored

FreeBSD Jails are the way we run multiple instances of stuffs on the same machine these days.  Oh, I need 6 instances of MariaDB?  I'll just create a few jails and call it a day.

The font is Monofur Nerd Font, as you can see in the attached screenshot.

Mon Sep 18 2023 23:04:32 EDT from IGnatius T Foobar Subject: Re: Write server PID to citadel.lock in addition to locking it.

Whoa, what font is that ?!!

I am aware that `/var/run` is the conventional location, and may yet move it there. Doing so would, however, prevent multiple instances of Citadel Server from running on the same host. There were definitely people doing that in the past, but I wonder if nowadays that is still a thing, with everyone now having virtual machines and jails and containers and all sorts of other ways to isolate multiple workloads on the same machine.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363842Mon, 18 Sep 2023 23:04:32 +05002099363842@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363835Mon, 18 Sep 2023 22:50:53 +05002099363835@Uncensored

PID files are usually in /var/run and are suffixed with "pid" as seen in the attached screenshot of my /var/run

Mon Sep 18 2023 10:21:10 EDT from rss <> Subject: Write server PID to citadel.lock in addition to locking it.

This will be useful for systems like FreeBSD that need to know a PID to monitor.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363794Mon, 18 Sep 2023 16:13:50 +05002099363794@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363786Mon, 18 Sep 2023 16:37:02 +05002099363786@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363778Mon, 18 Sep 2023 10:32:05 +05002099363778@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363770Mon, 18 Sep 2023 10:21:10 +05002099363770@UncensoredThis will be useful for systems like FreeBSD that need to know a PID to monitor.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363656Sun, 17 Sep 2023 21:19:56 +05002099363656@UncensoredDie in a hail of capitalist machine gun fire, Richard Stallman. Communism is straight from hell and so are you.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363642Sun, 17 Sep 2023 20:29:16 +05002099363642@UncensoredI have no words to describe the fuckery I am trying to reverse-enginner here. Ever heard of COMMENTS?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363286Sat, 16 Sep 2023 12:30:12 +05002099363286@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363282Sat, 16 Sep 2023 13:12:25 +05002099363282@UncensoredSanitize better. "&" is handled before "<" and ">" so it doesn't sanitize the &gt; and &lt; ampersands. Ampersands are awesome. They look a lot like treble clefs, don't they? Actually they hate each other.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363064Fri, 15 Sep 2023 23:04:27 +05002099363064@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099363063Fri, 15 Sep 2023 23:05:02 +05002099363063@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099362996Fri, 15 Sep 2023 19:43:46 +05002099362996@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099362982Fri, 15 Sep 2023 19:19:48 +05002099362982@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099361023Sat, 09 Sep 2023 16:19:13 +05002099361023@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099361022Sat, 09 Sep 2023 15:10:04 +05002099361022@Uncensored

While i am super rusty, if we need a non-prod FBSD install to beat on, i can always prop-up a VM.

I installed it on that 'box of crap' not long ago out of desperation, and enough memories did come back so i was able to get it to install ok, and some add-ons.  Tho i wouldn't be able to use it for its purpose in life due to some missing python stuff :(.  But then it promptly crashed under load. .Just like Linux/windows does . 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099361019Sat, 09 Sep 2023 15:07:28 +05002099361019@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099361007Sat, 09 Sep 2023 14:39:25 +05002099361007@Uncensored

I am not.  What is the secret incantation that makes it build on FreeBSD?

Fri Sep 08 2023 22:41:47 EDT from IGnatius T Foobar Subject: Re: Removed background and restart from citserver.

Kitty -- I hope you're having good results on FreeBSD -- please let me know if it works for you.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360935Fri, 08 Sep 2023 22:41:47 +05002099360935@Uncensored

Geez.  I can't believe how much more stable Citadel Server is with this new improved backend.  it was worth spending most of the summer working on this.

Kitty -- I hope you're having good results on FreeBSD -- please let me know if it works for you.

I've got a test running right now with the load tester running in an auto-restarting loop in one window, and in the other window Citadel Server is running under timeout(1) so it automatically dies from signal 9 after 20-30 seconds.  It's been running for close to an hour now, and no matter how catastrophically I make the server die, the database recovers cleanly on the next startup every time.  My faith in BDB's recoverability has been restored.  I'm just wondering whether we've been using it wrong for the last 20+ years (doubtful, considering LS's substantial talent at this sort of thing) or if some change came along later and silently made it wrong.

Anyway, the purpose of this exercise was originally to prepare for moving away from BDB, and we are in a position to add new backends now ... but then I unexpectedly made the BDB backend more or less bulletproof during a late-night coding and testing binge.  And so, here is the NEW plan.

1. I am not going to begin working on the LMDB backend at this time.  I want to spend my time on WebCit-NG.

2. If anyone wants to work on a backend of any type (LMDB, SQL, whatever) I'll be happy to provide whatever support you need, including modifications to the interface if needed.

3. Naturally, if any stability/durability issues are reported, fixing them will take first priority.

4. I'll do my best to keep everything buildable on FreeBSD.  It'll still require gcc and gmake for the time being, but as of right now it does work.

I'm trying to line up new hardware to run my stuff on.  Hopefully soon.  That'll be when I finally move Uncensored to a 64-bit system.  I'll proably run the container version.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360908Fri, 08 Sep 2023 21:51:54 +05002099360908@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360877Fri, 08 Sep 2023 19:59:00 +05002099360877@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360694Thu, 07 Sep 2023 10:58:36 +05002099360694@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360621Wed, 06 Sep 2023 19:21:01 +05002099360621@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360620Wed, 06 Sep 2023 20:07:24 +05002099360620@UncensoredThis is drastic, but the alternative is to purge records that are still good.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360491Tue, 05 Sep 2023 23:14:11 +05002099360491@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360490Tue, 05 Sep 2023 23:55:15 +05002099360490@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360489Wed, 06 Sep 2023 00:00:39 +05002099360489@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360488Wed, 06 Sep 2023 00:04:50 +05002099360488@UncensoredFixes a 'Brown Paper Bug' that will leak memory ... catastrophically if ctdldump is run on a big db.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360487Wed, 06 Sep 2023 00:05:01 +05002099360487@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360439Tue, 05 Sep 2023 19:09:38 +05002099360439@UncensoredThe 'edit user' and 'delete user' workflows run through the same function since the process of deleting a user simply edits them and changes their access level to 0. Add a check for cmd==25 (edit user) before asking the user if they want to change the email addresses.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099360438Tue, 05 Sep 2023 19:14:40 +05002099360438@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356620Tue, 05 Sep 2023 00:59:44 +05002099356620@UncensoredSomething about this warning makes it reference a bad pointer and crash during periods of extremely high load. I don't know why, but just leaving it alone seems to fix the problem.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356587Mon, 04 Sep 2023 15:40:43 +05002099356587@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356465Sat, 02 Sep 2023 22:28:41 +05002099356465@Uncensored

Sorry.  I have been sidetracked for about a month with work and life.

Going from upgrading the database to supporting multiple versions of the Visit records required some thought and will require rework of a lot of the implementation.  I had optimized a lot assuming the database was at one Visit version, so handling different versions requires changes to the logic and functions calls to keep it optimized.  I also re-thank the implementation of the Recent flag.

I ended up removing the branch since I needed to redo a lot and there were a lot of changes to the repository, so merging was getting out of hand.

I will be having a little more time now, so I will be going back to implement the flags.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356438Sat, 02 Sep 2023 18:06:00 +05002099356438@UncensoredThe rc system fully detaches it from the entire call stack, in the >end it just looks like init ran the daemon.  The rc system is really >just a series of shell scripts, nothing too fancy.  That's why PID >files are so important, the rc system uses those to figure out which >PID to send signals to. Cool. Give the new version a try and let me know how it works for you. We don't have the ability to auto-background anymore, but we can still write a PID file. SIGTERM and SIGINT will make the server shut itself down cleanly, and it does so much faster now. SIGKILL and SIGQUIT will make the server exit abruptly, and as previously noted, it doesn't seem to corrupt the db anymore when you do this. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356433Sat, 02 Sep 2023 18:27:59 +05002099356433@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356389Sat, 02 Sep 2023 02:59:22 +05002099356389@Uncensored

The rc system fully detaches it from the entire call stack, in the end it just looks like init ran the daemon.  The rc system is really just a series of shell scripts, nothing too fancy.  That's why PID files are so important, the rc system uses those to figure out which PID to send signals to.

Fri Sep 01 2023 16:40:26 EDT from IGnatius T Foobar Subject: Re: Removed background and restart from citserver.

I have to go examine other BSD rc scripts, but I'm guessing they simply do "&" to put a process in the background, and then they keep track of the pid so they can SIGTERM it later.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356388Sat, 02 Sep 2023 02:56:42 +05002099356388@Uncensored

FreeBSD's in-base (default) compiler is clang.  Moving all of base from gcc to clang was a monumental effort.

Fri Sep 01 2023 23:30:53 EDT from IGnatius T Foobar Subject: Re: Removed background and restart from citserver.

All righty then. The current code in git master is running on FreeBSD. Here's the deal:

1. You need ldap client library (`pkg install openldap26-client`) even if you aren't using LDAP
2. `gmake` and `gcc` are required. It won't build with whatever FreeBSD is using natively.
3. The configure script now detects whether it needs `-lresolv` and/or `-lintl` automatically
4. We now omit the `chkpw` and `chkpwd` programs on systems where they won't work. I'd actually like to remove system auth completely but I don't know if anyone is using it.

On my FreeBSD system I was able to get the server running and I ran the new `loadtest` utility with a few dozen threads beating the crap out of it. I abruptly killed the server with SIGKILL and SIGQUIT numerous times, during periods of high write activity, and even under the worst conditions it did not corrupt the database.

Looking really good here.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356378Sat, 02 Sep 2023 00:15:14 +05002099356378@UncensoredMost of these tools are now building successfully on FreeBSD.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356377Sat, 02 Sep 2023 00:22:50 +05002099356377@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356376Fri, 01 Sep 2023 23:30:53 +05002099356376@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356368Fri, 01 Sep 2023 23:27:08 +05002099356368@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356367Fri, 01 Sep 2023 23:37:20 +05002099356367@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356366Fri, 01 Sep 2023 23:42:03 +05002099356366@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356360Fri, 01 Sep 2023 20:59:34 +05002099356360@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356357Fri, 01 Sep 2023 20:29:59 +05002099356357@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356327Fri, 01 Sep 2023 16:40:26 +05002099356327@UncensoredSo FreeBSD's rc system sends a SIGTERM when you do "doas service >citserver stop".  This should run the same code that cleanly shuts >down citserver when you do a ".ATN y" from the text client.  All the Perfect. That's exactly the desired behavior, and it will be "even more that way" now. I have to go examine other BSD rc scripts, but I'm guessing they simply do "&" to put a process in the background, and then they keep track of the pid so they can SIGTERM it later. SIGINT and SIGTERM are handled by running the very same shutdown code that the server's "DOWN" command runs (which is what the text client's "<.A>dmin erminate-server ow" command executes). Unmount the databases cleanly, then exit(0) to GTFO. What's new, however, is that the database "environment" is now on mmap+disk instead of just in-memory. I don't know how we went for so many years without knowing that we had that wrong. This accomplishes two things: 1. The server no longer goes SIGSEGV when we try to close the environment 2. The database never, ever shows up as corrupted when we restart it In other words, the damn journaling system works correctly now. The funny thing is, it used to work fine even in its old form, so I don't know what's changed in the last few versions of Berkeley DB. And here we are, with a BDB implementation that's now rock solid, as a result of a two month long development effort intended to get us *off* BDB. But with that done, I'm gonna focus on FreeBSD for a while. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356304Fri, 01 Sep 2023 17:10:02 +05002099356304@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356300Fri, 01 Sep 2023 16:55:20 +05002099356300@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356294Fri, 01 Sep 2023 16:07:42 +05002099356294@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356291Fri, 01 Sep 2023 15:50:57 +05002099356291@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356268Fri, 01 Sep 2023 04:00:04 +05002099356268@Uncensored

So FreeBSD's rc system sends a SIGTERM when you do "doas service citserver stop".  This should run the same code that cleanly shuts down citserver when you do a ".ATN y" from the text client.  All the BSDs opurrate this way, and since it is a standard way of doing things, SMF (Solaris/OpenSolaris/Illumos) also supports this method of daemon shutdown.

Probably also a good idea to handle SIGQUIT and SIGKILL this way (for the odd platform that says these aren't untrappable).

If FreeBSD's rc system can't get a process to exit cleanly after a short period of time, it will SIGKILL, and that's most likely lead to database corruption on my installation.

Thu Aug 31 2023 23:39:48 EDT from IGnatius T Foobar Subject: Re: Removed background and restart from citserver.

citserver should exit cleanly when it receives a SIGINT, SIGQUIT, or
SIGKILL.

This may be why using FreeBSD's rc system caused badness on my
system.

And it so happens that FreeBSD is the reason I pulled that section of code out.

This is an opportunity to remove all of the "clever" stuff and really focus on portable, standard code.

I do feel that there's no longer any reason why a server program should have to do the work to put itself into the background. The operating system's supervisor program should be doing that. I'm sure I'll be learning more about how FreeBSD's rc system works. Seems like it's held pretty closely to Unix System III. That's fine, because I've always hated the System V init scripts.

I did release what we've got so far as Citadel 991, with some of the FreeBSD changes in place, but I'm going to keep poking at it until it builds cleanly without needing help.

Also I have an ACloudGuru account paid for by my employer and that lets me stand up cloud sandboxes for testing things. I'm going to start using that for an occasional build test, I think. The only problem is that the sandboxes

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356257Thu, 31 Aug 2023 23:39:48 +05002099356257@Uncensoredcitserver should exit cleanly when it receives a SIGINT, SIGQUIT, or >SIGKILL. > >This may be why using FreeBSD's rc system caused badness on my >system. And it so happens that FreeBSD is the reason I pulled that section of code out. This is an opportunity to remove all of the "clever" stuff and really focus on portable, standard code. I do feel that there's no longer any reason why a server program should have to do the work to put itself into the background. The operating system's supervisor program should be doing that. I'm sure I'll be learning more about how FreeBSD's rc system works. Seems like it's held pretty closely to Unix System III. That's fine, because I've always hated the System V init scripts. I did release what we've got so far as Citadel 991, with some of the FreeBSD changes in place, but I'm going to keep poking at it until it builds cleanly without needing help. Also I have an ACloudGuru account paid for by my employer and that lets me stand up cloud sandboxes for testing things. I'm going to start using that for an occasional build test, I think. The only problem is that the sandboxes automatically self-destruct after four hours, so it's not useful for much more than testing. Right now I've got the latest Easy Install build running on a Scamazon instance, with a 30-thread load test pounding away at it. I figure it's better to abuse their SSDs than mine. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356251Fri, 01 Sep 2023 00:10:28 +05002099356251@UncensoredIt was happening too late in the new code and failing on some new installations.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356250Fri, 01 Sep 2023 00:10:36 +05002099356250@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356224Thu, 31 Aug 2023 13:35:33 +05002099356224@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356223Thu, 31 Aug 2023 13:35:40 +05002099356223@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356215Thu, 31 Aug 2023 13:00:12 +05002099356215@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356214Thu, 31 Aug 2023 13:08:02 +05002099356214@UncensoredThis reverts commit c7589e99.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356213Thu, 31 Aug 2023 13:13:13 +05002099356213@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356201Thu, 31 Aug 2023 15:35:25 +05002099356201@Uncensored

citserver should exit cleanly when it receives a SIGINT, SIGQUIT, or SIGKILL.

This may be why using FreeBSD's rc system caused badness on my system.

Thu Aug 31 2023 11:10:32 EDT from rss <> Subject: Removed background and restart from citserver.

These functions should be managed by an external supervisor program.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356200Thu, 31 Aug 2023 11:10:32 +05002099356200@UncensoredThese functions should be managed by an external supervisor program.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356193Thu, 31 Aug 2023 15:32:55 +05002099356193@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356192Thu, 31 Aug 2023 10:48:43 +05002099356192@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356173Thu, 31 Aug 2023 09:43:47 +05002099356173@Uncensored

yay

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356126Thu, 31 Aug 2023 00:39:24 +05002099356126@UncensoredWhen I build from master now, when I shutdown citserver, it core dumps right >after closing the 0d database.  Since I had an issue where webcit was core >dumping and was not re-creatable by anyone else, I am wondering if this is >just me. Remember that discussion, from early July? That's part of what started this all ... and made me basically spend the whole summer overhauling the database layer instead of working on WebCit-NG. Well guess what ... it's fixed. I'm sure it had something to do with the "dbenv" and whether it was disk backed or memory backed or both, or something like that. Now that we're using what I believe is mmap'ed disk to back the environment (that's the new __db.00x files you'll see in the data directory) it no longer segfaults when closing the environment. And did I mention that since this change, it hasn't corrupted the test database even once, no matter how badly I abuse it? ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356121Thu, 31 Aug 2023 01:03:53 +05002099356121@UncensoredNo more search hooks. Modules can call each other now and that's a lot simpler. We also eliminated the index cache, because it made things a lot more complex, and a modern database is going to mmap most of the index as it gets used anyway.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356118Thu, 31 Aug 2023 00:28:30 +05002099356118@UncensoredWe don't call Unregister functions anymore because our objective is now to close the databases and GTFO when the server needs to shut down.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356115Thu, 31 Aug 2023 00:13:11 +05002099356115@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356077Wed, 30 Aug 2023 16:27:39 +05002099356077@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356043Wed, 30 Aug 2023 13:03:08 +05002099356043@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356006Tue, 29 Aug 2023 23:40:31 +05002099356006@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356005Tue, 29 Aug 2023 23:49:34 +05002099356005@UncensoredI don't want to celebrate prematurely, but we've gotten through 10,000 ops in every of 10 threads without deadlocking.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099356002Tue, 29 Aug 2023 23:30:32 +05002099356002@UncensoredAnd yet, it doesn't seem to be anything 'deep' that's making it deadlock. If I get desperate I may have to just give it its own thread or something.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355984Tue, 29 Aug 2023 18:12:04 +05002099355984@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355973Tue, 29 Aug 2023 16:03:34 +05002099355973@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355960Tue, 29 Aug 2023 14:12:09 +05002099355960@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355943Tue, 29 Aug 2023 12:00:10 +05002099355943@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355940Tue, 29 Aug 2023 12:36:36 +05002099355940@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355939Tue, 29 Aug 2023 12:44:31 +05002099355939@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355938Tue, 29 Aug 2023 12:50:22 +05002099355938@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355869Tue, 29 Aug 2023 02:01:22 +05002099355869@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355868Tue, 29 Aug 2023 02:37:59 +05002099355868@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355860Tue, 29 Aug 2023 00:53:58 +05002099355860@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355859Tue, 29 Aug 2023 00:54:50 +05002099355859@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355854Mon, 28 Aug 2023 23:38:55 +05002099355854@UncensoredThis should theoretically eliminate the need to ever call cdb_close_cursor()

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355851Mon, 28 Aug 2023 23:24:45 +05002099355851@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355845Mon, 28 Aug 2023 23:02:51 +05002099355845@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355844Mon, 28 Aug 2023 23:08:52 +05002099355844@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355839Mon, 28 Aug 2023 21:28:23 +05002099355839@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355837Mon, 28 Aug 2023 17:26:35 +05002099355837@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355834Mon, 28 Aug 2023 20:43:38 +05002099355834@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355805Mon, 28 Aug 2023 17:13:47 +05002099355805@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355803Mon, 28 Aug 2023 17:10:13 +05002099355803@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355792Mon, 28 Aug 2023 12:13:42 +05002099355792@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355791Mon, 28 Aug 2023 12:19:42 +05002099355791@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355790Mon, 28 Aug 2023 12:26:54 +05002099355790@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355761Sun, 27 Aug 2023 22:03:01 +05002099355761@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355756Sun, 27 Aug 2023 16:40:34 +05002099355756@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355719Sun, 27 Aug 2023 15:07:43 +05002099355719@Uncensored

Latest code isn't building on FreeBSD.  I has no idea how to fix this one.  So, here's a quick guide to set up a FreeBSD VM.

I'm going to assume you already have VM softwares and know how to use it.

Config:

CPU: 1 or 2

Memory: 8GB minimum for ZFS, if you do a UFS2 install you can get away with 2GB.

Disk: 50GB is moar than sufficient, use a SATA drive

Network: Just make sure it has webternet access, depending on how you do things it should also be able to access stuffs on your local network (like your VM host).  vtnet works, so use that as the network device

UEFI firmware: enable this if your VM software supports it

CD-ROM/DVD-ROM drive: use a SATA drive, this is where you'll attach the install image.

First, download the install image.  You'll want the memstick image for your hardware.  For most of you this will be FreeBSD-13.2-RELEASE-amd64-mini-memstick.img.xz

https://download.freebsd.org/ftp/releases/ISO-IMAGES/13.2/

Unpack the image and attach it as an optical media drive to your VM and boot.

Install should be self-explanatory.  This is not linux so there's no GUI installer.  Use auto-defaults for disk.

When creating your user account, you can do what I do and set the home folder inside /usr/home, this is where it's gonna go anyway due to a compatibility symlink.

 

Booting into your freshly installed system:

Log in as root.  I'm not even joking.

edit /etc/rc.conf and make sure the following lines are indeed present:

sshd_enable="YES"

If you had to add this, save the file and then: service sshd start

Now for your first installs: pkg install doas vim git git-extras gitty gitui

edit /usr/local/etc/doas.conf and make sure it has the following:

permit :wheel

permit nopass keepenv <your username> as root

If you wanna use ZSH, do this: pkg install zsh zsh-{antigen,autosuggestions,completions,navigation-tools,syntax-highlighting} git-prompt.zsh

 

Use the pw command to make ZSH the default shell for you user account (only if you wanna use zsh):

pw usermod -n <your username> -s zsh

Now you can logout, and then like a psychopath log in again, this time using your normal user account.  TEST TO MAKE SURE DOAS WORKS.  Should work with the above config, but just to test: doas cat /var/log/auth.log

Configure everything else as you would normally, keeping in mind everything will be installed under /usr/local instead of wherever the fuck linux installs stuff.  FreeBSD likes to keep softwares separate from base.

Now install Citadel's deps:

doas pkg install gmake gcc auto{conf,make} binutils, gsed, {lib,intl}tool openssl curl expat lib{ical,iconv,nghttp2,ssh2} icu gettext gettext-runtime openldap24-client readline shared-mime-info pkgconf

Whew, that was a long one.  It's okay if you decided to SSH into the VM to copy-paste that one.  Congrats, you now have a development VM to play with.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355708Sun, 27 Aug 2023 14:19:48 +05002099355708@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355646Sun, 27 Aug 2023 00:38:01 +05002099355646@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355641Sun, 27 Aug 2023 01:04:57 +05002099355641@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355640Sun, 27 Aug 2023 01:17:42 +05002099355640@UncensoredChanged that, of course. It was causing a double free.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355635Sat, 26 Aug 2023 21:29:07 +05002099355635@UncensoredIf there are multiple loadtest processes running -- and that's really the whole idea -- we will often try to delete a message that was already deleted by another process. That's not an error condition, but it would cause posts to outnumber deletes and the rooms would grow endlessly. So if we didn't successfully delete something, we go back and try deleting another one. Fun fact: the algorithm used to decide which message to delete is the same algorithm used in the 'fortune' program.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355631Sat, 26 Aug 2023 21:09:59 +05002099355631@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355628Sat, 26 Aug 2023 20:19:54 +05002099355628@Uncensoredhttps://docs.oracle.com/cd/E17276_01/html/programmer_reference/transapp_env_open.html The use of the DB_RECOVER flag to dbenv->open() appears to do more than just try to recover the environment upon startup. It also creates __db.00X files, which are perhaps holding the environment??? In any case it seems to be more solid this way. I am also removing the use of any "private" transactions, since they are no longer needed. Operations which write to the database check to see if the thread's dedicated transaction pointer is in effect, maintaining that transaction if it is, and creating a transaction in the same pointer otherwise. There is a "double free" bug somewhere in here and I'm still trying to figure out what conditions cause it to happen.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355621Sat, 26 Aug 2023 18:26:19 +05002099355621@Uncensoredopen() flags again, this time DB_CREATE | DB_INIT_LOCK | DB_INIT_LOG | DB_INIT_MPOOL | DB_INIT_TXN | DB_RECOVER | DB_THREAD ^^^^^^^^^^ The documentation says that DB_RECOVER means "run recovery before opening" but for some reason this combination of flags makes it create __db.00X files in the data directory, which I think are environment files. I'm not certain about that. But it seems to be more stable now. I've got a test system (it's on 'franklin' -- thanks Nurb432) running that I can reliably get to corrupt itself by interrupting it during a The Dreaded Auto Purger run. With any luck we'll be able to make this backend more simple and way more reliable. Just in time to deprecate it. :) ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355559Fri, 25 Aug 2023 23:17:26 +05002099355559@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355544Fri, 25 Aug 2023 13:08:53 +05002099355544@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355473Thu, 24 Aug 2023 19:47:33 +05002099355473@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355467Thu, 24 Aug 2023 18:29:04 +05002099355467@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355457Thu, 24 Aug 2023 16:06:31 +05002099355457@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355448Thu, 24 Aug 2023 15:37:18 +05002099355448@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355443Thu, 24 Aug 2023 15:16:20 +05002099355443@UncensoredIt works, but it is several orders of magnitude slower. Why?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355442Thu, 24 Aug 2023 15:23:09 +05002099355442@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355413Thu, 24 Aug 2023 10:44:37 +05002099355413@UncensoredThis makes ctdldump backend agnostic, or at least as backend agnostic as citserver itself is at this point. We will probably add some calling syntax across the board when we add more backends, but at least this utility doesn't have to be rewritten now. This makes me a happy ig. ctdlload will be next.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355393Thu, 24 Aug 2023 07:08:02 +05002099355393@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355389Thu, 24 Aug 2023 06:30:40 +05002099355389@UncensoredThat release was more than 11 years ago. Sites have had ample time to upgrade.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355384Thu, 24 Aug 2023 06:09:38 +05002099355384@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355380Thu, 24 Aug 2023 05:55:33 +05002099355380@Uncensoreddatabase.c has been moved from server/ into server/backends/common. Makefile now separates server objects from backend objects. This is all in preparation for ctdldump and ctdlload to link the backend code instead of calling BDB directly.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355310Wed, 23 Aug 2023 10:37:10 +05002099355310@UncensoredCTDLUID was probably a hard-coded preprocessor definition back in the ancient times. Now it is not.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355282Wed, 23 Aug 2023 11:52:01 +05002099355282@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355274Wed, 23 Aug 2023 06:17:28 +05002099355274@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355149Mon, 21 Aug 2023 19:54:07 +05002099355149@UncensoredThe third parameter has always been set to 0 so it wasn't ever doing anything before.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355146Mon, 21 Aug 2023 19:14:31 +05002099355146@UncensoredThis is a better practice than checking to see if the data length was 0. It now allows for extant but zero-length data to be returned.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355116Mon, 21 Aug 2023 12:45:38 +05002099355116@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355115Mon, 21 Aug 2023 12:49:58 +05002099355115@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355102Mon, 21 Aug 2023 11:09:45 +05002099355102@UncensoredThis allows us to maintain the DB_DBT_REALLOC heuristics.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355039Sun, 20 Aug 2023 17:23:47 +05002099355039@UncensoredThis would happen, for example, if we decompressed the record.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355038Sun, 20 Aug 2023 17:33:14 +05002099355038@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355037Sun, 20 Aug 2023 21:29:53 +05002099355037@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099355034Sun, 20 Aug 2023 20:54:22 +05002099355034@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354993Sun, 20 Aug 2023 10:55:42 +05002099354993@Uncensored

okay, putting html in the editor directly does not work :-P
second try:

 

Sat Aug 19 2023 23:18:20 EDT from IGnatius T Foobar

I ended up having to apply your changes manually.

ah sorry for that. i totally missed the attachment link above the reply frame. i only checked the editor icons.
replacing the br tags with a real linebreak however should be good enough.

 

Sat Aug 19 2023 23:18:20 EDT from IGnatius T Foobar

And thank you for the clarification about CPPFLAGS ... somehow after all these decades I never realized that CPP stood for "C PreProcessor" and not "C Plus Plus".

haha, my pleasure. and please delete my previous html post.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354950Sat, 19 Aug 2023 19:18:42 +05002099354950@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354947Sat, 19 Aug 2023 23:18:20 +05002099354947@Uncensored

UFarx: the formatter messed up that patch, I think.

just remove the br tags

I ended up having to apply your changes manually.  Thank you for the patch, but in the future please either post it as an attachment (good) or upload it to our gitlab as a merge request (better).

And thank you for the clarification about CPPFLAGS ... somehow after all these decades I never realized that CPP stood for "C PreProcessor" and not "C Plus Plus".

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354944Sat, 19 Aug 2023 18:42:31 +05002099354944@Uncensored************************************************************************ Before now, the Berkeley DB back end was supplied the DB_DBT_MALLOC flag and it became the caller's responsibility to handle any memory allocated and returned by cdb_fetch() and cdb_next_item(). These heuristics are not expected to be compatible with new back ends currently in planning. cdb_fetch() and cdb_next_item() now return data that is to be considered immutable (don't write to it or you'll segfault). The caller must still call cdb_free() to free the `struct cdbdata` itself, but the pointers inside it point to buffers that the back end will reuse. After a call to cdb_fetch() or cdb_next_item(), the buffers are guaranteed to be readable until the next call to one of those functions on the same table.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354921Sat, 19 Aug 2023 13:34:34 +05002099354921@UncensoredThis should be the last of them. Next step is to audit all other use of cdb_free().

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354910Sat, 19 Aug 2023 12:28:56 +05002099354910@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354727Thu, 17 Aug 2023 14:52:54 +05002099354727@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354722Thu, 17 Aug 2023 14:23:20 +05002099354722@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354721Thu, 17 Aug 2023 14:32:56 +05002099354721@UncensoredIn both cases, we return 0 to the caller and set the array pointer to NULL. This simplifies the calling convention and eliminates extra code to check for both conditions

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354713Thu, 17 Aug 2023 14:13:33 +05002099354713@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354712Thu, 17 Aug 2023 14:20:49 +05002099354712@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354708Thu, 17 Aug 2023 13:25:48 +05002099354708@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354705Thu, 17 Aug 2023 13:11:39 +05002099354705@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354513Wed, 16 Aug 2023 10:14:58 +05002099354513@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354437Wed, 16 Aug 2023 07:47:15 +05002099354437@Uncensored

 

Tue Aug 15 2023 23:46:27 EDT from IGnatius T Foobar

UFarx: the formatter messed up that patch, I think.

just remove the br tags

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354349Tue, 15 Aug 2023 19:45:24 +05002099354349@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354345Tue, 15 Aug 2023 23:46:27 +05002099354345@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354317Tue, 15 Aug 2023 18:18:31 +05002099354317@UncensoredWe have to do this everywhere. Berkeley DB can be configured to hand off ownership of memory to the caller, but LMDB cannot.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099354316Tue, 15 Aug 2023 19:14:24 +05002099354316@UncensoredA lot of the calls to cdb_fetch(CDB_MSGLISTS...) follow the same design pattern and many of them are in need of rework to handle how they free their memory. So I created a new function CtdlGetMsgList() to do it in a consistent way. Three callers have been migrated to the new syntax.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353108Fri, 11 Aug 2023 18:13:09 +05002099353108@Uncensored

here's the configure patch:

---

--- configure_O 2023-08-01 04:34:30.000000000 +0200
+++ configure 2023-08-11 23:58:52.000000000 +0200
@@ -7,7 +7,7 @@
# This program is open source software. Use, duplication, and/or
# disclosure are subject to the GNU General Purpose License version 3.

-echo
+echo
echo Running the configure script to create config.mk
echo

@@ -39,7 +39,6 @@
shift
done

-
########################################################################
# Set any missing values
########################################################################
@@ -50,10 +49,9 @@
# Configure the directory into which Citadel Server will be installed.
[ "$CTDLDIR" = "" ] && CTDLDIR=/usr/local/citadel

-# Permit override of CFLAGS and LDFLAGS using environment variables
-[ "$CFLAGS" = "" ] && CFLAGS='-ggdb'
-[ "$LDFLAGS" = "" ] && LDFLAGS=''
-
+# Per

---

i removed the hardcoded ggdb on purpose. people who want or need that can add it on their own.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353103Fri, 11 Aug 2023 17:37:25 +05002099353103@Uncensored

Fri Aug 11 2023 13:41:20 EDT from IGnatius T Foobar

I'd be pleased to see that. Maybe just do one component first so we can see what it will look like.

sure, one at a time.

Fri Aug 11 2023 13:41:20 EDT from IGnatius T Foobar

We try to make the build work cleanly on FreeBSD and Linux. There is no interest in testing on obsolete variants

sorted, no problem with cmake then.

Fri Aug 11 2023 14:36:40 EDT from LadySerenaKitty

I also limit myself to only using CMake 3.3, which is the last version made for IRIX.

oh nice, irix was my main platform for many years :-)

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353091Fri, 11 Aug 2023 12:14:09 +05002099353091@Uncensoreddbp[] is now bdb_table[] dbenv is now bdb_env

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353075Fri, 11 Aug 2023 14:57:16 +05002099353075@Uncensored

The email verification thingy doesn't seem to be workering.

Fri Aug 11 2023 08:26:21 EDT from IGnatius T Foobar

I already did the account creation thingy.

Ok, I approved the account. I guess I need to set up more alerts on that sort of thing.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353063Fri, 11 Aug 2023 14:36:40 +05002099353063@Uncensored

CMake does do a bit of automagic resolution of certain resources.  It's a common tie-in with many ports/pkg systems, so in 3 ways CMake makes building official packages on OS project build servers much easier.

I also limit myself to only using CMake 3.3, which is the last version made for IRIX.  Unless you're using a pretty extensive build system, building for IRIX is non-trivial.  CMake makes it trivial by automagically bringing in all the various library and include locations.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353054Fri, 11 Aug 2023 13:41:20 +05002099353054@Uncensoredif that's welcome, i'm happy to beef things up a little without >sacrificing any compatibility. I'd be pleased to see that. Maybe just do one component first so we can see what it will look like. We try to make the build work cleanly on FreeBSD and Linux. There is no interest in testing on obsolete variants such as Solaris, AIX, HPUX, etc. In other news, y'all may have noticed that we're scraping the Citadel commit log into this room now. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353042Fri, 11 Aug 2023 12:02:11 +05002099353042@Uncensored

 

Thu Aug 10 2023 22:04:00 EDT from LadySerenaKitty

I've never seen CMake be an issue for compatibility across multiple systems, and since it's a ready-made package for basically every OS

both is only true if you're dealing with:

1. rather recent os versions
2. mainstream systems

pure c programs like citadel are especially attractive for older and/or more exotic systems. making cmake mandatory would kill that advantage. looking at the citadel package itself, for which i proposed the changes, cmake would be overkill. with a little tuning like the things i suggested, it would be fine and remain highly compatible.

if that's welcome, i'm happy to beef things up a little without sacrificing any compatibility.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353041Fri, 11 Aug 2023 07:46:34 +05002099353041@UncensoredThis function only does file and directory level operations on the data/ directory and files in it. These operations will be common across all backends.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353035Fri, 11 Aug 2023 07:21:58 +05002099353035@Uncensored

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352907Fri, 11 Aug 2023 09:18:18 +05002099352907@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352904Fri, 11 Aug 2023 08:49:24 +05002099352904@Uncensored Therefore I am changing the API so that cdb_rewind() returns a cursor, >and cdb_next_item() must be passed that cursor with every call. As Well that was a disaster, and with more people involved now I ought to test this stuff before announcing an API change. I think I'm going to try simply moving the thread-specific stuff into berkeley_db.c and letting it handle that stuff internally instead of trying to do surgery on the module and change its inner workings. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352897Fri, 11 Aug 2023 08:27:21 +05002099352897@Uncensoredas for creating a patch, i would but if you wanna switch to cmake >anyway it might not be necessary anymore. a word of caution though >regarding cmake: CMake is interesting and I'm happy to learn about it, but we've got too much going on right now to think about switching to a new build system. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352896Fri, 11 Aug 2023 08:26:21 +05002099352896@UncensoredI already did the account creation thingy. Ok, I approved the account. I guess I need to set up more alerts on that sort of thing. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352869Thu, 10 Aug 2023 22:04:00 +05002099352869@Uncensored

With CMake, all the dependencies are listed right there in CMakeLists.txt, so someone creating a port for their OS of choice can damn near copy-paste the dependencies into the file that describes the port in whatever ports/pkg system is in use.

I've never seen CMake be an issue for compatibility across multiple systems, and since it's a ready-made package for basically every OS, build time for CMake should be a non-issue.  Even those who build everything from ports wouldn't have much issue because CMake is already used for much of the other infrastructure apps already in use.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352854Thu, 10 Aug 2023 20:46:40 +05002099352854@Uncensored

 

Thu Aug 10 2023 15:02:19 EDT from IGnatius T Foobar Subject: Re: Build System

CPPFLAGS is not used anywhere because there is no C++ anywhere in the system.

CPPFLAGS are not related to c++ but are preprocessor flags (like: -I/opt/something/include). c++ compiler options would be CXXFLAGS.

 

as for creating a patch, i would but if you wanna switch to cmake anyway it might not be necessary anymore. a word of caution though regarding cmake:

in many cases the problem with cmake is cmake itself because it has quite hefty compiler requirements. ironically often much more hefty than the actual program it's supposed to prepare. in case if citadel that would be such a case. so if compatibility is important to you, cmake is not a good choice.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352842Thu, 10 Aug 2023 18:50:53 +05002099352842@Uncensored

I already did the account creation thingy.

Thu Aug 10 2023 18:46:53 EDT from IGnatius T Foobar

Absolutely! Just go to https://code.citadel.org and create an account. You will need to use your @uncensored.citadel.org address, at least initially.
I'll approve it in short order.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352841Thu, 10 Aug 2023 18:46:53 +05002099352841@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352826Thu, 10 Aug 2023 16:20:44 +05002099352826@Uncensored

Can I pwease be granted access to the lab of git?  I promise not to hock up too many hairballs.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352814Thu, 10 Aug 2023 15:27:29 +05002099352814@Uncensored

It is nice and clean.  Additionally, it makes creating a FreeBSD port dead-simple:

https://github.com/freebsd/freebsd-ports/blob/main/security/diffcode/Makefile

The line that causes it to be built and packaged purrfectly for insertion into the FreeBSD Ports repos is line 12, "USES = cmake".  No other magic is needed.  A lot of Makefile-based projects have moar complercated ports because the locations of the output files varies widely.

Thu Aug 10 2023 15:19:38 EDT from IGnatius T Foobar

If it were up to me, the entire build system would be using CMake. 

That does look nice and clean.

My objective wasn't to stop using Make, but to stop using the GNU Autotools stuff. Those tools are built to handle all sorts of obscure edge cases that don't exist anymore. There just isn't that much variation in our target platforms anymore, so a few simple tests are all we need. As long as it builds on BSD and Linux, I'm fine with it; we no longer have to check for oddball systems with oddball libraries because no one is running Citadel on those systems anymore (and we don't have enough developer time to support them anyway).

I probably reinvented a wheel somewhere ... but it was a very basic, very simple wheel.

All of the usual criticisms of Richard Marx Stallman are included herein by reference.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352813Thu, 10 Aug 2023 15:19:38 +05002099352813@UncensoredIf it were up to me, the entire build system would be using CMake.  That does look nice and clean. My objective wasn't to stop using Make, but to stop using the GNU Autotools stuff. Those tools are built to handle all sorts of obscure edge cases that don't exist anymore. There just isn't that much variation in our target platforms anymore, so a few simple tests are all we need. As long as it builds on BSD and Linux, I'm fine with it; we no longer have to check for oddball systems with oddball libraries because no one is running Citadel on those systems anymore (and we don't have enough developer time to support them anyway). I probably reinvented a wheel somewhere ... but it was a very basic, very simple wheel. All of the usual criticisms of Richard Marx Stallman are included herein by reference. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352808Thu, 10 Aug 2023 15:10:31 +05002099352808@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352807Thu, 10 Aug 2023 15:07:21 +05002099352807@Uncensored

If it were up to me, the entire build system would be using CMake.  That's what I use in all my projects:

https://github.com/LadySerenaKitty/klaculate

https://gitlab.com/LadySerenaKitty/diffcode

https://gitlab.com/LadySerenaKitty/hexcode

https://gitlab.com/LadySerenaKitty/rotate

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352804Thu, 10 Aug 2023 15:02:19 +05002099352804@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352737Wed, 09 Aug 2023 17:37:41 +05002099352737@Uncensored

never mind. somebody moved it to the right room. these messages could actually be deleted.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352704Wed, 09 Aug 2023 12:41:57 +05002099352704@Uncensored

I could be wrong, but when you first get here, it defaults to the last room seen by a non-logged in person.  When you login, it stays there.

i always just go to the room list, to see what is new, for me.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352696Wed, 09 Aug 2023 11:19:33 +05002099352696@Uncensored

i know, it was an accident. i actually was going to post there but logging in changed the current room.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352687Wed, 09 Aug 2023 10:36:34 +05002099352687@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352682Wed, 09 Aug 2023 07:12:02 +05002099352682@Uncensored

Might want to post that in the dev room. 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352650Tue, 08 Aug 2023 21:12:28 +05002099352650@Uncensored

hello citadel team,

i have some suggestions for making the build system a bit more open:

- don't hardcode cc
the configure script and makefile shouldn't use cc but the environment variable CC. if that's not set, cc could be the fallback.

- include CPPFLAGS and LDFLAGS
the environment variables CPPFLAGS and LDFLAGS should of course be used. otherwise the tests for certain libs like ssl or iconv don't make much sense because they fail as soon as something is not in the standard system folders.

with these combined the test for libiconv for example would then look like this:

${CC} ${CPPFLAGS} $tempcc -o $tempfile ${LDFLAGS} -liconv

alternatively one could offer configure options for the required libs. for example something like --with-ssl. configure would then append include and lib to that path and add these to CPPFLAGS and LDFLAGS respectively.

in its current form the configure script is useless for anyone who does not have everything in the default system folders.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352642Tue, 08 Aug 2023 20:02:02 +05002099352642@Uncensored

Does to me.

Tue Aug 08 2023 06:15:30 PM EDT from IGnatius T Foobar

Does that sound acceptable to you all? .

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352633Tue, 08 Aug 2023 18:15:30 +05002099352633@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352611Tue, 08 Aug 2023 14:30:30 +05002099352611@Uncensored

I was mostly teasing on that. "get off my lawn" sort of thing :)

Tho as i scanned thru it seemed like one of the no-SQL sorts of things. 

Tue Aug 08 2023 09:23:09 AM EDT from IGnatius T Foobar Subject: Re: y creashRe: Database Recovery Tools

The only thing that's "all the rage with the kids" is *calling* it "NoSQL".
Berkeley DB has been a simple key/value data store for 30 years. And until recently it's worked fine for us.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352590Tue, 08 Aug 2023 13:35:23 +05002099352590@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352576Tue, 08 Aug 2023 09:23:09 +05002099352576@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352519Mon, 07 Aug 2023 18:16:34 +05002099352519@Uncensored

One of those new fangled no-sql things that is all the rage with the kids these days? 

Mon Aug 07 2023 10:44:40 AM EDT from IGnatius T Foobar Subject: Re: y creashRe: Database Recovery Tools

To be honest I'm leaning towards LMDB, 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352503Mon, 07 Aug 2023 13:51:27 +05002099352503@Uncensored

I'm a fan of SQL stuffs, like MariaDB.  It's all I use.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352486Mon, 07 Aug 2023 10:44:40 +05002099352486@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352485Mon, 07 Aug 2023 10:37:05 +05002099352485@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352478Mon, 07 Aug 2023 10:11:04 +05002099352478@Uncensored

With as long as it was gone, i figured it was not intentional. :( 

I know i cant contribute code from lack of time and i'm sooooo out of practice, but SQLite might be an easy and safe replacement? ( unless you go with the total abstraction model then its academic ) 

Mon Aug 07 2023 09:56:00 AM EDT from IGnatius T Foobar Subject: Re: y creashRe: Database Recovery Tools

Aaaaaaaaaaaand Uncensored crashed last night and took the database with it.

I don't know what the deal is with this; we've been running Berkeley DB for more than 20 years and it's never been this unstable before. But now it's a liability and I am afraid that some people will begin shying away from Citadel because of it -- if they're not already.

It has to go.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352473Mon, 07 Aug 2023 09:56:00 +05002099352473@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352429Sat, 05 Aug 2023 13:59:05 +05002099352429@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352422Sat, 05 Aug 2023 13:43:53 +05002099352422@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352412Sat, 05 Aug 2023 12:14:01 +05002099352412@Uncensored

My crash was on a dev system.  Since the DB is not in master, I just use the tar from EasyInstall and build it.

 

When it crashed, I tried to run the db_ tools and they give me the error about not having included the recovery part.  I did a clean EasyInstall and got the same error.

 

I played around with the build of Berkley and finally got it to build with my make of citadel.  The existing make file did not include the options to build the recovery part.  If I rebuilt it with configure, it worked.  I ended up with the following for my dev version.  I have a stubbed out library to check for memory leaks that I used in the db build, so that is the reason for the build order to get the header files into the ctdlsupport directory early because I delete the db files in ctdlsupport before building so it will not use a previous db versions header files.

cd $(DB_DIR)/build_unix
../dist/configure
make clean
make install_include
make
make install_lib
make install_utilities

If you are not having the db tool errors, it is just the way I build it, but since EasyInstall did the same for me, might need to be fixed, no matter how it is built.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352329Fri, 04 Aug 2023 13:55:14 +05002099352329@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352326Fri, 04 Aug 2023 13:51:15 +05002099352326@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352312Fri, 04 Aug 2023 12:25:10 +05002099352312@Uncensored

My database got corrupted and I tried to run the db_ tools and I got an error about the recovery not being compiled in.  I did an easy install and the same thing.  Can someone verify that db_verify does/does not work.  Other tools had same error message.  I had to go into the database build and run configure to generate the Makefile that would build it so it work work.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352307Fri, 04 Aug 2023 12:21:12 +05002099352307@Uncensored

Probably a role thing.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352080Tue, 01 Aug 2023 20:45:07 +05002099352080@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099352009Tue, 01 Aug 2023 11:30:47 +05002099352009@Uncensored

I do not have permissions to check in.  No button to merge and my icon shows "Cannot merge".  I am logged in.

Mon Jul 31 2023 06:25:58 PM EDT from IGnatius T Foobar Subject: Re: Merge Request Approval: IMAP memory issues with use of ConstStr

Sorry about that, it just got away from me. I approved it. Looks good.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351953Mon, 31 Jul 2023 18:25:58 +05002099351953@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351892Sun, 30 Jul 2023 20:22:53 +05002099351892@Uncensored

This is still waiting for approval.  Do you want me to bring the branch up to the head or anything else?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351805Sat, 29 Jul 2023 11:37:46 +05002099351805@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351755Fri, 28 Jul 2023 17:56:10 +05002099351755@Uncensored

While looking at the use of ConstStr, it was interesting how it was being used.  "Const" is definably not the description to use.  It really is just a StrBuf where the pointer does not need to be freed.  All sorts of code change the pointer string and really did not check what it is doing.  Probably worth replacing the use in our copious spare time lol.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351493Wed, 26 Jul 2023 08:58:29 +05002099351493@UncensoredNot sure why the parameter was empty, but a lot of code accessed ConstStr >pointers without checking for zero length and pointer was null and could >coredump, so went through and added checks. *sigh* The IMAP server was written completely with straight C pointers and string buffers and it was extensively tested as it was built. Unfortunately, the developer who added StrBuf and ConstStr to libcitadel was a little too eager and converted a lot of code all throughout the system, and introduced subtle bugs everywhere. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351492Wed, 26 Jul 2023 08:55:00 +05002099351492@UncensoredI am changing to updating the records on they fly rather than upgrading, so >the version number is really not that important.  New records use a version >signature and don't compare to the citserver version so no conflict. Sounds good. We are officially changed over from ctdlmigrate to ctdldump/ctdlload now, so if your tree has anything in the modules/migrate/ directory you can safely remove that now. We'll have to figure out how to deal with ctdldump/ctdlload with the multiple record version types, of course, but that should be straightforward. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351240Sun, 23 Jul 2023 23:01:30 +05002099351240@Uncensored

Forgot to say that I was not logged in either and that was what was causing the check-in.  I did not notice since I had access to everything.  Strange....

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351237Sun, 23 Jul 2023 22:43:56 +05002099351237@Uncensored

Had a coredump that was related to IMAP parameters and access to ConstStr.  Not sure why the parameter was empty, but a lot of code accessed ConstStr pointers without checking for zero length and pointer was null and could coredump, so went through and added checks.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351234Sun, 23 Jul 2023 22:19:58 +05002099351234@Uncensored

I am changing to updating the records on they fly rather than upgrading, so the version number is really not that important.  New records use a version signature and don't compare to the citserver version so no conflict.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351189Sun, 23 Jul 2023 13:36:38 +05002099351189@Uncensored

Got home quite a bit earlier than expected. Decided to set things up before i head out again..   Sooooo.... its up and running. Details sent via email.

Sat Jul 22 2023 10:19:29 PM EDT from IGnatius T Foobar

That is more than sufficient, thanks!

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351121Sat, 22 Jul 2023 22:19:29 +05002099351121@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351061Sat, 22 Jul 2023 17:59:03 +05002099351061@Uncensored

Let me set a box up tomorrow for you when i get back home.  A RK3588 with 8G ram ok? Couple hundred gig SSD.

We can work out connection details via PM after i get it built.

Sat Jul 22 2023 12:28:26 PM EDT from IGnatius T Foobar

I would certainly welcome having a chance to test the build on that target and see how it goes.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351008Sat, 22 Jul 2023 12:32:00 +05002099351008@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099351007Sat, 22 Jul 2023 12:28:26 +05002099351007@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350980Sat, 22 Jul 2023 09:48:42 +05002099350980@Uncensored

No. After the break in and later attacks i wiped everything, even backups as i didnt trust them after that. Would need to be a fresh install, which i doubt would be a 'good' test since it would be mostly empty.

That is why i was still offering up access here, you could beat on it as much as needed for testing between platforms. ( or i could mail you a Jetson or something :) ).

 

Sat Jul 22 2023 09:30:18 AM EDT from IGnatius T Foobar

Do you have a live system you can use as a test of source data? If so, the most excellent test would be (after I get ctdldump and ctdlload into the build) to dump your system, load the dump on another system, and go through it carefully to see if the source system was reproduced with 100% fidelity.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350976Sat, 22 Jul 2023 09:30:18 +05002099350976@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350964Sat, 22 Jul 2023 07:52:57 +05002099350964@Uncensored

i wondered what was going on. Figured it was not just an update.

While i have no users for load testing, if you want someone to at least test installs and basic ops, yell.  I can do both x86 and arm64  ( doubt arm32 is worth trying at this point ). I could do Risc-v too, but i doubt all the tools are there to make that work yet. 

And as always, the offer to prop up an ARM machine for you to have direct access to via SSH ( or vpn ) is on the table.

Fri Jul 21 2023 06:10:22 PM EDT from IGnatius T Foobar

F*****g hell. I had to restore from a backup this afternoon because my database bit the dust.

Looks like it's time to accelerate the replacement of Berkeley DB.

ctdldump/ctdlload is functionally complete, and we can start testing it.
I'm also thinking that maybe we want to split the server core and the database handler into two separate processes, so if something happens to citserver it doesn't whack the database along with it. This is something we'd get naturally with an external SQL server, I know.

*sigh*

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350938Fri, 21 Jul 2023 21:38:50 +05002099350938@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350903Fri, 21 Jul 2023 18:13:10 +05002099350903@Uncensored If not then I'll merge and then troubleshoot. I think when we tell it >not to squash the commits, it brings in your entire commit history >followed by a merge commit. Ok, I went ahead and tried it. It did exactly that. The commits that make up the merge are written to the log and credited to the person who actually wrote and submitted them. Then a commit appears at the end showing who performed the merge. I'm ok with that. The trick is to make sure the "squash commits" option is NOT checked, because that hides the details. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350902Fri, 21 Jul 2023 18:10:22 +05002099350902@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350865Thu, 20 Jul 2023 17:54:11 +05002099350865@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350849Thu, 20 Jul 2023 14:47:57 +05002099350849@Uncensored

Tried to create a new Merge Request for a different branch and when I click to create it, the page just spins and never creates it.  Something is up with GitLab....

Thu Jul 20 2023 02:28:36 PM EDT from HarlowSolutions Subject: Re: Approval Request: Memory_Leak_SmtpClient

Either I do not have permission to merge, or something is wrong with GitLab.  When I bring up the Merge Request, the left menu has a bunch of spinning updates that never complete.  I was able to assign the merge to myself, but that did not change anything, except there is a warning on my icon that says "cannot merge".

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350846Thu, 20 Jul 2023 14:28:36 +05002099350846@Uncensored

Either I do not have permission to merge, or something is wrong with GitLab.  When I bring up the Merge Request, the left menu has a bunch of spinning updates that never complete.  I was able to assign the merge to myself, but that did not change anything, except there is a warning on my icon that says "cannot merge".

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350822Thu, 20 Jul 2023 09:12:10 +05002099350822@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350643Tue, 18 Jul 2023 16:10:19 +05002099350643@Uncensored

There is a memory leak in the client.  An unused variable is being malloc'ed and never freed. 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350571Mon, 17 Jul 2023 23:54:27 +05002099350571@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099350224Fri, 14 Jul 2023 11:26:45 +05002099350224@Uncensored

After I finish up the IMAP Flags, I should have some time to contribute to the database.  I was initially thinking of SqlLite.  The trick is what database schema we want to support.  I was looking at keeping with the key/value concept and just replace database.c.  I have an idea of the schema for the database that will be efficient on database size.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349778Mon, 10 Jul 2023 22:27:26 +05002099349778@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349588Sun, 09 Jul 2023 17:57:38 +05002099349588@Uncensored So if you have support for multiple database types, each one would have a `citserver` binary, a `dump` binary, and a `load` binary. Some of these would be unnecessary if some of the back ends are SQL based and the dump format is a standard SQL dump. I see two different development paths. One is a march towards LMDB and one is a march towards SQL: (A) Blob stores only: 1. Make sure the `database.c` interface is 100% decoupled from the rest of the system. 2. Refactor `ctdl3264` into a dump-and-load program. 3. Develop drivers for LMDB, Cassandra, MongoDB, or whatever. (B) Blob *and* SQL stores: 1. The new abstraction becomes the interfaces such as Ctdl[Get|Put]User, Ctdl[Get|Put]Room, ForEachUser, etc. Refactor the code so these interfaces find their way into the pluggable side of things. 2. Add new pluggable stores for SQLite, MariaDB, etc. 3. Refactor `ctdl3264` into a program that can dump the blob stores into a standard SQL dump. (Dump and load on the SQL based back ends would use their native utilities.) I'm interested in hearing any and all good ideas! But no one gets a vote unless they commit to helping :) ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349548Sun, 09 Jul 2023 13:25:45 +05002099349548@Uncensored

MariaDB and/or MySQL

Sun Jul 09 2023 09:46:26 EDT from IGnatius T Foobar Subject: Re: Master: citserver coredump on Shutdown

Grrr. Unrecoverable error on my database this morning. I think maybe it is time to put Berkeley DB out to pasture after all.

Let's think about what we want the next to look like.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349525Sun, 09 Jul 2023 09:46:26 +05002099349525@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349108Wed, 05 Jul 2023 21:09:30 +05002099349108@UncensoredPretty consistent for me.  I put a check in the Berkley code to work around, >but not sure of the root cause either. Something must be getting double freed, but I can't figure out what. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349105Wed, 05 Jul 2023 21:08:56 +05002099349105@UncensoredI just realized that a Seen message set of *:2099348686 means all messages >have been seen.  Were all your messages unseen before the upgrade?  I do A seen message set of *:2099348686 means all messages have been seen up to and including 2099348686. We are using what RFC 3501 (IMAP) refers to as a sequence set. If you dig through the RFC's you can read all of the BNF notation, after which you will give up and throw things at your screen. But it's pretty simple to read (maybe not to manipulate, but definitely to read) once you understand it. A sequence set is basically zero or more atoms separated by commas. Each atom can be one of five things: m (a message number) - describes exactly one message. For example: 1,2,3,10,11,12 That means exactly those six messages, and no others, existing or future. m:n (a range) - describes all messages from m to n inclusive, including any new messages that may appear inside that range in the future. For example: 1,2,3,10-12 The above example means messages 1, 2, 3, and everything from 10 to 12 inclusive. If message 11 exists it is included. If message 11 does not exist but appears later on (for example, someone moved it in to the mailbox/room from elsewhere) it is included. *:n - a range from zero to n, inclusive. You'll see this a lot in Citadel; it means "all messages up to and including n" m:* - a range from m to infinity. You'll almost never see this because it excludes any new messages that are added in the future, which isn't exactly desirable. * - all messages, any number, current or future. Again, you'll almost never see this because it excludes any new messages that are added in the future. So if someone picks through a mailbox selecting and deselecting messages, you might see something like: *:124,160,199,200-207,315 Clear as mud, right? ;) To answer your question: when I tested it I had unread messages in quite a lot of rooms. After the conversion they were all marked as read even though I had not read them. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349054Wed, 05 Jul 2023 17:50:32 +05002099349054@Uncensored

Pretty consistent for me.  I put a check in the Berkley code to work around, but not sure of the root cause either.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349053Wed, 05 Jul 2023 17:49:13 +05002099349053@Uncensored

Duh.  Button next to Comment button.  I closed.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349043Wed, 05 Jul 2023 17:26:18 +05002099349043@UncensoredI was trying to figure out how to reject the request myself.  Does not look Do you have the button "Close merge request" on the bottom of the screen? ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349042Wed, 05 Jul 2023 17:25:46 +05002099349042@UncensoredIt looks like the Berkley code is passing a NULL to a memory free routine >that does not check for NULL.  Anyone else having a problem?  If not, I >will look into how I build the server. It happens to me too, some of the time, and I have been busting my butt trying to figure it out. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349021Wed, 05 Jul 2023 15:51:20 +05002099349021@Uncensored

I just realized that a Seen message set of *:2099348686 means all messages have been seen.  Were all your messages unseen before the upgrade?  I do ignore Visit records when upgrading that look bad.  If they got skipped, the message set would be blank and all messages would show as unseen after the upgrade.  Can you check in the log to see what the message says about the conversion.  Should show a count of any records were invalid/skipped.

Wed Jul 05 2023 01:48:13 PM EDT from HarlowSolutions Subject: Re: Merge Request: Support_IMAP_Flagged_Deleted_Draft_Recent_flags

I was trying to figure out how to reject the request myself.  Does not look like you can.  I Googled and others were talking about how GitLab was lacking that option.  If you can figure out how to reject or delete it, I will not be offended unless you don't tell me how :-)  Otherwise I will just update the branch and I think the request will get updated.

Thanks for the string.  I will play with it.  In my testing, the upgrade worked on Seen, but not very extensive examples.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349013Wed, 05 Jul 2023 14:53:50 +05002099349013@Uncensored

When I build from master now, when I shutdown citserver, it core dumps right after closing the 0d database.  Since I had an issue where webcit was core dumping and was not re-creatable by anyone else, I am wondering if this is just me.

It looks like the Berkley code is passing a NULL to a memory free routine that does not check for NULL.  Anyone else having a problem?  If not, I will look into how I build the server.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099349002Wed, 05 Jul 2023 13:48:13 +05002099349002@Uncensored

I was trying to figure out how to reject the request myself.  Does not look like you can.  I Googled and others were talking about how GitLab was lacking that option.  If you can figure out how to reject or delete it, I will not be offended unless you don't tell me how :-)  Otherwise I will just update the branch and I think the request will get updated.

Thanks for the string.  I will play with it.  In my testing, the upgrade worked on Seen, but not very extensive examples.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348984Wed, 05 Jul 2023 12:13:26 +05002099348984@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348924Wed, 05 Jul 2023 01:10:47 +05002099348924@Uncensored

Thanks for the feedback.  My testing only had a small database, so 10 min is rather bad.  I think switching to doing the conversion when accessed is the best idea.  It is simple since that is how I did it before I switched to the upgrade.  I only have to add some code to one function.  I am going to look into why the conversion did not work to make sure it is not an error that will occur when I do it on demand.  I would be interested in the Seen message set string that caused it to fail.  May be the pattern that is not being processed correctly.

I will update the branch and submit a new request when I am ready.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348686Mon, 03 Jul 2023 13:23:05 +05002099348686@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348675Mon, 03 Jul 2023 11:30:05 +05002099348675@UncensoredThat seems to imply that Sqlite might be a better option than >MySQL/MariaDB because we do *not* want to require people to install a >working database server before Citadel can be installed. Devil's Advocate from an Armchair Programmer: these days, if you bundle an app as a Docker image it's easy enough for the user to just spin it up. Docker image takes care of all the database bundling. Since it would be >1 process per image (database, citserver, maybe also webcit) you would need to run them under supervisord ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348566Sun, 02 Jul 2023 17:22:09 +05002099348566@Uncensoredkipped out of the room instead of otoing, leaving that message unmarked. When I returned to the room, it correctly showed as "1 new message". So the ongoing operation appears correct, it's just the conversion that has an issue. I love how you cleaned up the API. Bravo on that. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348467Sat, 01 Jul 2023 18:43:47 +05002099348467@UncensoredIf you want to stay with index/data for the database, I think I might go back >and see if I can finish up a database.c replacement with MySql.  What I Hey, I'm totally cool with moving to a SQL database, if someone else is doing to be doing the bulk of the work. Seriously. I am just one person and I need to focus on getting our web interface looking like it wasn't written 15 years ago. If you're serious about doing it, we can talk about the parameters and requirements. Obviously the primary requirement would be for it to be ultra-stable, preferably able to take abuse better than Berkeley DB can. But another requirement would be for it to remain ridiculously easy to install. That seems to imply that Sqlite might be a better option than MySQL/MariaDB because we do *not* want to require people to install a working database server before Citadel can be installed. If we're going to go SQL rather than NoSQL, it would make sense to take advantage of the schema layer. For example, functions like CtdlGetUser() and CtdlPutUser() would end up doing the work of mapping table columns to/from elements in the server's internal data structures. There's a project called DBmail [ https://dbmail.org/ ] that is basically an IMAP server that uses a SQL database as its store (but has no other features; no user interface, no groupware/collaboration stuff, requires an external MTA, etc) but it's been maintained for some time so it's definitely possible to use a SQL database for that purpose. So if you're serious about it and want to commit the time to it, and we can keep it *easy* for users to install (and to migrate to it) -- we can definitely explore that. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348383Fri, 30 Jun 2023 17:23:23 +05002099348383@Uncensored

No rush on the review.  I had to put the code aside for a while (pesky day job :-)  and had to write some tests to try to hit most code paths.

I tried not to change too much existing code since the change is pretty big to begin with.  I only tried to rewrite things that affected performance or optimize using the new functions.  I tried to use the profiler (-pg) but was not able to get citserver to output the profile file, so I really have not tested before/after.  If you know how to get the profiler working, I would be interest in seeing where we can optimize things for the biggest bang for the buck.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348379Fri, 30 Jun 2023 17:16:00 +05002099348379@Uncensored

If you want to stay with index/data for the database, I think I might go back and see if I can finish up a database.c replacement with MySql.  What I don't have is the statistics for a large email server (mine is very small).  I wrote a small C program that went through all the Berkley databases and found the min/max sizes for the indexes and data so I could see what the best implementation would be.  If you have a large db, I can send you the program just to get the stats (unless you have dome this before).

For memory leaks, I have been dealing with detecting them for years for a variety of companies.  I found the best for C was to ifdef allocation/checking code and only use for testing.  I used macros to replace the malloc functions with some header changes so you can activate your own routines without even having to edit all the allocation function calls.  Then just have the checking functions allocate more memory than requested and put signatures before and after the allocations so you can track leaks and detect memory over/under runs.  Slows things down a bit, but very good at identifying memory issues when testing.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348352Fri, 30 Jun 2023 11:36:04 +05002099348352@UncensoredJust to chime in, the database.c code is very clean.  The only problem I >have had with Berkeley is that if the code or system crashes, most of the >time, the database is corrupted and recover does not help sometimes and I >have to revert to a backup.  The code has become a lot more stable so not as >big an issue anymore for me. That's why some time ago we made a decision to get rid of all cleanup code except that which has to do with closing the database. Nothing else matters. There was one developer who was with us for a few years who loved to use Valgrind for leak detection, and he did a great job at that, but the cost of it was a very complex server shutdown. In practice, sometimes it never reached the point where the databases got closed, either because the server itself was crashing, or something else went wrong. Switching to something else will be a big job, which is why we haven't done it yet. It isn't so much the writing of the new back end that is the problem, but the conversion of all the existing installations out there. There are quite a lot of them. We've done it before. We went from flat files to GDBM and then eventually to Berkeley DB. At the time we built external tools to convert the database offline. We might consider doing that again. My current thinking is that maybe we abandon serv_migrate.c and then change ctdl3264.c into an offline export/import utility with an architecture-independent and database-independent export format. But for now, I plan to refocus on WebCit-NG, which is now several years behind schedule because of all the side quests. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348348Fri, 30 Jun 2023 11:20:19 +05002099348348@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348309Thu, 29 Jun 2023 21:56:54 +05002099348309@Uncensored

Just to chime in, the database.c code is very clean.  The only problem I have had with Berkeley is that if the code or system crashes, most of the time, the database is corrupted and recover does not help sometimes and I have to revert to a backup.  The code has become a lot more stable so not as big an issue anymore for me.

I did think about making a drop in replacement for database.c using MySql.  I started to play with it with the concept of key tables and having a set of tables with different sized blobs so you could store data records across multiple tables to optimize database size.  Did not get to the point where I could compare performance with Berkley, but it looked promising.  Optimally, not using indexes and rewriting all the code to use MySql tables and features would probably be the best, but a lot of work....

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099348305Thu, 29 Jun 2023 21:42:33 +05002099348305@Uncensored

Touched a lot of files and complete rewrite of Visit support functions.  Most of the logic centralized in user_ops.c to keep it clean and tried to optimize code and performance.

If you have any questions let me know.  I left merge request unassigned.  If you approve without any changes, I will plan to approve the merge as you said.

Building and Testing:

1. This version will upgrade the database records and the database will no longer be reverse compatible.  Recommend copying your database and restoring after testing.

2. I changed the REV_LEVEL for citserver to 981 and my Visit record is also 981.  When generating the new release with do-release.sh, you will need to change the REV_LEVEL back to 980.  If you release before merging the Visit code, the Visit version number will also have to change.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099347768Fri, 23 Jun 2023 15:35:42 +05002099347768@UncensoredNot sure if regression, but if you try to sent a message with a blank body, >webcit coredumps.  Just checked for empty message text and skipped trying to >output. I wasn't able to reproduce the problem but the patch looks like it will add some safety so I pulled it in anyway. In the future I think I'm going to just approve merge requests and then you can do the actual merge so that the commits appear in your name instead of mine. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099347716Fri, 23 Jun 2023 10:32:15 +05002099347716@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099347610Wed, 21 Jun 2023 13:54:16 +05002099347610@Uncensored 2023-06-20 15:02 from IGnatius T Foobar >Subject: Re: Long term plans for phase-out of Berkeley DB? > > Heh. Most of the database layer is still pretty much the same code >you wrote 22 years ago. You did a great job on that. As I recall, I interpreted their documentation pretty conservatively--any ambiguity or complexity was seen as a "well don't do it that way, then" situation, and so I ended up being pretty strict, global, and single-threaded about the locking model--so it should be stable, but it prevents you from doing some things that might perform a little better. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099347523Tue, 20 Jun 2023 15:02:04 +05002099347523@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099347515Tue, 20 Jun 2023 14:11:48 +05002099347515@Uncensored 2023-06-15 13:32 from IGnatius T Foobar >Subject: Long term plans for phase-out of Berkeley DB? > > A bit of thinking out loud with regard to long term plans for Citadel >Server. > > Berkeley DB seems to have gained a bad reputation in the open source >community. > Much of it began in 2013 when Oracle switched it from the Sleepycat >license to the AGPL. Debian discontinued updating it completely, which >of course makes Citadel's life difficult because we have to bring in >our own version of it, and that can create conflicts with the ancient >version that's already on the system, which can't be removed because >there are still things dependent on it, etc. etc. Well, this brings back memories. I would imagine you can avoid most system-level conflicts by configuring it with an alternate --prefix. who knows how much a burden it will be if the source becomes incompatible with the next version of Linux, though. My answer would be to use SQL, even if only sqlite. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099347255Sat, 17 Jun 2023 10:46:50 +05002099347255@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099347081Fri, 16 Jun 2023 00:14:40 +05002099347081@Uncensored

Not sure if regression, but if you try to sent a message with a blank body, webcit coredumps.  Just checked for empty message text and skipped trying to output.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099347026Thu, 15 Jun 2023 13:32:06 +05002099347026@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099346909Wed, 14 Jun 2023 12:24:38 +05002099346909@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099346893Wed, 14 Jun 2023 10:42:50 +05002099346893@Uncensored

That is not the branch that was merged.  It is the new one to actually add support for all the flags.  I ran into some issues testing so I am working on it locally.  Should be updating the branch and submitting soon.  Adding the flags is a big change (hopefully for the better), but touches a lot of files.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099345459Sun, 04 Jun 2023 22:23:10 +05002099345459@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099345362Sun, 04 Jun 2023 10:00:38 +05002099345362@Uncensored

I am completely new to Git and commits, so I did not realize there was a standard :-P

 

Thanks for the feedback and access.  I'll now shut up and code :-)

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099345307Sat, 03 Jun 2023 23:57:40 +05002099345307@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099345292Sat, 03 Jun 2023 21:47:41 +05002099345292@Uncensored

Ok.  I have gotten my feet wet, so now I have a couple more questions.  I am trying not to be annoying, but I seem to be running into things that I am not sure how to handle.  Just let me know if I should shut up and code :-)

As you have seen, I have been creating rather long, detailed commit information.  Do you want this type of detail in the commit or do you just want a smaller summary?  I am writing like I am providing details for a code reviewer.  If you don't want all the detail in the commit, I could add a message here with the details when I submit the merge request, or maybe there is something in GitLab we can use?

Is there a list of issues or enhancements that we can review and maybe work on?  I am willing to put in some effort to help with it.  This might be something that we could use the Issues in GitLab for.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099345010Thu, 01 Jun 2023 22:04:59 +05002099345010@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099345007Thu, 01 Jun 2023 21:42:49 +05002099345007@Uncensored

Did not mean to attach the patch in the last message.

It looks like Merge requires you to create a branch to merge.  Do you have any naming conventions you would like to use for branch names or is there a different way you want to submit code?

Thu Jun 01 2023 09:32:30 PM EDT from HarlowSolutions Subject: Re: Daily commit digest for Citadel (CDB_VISIT)

GitLab looks nice.  I figured out how to clone and I created a patch.  I will go and try to use merge.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099345004Thu, 01 Jun 2023 21:32:30 +05002099345004@Uncensored

GitLab looks nice.  I figured out how to clone and I created a patch.  I will go and try to use merge.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099344969Thu, 01 Jun 2023 16:49:35 +05002099344969@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099344653Tue, 30 May 2023 09:27:14 +05002099344653@Uncensoredfixed a couple of defects with the existing code that I am just going to >include with the new flag support.  Small but if you want me to submit >separate, let me know. I'd like it if you did that, please. If for no other reason, it would be a great way for us both to get used to how merge requests get handled on our new GitLab system. Also, I'm thinking about doing something similar with the Use Table database so we might as well put it all in at the same time. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099344583Mon, 29 May 2023 23:49:36 +05002099344583@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099344331Sat, 27 May 2023 18:03:59 +05002099344331@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099344109Thu, 25 May 2023 20:08:49 +05002099344109@Uncensored

I am testing a complete replacement for the Visit handling.  Looking good so far, but since we don't have a set of tests to check for regression, I am just running it and trying to hit as many code paths as I can.   In order to add all the IMAP flags, I had to pretty much rewrite the related code.  I fixed a couple of defects with the existing code that I am just going to include with the new flag support.  Small but if you want me to submit separate, let me know.

The best one is that when you purge a user, it assumes that the associated Visit record's user number is the top of the key.  It is actually the third, so it is trying to delete all Visits with a room number that matches the user number :-P 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099344049Thu, 25 May 2023 11:23:02 +05002099344049@Uncensoredproblem.  The server will operate fine for about an hour then it starts >deleting users without me being in the interface.  The stranger part is that This room isn't really for support issues, but you might want to check the time and date on your system. Also be sure that you're using a database from the same build (AMD64 or ARM32 or whatever). ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099344048Thu, 25 May 2023 11:20:57 +05002099344048@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099343887Wed, 24 May 2023 10:25:03 +05002099343887@Uncensored

I'm not sure if you want this kind of message in the Development area but I thought it might be better here.

I've installed the latest build on a clean version of Linux (Fedora 38) using Easy Install.  The install worked fine but it is having the strangest problem.  The server will operate fine for about an hour then it starts deleting users without me being in the interface.  The stranger part is that the user is not really deleted.  I can't login as the user so I go in as admin.  Once I'm in as admin the user does not appear in the user list but if I try to add it, it says it already exists.  I'm in a pretty bad way because I overwrote my Linux server with this build and it's not stable.  I've tried re-installing it cleanly twice and it's producing the same results.  Not sure what to do at this point because it's disabling my user and I can't fix it.

Regards,

Allen

 

 

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099343849Wed, 24 May 2023 06:29:23 +05002099343849@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099342602Mon, 15 May 2023 06:26:32 +05002099342602@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099342552Sun, 14 May 2023 21:05:40 +05002099342552@UncensoredNoticed flags were getting set wrong in Outlook and in WebCit.  I thought I >had introduced the bug(s).  Finally realized that the bugs were in the >release and had nothing to do with my code.  Spent way too much time >debugging my code :-) I've seen it malfunction but never quite figured out why. Thanks for the patch. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099342499Sun, 14 May 2023 10:45:57 +05002099342499@UncensoredNow to the issue: How do you want to support the change to the structure and >falling back to older versions of the mail server.  My implementation reads First of all, I love your idea and we should definitely do it. If I'm reading your description correctly, it could potentially mean we can add all sorts of arbitrary flags in the future, which would be really useful. To handle moving to the new version of the table structure, take a look at serv_upgrade.c to see an entire history of how we've done such things in the past. When the server starts up, it compares its version number to the config variable `MM_hosted_upgrade_level` which tells us the version number of the server that was running the previous time the database was opened. Then we go through a bunch of routines which basically go "if the version number is older than `x` then we need to do so-and-so upgrade..." and then when all of those conversions have been run, it sets `MM_hosted_upgrade_level` to the current running version of the server. At startup, if the version of the database is *newer* than the version currently running, the server immediately exits and tells the operator to upgrade it. We do not, under any circumstances, support moving backwards, so you don't have to worry about that. We'll need to patch serv_migrate.c to handle the new table format, but I'm actually thinking about abandoning that module because it doesn't really work too well on extra-large data sets. I'm quietly developing `ctdl3264.c` which is an *offline* conversion utility that I started hacking together to convert my own database from 32-bit to 64-bit, but I'm starting to realize that it could actually be a pretty good dump-and-load tool with a little extra effort. Thanks for the great idea and the willingness to implement it. Looking forward to seeing what you come up with! ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099342270Fri, 12 May 2023 23:30:53 +05002099342270@Uncensored

I am working on the changes to implement support for making the Flagged, Deleted and Draft flags persistent like the Seen and Answered flags.  Instead of just adding more large buffers to the Visit structure, I have implemented them by removing the buffers from the structure and storing all the message set strings after the structure in the database record.  The strings are just copied one after the other, so only the string values are saved.  Should greatly reduce the database space used by the views.

On loading a View record, a list of StrBufs stores the values until they are written to the database.  This should greatly reduce the database space used to store the records for even the current records (Seen and Answered) which take up 8K in buffers and putting the message list strings into dynamically allocated StrBuf links is pretty efficient.  I also added a version number to the view structure to make it easier to change the structure in the future, and was required since my version of the structure is smaller than the original and I could not use the size of the database record to determine the version like the existing code does since my version’s database record size depends on the total size of the message set strings which could match the old version’s size.

Now to the issue: How do you want to support the change to the structure and falling back to older versions of the mail server.  My implementation reads the database record and will determine if the record contains the old Visit structure or the new (based on the version number in the new structure which will never match the binary value in the older versions).  If old, it converts it to the new, and the new is used in the rest of the code and the new version replaces the old when written.

The issue with this is that once you start the server with this code, you cannot fall back to an older version of the server since the old structure is not compatible with the new structure.

If we need to support falling back to older version(s) for a while (e.g.  until the next release or two), I can only think of one way to implement it without maintaining multiple records:

• Keep the old version in the top of the database record and add the new one after.  When reading, the new version would detect the appending new structure and use it.  The old code would just read the old version of the structure and the new version would be lost on write.  Downsides:
  • Database records will remain to be about 8K (old version size) plus the new persistent flags (would not be in large buffers at least).
  • If you fall back, you lose the persistent data of the new flags when going back to the later.

What is the development philosophy on falling back?  Do we need to maintain the ability to fall back?  How many releases?  If we need to fall back, what option should be implemented (1, 2 or another idea)?  Both ideas are a bit ugly.

Also, I only update the database records to the new version if they are saved, so a mixture of old and new records will be in the database unless we go through every room and convert.  Is this type of thing ever done (one time upgrade)?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099341791Thu, 11 May 2023 22:24:45 +05002099341791@Uncensored

I have been working on implementing message sets for Flagging, Draft, etc.  Noticed flags were getting set wrong in Outlook and in WebCit.  I thought I had introduced the bug(s).  Finally realized that the bugs were in the release and had nothing to do with my code.  Spent way too much time debugging my code :-)

Only one line changes but wanted to keep separate from other work.

------------------------------------

serv_imap.c (citserver)/roomops.c (webcit): bugfixes to message flag handling (Phil Slack)

serv_imap.c: IMAP message flags are not initialized when loading messages.  imap_set_seen_flags() is passed the index of the first message to process.  It is zero based, but the function error check rejects a value of zero, so the flag for the messages in the room updated.  Changed check to allow zero.

roomops.c: Mail messages in a room are set to Seen when just viewing the room. A mailbox room view can be a mailbox view or a json list view.  dotgoto() did not handle when set to json and set all the messages to Seen. Changed to handle a json view the same as a mailbox view.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338961Fri, 05 May 2023 06:27:49 +05002099338961@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338890Thu, 04 May 2023 18:17:39 +05002099338890@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338859Thu, 04 May 2023 14:25:50 +05002099338859@Uncensored

Attached is a patch to fix the cprintf() function in Citadel.  It was not handing truncation properly and could output invalid data.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338850Thu, 04 May 2023 13:10:19 +05002099338850@Uncensored

I am not sure where the EasyInstall script is, but there is an issue on at least on CentOS and Rocky Linux when systemd starts citserver.  I am not sure if it is an issue on other Linux systems, so someone may know if what I did to fix it is portable.

citdel.service uses a target of network.target.  I found there is a race condition when citserver is starting up where the network startup is not ready and citserver fails to open the listening ports.  I had to change network.target to network.online.target to ensure the network is up before citserver is run.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338822Thu, 04 May 2023 09:58:32 +05002099338822@Uncensored

Phil Slack

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338816Thu, 04 May 2023 09:42:20 +05002099338816@Uncensored 2023-05-03 16:12 from HarlowSolutions By what name do you want to be credited in the documentation? (oh and thanks for the patch!) ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338751Wed, 03 May 2023 19:44:18 +05002099338751@Uncensored

Thanks.  Will do.

 

Mon May 01 2023 23:40:06 EDT from IGnatius T Foobar

Welcome awrdgrs and sharivegas!

Three new contributors in just a couple of days. This makes me very happy
:)

Please read the last couple of days worth of messages in this room. It will serve as a quick introduction to the project and how to get started as a contributor.
There's plenty to do and all three of you have submitted nice clean patches so far. VERY MUCH APPRECIATED!

We generally like to say "work on whatever interests you" but if anyone wants some ideas I might be able to suggest a few things.
\

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338725Wed, 03 May 2023 16:12:47 +05002099338725@Uncensored

Main issue is stripout() looses a character when stripping.  Reworked both stripout() and stripallbut() to be consistent in handling strips.  Actually runs faster than original code.

For multiple boundaries, stripout() mangled the resulting string and stripallbut() just returned the original.  I made consistent by looking for the first and last occurrence of the boundary character.  If you think the boundaries should be handled differently, let me know.  Really should not happen in the real world very often, but should be consistent.

There is also a flush of stderr in stripallbut() which I am not sure why is there.  stderr is not buffered, so flushing does not do anything, but that is out of the scope of this issue, so I just left in.

----------------------------------------------------------------------------------------------

Fix LibCitadel stripout() function removing characters.  Make strip functions boundary handling consistent. 

 

libcitadel/lib/tools.c

  stripout()

    Strips too many characters.  Causes incorrect From address on inbound and probably other places.

       stripout(“Foobar<foobar@foobar.com>”) = Fooba.  Should be Foobar

    Mangles multiple boundaries. Should strip using outer boundaries.

      stripout(“ABC()(DEF)()GHI”) = ABC()(DEFGHI.  Should return ABCGHI.

  stripallbut()

    Handle outer boundaries like stripout()

      stripallbut(“ABC()(DEF)()GHI”) returns unchanged.  Should return )(DEF)(

    Code does a stderr flush.  Not sure why, but left it in.

  string_trimlen()

    Removed function.  Not used anywhere in the code and less efficient than string_trim()

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338596Wed, 03 May 2023 06:27:23 +05002099338596@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338529Tue, 02 May 2023 17:50:06 +05002099338529@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338504Tue, 02 May 2023 14:29:21 +05002099338504@Uncensored

The bootstrap was the part I was missing.  Thanks.

For webcit, I am glad to hear that it is getting rewritten.  At one point, I tried to fix the calendar so it would work as an internet calendar in Outlook, but after a bunch of work, it was not worth it.  Got it talking to Outlook, but then I found there were bugs in the iCal library and just decided it was not worth spending any more time on it.  I ended up using iCloud to share calendars.

One thing I will submit a patch for is the recipient handling.  Some of my users caused core dumps because of long addresses.  It looks like the address length is limited to 256 and the total recipient line is limited to 900 characters.  I think these were probably from the standard, but I have found that many mail servers violate the standard.  Is there any reason to limit these in the server?  For my implementation, I just bumped up both to handle SIZ (4096) throughout the code and have not seen any issues.  Any reason I should not be allowing it?  If there is, I can just add the code to avoid the core dump. 

Out of curiosity, why are the Makefiles built for libcitadel and webcit, but are checked in for citadel and textclient?

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338498Tue, 02 May 2023 13:50:40 +05002099338498@Uncensored

The build is currently broken with the last changes.  citadel/bootstrap is still referencing citadel.h.  Should be citadel_defs.h.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338444Tue, 02 May 2023 06:27:17 +05002099338444@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338393Mon, 01 May 2023 23:40:06 +05002099338393@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338379Mon, 01 May 2023 23:15:20 +05002099338379@Uncensored Date: Mon May 1 23:15:18 2023 -0400 Dockerfile: install textclient to /usr/local. Thanks to sharivegas ----------------------------------------------------------------------- Summary of changes: Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338370Mon, 01 May 2023 22:34:08 +05002099338370@Uncensored because, as you've probably guessed, those get fed into a translator for international languages and if you change the string it throws away all of the translations. And you probably also noticed that WebCit is being completely rewritten, because it's based on 27 year old spaghetti code that's been so badly abused that it isn't worth trying to fix. The template engine in particular is super ugly -- it was meant to separate the code from the markup but it ended up being even harder to work with than it was before. When you get your development system up and running you'll be able to look at webcit-ng and see how it's coming together. As for how to build the development system -- you can take a look at the build script for either the Docker container or Easy Install to get an idea of how it comes together. [ https://easyinstall.citadel.org/install ] That's a good place to start. Ignore the bit about `ctdlvisor` since that's container specific. Basically, the order goes like this: 1. Install the development packages for all dependencies ... on a CentOS system that would be yum groupinstall "Development Tools" yum install \ zlib-devel \ openldap-devel \ openssl-devel \ libcurl-devel \ libical-devel \ expat-devel \ readline-devel 2. Install the Berkeley DB library -- download it from https://easyinstall.citadel.org/db-6.2.32.NC.tar.gz and unpack it, then cd db-6.2.32.NC/build_unix ../dist/configure --prefix=/usr/local --disable-static --disable-compat185 --disable-cxx --disable-debug --disable-dump185 --disable-java --disable-tcl --disable-test --without-rpm make make install 3. Clone the git repository git clone git://git.citadel.org/citadel 4. Build and install libcitadel cd citadel/libcitadel ./bootstrap ./configure make make install 5. Build the Citadel Server. I usually run it from the build directory, in the foreground, when I'm using it. cd citadel/citadel ./bootstrap ./configure make and then run it with: ./citserver -x9 -h`pwd` 6. In another window, build WebCit. I usually run this from its build directory as well. cd citadel/webcit ./bootstrap ./configure make and then run it with: ./webcit -p80 uds ~/citadel/citadel 7. If you want the text mode client, it's the same routine again, but in citadel/textclient That ought to be enough to get you started. Thanks for your interest in helping out with development! ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099338249Sun, 30 Apr 2023 20:23:01 +05002099338249@Uncensored

Submitting Code:

What you said makes very good sense.  To try out submitting code, I cloned down the citadel release, created a branch and made some updates to fix some WebCit page issues and cleaned up a little formatting.  Seemed like a simple change to submit with low impact for a first try.  I created a patch from the branch (attached).  Is this what you were expecting for submitting changes?

 

New Features:

The Flagging and Aliasing were just examples.  The Aliasing is a big help to my server, but I figured may not be considered a useful feature to others.  It is a bit tricky to implement and as you noted, you have to be careful about user names.  It is fun when you get to tell a company like Fidelity Investments that their email list has been stolen and you have the proof :-)

The flagging is most likely useful.  I added support for Draft, Flagged, Deleted and Recent.  After reviewing the standards I noticed that Seen was not quite implemented properly so I fixed that while implementing the others.  I’ll write up details on it and send it to you.

Building Code:

The main issue I ran into was trying to build the server from the citadel repository.  I normally have just copied the build after an easy install and then made my changes on top of it so all I had to do is run Make.  With the citadel repository, I tried to create the configure scripts and then run them to create the make files, but ran into some missing files and script errors.  I am compiling on Rocky Linux.  I assume that developers are not running autoconf, etc. from just a citadel repository clone or to build easy install.  What is the proper process for building from the repository?

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099337934Fri, 28 Apr 2023 06:25:28 +05002099337934@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099337834Thu, 27 Apr 2023 10:33:09 +05002099337834@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099337563Tue, 25 Apr 2023 12:00:53 +05002099337563@Uncensored

Thanks.  Looking forward to it.

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099337534Tue, 25 Apr 2023 09:11:49 +05002099337534@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099336923Sat, 22 Apr 2023 21:36:12 +05002099336923@Uncensored

I want to start contributing to the Citadel project as a developer, but I want to understand the developer process for submitting changes and testing.

I have been using Citadel as a small business server for a few years now and have fixed bugs and limitations and also added a few features for my own use over time.

I don't want to start committing code and find out that I should have been doing it a different way or break anyone's development.  Is there any document covering how-to and best practices?

If not, here are my initial questions:

Git

  I have never used git before, but have cloned down the source and did a little reading.  I think all I need to do is git add my changes and then commit.  What is the best practice?  Create branches?  Doesn't matter?

  Do you have an example commit command so I know all the options that I should be using.  Any standards?

Testing

  Is there any test suite for Citadel?  I do my own testing, but I mainly support Outlook and IMAP, so I am not sure how to test for regression in other protocols and clients.

  How are committed changes tested before release?

New Features

  If I have an idea for a new feature, how do I find out if you want it implemented and the best way to integrate?

    Example: I implemented Flagging in IMAP by expanding on the Visit structure.

    Example: I expanded aliasing to allow users to use email addresses appended by anything to go to their account without explicitly adding an alias (e.g. User is myacct.  Email like myacctspam@example.com, myacctbank@example.com, etc will be redirected to myacct).  Has been very useful for anti-spamming and identifying who gave away/lost and email address.  Supported sending using the alias also.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099336003Thu, 20 Apr 2023 06:25:26 +05002099336003@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099335521Wed, 19 Apr 2023 06:27:20 +05002099335521@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099335221Tue, 18 Apr 2023 06:27:24 +05002099335221@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099334698Sat, 15 Apr 2023 06:28:22 +05002099334698@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099334527Fri, 14 Apr 2023 06:27:32 +05002099334527@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099334386Thu, 13 Apr 2023 06:26:16 +05002099334386@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099334206Wed, 12 Apr 2023 06:27:32 +05002099334206@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099334060Tue, 11 Apr 2023 06:27:33 +05002099334060@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099333654Sat, 08 Apr 2023 06:27:49 +05002099333654@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099333209Thu, 06 Apr 2023 06:25:19 +05002099333209@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099332197Sat, 01 Apr 2023 06:28:21 +05002099332197@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099332060Fri, 31 Mar 2023 06:25:27 +05002099332060@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099331915Thu, 30 Mar 2023 06:26:35 +05002099331915@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099331655Tue, 28 Mar 2023 06:25:33 +05002099331655@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099330564Sun, 19 Mar 2023 06:27:49 +05002099330564@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099330013Tue, 14 Mar 2023 19:28:07 +05002099330013@Uncensoredwtf, why do you want to break the universe? Heh. Sometimes there are days when it feels like the universe is not worth saving :) ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099329931Tue, 14 Mar 2023 06:27:33 +05002099329931@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099329838Mon, 13 Mar 2023 13:43:01 +05002099329838@Uncensored

wtf, why do you want to break the universe?

Mon Mar 13 2023 06:27:26 EDT from noreply Subject: Daily commit digest for Citadel

cff70a055 Art Cancro 2023-03-12 Implemented an algorithm that can correctly divide by zero.

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099329789Mon, 13 Mar 2023 06:27:26 +05002099329789@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099329684Sun, 12 Mar 2023 06:27:25 +05002099329684@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099329433Fri, 10 Mar 2023 06:29:24 +05002099329433@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099329124Wed, 08 Mar 2023 06:27:34 +05002099329124@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099328841Mon, 06 Mar 2023 06:27:20 +05002099328841@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099328722Sun, 05 Mar 2023 06:25:29 +05002099328722@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099327951Mon, 27 Feb 2023 06:29:23 +05002099327951@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099327072Sun, 19 Feb 2023 06:27:32 +05002099327072@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099326480Wed, 15 Feb 2023 06:27:32 +05002099326480@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099326168Mon, 13 Feb 2023 06:29:25 +05002099326168@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099326028Sun, 12 Feb 2023 06:27:19 +05002099326028@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099325970Sat, 11 Feb 2023 17:21:48 +05002099325970@Uncensored Date: Sat Feb 11 17:21:45 2023 -0500 Unpublish port 2020 , we don't use it anymore ----------------------------------------------------------------------- Summary of changes: Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099325395Wed, 08 Feb 2023 06:27:33 +05002099325395@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099324278Tue, 31 Jan 2023 06:27:19 +05002099324278@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099324135Sun, 29 Jan 2023 06:25:59 +05002099324135@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099323913Fri, 27 Jan 2023 06:27:50 +05002099323913@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099323667Wed, 25 Jan 2023 06:25:52 +05002099323667@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099322775Sun, 15 Jan 2023 06:29:25 +05002099322775@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099322095Sat, 07 Jan 2023 06:29:24 +05002099322095@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099321974Fri, 06 Jan 2023 06:28:22 +05002099321974@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099321606Tue, 03 Jan 2023 06:25:57 +05002099321606@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099321501Mon, 02 Jan 2023 06:28:22 +05002099321501@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099321196Thu, 29 Dec 2022 06:27:49 +05002099321196@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099321121Wed, 28 Dec 2022 06:27:17 +05002099321121@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099321038Tue, 27 Dec 2022 06:27:33 +05002099321038@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099320697Fri, 23 Dec 2022 06:27:33 +05002099320697@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099320234Sun, 18 Dec 2022 06:26:22 +05002099320234@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099320127Sat, 17 Dec 2022 06:27:48 +05002099320127@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099320052Fri, 16 Dec 2022 06:29:22 +05002099320052@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099319965Thu, 15 Dec 2022 09:30:33 +05002099319965@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099319856Wed, 14 Dec 2022 06:27:23 +05002099319856@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099319730Tue, 13 Dec 2022 06:26:05 +05002099319730@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099319523Sun, 11 Dec 2022 06:26:05 +05002099319523@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099319228Thu, 08 Dec 2022 06:25:53 +05002099319228@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099318826Mon, 05 Dec 2022 06:25:45 +05002099318826@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099318385Thu, 01 Dec 2022 12:34:23 +05002099318385@Uncensored Date: Thu Dec 1 12:34:19 2022 -0500 Updated docs ----------------------------------------------------------------------- Summary of changes: Dockerfile | 16 ++++++++++++++-- README.txt | 13 +++++++++---- ctdlvisor.c | 2 +- 3 files changed, 24 insertions(+), 7 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099318333Thu, 01 Dec 2022 02:01:25 +05002099318333@Uncensored Date: Thu Dec 1 02:00:50 2022 -0500 Switched to a multi stage build for a significantly smaller container image. ----------------------------------------------------------------------- Summary of changes: Dockerfile | 90 ++++++++++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 61 insertions(+), 29 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099318317Wed, 30 Nov 2022 21:12:58 +05002099318317@Uncensored Date: Wed Nov 30 21:12:55 2022 -0500 moved update block and fixed comment ----------------------------------------------------------------------- Summary of changes: Dockerfile | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099317812Fri, 25 Nov 2022 11:18:54 +05002099317812@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099317689Thu, 24 Nov 2022 06:25:39 +05002099317689@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099317641Wed, 23 Nov 2022 17:10:29 +05002099317641@Uncensored

AHAHAHAHAHAHA! 

Wed Nov 23 2022 16:44:22 EST from IGnatius T Foobar

I just removed the "check for new mail in the inbox" function out of the server's GOTO command and moved it into a new command called BIFF. I wonder how many people will know why I named it that?

 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099317637Wed, 23 Nov 2022 16:44:22 +05002099317637@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099317190Sun, 20 Nov 2022 06:25:40 +05002099317190@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099317102Sat, 19 Nov 2022 06:26:05 +05002099317102@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099316484Sat, 12 Nov 2022 06:26:05 +05002099316484@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099316321Thu, 10 Nov 2022 06:25:53 +05002099316321@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099316057Mon, 07 Nov 2022 06:26:05 +05002099316057@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099316004Sun, 06 Nov 2022 06:25:53 +05002099316004@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099315757Thu, 03 Nov 2022 06:25:45 +05002099315757@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099315417Sun, 30 Oct 2022 06:26:13 +05002099315417@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099315110Thu, 27 Oct 2022 06:25:14 +05002099315110@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099315052Wed, 26 Oct 2022 15:17:52 +05002099315052@Uncensored Date: Tue Oct 25 23:33:03 2022 -0400 Pass the subject to the reply commit 2352dc30c074739244acefa61e6fcd7e01b250e0 Author: Art Cancro Date: Tue Oct 25 23:30:42 2022 -0400 to, cc, subject in mail_compose() commit 4e732609e9cc6e93cb7c36d87775a86e14cd9f8d Author: Art Cancro Date: Tue Oct 25 23:22:23 2022 -0400 ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099314948Tue, 25 Oct 2022 23:25:21 +05002099314948@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099314947Tue, 25 Oct 2022 23:22:26 +05002099314947@Uncensored Date: Tue Oct 25 23:22:23 2022 -0400 The icon for "Send message" is now a paper airplane instead of a check mark. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_mail.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099314552Fri, 21 Oct 2022 19:25:11 +05002099314552@Uncensored Date: Fri Oct 21 19:25:09 2022 -0400 reply quote works now ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_mail.js | 90 ++++++++++++++++++++++------------------ 1 file changed, 49 insertions(+), 41 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099314460Thu, 20 Oct 2022 19:06:04 +05002099314460@Uncensored Date: Thu Oct 20 19:05:59 2022 -0400 get ready for quoted messages http://code.citadel.org/?p=citadel.git&a=commit&h=fd524cfbe226abccc7d1324af2005fd04e014790 commit fd524cfbe226abccc7d1324af2005fd04e014790 Author: Art Cancro Date: Thu Oct 20 18:15:15 2022 -0400 Sending mail now works. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/messages.c | 15 ++++++++--- webcit-ng/static/js/view_mail.js | 54 +++++++++++++++++++++++++++------------- webcit-ng/static/js/views.js | 2 +- 3 files changed, 49 insertions(+), 22 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099314362Wed, 19 Oct 2022 19:34:58 +05002099314362@Uncensored Date: Wed Oct 19 19:34:53 2022 -0400 Sending mail to the server (needs some more work) ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_mail.js | 65 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 63 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099314334Wed, 19 Oct 2022 13:03:58 +05002099314334@Uncensored Date: Wed Oct 19 12:02:33 2022 -0400 cancel button works :) ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_mail.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099314245Tue, 18 Oct 2022 18:39:26 +05002099314245@Uncensored Date: Tue Oct 18 18:39:19 2022 -0400 test commit http://code.citadel.org/?p=citadel.git&a=commit&h=b914876f051fbed2f84b17c86843d072539f4769 commit b914876f051fbed2f84b17c86843d072539f4769 Author: Art Cancro Date: Mon Oct 17 19:32:42 2022 -0400 Indent blockquotes by 1em http://code.citadel.org/?p=citadel.git&a=commit&h=56283c748df23d8fa012b2b56cafe7828bee973b commit 56283c748df23d8fa012b2b56cafe7828bee973b Author: Art Cancro Date: Mon Oct 17 19:26:04 2022 -0400 CC/BCC button in To: line makes the CC: and BCC: lines appear. ----------------------------------------------------------------------- Summary of changes: citadel/citadel.lock | 0 webcit-ng/static/css/webcit.css | 49 +++++++++++++++++++++++++++++++++++++--- webcit-ng/static/js/view_mail.js | 28 ++++++++++++++++++++--- 3 files changed, 71 insertions(+), 6 deletions(-) create mode 100644 citadel/citadel.lock hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099313998Sat, 15 Oct 2022 23:09:16 +05002099313998@Uncensored Date: Sat Oct 15 23:09:03 2022 -0400 More style work on the mail composition window ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 29 +++++++++++++++++++++-------- webcit-ng/static/js/view_mail.js | 23 +++++++++++++++-------- 2 files changed, 36 insertions(+), 16 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099313590Tue, 11 Oct 2022 23:26:10 +05002099313590@Uncensored Date: Tue Oct 11 23:25:41 2022 -0400 Don't show a focus border on contenteditable items http://code.citadel.org/?p=citadel.git&a=commit&h=2bb782979db4e4a6082116bf32c565c82b779a31 commit 2bb782979db4e4a6082116bf32c565c82b779a31 Author: Art Cancro Date: Tue Oct 11 23:19:24 2022 -0400 Make the 'Write mail' button disappear when we're already in the mail compose screen. http://code.citadel.org/?p=citadel.git&a=commit&h=e9c01ed778e2e39f5c824a001049305fb0841811 commit e9c01ed778e2e39f5c824a001049305fb0841811 Author: Art Cancro Date: Tue Oct 11 23:14:08 2022 -0400 Initial layout of mail compose screen. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 55 ++++++++++++++++++++++++++++++++++++++-- webcit-ng/static/js/view_mail.js | 39 +++++++++++++++++++--------- 2 files changed, 80 insertions(+), 14 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099312491Tue, 04 Oct 2022 22:32:34 +05002099312491@Uncensored Date: Tue Oct 4 22:18:32 2022 -0400 Began working on the screen layout for compose mail http://code.citadel.org/?p=citadel.git&a=commit&h=e5c4d0b4eff8ec1322f2437fffc7b8fc48c6315f commit e5c4d0b4eff8ec1322f2437fffc7b8fc48c6315f Author: Art Cancro Date: Tue Oct 4 21:42:40 2022 -0400 When a mail message takes up less than the full height of the reading pane, make it float to the top of the pane. Specified the grid element sizes in the grid instead of in the children. http://code.citadel.org/?p=citadel.git&a=commit&h=c11fc20363fc9a9cd2787169339aed10b66c8184 commit c11fc20363fc9a9cd2787169339aed10b66c8184 Author: Art Cancro Date: Tue Oct 4 19:42:25 2022 -0400 more style changes to the mailbox message list ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 18 +++++++++++------- webcit-ng/static/js/view_mail.js | 12 +++++++----- 2 files changed, 18 insertions(+), 12 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099311699Mon, 26 Sep 2022 17:19:46 +05002099311699@Uncensored Date: Mon Sep 26 17:19:18 2022 -0400 Got all of the elements in the top banner bar to line up across the same horizontal axis. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 59 +++++++++++++++++++++++++++++++++-------- webcit-ng/static/index.html | 34 +++++++++++++++--------- webcit-ng/static/js/main.js | 2 +- 3 files changed, 71 insertions(+), 24 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099311493Sat, 24 Sep 2022 11:09:32 +05002099311493@Uncensored Date: Sat Sep 24 11:09:28 2022 -0400 Something about the way we were rendering items in the banner bar was making it overflow and scrollbars were appearing. Removed all of the float styling for now. I will rewrite it as a flexbox. http://code.citadel.org/?p=citadel.git&a=commit&h=6bab2c308d59bf65faa1c9b4a8c04ba5abed26d0 commit 6bab2c308d59bf65faa1c9b4a8c04ba5abed26d0 Author: Art Cancro Date: Fri Sep 23 15:50:24 2022 -0400 Gave the grid-template-areas more meaningful and unique names http://code.citadel.org/?p=citadel.git&a=commit&h=6fe92cbc7d39e5b4080c3c0e7dd29dc593454746 commit 6fe92cbc7d39e5b4080c3c0e7dd29dc593454746 Author: Art Cancro Date: Fri Sep 23 15:47:26 2022 -0400 moved the username and login button back to separate items http://code.citadel.org/?p=citadel.git&a=commit&h=9ba06f78d5bdee43595944519e3983d9e65af5a2 commit 9ba06f78d5bdee43595944519e3983d9e65af5a2 Author: Art Cancro Date: Fri Sep 23 15:34:25 2022 -0400 Changed the sidebar button style AGAIN. It looks more current-year now. I like the old style beveled buttons but that look is dated. http://code.citadel.org/?p=citadel.git&a=commit&h=13f79e5472836fb937bc6b98fe444e6beaee2a51 commit 13f79e5472836fb937bc6b98fe444e6beaee2a51 Author: Art Cancro Date: Fri Sep 23 14:55:37 2022 -0400 Resized the banner bar using vh instead of pixels. Resized the sidebar using vw instead of pixels. Replaced the CITADEL name in the corner with our logo, also bearing a link to the web site. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 37 ++++++++++++++++++++++--------------- webcit-ng/static/index.html | 17 ++++++----------- 2 files changed, 28 insertions(+), 26 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099311362Thu, 22 Sep 2022 19:30:45 +05002099311362@Uncensored Date: Thu Sep 22 19:30:42 2022 -0400 Fixed the rendering on the 'older posts' and 'newer posts' buttons. No longer relies on w3css styles we aren't using anymore. Also made the whole div clickable instead of just the text. http://code.citadel.org/?p=citadel.git&a=commit&h=32e59fc6da61b0b3cf4cc0ccf90682170e14660c commit 32e59fc6da61b0b3cf4cc0ccf90682170e14660c Author: Art Cancro Date: Thu Sep 22 18:06:59 2022 -0400 Tightened up the padding around the room list and rendered it with the flexbox model. Cleaned up the styles used in hover and selection on the sidebar. http://code.citadel.org/?p=citadel.git&a=commit&h=68676c15bf5aa9bdd8ab654c7f049f17c0dec4f8 commit 68676c15bf5aa9bdd8ab654c7f049f17c0dec4f8 Author: Art Cancro Date: Thu Sep 22 15:19:55 2022 -0400 style roomlist http://code.citadel.org/?p=citadel.git&a=commit&h=fdef03022a466ce3dbaedf8ceef8d1683ae2dd73 commit fdef03022a466ce3dbaedf8ceef8d1683ae2dd73 Merge: 52dc26285 274c95e13 Author: Art Cancro Date: Thu Sep 22 15:19:07 2022 -0400 Merge branch 'master' of ssh://git.citadel.org/var/www/gitroot/citadel commit 274c95e13b3868d29c4790a4603f27c0a04616aa Author: Art Cancro Date: Wed Sep 21 19:13:45 2022 -0400 Tried to add a few style thingies back into the renderer commit 4df5f560d552000f252a0e4dda2026b7a0373f0c Author: Art Cancro Date: Wed Sep 21 18:44:43 2022 -0400 Added a new parameter to html_to_ascii() to let it know when it's rendering to a terminal that supports ANSI escape sequences. When this support is active, render blockquotes in dimmer video and italic (if supported by the terminal). commit 8c0cafc4fa850ad2d7a3c2624477bc1b148d995e Author: Art Cancro Date: Wed Sep 21 18:25:48 2022 -0400 When rendering messages in the old text client format, identify pull quotes and render them in dimmer video and italic font (if supported by the terminal). http://code.citadel.org/?p=citadel.git&a=commit&h=52dc262858e29ebd34fec6bdf726511baede1dcf commit 52dc262858e29ebd34fec6bdf726511baede1dcf Author: Art Cancro Date: Tue Sep 20 11:23:51 2022 -0400 Reworked the room list to output semantically. We will describe the layout using CSS flexbox in an upcoming commit. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 39 +++++++++++++++++++++++++++------------ webcit-ng/static/index.html | 23 +++++++++-------------- webcit-ng/static/js/roomlist.js | 22 ++++++++++++++++------ webcit-ng/static/js/view_forum.js | 12 ++++++------ webcit-ng/static/js/views.js | 29 ++++++++++++++++++++--------- 5 files changed, 78 insertions(+), 47 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099311277Wed, 21 Sep 2022 19:13:48 +05002099311277@Uncensored Date: Wed Sep 21 19:13:45 2022 -0400 Tried to add a few style thingies back into the renderer http://code.citadel.org/?p=citadel.git&a=commit&h=4df5f560d552000f252a0e4dda2026b7a0373f0c commit 4df5f560d552000f252a0e4dda2026b7a0373f0c Author: Art Cancro Date: Wed Sep 21 18:44:43 2022 -0400 Added a new parameter to html_to_ascii() to let it know when it's rendering to a terminal that supports ANSI escape sequences. When this support is active, render blockquotes in dimmer video and italic (if supported by the terminal). http://code.citadel.org/?p=citadel.git&a=commit&h=8c0cafc4fa850ad2d7a3c2624477bc1b148d995e commit 8c0cafc4fa850ad2d7a3c2624477bc1b148d995e Author: Art Cancro Date: Wed Sep 21 18:25:48 2022 -0400 When rendering messages in the old text client format, identify pull quotes and render them in dimmer video and italic font (if supported by the terminal). ----------------------------------------------------------------------- Summary of changes: citadel/server/msgbase.c | 2 +- libcitadel/lib/html_to_ascii.c | 77 +++++++++++++++++++++++++++--------------- libcitadel/lib/libcitadel.h | 14 ++++---- textclient/commands.c | 13 +++++++ textclient/messages.c | 2 +- webcit/messages.c | 2 +- 6 files changed, 72 insertions(+), 38 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310911Sat, 17 Sep 2022 17:23:09 +05002099310911@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310910Sat, 17 Sep 2022 17:23:05 +05002099310910@Uncensored Date: Sat Sep 17 17:23:02 2022 -0400 Release version 958 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=60bc77ee859ec10fd42094598e7dde310f3e1d2f commit 60bc77ee859ec10fd42094598e7dde310f3e1d2f Author: Art Cancro Date: Sat Sep 17 17:21:27 2022 -0400 In the text client, changed some misleading error messages http://code.citadel.org/?p=citadel.git&a=commit&h=648c829fbbfc417b675243a7fe86194731abf2cd commit 648c829fbbfc417b675243a7fe86194731abf2cd Author: Art Cancro Date: Sat Sep 17 17:15:40 2022 -0400 Removed the 'UIMG 0||userpic' server command issued to check whether the user has permission to upload the photo. That is an obsolete command and it will fail every time unless the user is an administrator. ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/citadel.c | 9 +++--- textclient/config.mk | 4 +-- textclient/textclient.h | 2 +- webcit/graphics.c | 69 ++++++++++++++++----------------------------- webcit/webcit.h | 2 +- 8 files changed, 35 insertions(+), 57 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310870Sat, 17 Sep 2022 12:32:24 +05002099310870@Uncensored Date: Sat Sep 17 16:32:17 2022 +0000 trying to figure out the problem with graphics upload in webcit classic http://code.citadel.org/?p=citadel.git&a=commit&h=2ed043e2df02ef48857912c65daec06b77b10ac2 commit 2ed043e2df02ef48857912c65daec06b77b10ac2 Author: Art Cancro Date: Fri Sep 16 21:28:44 2022 +0000 sed s/goodbuye/goodbye ... I wonder how much was broken because of this http://code.citadel.org/?p=citadel.git&a=commit&h=5d2d3f4eea91c74af93c735bff7ad9955b466181 commit 5d2d3f4eea91c74af93c735bff7ad9955b466181 Author: Art Cancro Date: Fri Sep 16 21:20:04 2022 +0000 Reverts commit c6aec42f213ec284e34648f3d69bcf927dccddb1 because putting the opening brace on the same line as the function declaration causes mk_modules_init.sh to barf its lungs out. http://code.citadel.org/?p=citadel.git&a=commit&h=9f8e0bd23ce7dde31156b634f3a66bf234b11927 commit 9f8e0bd23ce7dde31156b634f3a66bf234b11927 Author: Art Cancro Date: Fri Sep 16 18:54:31 2022 +0000 just some idle style cleanup http://code.citadel.org/?p=citadel.git&a=commit&h=7408ecea5cc097c76ed667097020e1d9a1228b0d commit 7408ecea5cc097c76ed667097020e1d9a1228b0d Author: Art Cancro Date: Fri Sep 16 18:44:08 2022 +0000 text client: if the 'who am i' command is used to populate the host name, strip the trailing newline. Otherwise the newline gets sent as part of an IDEN command and it confuses the server protocol. ----------------------------------------------------------------------- Summary of changes: citadel/config.mk | 2 +- textclient/citadel.c | 71 +- textclient/citadel_ipc.c | 2 +- textclient/config.mk | 4 +- textclient/routines.c | 3 + webcit/addressbook_popup.c | 23 +- webcit/auth.c | 213 +-- webcit/autocompletion.c | 31 +- webcit/availability.c | 92 +- webcit/bbsview_renderer.c | 198 +-- webcit/blogview_renderer.c | 180 +-- webcit/calendar.c | 351 +++-- webcit/calendar.h | 63 +- webcit/calendar_tools.c | 118 +- webcit/calendar_view.c | 826 ++++++----- webcit/context_loop.c | 345 +++-- webcit/cookie_conversion.c | 24 +- webcit/crypto.c | 27 +- webcit/dav.h | 11 +- webcit/dav_delete.c | 10 +- webcit/dav_get.c | 52 +- webcit/dav_main.c | 161 ++- webcit/dav_options.c | 32 +- webcit/dav_propfind.c | 577 ++++---- webcit/dav_put.c | 38 +- webcit/dav_report.c | 46 +- webcit/downloads.c | 252 ++-- webcit/event.c | 578 ++++---- webcit/feed_generator.c | 71 +- webcit/fmt_date.c | 148 +- webcit/gettext.c | 204 +-- webcit/graphics.c | 59 +- webcit/html2html.c | 377 +++-- webcit/http_datestring.c | 30 +- webcit/ical_dezonify.c | 63 +- webcit/ical_subst.c | 257 ++-- webcit/iconbar.c | 161 ++- webcit/icontheme.c | 90 +- webcit/inetconf.c | 84 +- webcit/jsonview_renderer.c | 56 +- webcit/listsub.c | 25 +- webcit/locate_host.c | 10 +- webcit/mailview_renderer.c | 78 +- webcit/mainmenu.c | 42 +- webcit/marchlist.c | 57 +- webcit/messages.c | 702 +++++----- webcit/messages.h | 155 ++- webcit/msg_renderers.c | 927 +++++++------ webcit/netconf.c | 120 +- webcit/notes.c | 176 ++- webcit/openid.c | 56 +- webcit/paging.c | 37 +- webcit/paramhandling.c | 440 +++--- webcit/paramhandling.h | 24 +- webcit/preferences.c | 509 ++++--- webcit/preferences.h | 25 +- webcit/pushemail.c | 106 +- webcit/roomchat.c | 16 +- webcit/roomlist.c | 522 ++++--- webcit/roomops.c | 570 ++++---- webcit/roomops.h | 92 +- webcit/roomtokens.c | 302 +++-- webcit/roomviews.c | 151 ++- webcit/serv_func.c | 210 +-- webcit/sieve.c | 366 +++-- webcit/siteconfig.c | 349 ++--- webcit/sitemap.c | 73 +- webcit/smtpqueue.c | 271 ++-- webcit/sockets.c | 409 +++--- webcit/sockets.h | 21 +- webcit/static.c | 103 +- webcit/static/t/aide/siteconfig/tab_general.html | 2 +- webcit/subst.c | 1585 ++++++++++++++-------- webcit/subst.h | 168 ++- webcit/summary.c | 48 +- webcit/sysdep.c | 208 +-- webcit/sysmsgs.c | 24 +- webcit/tabs.c | 159 ++- webcit/tasks.c | 302 +++-- webcit/useredit.c | 501 ++++--- webcit/utils.c | 161 +-- webcit/utils.h | 5 +- webcit/vcard_edit.c | 517 ++++--- webcit/webcit.c | 312 +++-- webcit/webcit.h | 326 +++-- webcit/webserver.c | 85 +- webcit/webserver.h | 9 +- webcit/who.c | 184 ++- webcit/wiki.c | 103 +- 89 files changed, 10257 insertions(+), 7316 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310766Fri, 16 Sep 2022 12:43:01 +05002099310766@Uncensored Date: Fri Sep 16 10:36:49 2022 -0400 Style update to server/modules/ctdlproto/serv_file.c http://code.citadel.org/?p=citadel.git&a=commit&h=0b43e938666e409343ee326e4299754ee9702040 commit 0b43e938666e409343ee326e4299754ee9702040 Author: Art Cancro Date: Thu Sep 15 19:05:59 2022 -0400 Changed 'the Greetingpicture for the login prompt' to 'graphics to be displayed on the login screen' ----------------------------------------------------------------------- Summary of changes: citadel/citadel.lock | 0 citadel/server/modules/ctdlproto/serv_file.c | 247 ++++++++++----------------- webcit/graphics.c | 2 +- webcit/po/webcit/ar.po | 2 +- webcit/po/webcit/bg.po | 2 +- webcit/po/webcit/cs.po | 2 +- webcit/po/webcit/da.po | 2 +- webcit/po/webcit/de.po | 2 +- webcit/po/webcit/el.po | 2 +- webcit/po/webcit/en_GB.po | 4 +- webcit/po/webcit/es.po | 2 +- webcit/po/webcit/et.po | 2 +- webcit/po/webcit/fi.po | 2 +- webcit/po/webcit/fr.po | 2 +- webcit/po/webcit/he.po | 2 +- webcit/po/webcit/hu.po | 2 +- webcit/po/webcit/it.po | 2 +- webcit/po/webcit/kk.po | 2 +- webcit/po/webcit/ko.po | 2 +- webcit/po/webcit/nl.po | 2 +- webcit/po/webcit/pl.po | 2 +- webcit/po/webcit/pt_BR.po | 2 +- webcit/po/webcit/ro.po | 2 +- webcit/po/webcit/ru.po | 2 +- webcit/po/webcit/sl.po | 2 +- webcit/po/webcit/sv.po | 2 +- webcit/po/webcit/tr.po | 2 +- webcit/po/webcit/webcit.pot | 2 +- webcit/po/webcit/zh.po | 2 +- 29 files changed, 119 insertions(+), 184 deletions(-) delete mode 100644 citadel/citadel.lock hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310703Thu, 15 Sep 2022 18:51:25 +05002099310703@Uncensored Date: Thu Sep 15 18:48:15 2022 -0400 Render user pic as a circle using clip-path() CSS http://code.citadel.org/?p=citadel.git&a=commit&h=b152326c91ecfd4cc5782c4df2f2527fbad2b5b5 commit b152326c91ecfd4cc5782c4df2f2527fbad2b5b5 Author: Art Cancro Date: Thu Sep 15 18:37:50 2022 -0400 Consolidated all renderings of a user profile picture (avatar) into a single rendering function render_userpic(). This is currently called to display the user's avatar in the banner when logged in, and in both the mail and forum views. http://code.citadel.org/?p=citadel.git&a=commit&h=6c10a091d1e9cc892275594c68634fe204b24e3f commit 6c10a091d1e9cc892275594c68634fe204b24e3f Author: Art Cancro Date: Tue Sep 13 00:05:28 2022 -0400 Minor style changes to room list and mailbox reading pane ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 14 +++++++++++--- webcit-ng/static/index.html | 8 +++++--- webcit-ng/static/js/main.js | 2 ++ webcit-ng/static/js/user_profile.js | 20 +++++++++++++++++--- webcit-ng/static/js/view_forum.js | 5 +---- webcit-ng/static/js/view_mail.js | 5 +---- 6 files changed, 37 insertions(+), 17 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310290Sat, 10 Sep 2022 23:05:43 +05002099310290@Uncensored Date: Sat Sep 10 23:05:39 2022 -0400 CSS tweaks to room list view. http://code.citadel.org/?p=citadel.git&a=commit&h=0e1b188acdb41d1832c41084e3d29003db3e3f8c commit 0e1b188acdb41d1832c41084e3d29003db3e3f8c Author: Art Cancro Date: Sat Sep 10 22:21:08 2022 -0400 Make all CSS comment blocks start in the same column. Probably not sustainable. http://code.citadel.org/?p=citadel.git&a=commit&h=87a48a66b28e4cfb53df86776ccce871aa9b0f68 commit 87a48a66b28e4cfb53df86776ccce871aa9b0f68 Author: Art Cancro Date: Sat Sep 10 20:13:44 2022 -0400 README.txt is now README.md because why not. Also included an obnoxious comment about how we're not going to use your favorite CSS or JS library because everything is lovingly hand coded and Citadel components tend to outlive web libraries. http://code.citadel.org/?p=citadel.git&a=commit&h=fca7e544adaf01d32081290959c5dce7df8631f8 commit fca7e544adaf01d32081290959c5dce7df8631f8 Author: Art Cancro Date: Sat Sep 10 15:44:50 2022 -0400 Moved some of the banner and sidebar items around http://code.citadel.org/?p=citadel.git&a=commit&h=b439cb87f482a423d90eae995cdbba424d2ce5af commit b439cb87f482a423d90eae995cdbba424d2ce5af Author: Art Cancro Date: Fri Sep 9 18:55:41 2022 -0400 Remove the box around the message text in the mailbox view. Set a 3px bottom border under the message list. Looks pretty good now. ----------------------------------------------------------------------- Summary of changes: webcit-ng/{README.txt => README.md} | 22 +++----- webcit-ng/static/css/webcit.css | 102 +++++++++++++++++++----------------- webcit-ng/static/index.html | 38 +++++++------- webcit-ng/static/js/roomlist.js | 4 +- webcit-ng/static/js/view_mail.js | 2 +- 5 files changed, 81 insertions(+), 87 deletions(-) rename webcit-ng/{README.txt => README.md} (90%) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310200Fri, 09 Sep 2022 18:09:36 +05002099310200@Uncensored Date: Fri Sep 9 18:09:34 2022 -0400 Remove the console log of the address render. It works now and we don't need to log it. http://code.citadel.org/?p=citadel.git&a=commit&h=60ecdd5eeb96be571020966047762965b818a0ef commit 60ecdd5eeb96be571020966047762965b818a0ef Author: Art Cancro Date: Fri Sep 9 18:08:57 2022 -0400 Moved render_msg_author() into a different file ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/user_profile.js | 18 ++++++++++++++++++ webcit-ng/static/js/view_forum.js | 4 +--- webcit-ng/static/js/view_mail.js | 5 +---- 3 files changed, 20 insertions(+), 7 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310186Fri, 09 Sep 2022 15:40:19 +05002099310186@Uncensored Date: Fri Sep 9 15:39:27 2022 -0400 Separate out the display name and email addresses in the JSON output of a message. Also send out the "message originated locally" flag. This will allow the JS side to be smarter about how it displays. ----------------------------------------------------------------------- Summary of changes: webcit-ng/server/forum_view.c | 13 +++---------- webcit-ng/static/css/webcit.css | 14 ++++++++++++++ webcit-ng/static/js/view_mail.js | 9 +++++---- 3 files changed, 22 insertions(+), 14 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310158Fri, 09 Sep 2022 11:58:04 +05002099310158@Uncensored Date: Fri Sep 9 11:58:04 2022 -0400 more tweaks to mailbox css ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 9 +++++++-- webcit-ng/static/js/view_mail.js | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310150Fri, 09 Sep 2022 10:59:26 +05002099310150@Uncensored Date: Fri Sep 9 10:59:24 2022 -0400 The mailbox reading pane seems to work best when the height is not specified at all. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310109Thu, 08 Sep 2022 19:56:37 +05002099310109@Uncensored Date: Thu Sep 8 19:55:40 2022 -0400 Applied style changes to the mailbox pane that are both semantically correct and look really good. Now I am become keyboard, destroyer of worlds. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 36 ++++++++++++++++++++++++++---------- webcit-ng/static/js/view_mail.js | 3 +-- 2 files changed, 27 insertions(+), 12 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310097Thu, 08 Sep 2022 19:18:56 +05002099310097@Uncensored Date: Thu Sep 8 19:18:54 2022 -0400 simplify the build and move the C server into a directory ----------------------------------------------------------------------- Summary of changes: webcit-ng/README.txt | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310096Thu, 08 Sep 2022 19:17:44 +05002099310096@Uncensored Date: Thu Sep 8 19:17:41 2022 -0400 Move *.c and *.h into server/ directory. ----------------------------------------------------------------------- Summary of changes: webcit-ng/.gitignore | 1 + webcit-ng/Makefile | 17 +++-------------- webcit-ng/{ => server}/admin_functions.c | 0 webcit-ng/{ => server}/caldav_reports.c | 0 webcit-ng/{ => server}/ctdl_commands.c | 0 webcit-ng/{ => server}/ctdlclient.c | 0 webcit-ng/{ => server}/ctdlfunctions.c | 0 webcit-ng/{ => server}/floor_functions.c | 0 webcit-ng/{ => server}/forum_view.c | 0 webcit-ng/{ => server}/html2html.c | 0 webcit-ng/{ => server}/http.c | 0 webcit-ng/{ => server}/main.c | 0 webcit-ng/{ => server}/messages.c | 0 webcit-ng/{ => server}/request.c | 0 webcit-ng/{ => server}/room_functions.c | 0 webcit-ng/{ => server}/static.c | 0 webcit-ng/{ => server}/tcp_sockets.c | 0 webcit-ng/{ => server}/text2html.c | 0 webcit-ng/{ => server}/tls.c | 0 webcit-ng/{ => server}/user_functions.c | 0 webcit-ng/{ => server}/util.c | 0 webcit-ng/{ => server}/webcit.h | 0 webcit-ng/{ => server}/webserver.c | 0 23 files changed, 4 insertions(+), 14 deletions(-) rename webcit-ng/{ => server}/admin_functions.c (100%) rename webcit-ng/{ => server}/caldav_reports.c (100%) rename webcit-ng/{ => server}/ctdl_commands.c (100%) rename webcit-ng/{ => server}/ctdlclient.c (100%) rename webcit-ng/{ => server}/ctdlfunctions.c (100%) rename webcit-ng/{ => server}/floor_functions.c (100%) rename webcit-ng/{ => server}/forum_view.c (100%) rename webcit-ng/{ => server}/html2html.c (100%) rename webcit-ng/{ => server}/http.c (100%) rename webcit-ng/{ => server}/main.c (100%) rename webcit-ng/{ => server}/messages.c (100%) rename webcit-ng/{ => server}/request.c (100%) rename webcit-ng/{ => server}/room_functions.c (100%) rename webcit-ng/{ => server}/static.c (100%) rename webcit-ng/{ => server}/tcp_sockets.c (100%) rename webcit-ng/{ => server}/text2html.c (100%) rename webcit-ng/{ => server}/tls.c (100%) rename webcit-ng/{ => server}/user_functions.c (100%) rename webcit-ng/{ => server}/util.c (100%) rename webcit-ng/{ => server}/webcit.h (100%) rename webcit-ng/{ => server}/webserver.c (100%) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310095Thu, 08 Sep 2022 19:14:15 +05002099310095@Uncensored Date: Thu Sep 8 19:14:11 2022 -0400 mailbox temporary style ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 60 ++++++---- webcit-ng/static/js/view_mail.js | 8 +- webcit-ng/tls2.c~ | 237 --------------------------------------- 3 files changed, 40 insertions(+), 265 deletions(-) delete mode 100644 webcit-ng/tls2.c~ hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310088Thu, 08 Sep 2022 17:57:27 +05002099310088@Uncensored Date: Thu Sep 8 17:57:24 2022 -0400 indent -kr -i8 -brf -bbb -fnc -l132 -nce on all of webcit-classic ----------------------------------------------------------------------- Summary of changes: webcit/addressbook_popup.c | 23 +- webcit/auth.c | 213 +++--- webcit/autocompletion.c | 31 +- webcit/availability.c | 92 ++- webcit/bbsview_renderer.c | 198 +++--- webcit/blogview_renderer.c | 180 +++-- webcit/calendar.c | 351 +++++----- webcit/calendar.h | 63 +- webcit/calendar_tools.c | 118 ++-- webcit/calendar_view.c | 826 ++++++++++------------- webcit/context_loop.c | 345 +++++----- webcit/cookie_conversion.c | 24 +- webcit/crypto.c | 27 +- webcit/dav.h | 11 +- webcit/dav_delete.c | 10 +- webcit/dav_get.c | 52 +- webcit/dav_main.c | 161 ++--- webcit/dav_options.c | 32 +- webcit/dav_propfind.c | 577 +++++++--------- webcit/dav_put.c | 38 +- webcit/dav_report.c | 46 +- webcit/downloads.c | 252 +++---- webcit/event.c | 578 +++++++--------- webcit/feed_generator.c | 71 +- webcit/fmt_date.c | 148 ++--- webcit/gettext.c | 204 +++--- webcit/graphics.c | 47 +- webcit/html2html.c | 377 +++++------ webcit/http_datestring.c | 30 +- webcit/ical_dezonify.c | 63 +- webcit/ical_subst.c | 257 +++---- webcit/iconbar.c | 161 ++--- webcit/icontheme.c | 90 +-- webcit/inetconf.c | 84 +-- webcit/jsonview_renderer.c | 56 +- webcit/listsub.c | 25 +- webcit/locate_host.c | 10 +- webcit/mailview_renderer.c | 78 +-- webcit/mainmenu.c | 42 +- webcit/marchlist.c | 57 +- webcit/messages.c | 702 +++++++++----------- webcit/messages.h | 155 ++--- webcit/msg_renderers.c | 927 +++++++++++--------------- webcit/netconf.c | 120 ++-- webcit/notes.c | 176 ++--- webcit/openid.c | 56 +- webcit/paging.c | 37 +- webcit/paramhandling.c | 440 +++++------- webcit/paramhandling.h | 24 +- webcit/preferences.c | 509 +++++--------- webcit/preferences.h | 25 +- webcit/pushemail.c | 106 ++- webcit/roomchat.c | 16 +- webcit/roomlist.c | 522 ++++++--------- webcit/roomops.c | 570 +++++++--------- webcit/roomops.h | 92 +-- webcit/roomtokens.c | 302 ++++----- webcit/roomviews.c | 151 ++--- webcit/serv_func.c | 210 +++--- webcit/sieve.c | 366 +++++----- webcit/siteconfig.c | 349 +++++----- webcit/sitemap.c | 73 +- webcit/smtpqueue.c | 271 +++----- webcit/sockets.c | 409 +++++------- webcit/sockets.h | 21 +- webcit/static.c | 103 ++- webcit/subst.c | 1585 +++++++++++++++++--------------------------- webcit/subst.h | 168 ++--- webcit/summary.c | 48 +- webcit/sysdep.c | 208 +++--- webcit/sysmsgs.c | 24 +- webcit/tabs.c | 159 ++--- webcit/tasks.c | 302 ++++----- webcit/useredit.c | 501 ++++++-------- webcit/utils.c | 161 +++-- webcit/utils.h | 5 +- webcit/vcard_edit.c | 517 ++++++--------- webcit/webcit.c | 312 ++++----- webcit/webcit.h | 326 ++++----- webcit/webserver.c | 85 ++- webcit/webserver.h | 9 +- webcit/who.c | 184 ++--- webcit/wiki.c | 103 ++- 83 files changed, 7257 insertions(+), 10220 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310087Thu, 08 Sep 2022 17:55:03 +05002099310087@Uncensored Date: Thu Sep 8 17:55:01 2022 -0400 oops removed some backups that got committed ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c~ | 2099 ---------------------------------------- textclient/client_chat.c~ | 247 ----- textclient/client_passwords.c~ | 131 --- textclient/commands.c~ | 1731 --------------------------------- textclient/ipc_c_tcp.c~ | 57 -- textclient/messages.c~ | 1922 ------------------------------------ textclient/rooms.c~ | 1313 ------------------------- textclient/routines.c~ | 570 ----------- textclient/routines2.c~ | 564 ----------- textclient/screen.c~ | 248 ----- textclient/tuiconfig.c~ | 858 ---------------- 11 files changed, 9740 deletions(-) delete mode 100644 textclient/citadel.c~ delete mode 100644 textclient/client_chat.c~ delete mode 100644 textclient/client_passwords.c~ delete mode 100644 textclient/commands.c~ delete mode 100644 textclient/ipc_c_tcp.c~ delete mode 100644 textclient/messages.c~ delete mode 100644 textclient/rooms.c~ delete mode 100644 textclient/routines.c~ delete mode 100644 textclient/routines2.c~ delete mode 100644 textclient/screen.c~ delete mode 100644 textclient/tuiconfig.c~ hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310083Thu, 08 Sep 2022 17:36:04 +05002099310083@Uncensored Date: Thu Sep 8 17:36:02 2022 -0400 minor change to mailbox pane ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 1 + webcit-ng/static/js/view_mail.js | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099310008Wed, 07 Sep 2022 17:33:49 +05002099310008@Uncensored Date: Wed Sep 7 17:31:55 2022 -0400 Got the mailbox view (mailbox pane + reading pane) working correctly. It's a CSS Grid view, so we should be able to offer a side-by-side view later just by amending the styles. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 47 ++++++++++++++++++++++++++++++++-------- webcit-ng/static/js/login.js | 28 +++++++++++++----------- webcit-ng/static/js/view_mail.js | 8 ++++--- webcit-ng/static/js/views.js | 2 +- 4 files changed, 59 insertions(+), 26 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099309829Tue, 06 Sep 2022 00:21:46 +05002099309829@Uncensored Date: Tue Sep 6 00:21:43 2022 -0400 Continuing along with the effort to replace the remaining w3css styles with hand-crafted CSS of our own. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 45 +++++++++++++++++++++++++++++++++++---- webcit-ng/static/index.html | 4 ++-- webcit-ng/static/js/login.js | 40 +++++++++++++++------------------- webcit-ng/static/js/view_forum.js | 39 ++++++++++++++++----------------- 4 files changed, 78 insertions(+), 50 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099309805Mon, 05 Sep 2022 18:52:17 +05002099309805@Uncensored Date: Mon Sep 5 18:51:53 2022 -0400 More CSS cleanup ----------------------------------------------------------------------- Summary of changes: textclient/{citadel.c => citadel.c~} | 132 +++++++++++---------- textclient/{client_chat.c => client_chat.c~} | 32 ++--- .../{client_passwords.c => client_passwords.c~} | 15 ++- textclient/{commands.c => commands.c~} | 74 ++++++------ textclient/{ipc_c_tcp.c => ipc_c_tcp.c~} | 16 +-- textclient/{messages.c => messages.c~} | 0 textclient/{rooms.c => rooms.c~} | 121 ++++++++++--------- textclient/{routines.c => routines.c~} | 69 +++++------ textclient/{routines2.c => routines2.c~} | 43 ++++--- textclient/{screen.c => screen.c~} | 0 textclient/{tuiconfig.c => tuiconfig.c~} | 18 +-- webcit-ng/static/css/webcit.css | 11 +- webcit-ng/{tls.c => tls2.c~} | 88 +++++++++----- 13 files changed, 336 insertions(+), 283 deletions(-) copy textclient/{citadel.c => citadel.c~} (97%) copy textclient/{client_chat.c => client_chat.c~} (95%) copy textclient/{client_passwords.c => client_passwords.c~} (95%) copy textclient/{commands.c => commands.c~} (96%) copy textclient/{ipc_c_tcp.c => ipc_c_tcp.c~} (81%) copy textclient/{messages.c => messages.c~} (100%) copy textclient/{rooms.c => rooms.c~} (95%) copy textclient/{routines.c => routines.c~} (95%) copy textclient/{routines2.c => routines2.c~} (96%) copy textclient/{screen.c => screen.c~} (100%) copy textclient/{tuiconfig.c => tuiconfig.c~} (97%) copy webcit-ng/{tls.c => tls2.c~} (67%) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099309572Fri, 02 Sep 2022 11:41:51 +05002099309572@Uncensored Date: Fri Sep 2 11:41:46 2022 -0400 indent -kr -i8 -brf -bbb -fnc -l132 -nce ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 132 +++++++++--------- textclient/citadel_ipc.c | 318 ++++++++++++++++++------------------------ textclient/client_chat.c | 32 +++-- textclient/client_passwords.c | 15 +- textclient/commands.c | 74 +++++----- textclient/ipc_c_tcp.c | 16 +-- textclient/messages.c | 103 +++++++------- textclient/rooms.c | 121 ++++++++-------- textclient/routines.c | 69 +++++---- textclient/routines2.c | 43 +++--- textclient/tuiconfig.c | 18 ++- 11 files changed, 440 insertions(+), 501 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099309569Fri, 02 Sep 2022 11:29:05 +05002099309569@Uncensored Date: Fri Sep 2 11:29:03 2022 -0400 More progress on moving to the box layout ----------------------------------------------------------------------- Summary of changes: webcit-ng/caldav_reports.c | 12 +++++++++--- webcit-ng/static/css/webcit.css | 33 +++++++++++++++++++++------------ webcit-ng/static/index.html | 23 +++++++++++++++-------- 3 files changed, 45 insertions(+), 23 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099309409Wed, 31 Aug 2022 17:53:25 +05002099309409@Uncensored Date: Wed Aug 31 17:52:45 2022 -0400 Use spaces in api.txt ----------------------------------------------------------------------- Summary of changes: citadel/citadel.lock | 0 citadel/config.mk | 4 +++ citadel/obsolete.txt | 43 +++++++++++++++++++++++++++++ ctdlsh/{main.c => main.c~} | 34 +++++++++++------------ textclient/citadel_ipc.c | 36 ++++++++---------------- textclient/config.mk | 5 ++++ webcit-ng/api.txt | 61 ++++++++++++++++++++--------------------- webcit-ng/static/css/webcit.css | 16 +++++++---- webcit-ng/static/index.html | 22 +++++++-------- 9 files changed, 131 insertions(+), 90 deletions(-) create mode 100644 citadel/citadel.lock create mode 100644 citadel/config.mk create mode 100644 citadel/obsolete.txt copy ctdlsh/{main.c => main.c~} (75%) create mode 100644 textclient/config.mk hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099309337Tue, 30 Aug 2022 23:20:05 +05002099309337@Uncensored Date: Tue Aug 30 23:20:03 2022 -0400 test commit ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099309332Tue, 30 Aug 2022 23:09:34 +05002099309332@Uncensored Date: Tue Aug 30 23:09:31 2022 -0400 Removed W3CSS and moved to CSS grid layout. There's a bunch of stuff left to tweak but this is going to be much easier. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/w3.css | 235 ------------------------------------ webcit-ng/static/css/webcit.css | 76 +++++++++++- webcit-ng/static/index.html | 89 +++++--------- webcit-ng/static/js/roomlist.js | 1 - webcit-ng/static/js/user_profile.js | 1 - webcit-ng/static/js/view_mail.js | 10 +- webcit-ng/static/js/views.js | 14 +-- 7 files changed, 107 insertions(+), 319 deletions(-) delete mode 100644 webcit-ng/static/css/w3.css hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099309088Sat, 27 Aug 2022 13:10:32 +05002099309088@Uncensored Date: Sat Aug 27 13:10:29 2022 -0400 Unwrapped some old 80-column code ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/smtp/serv_smtp.c | 61 +++++------- ctdlsh/main.c | 34 +++---- textclient/tuiconfig.c | 160 +++++++++++++------------------- 3 files changed, 107 insertions(+), 148 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099307597Tue, 09 Aug 2022 09:55:28 +05002099307597@Uncensored Date: Tue Aug 9 09:55:13 2022 -0400 Truncate username display to 25 characters so it doesn't overrun the column ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 2 +- textclient/commands.c | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099307596Tue, 09 Aug 2022 09:47:36 +05002099307596@Uncensored Date: Tue Aug 9 09:47:05 2022 -0400 Passing some idle time by applying rules from the style guide to commands.c ----------------------------------------------------------------------- Summary of changes: textclient/commands.c | 370 ++++++++++++++++++++++---------------------------- textclient/screen.c | 8 +- 2 files changed, 165 insertions(+), 213 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099306951Sun, 31 Jul 2022 22:05:28 +05002099306951@Uncensored Date: Sun Jul 31 22:05:18 2022 -0400 In the online users list, display partially logged in (username sent but no successful password yet) users as "not logged in" instead of displaying the user name. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/rwho/serv_rwho.c | 78 +++++++++++++-------------------- webcit-ng/static/css/webcit.css | 8 ++++ webcit-ng/static/js/view_mail.js | 19 ++++++-- 3 files changed, 54 insertions(+), 51 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099306350Fri, 22 Jul 2022 14:43:21 +05002099306350@Uncensored Date: Fri Jul 22 14:42:49 2022 -0400 Display "brief" datestamps in mailbox: date if not today, time if today. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/roomlist.js | 2 +- webcit-ng/static/js/util.js | 19 +++++++++++++++---- webcit-ng/static/js/view_forum.js | 4 ++-- webcit-ng/static/js/view_mail.js | 23 ++++++++++------------- webcit-ng/static/js/views.js | 2 +- 5 files changed, 29 insertions(+), 21 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099306239Wed, 20 Jul 2022 17:01:41 +05002099306239@Uncensored Date: Wed Jul 20 17:01:06 2022 -0400 BUILD_ID is now the output of "git describe" , falling back to the two digit year and julian date if that fails. http://code.citadel.org/?p=citadel.git&a=commit&h=71c3e52b0fa6a0ff08cabcf05efc3b74ad969518 commit 71c3e52b0fa6a0ff08cabcf05efc3b74ad969518 Author: Art Cancro Date: Wed Jul 20 16:57:01 2022 -0400 Remove w3_ from index.html ----------------------------------------------------------------------- Summary of changes: citadel/configure | 2 +- webcit-ng/static/index.html | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099306236Wed, 20 Jul 2022 16:49:04 +05002099306236@Uncensored Date: Wed Jul 20 16:48:36 2022 -0400 Increase the z-index of the fly-in menu on small screens so it isn't covered by the mailbox ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099306104Mon, 18 Jul 2022 15:34:44 +05002099306104@Uncensored Date: Mon Jul 18 15:34:41 2022 -0400 Added the dispatch function for entering a new mail message ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_mail.js | 12 ++++++++++++ webcit-ng/static/js/views.js | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099306020Sun, 17 Jul 2022 18:17:31 +05002099306020@Uncensored Date: Sun Jul 17 18:17:27 2022 -0400 Removed the excess vertical whitespace between headers and message body ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 2 +- webcit-ng/static/js/view_mail.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305970Sat, 16 Jul 2022 13:08:19 +05002099305970@Uncensored Date: Sat Jul 16 13:08:16 2022 -0400 Mailbox refresh is working completely now. ----------------------------------------------------------------------- Summary of changes: webcit-ng/README.txt | 7 ++++--- webcit-ng/room_functions.c | 1 - webcit-ng/static/js/view_mail.js | 25 +++++++++++++++++-------- 3 files changed, 21 insertions(+), 12 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305912Fri, 15 Jul 2022 13:56:20 +05002099305912@Uncensored Date: Fri Jul 15 13:56:13 2022 -0400 Add a web API command for the server STAT command. This will allow us to implement a new-messages check that does not require loading the entire room again. ----------------------------------------------------------------------- Summary of changes: webcit-ng/api.txt | 1 + webcit-ng/room_functions.c | 40 ++++++++++++++++++++++++++++++++++++++-- webcit-ng/static/js/defs.js | 1 + webcit-ng/static/js/main.js | 2 ++ webcit-ng/static/js/view_mail.js | 9 +++++++-- webcit-ng/webcit.h | 2 ++ 6 files changed, 51 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305845Thu, 14 Jul 2022 11:39:31 +05002099305845@Uncensored Date: Thu Jul 14 11:39:25 2022 -0400 All right, this is more or less it. I had to resort to creating a function stuffbar() that has to be called whenever we render a new screen in the main div, to tell it whether or not the stuffbar requires displaying in this view. Since we will be using the stuffbar for multiple things this seems ok. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 4 ++-- webcit-ng/static/js/roomlist.js | 1 + webcit-ng/static/js/user_profile.js | 1 + webcit-ng/static/js/views.js | 11 +++++++++++ 4 files changed, 15 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305794Wed, 13 Jul 2022 23:11:20 +05002099305794@Uncensored Date: Wed Jul 13 23:11:17 2022 -0400 Finally got the divs to display correctly by making the mailbox a part of the top banner. Committing this as-is even though I still hjave to make the mailbox load and unload at the correct times. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 28 +++------------------------- webcit-ng/static/index.html | 10 ++++++++-- webcit-ng/static/js/view_mail.js | 12 ++++++------ 3 files changed, 17 insertions(+), 33 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305723Tue, 12 Jul 2022 14:38:38 +05002099305723@Uncensored Date: Tue Jul 12 14:38:34 2022 -0400 Finally got the pane scrolling working the right way. Wowzers. Saving this as a commit before I mess it up again. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305714Tue, 12 Jul 2022 11:37:13 +05002099305714@Uncensored Date: Tue Jul 12 11:37:10 2022 -0400 Ok, this is close ... saving my work before I try something destructive ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 32 +++++++++++++++++++++------- webcit-ng/static/index.html | 46 +++++++++++++++++++++++----------------- webcit-ng/static/js/view_mail.js | 13 +++++++++--- 3 files changed, 60 insertions(+), 31 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305606Sun, 10 Jul 2022 19:23:03 +05002099305606@Uncensored Date: Sun Jul 10 19:23:01 2022 -0400 Convert RFC2047-encoded strings to UTF8 before display ----------------------------------------------------------------------- Summary of changes: citadel/server/internet_addressing.c | 3 ++- webcit-ng/forum_view.c | 1 + webcit-ng/room_functions.c | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305605Sun, 10 Jul 2022 19:10:13 +05002099305605@Uncensored Date: Sun Jul 10 19:09:54 2022 -0400 utf8ify_rfc822_string() is in libcitadel now ----------------------------------------------------------------------- Summary of changes: citadel/server/internet_addressing.c | 208 ------------------ citadel/server/modules/expire/serv_expire.c | 10 +- libcitadel/Makefile.in | 3 + libcitadel/lib/array.c | 15 +- libcitadel/lib/base64.c | 20 +- libcitadel/lib/decode.c | 226 ++++++++++++++++++++ libcitadel/lib/hash.c | 15 +- libcitadel/lib/html_to_ascii.c | 15 +- libcitadel/lib/json.c | 15 +- libcitadel/lib/libcitadel.c | 15 +- libcitadel/lib/libcitadel.h | 12 +- libcitadel/lib/mime_parser.c | 15 +- libcitadel/lib/stringbuf.c | 15 +- libcitadel/lib/tools.c | 16 +- libcitadel/lib/urlhandling.c | 2 + libcitadel/lib/vcard.c | 15 +- libcitadel/lib/vnote.c | 15 +- webcit-ng/static/css/webcit.css | 17 ++ webcit-ng/static/index.html | 2 +- webcit-ng/static/js/view_mail.js | 7 +- webcit/Makefile.in | 4 +- webcit/decode.c | 319 ---------------------------- webcit/webcit.h | 2 +- 23 files changed, 289 insertions(+), 694 deletions(-) create mode 100644 libcitadel/lib/decode.c delete mode 100644 webcit/decode.c hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305367Wed, 06 Jul 2022 11:52:15 +05002099305367@Uncensored Date: Wed Jul 6 11:51:18 2022 -0400 Define the citserver BUILD_ID as a five digit number consisting of the two digit year and a zero-padded three digit julian date. No, this is not Year 2100 compliant. I will be delighted if Citadel is still in use half a century after I'm dead and this will be a small problem for someone to solve. ----------------------------------------------------------------------- Summary of changes: citadel/Makefile | 5 ----- citadel/configure | 7 +------ citadel/server/citadel_dirs.c | 1 - citadel/server/citserver.c | 1 - citadel/server/clientsocket.c | 1 - citadel/server/config.c | 1 - citadel/server/context.c | 1 - citadel/server/control.c | 1 - citadel/server/database.c | 1 - citadel/server/default_timezone.c | 1 - citadel/server/domain.c | 1 - citadel/server/euidindex.c | 1 - citadel/server/genstamp.c | 13 ++++--------- citadel/server/housekeeping.c | 1 - citadel/server/internet_addressing.c | 1 - citadel/server/journaling.c | 5 ++--- citadel/server/ldap.c | 1 - citadel/server/locate_host.c | 19 ++++++------------- citadel/server/modules_init.c | 1 - citadel/server/msgbase.c | 6 ------ citadel/server/netconfig.c | 5 ----- citadel/server/room_ops.c | 5 ----- citadel/server/serv_extensions.c | 22 ++++++++-------------- citadel/server/server_main.c | 5 ----- citadel/server/support.c | 3 +++ citadel/server/sysdep.c | 5 ----- citadel/server/threads.c | 5 ----- citadel/server/user_ops.c | 5 ----- 28 files changed, 24 insertions(+), 100 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305268Mon, 04 Jul 2022 16:05:14 +05002099305268@Uncensored Date: Mon Jul 4 16:05:10 2022 -0400 Began CSS stylizing the mailbox view ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 22 ++++++++++++++++------ webcit-ng/static/js/view_forum.js | 4 ++-- webcit-ng/static/js/view_mail.js | 10 ++++++---- 3 files changed, 24 insertions(+), 12 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305254Mon, 04 Jul 2022 11:23:31 +05002099305254@Uncensored Date: Mon Jul 4 11:23:20 2022 -0400 Don't re-display a selected message when refreshing the mailbox: ----------------------------------------------------------------------- Summary of changes: webcit-ng/http.c | 6 +++--- webcit-ng/static/js/view_mail.js | 12 +++++++----- webcit-ng/webserver.c | 1 - 3 files changed, 10 insertions(+), 9 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305251Mon, 04 Jul 2022 11:17:55 +05002099305251@Uncensored Date: Mon Jul 4 11:17:52 2022 -0400 Clear any existing mailbox refresh when setting up a new one http://code.citadel.org/?p=citadel.git&a=commit&h=085dd916fef639f079d5f680aa20d007366a10f3 commit 085dd916fef639f079d5f680aa20d007366a10f3 Author: Art Cancro Date: Mon Jul 4 11:09:19 2022 -0400 Started separating mail and forum message renderers ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 10 ++++- webcit-ng/static/js/view_forum.js | 6 +-- webcit-ng/static/js/view_mail.js | 92 +++++++++++++++++++++++++++++++++++++-- 3 files changed, 100 insertions(+), 8 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305225Mon, 04 Jul 2022 00:24:52 +05002099305225@Uncensored Date: Mon Jul 4 00:24:48 2022 -0400 Added the logic to auto-refresh mailbox display ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 2 ++ webcit-ng/static/js/view_mail.js | 61 ++++++++++++++++++++++++++++++++------- 2 files changed, 53 insertions(+), 10 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305211Sun, 03 Jul 2022 17:05:07 +05002099305211@Uncensored Date: Sun Jul 3 17:04:46 2022 -0400 Rendering a single row in a mailbox now has its own function http://code.citadel.org/?p=citadel.git&a=commit&h=d4e8b9166607cc418e714c86716b55eb1f0ec116 commit d4e8b9166607cc418e714c86716b55eb1f0ec116 Author: Art Cancro Date: Sun Jul 3 16:55:42 2022 -0400 Use the library functions to stringify a date instead of doing it the hard way. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/defs.js | 2 -- webcit-ng/static/js/util.js | 37 +++++++++---------------------------- webcit-ng/static/js/view_mail.js | 32 ++++++++++++++++++++++++-------- 3 files changed, 33 insertions(+), 38 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305130Fri, 01 Jul 2022 22:17:10 +05002099305130@Uncensored Date: Fri Jul 1 22:17:06 2022 -0400 Beginnings of mailbox view ----------------------------------------------------------------------- Summary of changes: webcit-ng/room_functions.c | 3 +-- webcit-ng/static/js/view_mail.js | 35 ++++++++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 3 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305088Fri, 01 Jul 2022 12:30:13 +05002099305088@Uncensored Date: Fri Jul 1 12:30:10 2022 -0400 I can't see the screen with my sunglasses on ----------------------------------------------------------------------- Summary of changes: citadel/utils/auth.c | 1 - citadel/utils/chkpw.c | 1 - citadel/utils/chkpwd.c | 1 - citadel/utils/citmail.c | 1 - citadel/utils/ctdlmigrate.c | 4 ++-- citadel/utils/sendcommand.c | 1 - citadel/utils/setup.c | 1 - 7 files changed, 2 insertions(+), 8 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305087Fri, 01 Jul 2022 12:21:19 +05002099305087@Uncensored Date: Fri Jul 1 12:20:30 2022 -0400 New API "/ctdl/r/ROOMNAME/mailbox" downloads a mailbox summary of the current room (all fields). ----------------------------------------------------------------------- Summary of changes: webcit-ng/api.txt | 1 + webcit-ng/room_functions.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 46 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305083Fri, 01 Jul 2022 11:35:18 +05002099305083@Uncensored Date: Fri Jul 1 11:34:55 2022 -0400 Set things up for mailbox view implementation ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 19 ++++++++++--------- webcit-ng/static/js/{user_profile.js => view_mail.js} | 6 ++++-- webcit-ng/static/js/views.js | 3 ++- 3 files changed, 16 insertions(+), 12 deletions(-) copy webcit-ng/static/js/{user_profile.js => view_mail.js} (54%) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305024Thu, 30 Jun 2022 14:44:48 +05002099305024@Uncensored Date: Thu Jun 30 14:44:45 2022 -0400 Set up the view dispatcher for mailbox rooms ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 8 ++++---- webcit-ng/static/js/views.js | 10 +++++++++- 2 files changed, 13 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305012Thu, 30 Jun 2022 14:00:32 +05002099305012@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099305011Thu, 30 Jun 2022 13:56:35 +05002099305011@Uncensored Date: Thu Jun 30 13:56:30 2022 -0400 Added the javascript logic to delete a message. This pretty much completes the forum module. ----------------------------------------------------------------------- Summary of changes: webcit-ng/forum_view.c | 1 + webcit-ng/static/js/view_forum.js | 21 ++++++++++++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304955Wed, 29 Jun 2022 17:17:08 +05002099304955@Uncensored Date: Wed Jun 29 17:17:04 2022 -0400 Pass through the data to tell the client if it has room aide privileges and/or permission to delete messages in the current room. Aide or Room Aide privileges are now indicated via a user-with-cog icon in the room name banner. The delete button in the forum view now only appears if the client believes it is allowed. ----------------------------------------------------------------------- Summary of changes: webcit-ng/room_functions.c | 16 ++++++++++++++-- webcit-ng/static/js/defs.js | 2 ++ webcit-ng/static/js/main.js | 8 +++++--- webcit-ng/static/js/view_forum.js | 16 ++++++++++------ webcit-ng/webcit.h | 1 + 5 files changed, 32 insertions(+), 11 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304946Wed, 29 Jun 2022 16:21:07 +05002099304946@Uncensored Date: Wed Jun 29 16:21:04 2022 -0400 new license declaration text ----------------------------------------------------------------------- Summary of changes: webcit-ng/admin_functions.c | 11 ++--------- webcit-ng/caldav_reports.c | 11 ++--------- webcit-ng/ctdl_commands.c | 11 ++--------- webcit-ng/ctdlclient.c | 11 ++--------- webcit-ng/ctdlfunctions.c | 11 ++--------- webcit-ng/floor_functions.c | 11 ++--------- webcit-ng/forum_view.c | 11 ++--------- webcit-ng/html2html.c | 11 ++--------- webcit-ng/http.c | 11 ++--------- webcit-ng/main.c | 11 ++--------- webcit-ng/messages.c | 11 ++--------- webcit-ng/request.c | 11 ++--------- webcit-ng/room_functions.c | 11 ++--------- webcit-ng/static.c | 11 ++--------- webcit-ng/static/js/defs.js | 12 ++---------- webcit-ng/static/js/login.js | 11 ++--------- webcit-ng/static/js/main.js | 11 ++--------- webcit-ng/static/js/roomlist.js | 11 ++--------- webcit-ng/static/js/user_profile.js | 11 ++--------- webcit-ng/static/js/util.js | 11 ++--------- webcit-ng/static/js/view_forum.js | 11 ++--------- webcit-ng/static/js/views.js | 11 ++--------- webcit-ng/tcp_sockets.c | 11 ++--------- webcit-ng/text2html.c | 11 ++--------- webcit-ng/tls.c | 11 ++--------- webcit-ng/user_functions.c | 11 ++--------- webcit-ng/util.c | 11 ++--------- webcit-ng/webserver.c | 11 ++--------- 28 files changed, 56 insertions(+), 253 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304943Wed, 29 Jun 2022 16:13:50 +05002099304943@Uncensored Date: Wed Jun 29 16:13:30 2022 -0400 webcit-ng: don't generate .d files , they are not needed ----------------------------------------------------------------------- Summary of changes: webcit-ng/Makefile | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304784Mon, 27 Jun 2022 21:53:17 +05002099304784@Uncensored Date: Mon Jun 27 21:52:58 2022 -0400 Removed more old artifacts from autoconf's reign of terror. ----------------------------------------------------------------------- Summary of changes: citadel/server/sysdep.h | 204 ++---------------------------------------------- 1 file changed, 6 insertions(+), 198 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304732Mon, 27 Jun 2022 12:45:58 +05002099304732@Uncensored

Those who have followed the development of the server for many years will notice an intent here.  Look at how little happens between receiving a signal and exiting the server process.  In the past, we made an effort to clean everything up.  We cleanly logged out every session, each module meticulously closed and released all of its memory and server resources, we really made an effort to come down in an organized way.

Over the years what we learned was that in the 30 to 120 seconds this would require, on many systems some other agent (either a system supervisor process or an end user) would get impatient and SIGKILL the server process.  While this worked most of the time, it sometimes led to database corruption.  For this reason I made a decision that when Citadel Server is instructed to shut down for any reason, it needs to do so as quickly as possible.  All connections are terminated, the database is flushed and cleanly closed, and we get the hell out of Dodge.  The operating system will take care of deallocating memory, and it can do this better than we can anyway.  (Yes, this means we can't use Valgrind to track memory leaks at exit time.  This is a small price to pay for such a big win.)

citserver[3417116]: sysdep: caught signal 2
citserver[3417116]: extensions: [XMPP] closing service
citserver[3417116]: extensions: [LMTP-UnF] closed unix domain socket lmtp-unfiltered.socket
citserver[3417116]: extensions: [LMTP] closed unix domain socket lmtp.socket
citserver[3417116]: extensions: [SMTP-MSA] closing service
citserver[3417116]: extensions: [SMTPs-MTA] closing service
citserver[3417116]: extensions: [SMTP-MTA] closing service
citserver[3417116]: extensions: [POP3S] closing service
citserver[3417116]: extensions: [POP3] closing service
citserver[3417116]: extensions: [NNTPS] closing service
citserver[3417116]: extensions: [NNTP] closing service
citserver[3417116]: extensions: [IMAPS] closing service
citserver[3417116]: extensions: [IMAP] closing service
citserver[3417116]: extensions: [citadel-TCP] closing service
citserver[3417116]: extensions: [citadel-UDS] closed unix domain socket citadel-admin.socket
citse ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304728Mon, 27 Jun 2022 12:35:49 +05002099304728@Uncensored Date: Mon Jun 27 12:34:48 2022 -0400 Removed close_masters() because it was completely redundant. Master sockets are already closed during extension shutdown routines. And yes we still use the word "master" because we are not politicially correct twits. ----------------------------------------------------------------------- Summary of changes: citadel/server/serv_extensions.c | 65 +++++++++++++++------------------------- citadel/server/sysdep.c | 53 -------------------------------- 2 files changed, 24 insertions(+), 94 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304723Mon, 27 Jun 2022 12:16:31 +05002099304723@Uncensored Date: Mon Jun 27 12:16:27 2022 -0400 Nothing to see here, move along ----------------------------------------------------------------------- Summary of changes: citadel/server/typesize.h | 55 +++++++++++++++++++---------------------------- 1 file changed, 22 insertions(+), 33 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304641Sat, 25 Jun 2022 13:25:34 +05002099304641@Uncensored Date: Sat Jun 25 13:25:32 2022 -0400 Removed the comments about not needing to block on select() , after remembering that even though the thundering herd problem no longer exists, we still have to deal with timer events and incoming data on client sockets. select() is still appropriate here. ----------------------------------------------------------------------- Summary of changes: citadel/server/sysdep.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304640Sat, 25 Jun 2022 13:20:56 +05002099304640@Uncensored Date: Sat Jun 25 13:20:38 2022 -0400 Mostly just changes to make the code more readable. Everyone should do this once in a while. ----------------------------------------------------------------------- Summary of changes: citadel/server/ipcdef.h | 2 +- citadel/server/modules/expire/serv_expire.c | 1 - citadel/server/room_ops.c | 264 +++++++++++----------------- citadel/server/server_main.c | 30 ++-- 4 files changed, 113 insertions(+), 184 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304635Sat, 25 Jun 2022 11:09:32 +05002099304635@Uncensored Date: Sat Jun 25 11:08:52 2022 -0400 The unused messages in setup.c are now in an unused function instead of being blocked out. I don't know if this makes a difference to the strings available for translation but I did it just in case. ----------------------------------------------------------------------- Summary of changes: citadel/utils/setup.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304388Tue, 21 Jun 2022 14:24:23 +05002099304388@Uncensored Date: Tue Jun 21 14:24:04 2022 -0400 Removed support for Solaris, which has been dead for at least five years. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/vcard/serv_vcard.c | 5 ----- citadel/server/sysdep.h | 16 ---------------- citadel/server/user_ops.c | 5 ----- citadel/utils/setup.c | 2 +- 4 files changed, 1 insertion(+), 27 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304294Mon, 20 Jun 2022 14:14:07 +05002099304294@Uncensored Date: Mon Jun 20 14:13:49 2022 -0400 I was today years old when I learned that the "thundering herd" problem no longer exists in the Linux kernel. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/crypto/serv_crypto.c | 3 +- citadel/server/sysdep.c | 154 +++++++++++++--------------- webcit-ng/webserver.c | 2 + 3 files changed, 76 insertions(+), 83 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099304105Sat, 18 Jun 2022 19:52:15 +05002099304105@Uncensored Date: Sat Jun 18 19:52:11 2022 -0400 Remove the notice that this is experimental ----------------------------------------------------------------------- Summary of changes: README.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303779Thu, 16 Jun 2022 00:01:47 +05002099303779@Uncensored Date: Thu Jun 16 00:01:44 2022 -0400 In webcit-ng, allow -h to specify the Citadel Server data directory. This will allow -h to work the same across all programs. ----------------------------------------------------------------------- Summary of changes: webcit-ng/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303742Wed, 15 Jun 2022 14:50:14 +05002099303742@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303741Wed, 15 Jun 2022 14:50:11 +05002099303741@Uncensored Date: Wed Jun 15 14:50:07 2022 -0400 Release version 957 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303740Wed, 15 Jun 2022 14:50:02 +05002099303740@Uncensored Date: Wed Jun 15 14:49:41 2022 -0400 Removed some more portability hacks that were made for systems that are now completely obsolete. ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel.h | 8 ++-- citadel/server/sysdep.h | 95 ----------------------------------------------- citadel/server/user_ops.c | 12 +++--- textclient/citadel.c | 2 +- 4 files changed, 13 insertions(+), 104 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303705Wed, 15 Jun 2022 08:54:55 +05002099303705@Uncensored Date: Wed Jun 15 08:54:38 2022 -0400 Handle system accounts differently in auto purger http://code.citadel.org/?p=citadel.git&a=commit&h=ef01dd968859a9550d6c53e43ac49449d86212d3 commit ef01dd968859a9550d6c53e43ac49449d86212d3 Author: Art Cancro Date: Tue Jun 14 19:55:33 2022 -0400 Nice color modes in setup ----------------------------------------------------------------------- Summary of changes: citadel/po/citadel-setup/ar.po | 2 +- citadel/po/citadel-setup/citadel-setup.pot | 2 +- citadel/po/citadel-setup/cs.po | 2 +- citadel/po/citadel-setup/de.po | 2 +- citadel/po/citadel-setup/en_GB.po | 4 +- citadel/po/citadel-setup/es.po | 2 +- citadel/po/citadel-setup/fi.po | 2 +- citadel/po/citadel-setup/fr.po | 2 +- citadel/po/citadel-setup/hu.po | 2 +- citadel/po/citadel-setup/it.po | 2 +- citadel/po/citadel-setup/ja.po | 2 +- citadel/po/citadel-setup/kk.po | 2 +- citadel/po/citadel-setup/ko.po | 2 +- citadel/po/citadel-setup/pl.po | 2 +- citadel/po/citadel-setup/pt.po | 2 +- citadel/po/citadel-setup/pt_BR.po | 2 +- citadel/po/citadel-setup/ru.po | 2 +- citadel/po/citadel-setup/sv.po | 2 +- citadel/po/citadel-setup/vi.po | 2 +- citadel/server/modules/expire/serv_expire.c | 9 +- citadel/server/parsedate.c | 1126 ++++++++++++--------------- citadel/server/user_ops.c | 5 + citadel/utils/setup.c | 34 +- 23 files changed, 545 insertions(+), 669 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303653Tue, 14 Jun 2022 19:26:07 +05002099303653@Uncensored Date: Tue Jun 14 19:24:38 2022 -0400 configure (in Citadel Server) - don't accept "--prefix" anymore. This option might confuse some people into thinking they're going to get ${prefix}/[bin|etc|var] but we don't do that. Now we only accept "--ctdldir" to reflect our own directory hierarchy. Easy Install has been modified to use --ctdldir as well. ----------------------------------------------------------------------- Summary of changes: citadel/configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303624Tue, 14 Jun 2022 15:07:19 +05002099303624@Uncensored Date: Tue Jun 14 15:06:16 2022 -0400 CtdlEncodeBase64() - only add linebreaks if told to by the caller. Also changed this parameter to an enum. ----------------------------------------------------------------------- Summary of changes: citadel/server/modules/bio/serv_bio.c | 2 +- citadel/server/modules/image/serv_image.c | 6 +++--- citadel/server/modules/imap/serv_imap.c | 6 +++--- citadel/server/modules/migrate/serv_migrate.c | 2 +- citadel/server/modules/smtp/serv_smtp.c | 4 ++-- citadel/server/modules/upgrade/serv_upgrade.c | 4 ++-- citadel/server/modules/wiki/serv_wiki.c | 2 +- citadel/server/netconfig.c | 2 +- libcitadel/lib/base64.c | 6 ++++-- libcitadel/lib/libcitadel.h | 4 ++++ libcitadel/lib/tools.c | 2 +- textclient/client_passwords.c | 4 ++-- webcit-ng/admin_functions.c | 2 +- webcit-ng/ctdlclient.c | 2 +- webcit/messages.c | 2 +- webcit/sieve.c | 2 +- 16 files changed, 29 insertions(+), 23 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303390Sun, 12 Jun 2022 21:28:41 +05002099303390@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303389Sun, 12 Jun 2022 21:28:38 +05002099303389@Uncensored Date: Sun Jun 12 21:28:35 2022 -0400 Release version 956 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=d710e0b3ecf3c5e7021ab3cb3fae3517d932a6fc commit d710e0b3ecf3c5e7021ab3cb3fae3517d932a6fc Author: Art Cancro Date: Sun Jun 12 21:28:30 2022 -0400 sed might be sed on some systems and gsed on others ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/scripts/get_ical_data.sh | 22 +++++++++++++++++----- webcit/webcit.h | 2 +- 6 files changed, 22 insertions(+), 10 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303383Sun, 12 Jun 2022 21:20:35 +05002099303383@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303382Sun, 12 Jun 2022 21:20:32 +05002099303382@Uncensored Date: Sun Jun 12 21:20:30 2022 -0400 Release version 955 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel.h | 4 ++-- citadel/server/sysdep.h | 3 --- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 6 files changed, 6 insertions(+), 9 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303373Sun, 12 Jun 2022 21:02:07 +05002099303373@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303372Sun, 12 Jun 2022 21:02:06 +05002099303372@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303371Sun, 12 Jun 2022 21:02:06 +05002099303371@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303370Sun, 12 Jun 2022 21:02:05 +05002099303370@Uncensored Date: Sun Jun 12 21:01:55 2022 -0400 Release version 954 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=f8fb91893d1a4e9416b9238e4b695718c7537831 commit f8fb91893d1a4e9416b9238e4b695718c7537831 Author: Art Cancro Date: Sun Jun 12 21:01:40 2022 -0400 Release version 953 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=6d1d95cde32f6814f270529ab1301aa0a32165d1 commit 6d1d95cde32f6814f270529ab1301aa0a32165d1 Author: Art Cancro Date: Sun Jun 12 21:00:26 2022 -0400 Release version 952 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/server/citadel.h | 2 +- do-release.sh | 6 +++--- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303339Sun, 12 Jun 2022 17:05:15 +05002099303339@Uncensored

 

Sat Jun 11 2022 13:12:07 EDT from IGnatius T Foobar Subject: Re: Notes on new build system

I'm going to need some help with QA on FreeBSD and I'm hoping that LadySerenaKitty is willing to continue offering a bit of time in that area.

 

The running theory is that I am going to continue halping, but that's just a theory, A CODE THEORY!

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303311Sun, 12 Jun 2022 14:22:58 +05002099303311@Uncensored Date: Sun Jun 12 14:22:38 2022 -0400 Add ${LDFLAGS} to utilities, not just the server. ----------------------------------------------------------------------- Summary of changes: citadel/Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303256Sun, 12 Jun 2022 00:28:46 +05002099303256@Uncensored Date: Sun Jun 12 00:27:59 2022 -0400 There are three specific compiler warnings that we don't care about. Suppress them using a GCC pragma in the header files instead of mucking up the build system. ----------------------------------------------------------------------- Summary of changes: citadel/configure | 2 +- citadel/server/citadel.h | 99 +++++++++++++++---------------------------- citadel/server/citadel_dirs.h | 2 +- citadel/server/citserver.h | 3 -- 4 files changed, 35 insertions(+), 71 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303253Sun, 12 Jun 2022 00:02:25 +05002099303253@Uncensored Date: Sun Jun 12 00:01:58 2022 -0400 More tweaking to cleanly support bin and run directories. ----------------------------------------------------------------------- Summary of changes: citadel/Makefile | 6 +- citadel/Makefile.in | 343 -------- citadel/README.txt | 3 +- citadel/configure.ac | 994 ----------------------- citadel/{COPYING => license.txt} | 0 citadel/mkinstalldirs | 38 - citadel/server/citadel_dirs.h | 4 +- citadel/server/modules/autocompletion/.gitignore | 1 - citadel/server/modules/bio/.gitignore | 1 - citadel/server/modules/bio/serv_bio.c | 71 +- citadel/server/modules/calendar/.gitignore | 1 - citadel/server/modules/checkpoint/.gitignore | 1 - citadel/server/modules/clamav/.gitignore | 1 - citadel/server/modules/crypto/.gitignore | 1 - citadel/server/modules/expire/.gitignore | 1 - citadel/server/modules/fulltext/.gitignore | 1 - citadel/server/modules/imap/.gitignore | 1 - citadel/server/modules/inboxrules/.gitignore | 1 - citadel/server/modules/inetcfg/.gitignore | 1 - citadel/server/modules/instmsg/.gitignore | 1 - citadel/server/modules/listsub/.gitignore | 1 - citadel/server/modules/migrate/.gitignore | 1 - citadel/server/modules/newuser/.gitignore | 1 - citadel/server/modules/notes/.gitignore | 1 - citadel/server/modules/openid/.gitignore | 1 - citadel/server/modules/pop3/.gitignore | 1 - citadel/server/modules/pop3client/.gitignore | 1 - citadel/server/modules/roomchat/.gitignore | 1 - citadel/server/modules/rssclient/.gitignore | 1 - citadel/server/modules/rwho/.gitignore | 1 - citadel/server/modules/smtp/.gitignore | 1 - citadel/server/modules/spam/.gitignore | 1 - citadel/server/modules/test/.gitignore | 1 - citadel/server/modules/upgrade/.gitignore | 1 - citadel/server/modules/vcard/.gitignore | 1 - citadel/server/modules/wiki/.gitignore | 1 - citadel/server/modules/xmpp/.gitignore | 1 - citadel/server/modules_init.c | 92 +-- citadel/utils/guesstimezone.sh | 0 39 files changed, 78 insertions(+), 1502 deletions(-) delete mode 100644 citadel/Makefile.in delete mode 100644 citadel/configure.ac rename citadel/{COPYING => license.txt} (100%) delete mode 100755 citadel/mkinstalldirs delete mode 100644 citadel/server/modules/autocompletion/.gitignore delete mode 100644 citadel/server/modules/bio/.gitignore delete mode 100644 citadel/server/modules/calendar/.gitignore delete mode 100644 citadel/server/modules/checkpoint/.gitignore delete mode 100644 citadel/server/modules/clamav/.gitignore delete mode 100644 citadel/server/modules/crypto/.gitignore delete mode 100644 citadel/server/modules/expire/.gitignore delete mode 100644 citadel/server/modules/fulltext/.gitignore delete mode 100644 citadel/server/modules/imap/.gitignore delete mode 100644 citadel/server/modules/inboxrules/.gitignore delete mode 100644 citadel/server/modules/inetcfg/.gitignore delete mode 100644 citadel/server/modules/instmsg/.gitignore delete mode 100644 citadel/server/modules/listsub/.gitignore delete mode 100644 citadel/server/modules/migrate/.gitignore delete mode 100644 citadel/server/modules/newuser/.gitignore delete mode 100644 citadel/server/modules/notes/.gitignore delete mode 100644 citadel/server/modules/openid/.gitignore delete mode 100644 citadel/server/modules/pop3/.gitignore delete mode 100644 citadel/server/modules/pop3client/.gitignore delete mode 100644 citadel/server/modules/roomchat/.gitignore delete mode 100644 citadel/server/modules/rssclient/.gitignore delete mode 100644 citadel/server/modules/rwho/.gitignore delete mode 100644 citadel/server/modules/smtp/.gitignore delete mode 100644 citadel/server/modules/spam/.gitignore delete mode 100644 citadel/server/modules/test/.gitignore delete mode 100644 citadel/server/modules/upgrade/.gitignore delete mode 100644 citadel/server/modules/vcard/.gitignore delete mode 100644 citadel/server/modules/wiki/.gitignore delete mode 100644 citadel/server/modules/xmpp/.gitignore mode change 100644 => 100755 citadel/utils/guesstimezone.sh hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303242Sat, 11 Jun 2022 19:41:02 +05002099303242@Uncensored Date: Sat Jun 11 19:40:07 2022 -0400 CTDLDIR is now properly compiled into the source code based on what was configured at build time. This makes it properly run from its native directory if no extra commands are supplied, but it can run from another data directory if specified. ----------------------------------------------------------------------- Summary of changes: citadel/configure | 1 + citadel/server/sysdep.h | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303239Sat, 11 Jun 2022 19:30:05 +05002099303239@Uncensored Date: Sat Jun 11 19:27:53 2022 -0400 If you can't handle me at my worst, you don't deserve me at my best. ----------------------------------------------------------------------- Summary of changes: citadel/configure | 18 +- citadel/server/citadel_dirs.h | 14 +- .../modules/autocompletion/serv_autocompletion.c | 1 + citadel/server/modules/bio/serv_bio.c | 2 +- citadel/server/modules/blog/serv_blog.c | 2 +- citadel/server/modules/calendar/serv_calendar.c | 4 +- .../server/modules/checkpoint/serv_checkpoint.c | 1 + citadel/server/modules/clamav/serv_virus.c | 1 + citadel/server/modules/ctdlproto/serv_file.c | 6 +- citadel/server/modules/ctdlproto/serv_messages.c | 6 +- citadel/server/modules/ctdlproto/serv_rooms.c | 5 +- citadel/server/modules/ctdlproto/serv_session.c | 5 +- citadel/server/modules/ctdlproto/serv_syscmds.c | 5 +- citadel/server/modules/ctdlproto/serv_user.c | 6 +- citadel/server/modules/expire/serv_expire.c | 1 + citadel/server/modules/fulltext/serv_fulltext.c | 3 +- citadel/server/modules/image/serv_image.c | 2 +- citadel/server/modules/imap/serv_imap.c | 247 ++++++++------------- .../server/modules/inboxrules/serv_inboxrules.c | 1 + citadel/server/modules/inetcfg/serv_inetcfg.c | 6 +- citadel/server/modules/instmsg/serv_instmsg.c | 4 +- .../server/modules/listdeliver/serv_listdeliver.c | 2 +- citadel/server/modules/listsub/serv_listsub.c | 4 +- citadel/server/modules/migrate/serv_migrate.c | 5 +- citadel/server/modules/newuser/serv_newuser.c | 1 + citadel/server/modules/nntp/serv_nntp.c | 2 + citadel/server/modules/notes/serv_notes.c | 1 + citadel/server/modules/openid/serv_openid_rp.c | 9 +- citadel/server/modules/pop3/serv_pop3.c | 1 + .../server/modules/pop3client/serv_pop3client.c | 3 +- citadel/server/modules/roomchat/serv_roomchat.c | 1 + citadel/server/modules/rssclient/serv_rssclient.c | 1 + citadel/server/modules/rwho/serv_rwho.c | 1 + citadel/server/modules/smtp/serv_smtp.c | 1 + citadel/server/modules/smtp/serv_smtpclient.c | 2 +- citadel/server/modules/spam/serv_spam.c | 2 +- citadel/server/modules/test/serv_test.c | 1 + citadel/server/modules/upgrade/serv_upgrade.c | 1 + citadel/server/modules/vcard/serv_vcard.c | 3 +- citadel/server/modules/wiki/serv_wiki.c | 4 +- citadel/server/modules/xmpp/serv_xmpp.c | 3 + citadel/server/modules_init.h | 2 +- 42 files changed, 160 insertions(+), 230 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303223Sat, 11 Jun 2022 13:48:51 +05002099303223@Uncensored Date: Sat Jun 11 13:46:34 2022 -0400 More work on "make install" including some simplification of database_cleanup.sh. Debian stopped updating their Berkeley DB packages so we aren't going to support their "db{version}_util" syntax anymore. This makes life easier for the build process, even though we now have no hope of expecting that a compatible version of BDB will be available in the operating system." ----------------------------------------------------------------------- Summary of changes: citadel/Makefile | 8 ++++++ citadel/utils/database_cleanup.sh | 60 ++++++++++++--------------------------- 2 files changed, 26 insertions(+), 42 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303216Sat, 11 Jun 2022 13:12:07 +05002099303216@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303118Fri, 10 Jun 2022 12:27:08 +05002099303118@Uncensored

Didn't want to put it in the news room, but IG : if you ever need access to other ARM hardware beyond a PI, let me know and ill get you a VPN account or something to use.  I also have plenty of VM space if you need throwaway *BSD to test with.

and wait, just Linux BSD? What about 9Front  ??? :)  ( just teasing )

I also do have functioning RiscV hardware i can put out there, if its of interest. ( still lower end hardware just a dual core/8g ram, but its functional now at least )

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303025Thu, 09 Jun 2022 16:21:24 +05002099303025@Uncensored Date: Thu Jun 9 16:21:20 2022 -0400 Modified some of the server source files to carry the new and improved version of the GPL declaration that disrespects Richard Stallman. ----------------------------------------------------------------------- Summary of changes: citadel/server/database.c | 10 ++---- citadel/server/default_timezone.c | 24 +++++--------- citadel/server/domain.c | 57 +++++++++++++------------------- citadel/server/euidindex.c | 13 +++----- citadel/server/genstamp.c | 5 +++ citadel/server/housekeeping.c | 63 +++++++++++++----------------------- citadel/server/internet_addressing.c | 10 ++---- citadel/server/journaling.c | 22 ++++--------- citadel/server/ldap.c | 10 ++---- 9 files changed, 78 insertions(+), 136 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099303024Thu, 09 Jun 2022 16:14:29 +05002099303024@Uncensored Date: Thu Jun 9 16:14:26 2022 -0400 Make sure all of the utilities carry the new and improved version of the GPL declaration that disrespects Richard Stallman. ----------------------------------------------------------------------- Summary of changes: citadel/utils/ctdlmigrate.c | 10 +++------- citadel/utils/sendcommand.c | 10 +++------- citadel/utils/setup.c | 15 +++++---------- 3 files changed, 11 insertions(+), 24 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099302886Wed, 08 Jun 2022 15:26:55 +05002099302886@Uncensored Date: Wed Jun 8 15:26:51 2022 -0400 textclient: test to see whether iconv requires -liconv in ldflags. Now it should work on both Linux and FreeBSD. I will backport this patch to the production release. ----------------------------------------------------------------------- Summary of changes: citadel/bootstrap | 7 ++----- citadel/configure | 1 + citadel/packageversion | 1 - textclient/configure | 43 ++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 45 insertions(+), 7 deletions(-) delete mode 100644 citadel/packageversion hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099302835Wed, 08 Jun 2022 10:20:20 +05002099302835@Uncensored Date: Wed Jun 8 10:20:16 2022 -0400 chkpw and chkpwd are now working ----------------------------------------------------------------------- Summary of changes: citadel/Makefile | 14 ++++++++--- citadel/configure | 62 +++++++++++++++++++++++++++++++--------------- citadel/server/citserver.c | 6 +++++ citadel/utils/auth.c | 7 +++--- citadel/utils/chkpw.c | 26 +++++++------------ citadel/utils/chkpwd.c | 23 ++++++++--------- 6 files changed, 80 insertions(+), 58 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099302552Sun, 05 Jun 2022 13:05:42 +05002099302552@Uncensored Date: Sun Jun 5 13:05:38 2022 -0400 Converted citmail to the new setup: http://code.citadel.org/?p=citadel.git&a=commit&h=dbed85c6d6552ab0e6299669f759a39abb7557ae commit dbed85c6d6552ab0e6299669f759a39abb7557ae Author: Art Cancro Date: Sun Jun 5 13:02:46 2022 -0400 Converted two more utilities: ctdlmigrate and sendcommand ----------------------------------------------------------------------- Summary of changes: citadel/COPYING | 3 +- citadel/Makefile | 11 +++++++- citadel/packageversion | 2 +- citadel/utils/citmail.c | 8 +++--- citadel/utils/ctdlmigrate.c | 10 +++---- citadel/utils/sendcommand.c | 67 ++++++++++++++++++--------------------------- 6 files changed, 47 insertions(+), 54 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099302548Sun, 05 Jun 2022 12:49:19 +05002099302548@Uncensored Date: Sun Jun 5 12:49:16 2022 -0400 Moved 'setup' to the utils directory and converted the build ----------------------------------------------------------------------- Summary of changes: citadel/Makefile | 15 +- citadel/acinclude.m4 | 50 ------ citadel/bootstrap | 26 --- citadel/configure | 23 ++- citadel/configure.ac | 15 ++ citadel/install-sh | 250 --------------------------- citadel/internetmail.h | 2 - citadel/m4/ucread.m4 | 33 ---- citadel/scripts/dolcov.sh | 24 --- citadel/scripts/mk_module_init.sh | 215 ----------------------- citadel/scripts/valgrind_suspressions.txt | 273 ------------------------------ citadel/{ => utils}/auth.c | 0 citadel/{ => utils}/auth.h | 0 citadel/{ => utils}/axdefs.h | 0 citadel/{ => utils}/chkpw.c | 0 citadel/{ => utils}/chkpwd.c | 0 citadel/{ => utils}/citadel.pam | 0 citadel/{ => utils}/citmail.c | 0 citadel/{ => utils}/ctdlmigrate.c | 0 citadel/{ => utils}/database_cleanup.sh | 0 citadel/{ => utils}/guesstimezone.sh | 2 +- citadel/{ => utils}/sendcommand.c | 0 citadel/{ => utils}/setup.c | 182 ++++++++------------ 23 files changed, 113 insertions(+), 997 deletions(-) delete mode 100644 citadel/acinclude.m4 delete mode 100644 citadel/install-sh delete mode 100644 citadel/internetmail.h delete mode 100644 citadel/m4/ucread.m4 delete mode 100755 citadel/scripts/dolcov.sh delete mode 100755 citadel/scripts/mk_module_init.sh delete mode 100644 citadel/scripts/valgrind_suspressions.txt rename citadel/{ => utils}/auth.c (100%) rename citadel/{ => utils}/auth.h (100%) rename citadel/{ => utils}/axdefs.h (100%) rename citadel/{ => utils}/chkpw.c (100%) rename citadel/{ => utils}/chkpwd.c (100%) rename citadel/{ => utils}/citadel.pam (100%) rename citadel/{ => utils}/citmail.c (100%) rename citadel/{ => utils}/ctdlmigrate.c (100%) rename citadel/{ => utils}/database_cleanup.sh (100%) rename citadel/{ => utils}/guesstimezone.sh (99%) rename citadel/{ => utils}/sendcommand.c (100%) rename citadel/{ => utils}/setup.c (84%) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099302510Sat, 04 Jun 2022 19:12:09 +05002099302510@Uncensored Date: Sat Jun 4 19:11:58 2022 -0400 This is an omnibus commit which moves the Citadel Server from crusty old GNU Autotools to the shiny new conf-IG-ure system. WARNING BROKEN BUILD ALERT: at the moment it only compiles the server and lacks 'clean' and 'install' targets. Subsequent commits will resolve these but don't try to build production from this yet. ----------------------------------------------------------------------- Summary of changes: citadel/.gitignore | 17 - citadel/COPYING | 24 +- citadel/Makefile | 27 + citadel/config.guess | 1701 ------------------ citadel/config.sub | 1855 -------------------- {textclient => citadel}/configure | 23 +- citadel/missing | 283 --- citadel/modules/blog/serv_blog.c | 90 - citadel/scripts/mk_svn_revision.sh | 78 - citadel/{ => server}/citadel.h | 0 citadel/{ => server}/citadel_dirs.c | 0 citadel/{ => server}/citadel_dirs.h | 0 citadel/{ => server}/citadel_ldap.h | 0 citadel/{ => server}/citserver.c | 2 +- citadel/{ => server}/citserver.h | 0 citadel/{ => server}/clientsocket.c | 0 citadel/{ => server}/clientsocket.h | 0 citadel/{ => server}/config.c | 0 citadel/{ => server}/config.h | 0 citadel/{ => server}/context.c | 0 citadel/{ => server}/context.h | 0 citadel/{ => server}/control.c | 9 +- citadel/{ => server}/control.h | 0 citadel/{ => server}/ctdl_module.h | 5 +- citadel/{ => server}/database.c | 9 +- citadel/{ => server}/database.h | 0 citadel/{ => server}/default_timezone.c | 0 citadel/{ => server}/default_timezone.h | 0 citadel/{ => server}/domain.c | 0 citadel/{ => server}/domain.h | 0 citadel/{ => server}/euidindex.c | 5 +- citadel/{ => server}/euidindex.h | 0 citadel/{ => server}/genstamp.c | 0 citadel/{ => server}/genstamp.h | 0 citadel/{ => server}/housekeeping.c | 0 citadel/{ => server}/housekeeping.h | 0 citadel/{ => server}/internet_addressing.c | 1 - citadel/{ => server}/internet_addressing.h | 0 citadel/{ => server}/ipcdef.h | 0 citadel/{ => server}/journaling.c | 0 citadel/{ => server}/journaling.h | 0 citadel/{ => server}/ldap.c | 6 + citadel/{ => server}/locate_host.c | 0 citadel/{ => server}/locate_host.h | 0 .../{ => server}/modules/autocompletion/.gitignore | 0 .../modules/autocompletion/serv_autocompletion.c | 12 +- .../modules/autocompletion/serv_autocompletion.h | 0 citadel/{ => server}/modules/bio/.gitignore | 0 citadel/{ => server}/modules/bio/serv_bio.c | 14 +- citadel/server/modules/blog/serv_blog.c | 80 + citadel/{ => server}/modules/calendar/.gitignore | 0 .../{ => server}/modules/calendar/serv_calendar.c | 22 +- .../{ => server}/modules/calendar/serv_calendar.h | 0 citadel/{ => server}/modules/checkpoint/.gitignore | 0 .../modules/checkpoint/serv_checkpoint.c | 29 +- citadel/{ => server}/modules/clamav/.gitignore | 0 citadel/{ => server}/modules/clamav/serv_virus.c | 36 +- citadel/{ => server}/modules/crypto/.gitignore | 0 citadel/{ => server}/modules/crypto/serv_crypto.c | 14 +- citadel/{ => server}/modules/crypto/serv_crypto.h | 0 citadel/{ => server}/modules/ctdlproto/files.h | 0 .../modules/ctdlproto/serv_ctdlproto.c | 6 +- citadel/{ => server}/modules/ctdlproto/serv_file.c | 17 +- .../{ => server}/modules/ctdlproto/serv_messages.c | 17 +- .../{ => server}/modules/ctdlproto/serv_rooms.c | 13 +- .../{ => server}/modules/ctdlproto/serv_session.c | 14 +- .../{ => server}/modules/ctdlproto/serv_syscmds.c | 9 +- citadel/{ => server}/modules/ctdlproto/serv_user.c | 17 +- citadel/{ => server}/modules/expire/.gitignore | 0 .../{ => server}/modules/expire/expire_policy.c | 24 +- citadel/{ => server}/modules/expire/policy.h | 0 citadel/{ => server}/modules/expire/serv_expire.c | 32 +- citadel/{ => server}/modules/fulltext/.gitignore | 0 citadel/{ => server}/modules/fulltext/crc16.c | 0 citadel/{ => server}/modules/fulltext/crc16.h | 0 .../{ => server}/modules/fulltext/ft_wordbreaker.c | 22 +- .../{ => server}/modules/fulltext/ft_wordbreaker.h | 0 .../{ => server}/modules/fulltext/serv_fulltext.c | 33 +- .../{ => server}/modules/fulltext/serv_fulltext.h | 0 citadel/{ => server}/modules/image/serv_image.c | 12 +- citadel/{ => server}/modules/imap/.gitignore | 0 citadel/{ => server}/modules/imap/imap_acl.c | 26 +- citadel/{ => server}/modules/imap/imap_acl.h | 0 citadel/{ => server}/modules/imap/imap_fetch.c | 26 +- citadel/{ => server}/modules/imap/imap_fetch.h | 0 citadel/{ => server}/modules/imap/imap_list.c | 24 +- citadel/{ => server}/modules/imap/imap_list.h | 0 citadel/{ => server}/modules/imap/imap_metadata.c | 27 +- citadel/{ => server}/modules/imap/imap_metadata.h | 0 citadel/{ => server}/modules/imap/imap_misc.c | 30 +- citadel/{ => server}/modules/imap/imap_misc.h | 0 citadel/{ => server}/modules/imap/imap_search.c | 26 +- citadel/{ => server}/modules/imap/imap_search.h | 0 citadel/{ => server}/modules/imap/imap_store.c | 26 +- citadel/{ => server}/modules/imap/imap_store.h | 0 citadel/{ => server}/modules/imap/imap_tools.c | 8 +- citadel/{ => server}/modules/imap/imap_tools.h | 0 citadel/{ => server}/modules/imap/serv_imap.c | 49 +- citadel/{ => server}/modules/imap/serv_imap.h | 0 citadel/{ => server}/modules/inboxrules/.gitignore | 0 .../modules/inboxrules/serv_inboxrules.c | 26 +- citadel/{ => server}/modules/inetcfg/.gitignore | 0 .../{ => server}/modules/inetcfg/serv_inetcfg.c | 34 +- citadel/{ => server}/modules/instmsg/.gitignore | 0 .../{ => server}/modules/instmsg/serv_instmsg.c | 27 +- .../{ => server}/modules/instmsg/serv_instmsg.h | 1 - .../modules/listdeliver/serv_listdeliver.c | 27 +- citadel/{ => server}/modules/listsub/.gitignore | 0 .../{ => server}/modules/listsub/serv_listsub.c | 30 +- citadel/{ => server}/modules/migrate/.gitignore | 0 .../{ => server}/modules/migrate/serv_migrate.c | 30 +- citadel/{ => server}/modules/newuser/.gitignore | 0 .../{ => server}/modules/newuser/serv_newuser.c | 28 +- citadel/{ => server}/modules/nntp/serv_nntp.c | 44 +- citadel/{ => server}/modules/nntp/serv_nntp.h | 0 citadel/{ => server}/modules/nntp/wildmat.c | 0 citadel/{ => server}/modules/notes/.gitignore | 0 citadel/{ => server}/modules/notes/serv_notes.c | 28 +- citadel/{ => server}/modules/openid/.gitignore | 0 .../{ => server}/modules/openid/serv_openid_rp.c | 18 +- citadel/{ => server}/modules/pop3/.gitignore | 0 citadel/{ => server}/modules/pop3/serv_pop3.c | 30 +- citadel/{ => server}/modules/pop3/serv_pop3.h | 0 citadel/{ => server}/modules/pop3client/.gitignore | 0 .../modules/pop3client/serv_pop3client.c | 34 +- citadel/{ => server}/modules/roomchat/.gitignore | 0 .../{ => server}/modules/roomchat/serv_roomchat.c | 26 +- citadel/{ => server}/modules/rssclient/.gitignore | 0 .../modules/rssclient/serv_rssclient.c | 34 +- citadel/{ => server}/modules/rwho/.gitignore | 0 citadel/{ => server}/modules/rwho/serv_rwho.c | 30 +- citadel/{ => server}/modules/smtp/.gitignore | 0 citadel/{ => server}/modules/smtp/serv_smtp.c | 39 +- .../{ => server}/modules/smtp/serv_smtpclient.c | 29 +- citadel/{ => server}/modules/smtp/smtp_util.c | 36 +- citadel/{ => server}/modules/smtp/smtp_util.h | 0 citadel/{ => server}/modules/spam/.gitignore | 0 citadel/{ => server}/modules/spam/serv_spam.c | 36 +- citadel/{ => server}/modules/test/.gitignore | 0 citadel/{ => server}/modules/test/serv_test.c | 44 +- citadel/{ => server}/modules/upgrade/.gitignore | 0 .../{ => server}/modules/upgrade/serv_upgrade.c | 40 +- .../{ => server}/modules/upgrade/serv_upgrade.h | 0 citadel/{ => server}/modules/vcard/.gitignore | 0 citadel/{ => server}/modules/vcard/serv_vcard.c | 38 +- citadel/{ => server}/modules/wiki/.gitignore | 0 citadel/{ => server}/modules/wiki/serv_wiki.c | 40 +- citadel/{ => server}/modules/xmpp/.gitignore | 0 citadel/{ => server}/modules/xmpp/serv_xmpp.c | 27 +- citadel/{ => server}/modules/xmpp/serv_xmpp.h | 0 citadel/{ => server}/modules/xmpp/xmpp_messages.c | 16 +- citadel/{ => server}/modules/xmpp/xmpp_presence.c | 16 +- .../modules/xmpp/xmpp_query_namespace.c | 16 +- citadel/{ => server}/modules/xmpp/xmpp_queue.c | 16 +- .../{ => server}/modules/xmpp/xmpp_sasl_service.c | 18 +- citadel/server/modules_init.c | 75 + citadel/server/modules_init.h | 64 + citadel/{ => server}/msgbase.c | 13 +- citadel/{ => server}/msgbase.h | 2 +- citadel/{ => server}/netconfig.c | 10 +- citadel/{ => server}/parsedate.c | 0 citadel/{ => server}/parsedate.h | 0 citadel/{ => server}/parsedate.y | 0 citadel/{ => server}/room_ops.c | 1 - citadel/{ => server}/room_ops.h | 7 +- citadel/{ => server}/serv_extensions.c | 0 citadel/{ => server}/serv_extensions.h | 0 citadel/{ => server}/serv_vcard.h | 0 citadel/{ => server}/server.h | 0 citadel/{ => server}/server_main.c | 7 +- citadel/{ => server}/support.c | 0 citadel/{ => server}/support.h | 0 citadel/{ => server}/sysconfig.h | 0 citadel/{ => server}/sysdep.c | 0 citadel/server/sysdep.h | 349 ++++ citadel/{ => server}/sysdep_decls.h | 0 citadel/{ => server}/threads.c | 2 +- citadel/{ => server}/threads.h | 0 citadel/{ => server}/typesize.h | 0 citadel/{ => server}/user_ops.c | 0 citadel/{ => server}/user_ops.h | 0 citadel/svn_revision.h | 5 - 182 files changed, 1325 insertions(+), 4868 deletions(-) create mode 100644 citadel/Makefile delete mode 100644 citadel/config.guess delete mode 100644 citadel/config.sub copy {textclient => citadel}/configure (80%) delete mode 100755 citadel/missing delete mode 100644 citadel/modules/blog/serv_blog.c delete mode 100755 citadel/scripts/mk_svn_revision.sh rename citadel/{ => server}/citadel.h (100%) rename citadel/{ => server}/citadel_dirs.c (100%) rename citadel/{ => server}/citadel_dirs.h (100%) rename citadel/{ => server}/citadel_ldap.h (100%) rename citadel/{ => server}/citserver.c (99%) rename citadel/{ => server}/citserver.h (100%) rename citadel/{ => server}/clientsocket.c (100%) rename citadel/{ => server}/clientsocket.h (100%) rename citadel/{ => server}/config.c (100%) rename citadel/{ => server}/config.h (100%) rename citadel/{ => server}/context.c (100%) rename citadel/{ => server}/context.h (100%) rename citadel/{ => server}/control.c (99%) rename citadel/{ => server}/control.h (100%) rename citadel/{ => server}/ctdl_module.h (99%) rename citadel/{ => server}/database.c (98%) rename citadel/{ => server}/database.h (100%) rename citadel/{ => server}/default_timezone.c (100%) rename citadel/{ => server}/default_timezone.h (100%) rename citadel/{ => server}/domain.c (100%) rename citadel/{ => server}/domain.h (100%) rename citadel/{ => server}/euidindex.c (98%) rename citadel/{ => server}/euidindex.h (100%) rename citadel/{ => server}/genstamp.c (100%) rename citadel/{ => server}/genstamp.h (100%) rename citadel/{ => server}/housekeeping.c (100%) rename citadel/{ => server}/housekeeping.h (100%) rename citadel/{ => server}/internet_addressing.c (99%) rename citadel/{ => server}/internet_addressing.h (100%) rename citadel/{ => server}/ipcdef.h (100%) rename citadel/{ => server}/journaling.c (100%) rename citadel/{ => server}/journaling.h (100%) rename citadel/{ => server}/ldap.c (98%) rename citadel/{ => server}/locate_host.c (100%) rename citadel/{ => server}/locate_host.h (100%) rename citadel/{ => server}/modules/autocompletion/.gitignore (100%) rename citadel/{ => server}/modules/autocompletion/serv_autocompletion.c (96%) rename citadel/{ => server}/modules/autocompletion/serv_autocompletion.h (100%) rename citadel/{ => server}/modules/bio/.gitignore (100%) rename citadel/{ => server}/modules/bio/serv_bio.c (96%) create mode 100644 citadel/server/modules/blog/serv_blog.c rename citadel/{ => server}/modules/calendar/.gitignore (100%) rename citadel/{ => server}/modules/calendar/serv_calendar.c (99%) rename citadel/{ => server}/modules/calendar/serv_calendar.h (100%) rename citadel/{ => server}/modules/checkpoint/.gitignore (100%) rename citadel/{ => server}/modules/checkpoint/serv_checkpoint.c (65%) rename citadel/{ => server}/modules/clamav/.gitignore (100%) rename citadel/{ => server}/modules/clamav/serv_virus.c (89%) rename citadel/{ => server}/modules/crypto/.gitignore (100%) rename citadel/{ => server}/modules/crypto/serv_crypto.c (98%) rename citadel/{ => server}/modules/crypto/serv_crypto.h (100%) rename citadel/{ => server}/modules/ctdlproto/files.h (100%) rename citadel/{ => server}/modules/ctdlproto/serv_ctdlproto.c (96%) rename citadel/{ => server}/modules/ctdlproto/serv_file.c (98%) rename citadel/{ => server}/modules/ctdlproto/serv_messages.c (99%) rename citadel/{ => server}/modules/ctdlproto/serv_rooms.c (99%) rename citadel/{ => server}/modules/ctdlproto/serv_session.c (96%) rename citadel/{ => server}/modules/ctdlproto/serv_syscmds.c (93%) rename citadel/{ => server}/modules/ctdlproto/serv_user.c (98%) rename citadel/{ => server}/modules/expire/.gitignore (100%) rename citadel/{ => server}/modules/expire/expire_policy.c (93%) rename citadel/{ => server}/modules/expire/policy.h (100%) rename citadel/{ => server}/modules/expire/serv_expire.c (98%) rename citadel/{ => server}/modules/fulltext/.gitignore (100%) rename citadel/{ => server}/modules/fulltext/crc16.c (100%) rename citadel/{ => server}/modules/fulltext/crc16.h (100%) rename citadel/{ => server}/modules/fulltext/ft_wordbreaker.c (92%) rename citadel/{ => server}/modules/fulltext/ft_wordbreaker.h (100%) rename citadel/{ => server}/modules/fulltext/serv_fulltext.c (96%) rename citadel/{ => server}/modules/fulltext/serv_fulltext.h (100%) rename citadel/{ => server}/modules/image/serv_image.c (98%) rename citadel/{ => server}/modules/imap/.gitignore (100%) rename citadel/{ => server}/modules/imap/imap_acl.c (95%) rename citadel/{ => server}/modules/imap/imap_acl.h (100%) rename citadel/{ => server}/modules/imap/imap_fetch.c (99%) rename citadel/{ => server}/modules/imap/imap_fetch.h (100%) rename citadel/{ => server}/modules/imap/imap_list.c (96%) rename citadel/{ => server}/modules/imap/imap_list.h (100%) rename citadel/{ => server}/modules/imap/imap_metadata.c (95%) rename citadel/{ => server}/modules/imap/imap_metadata.h (100%) rename citadel/{ => server}/modules/imap/imap_misc.c (95%) rename citadel/{ => server}/modules/imap/imap_misc.h (100%) rename citadel/{ => server}/modules/imap/imap_search.c (97%) rename citadel/{ => server}/modules/imap/imap_search.h (100%) rename citadel/{ => server}/modules/imap/imap_store.c (94%) rename citadel/{ => server}/modules/imap/imap_store.h (100%) rename citadel/{ => server}/modules/imap/imap_tools.c (99%) rename citadel/{ => server}/modules/imap/imap_tools.h (100%) rename citadel/{ => server}/modules/imap/serv_imap.c (98%) rename citadel/{ => server}/modules/imap/serv_imap.h (100%) rename citadel/{ => server}/modules/inboxrules/.gitignore (100%) rename citadel/{ => server}/modules/inboxrules/serv_inboxrules.c (98%) rename citadel/{ => server}/modules/inetcfg/.gitignore (100%) rename citadel/{ => server}/modules/inetcfg/serv_inetcfg.c (86%) rename citadel/{ => server}/modules/instmsg/.gitignore (100%) rename citadel/{ => server}/modules/instmsg/serv_instmsg.c (97%) rename citadel/{ => server}/modules/instmsg/serv_instmsg.h (92%) rename citadel/{ => server}/modules/listdeliver/serv_listdeliver.c (95%) rename citadel/{ => server}/modules/listsub/.gitignore (100%) rename citadel/{ => server}/modules/listsub/serv_listsub.c (96%) rename citadel/{ => server}/modules/migrate/.gitignore (100%) rename citadel/{ => server}/modules/migrate/serv_migrate.c (98%) rename citadel/{ => server}/modules/newuser/.gitignore (100%) rename citadel/{ => server}/modules/newuser/serv_newuser.c (84%) rename citadel/{ => server}/modules/nntp/serv_nntp.c (97%) rename citadel/{ => server}/modules/nntp/serv_nntp.h (100%) rename citadel/{ => server}/modules/nntp/wildmat.c (100%) rename citadel/{ => server}/modules/notes/.gitignore (100%) rename citadel/{ => server}/modules/notes/serv_notes.c (90%) rename citadel/{ => server}/modules/openid/.gitignore (100%) rename citadel/{ => server}/modules/openid/serv_openid_rp.c (99%) rename citadel/{ => server}/modules/pop3/.gitignore (100%) rename citadel/{ => server}/modules/pop3/serv_pop3.c (97%) rename citadel/{ => server}/modules/pop3/serv_pop3.h (100%) rename citadel/{ => server}/modules/pop3client/.gitignore (100%) rename citadel/{ => server}/modules/pop3client/serv_pop3client.c (93%) rename citadel/{ => server}/modules/roomchat/.gitignore (100%) rename citadel/{ => server}/modules/roomchat/serv_roomchat.c (93%) rename citadel/{ => server}/modules/rssclient/.gitignore (100%) rename citadel/{ => server}/modules/rssclient/serv_rssclient.c (95%) rename citadel/{ => server}/modules/rwho/.gitignore (100%) rename citadel/{ => server}/modules/rwho/serv_rwho.c (90%) rename citadel/{ => server}/modules/smtp/.gitignore (100%) rename citadel/{ => server}/modules/smtp/serv_smtp.c (98%) rename citadel/{ => server}/modules/smtp/serv_smtpclient.c (97%) rename citadel/{ => server}/modules/smtp/smtp_util.c (94%) rename citadel/{ => server}/modules/smtp/smtp_util.h (100%) rename citadel/{ => server}/modules/spam/.gitignore (100%) rename citadel/{ => server}/modules/spam/serv_spam.c (89%) rename citadel/{ => server}/modules/test/.gitignore (100%) rename citadel/{ => server}/modules/test/serv_test.c (54%) rename citadel/{ => server}/modules/upgrade/.gitignore (100%) rename citadel/{ => server}/modules/upgrade/serv_upgrade.c (97%) rename citadel/{ => server}/modules/upgrade/serv_upgrade.h (100%) rename citadel/{ => server}/modules/vcard/.gitignore (100%) rename citadel/{ => server}/modules/vcard/serv_vcard.c (98%) rename citadel/{ => server}/modules/wiki/.gitignore (100%) rename citadel/{ => server}/modules/wiki/serv_wiki.c (96%) rename citadel/{ => server}/modules/xmpp/.gitignore (100%) rename citadel/{ => server}/modules/xmpp/serv_xmpp.c (97%) rename citadel/{ => server}/modules/xmpp/serv_xmpp.h (100%) rename citadel/{ => server}/modules/xmpp/xmpp_messages.c (91%) rename citadel/{ => server}/modules/xmpp/xmpp_presence.c (97%) rename citadel/{ => server}/modules/xmpp/xmpp_query_namespace.c (96%) rename citadel/{ => server}/modules/xmpp/xmpp_queue.c (93%) rename citadel/{ => server}/modules/xmpp/xmpp_sasl_service.c (93%) create mode 100644 citadel/server/modules_init.c create mode 100644 citadel/server/modules_init.h rename citadel/{ => server}/msgbase.c (99%) rename citadel/{ => server}/msgbase.h (98%) rename citadel/{ => server}/netconfig.c (97%) rename citadel/{ => server}/parsedate.c (100%) rename citadel/{ => server}/parsedate.h (100%) rename citadel/{ => server}/parsedate.y (100%) rename citadel/{ => server}/room_ops.c (99%) rename citadel/{ => server}/room_ops.h (85%) rename citadel/{ => server}/serv_extensions.c (100%) rename citadel/{ => server}/serv_extensions.h (100%) rename citadel/{ => server}/serv_vcard.h (100%) rename citadel/{ => server}/server.h (100%) rename citadel/{ => server}/server_main.c (98%) rename citadel/{ => server}/support.c (100%) rename citadel/{ => server}/support.h (100%) rename citadel/{ => server}/sysconfig.h (100%) rename citadel/{ => server}/sysdep.c (100%) create mode 100644 citadel/server/sysdep.h rename citadel/{ => server}/sysdep_decls.h (100%) rename citadel/{ => server}/threads.c (99%) rename citadel/{ => server}/threads.h (100%) rename citadel/{ => server}/typesize.h (100%) rename citadel/{ => server}/user_ops.c (100%) rename citadel/{ => server}/user_ops.h (100%) delete mode 100644 citadel/svn_revision.h hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099302084Mon, 30 May 2022 18:33:51 +05002099302084@Uncensored Date: Mon May 30 18:33:41 2022 -0400 removed some debugs ----------------------------------------------------------------------- Summary of changes: citadel/chkpw.c | 3 +-- citadel/ldap.c | 11 +++++++++++ citadel/msgbase.c | 9 ++------- libcitadel/lib/mime_parser.c | 2 -- 4 files changed, 14 insertions(+), 11 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099301577Mon, 23 May 2022 15:57:52 +05002099301577@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099301576Mon, 23 May 2022 15:57:50 +05002099301576@Uncensored Date: Mon May 23 20:57:40 2022 +0100 Release version 951 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099301575Mon, 23 May 2022 15:57:36 +05002099301575@Uncensored Date: Mon May 23 20:56:39 2022 +0100 Rewrote our local implementation of a Base64 encoder/decoder as specified in RFC 2045 section 6.8. In the past, someone tried to make this "elegant" and in the process they made it broken when certain conditions exist. If you are reading this and it isn't broken, don't try to improve it. It works and I don't want to fix it again. I don't care how many nanoseconds you think you can shave off the execution time. Don't fucking touch it. ----------------------------------------------------------------------- Summary of changes: libcitadel/Makefile.in | 13 +- libcitadel/configure.in | 3 +- libcitadel/lib/b64/AUTHORS | 7 - libcitadel/lib/b64/LICENSE | 29 - libcitadel/lib/b64/README | 138 - libcitadel/lib/b64/cdecode.c | 88 - libcitadel/lib/b64/cdecode.h | 28 - libcitadel/lib/b64/cencode.c | 107 - libcitadel/lib/b64/cencode.h | 31 - libcitadel/lib/base64.c | 178 + libcitadel/lib/libcitadel.h | 6 +- libcitadel/lib/stringbuf.c | 1159 +- libcitadel/lib/tools.c | 242 +- libcitadel/tests/.gitignore | 9 - libcitadel/tests/Makefile.in | 113 - libcitadel/tests/dolcov.sh | 20 - libcitadel/tests/hashlist_test.c | 335 - libcitadel/tests/html_to_ascii_test.c | 237 - libcitadel/tests/mime_xdg_lookup_type.c | 113 - libcitadel/tests/mimeparser_test.c | 272 - libcitadel/tests/run_tests.sh | 71 - libcitadel/tests/stringbuf_IO_test.c | 480 - libcitadel/tests/stringbuf_conversion.c | 481 - libcitadel/tests/stringbuf_stream.c | 166 - libcitadel/tests/stringbuf_test.c | 650 - libcitadel/tests/stringbuf_test.h | 15 - libcitadel/tests/stripallbut_test.c | 145 - .../emailaddresses/email_recipientstrings.txt | 10 - libcitadel/tests/testdata/html/entitystrings.txt | 2 - libcitadel/tests/testdata/mime/badmsg.eml | 145 - libcitadel/tests/testdata/mime/browser.mime | Bin 9563 -> 0 bytes libcitadel/tests/testdata/mime/bumperstickers.eml | 16841 --- libcitadel/tests/testdata/mime/endlessloop.eml | 716 - libcitadel/tests/testdata/mime/karsten_1.eml | 101352 ------------------ libcitadel/tests/testdata/mime/karsten_2.eml | 90974 ---------------- .../mime/mail_with_multiple_attachments.eml | 13548 --- .../tests/testdata/mime/mime_with_base64.eml | 618 - libcitadel/tests/testdata/mime/mortorary.eml | 60 - .../tests/testdata/mime/post_mimecontainer.mime | 228 - .../tests/testdata/mime/qp_with_extra_blanks.eml | 75 - libcitadel/tests/testdata/mime/spam_GB2312.eml | 2434 - .../tests/testdata/mime/spam_iso-2022-jp.eml | 322 - libcitadel/tests/testdata/mime/spam_koir8-r.eml | 100 - libcitadel/tests/testdata/mime/spam_utf8.eml | 79 - .../tests/testdata/mime/spam_windows-1255.eml | 98 - .../tests/testdata/mime/spam_windows-1255_2.eml | 90 - .../tests/testdata/mime/spam_windows-874.eml | 40 - .../testdata/mime/vcard_hides_message_content.eml | 201 - libcitadel/tests/testdata/qpstrings/list | 2 - libcitadel/tests/token_test.c | 26 - libcitadel/tests/wildfire_test.c | 111 - webcit/messages.c | 11 - 52 files changed, 745 insertions(+), 232474 deletions(-) delete mode 100644 libcitadel/lib/b64/AUTHORS delete mode 100644 libcitadel/lib/b64/LICENSE delete mode 100644 libcitadel/lib/b64/README delete mode 100644 libcitadel/lib/b64/cdecode.c delete mode 100644 libcitadel/lib/b64/cdecode.h delete mode 100644 libcitadel/lib/b64/cencode.c delete mode 100644 libcitadel/lib/b64/cencode.h create mode 100644 libcitadel/lib/base64.c delete mode 100644 libcitadel/tests/.gitignore delete mode 100644 libcitadel/tests/Makefile.in delete mode 100644 libcitadel/tests/dolcov.sh delete mode 100644 libcitadel/tests/hashlist_test.c delete mode 100644 libcitadel/tests/html_to_ascii_test.c delete mode 100644 libcitadel/tests/mime_xdg_lookup_type.c delete mode 100644 libcitadel/tests/mimeparser_test.c delete mode 100755 libcitadel/tests/run_tests.sh delete mode 100644 libcitadel/tests/stringbuf_IO_test.c delete mode 100644 libcitadel/tests/stringbuf_conversion.c delete mode 100644 libcitadel/tests/stringbuf_stream.c delete mode 100644 libcitadel/tests/stringbuf_test.c delete mode 100644 libcitadel/tests/stringbuf_test.h delete mode 100644 libcitadel/tests/stripallbut_test.c delete mode 100644 libcitadel/tests/testdata/emailaddresses/email_recipientstrings.txt delete mode 100644 libcitadel/tests/testdata/html/entitystrings.txt delete mode 100644 libcitadel/tests/testdata/mime/badmsg.eml delete mode 100644 libcitadel/tests/testdata/mime/browser.mime delete mode 100644 libcitadel/tests/testdata/mime/bumperstickers.eml delete mode 100644 libcitadel/tests/testdata/mime/endlessloop.eml delete mode 100644 libcitadel/tests/testdata/mime/karsten_1.eml delete mode 100644 libcitadel/tests/testdata/mime/karsten_2.eml delete mode 100644 libcitadel/tests/testdata/mime/mail_with_multiple_attachments.eml delete mode 100644 libcitadel/tests/testdata/mime/mime_with_base64.eml delete mode 100644 libcitadel/tests/testdata/mime/mortorary.eml delete mode 100644 libcitadel/tests/testdata/mime/post_mimecontainer.mime delete mode 100644 libcitadel/tests/testdata/mime/qp_with_extra_blanks.eml delete mode 100644 libcitadel/tests/testdata/mime/spam_GB2312.eml delete mode 100644 libcitadel/tests/testdata/mime/spam_iso-2022-jp.eml delete mode 100644 libcitadel/tests/testdata/mime/spam_koir8-r.eml delete mode 100644 libcitadel/tests/testdata/mime/spam_utf8.eml delete mode 100644 libcitadel/tests/testdata/mime/spam_windows-1255.eml delete mode 100644 libcitadel/tests/testdata/mime/spam_windows-1255_2.eml delete mode 100644 libcitadel/tests/testdata/mime/spam_windows-874.eml delete mode 100644 libcitadel/tests/testdata/mime/vcard_hides_message_content.eml delete mode 100644 libcitadel/tests/testdata/qpstrings/list delete mode 100644 libcitadel/tests/token_test.c delete mode 100644 libcitadel/tests/wildfire_test.c hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099301472Sat, 21 May 2022 12:55:51 +05002099301472@Uncensored Date: Sat May 21 17:55:44 2022 +0100 Committing all of my little comment syntax changes and getting them out of the way because I'm about to rip out a big chunk of code and rewrite it. ----------------------------------------------------------------------- Summary of changes: citadel/msgbase.c | 92 ++++++++++++++++---------------- libcitadel/lib/mime_parser.c | 123 +++++++++++++++++-------------------------- 2 files changed, 95 insertions(+), 120 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099301406Fri, 20 May 2022 19:47:39 +05002099301406@Uncensored Date: Sat May 21 00:47:35 2022 +0100 comment style ----------------------------------------------------------------------- Summary of changes: citadel/modules/ctdlproto/serv_messages.c | 71 +++++++++------------ libcitadel/lib/stringbuf.c | 101 ++++++------------------------ webcit/messages.c | 18 +++--- 3 files changed, 59 insertions(+), 131 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099301205Wed, 18 May 2022 15:52:23 +05002099301205@Uncensored Date: Wed May 18 20:52:09 2022 +0100 Removed traces after realizing that I was hitting config.c_maxmsglen and not an actual bug. Added a debug message to indicate when this happened. ----------------------------------------------------------------------- Summary of changes: citadel/modules/inboxrules/serv_inboxrules.c | 42 ++++----- citadel/msgbase.c | 37 ++++---- libcitadel/lib/stringbuf.c | 124 ++++++++++++--------------- 3 files changed, 89 insertions(+), 114 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099301117Tue, 17 May 2022 14:03:14 +05002099301117@Uncensored Date: Tue May 17 19:03:11 2022 +0100 Temporarily added some debugs and an assert() statement to show where the message buffer is getting truncated during large reads on low memory systems. ----------------------------------------------------------------------- Summary of changes: citadel/modules/ctdlproto/serv_messages.c | 7 +++---- citadel/msgbase.c | 20 +++++++++++++++----- 2 files changed, 18 insertions(+), 9 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099301110Tue, 17 May 2022 13:13:13 +05002099301110@Uncensored Date: Tue May 17 18:13:08 2022 +0100 Found another vestige of ignet to remove ----------------------------------------------------------------------- Summary of changes: citadel/modules/ctdlproto/serv_messages.c | 8 +++----- citadel/msgbase.c | 4 ++-- citadel/server.h | 1 - webcit/messages.c | 13 +++++++------ 4 files changed, 12 insertions(+), 14 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099301013Mon, 16 May 2022 11:27:00 +05002099301013@Uncensored Date: Mon May 16 16:26:52 2022 +0100 Fixed a buffer size calculation that caused uploads to crash on memory-constrained systems such as raspberry pi. ----------------------------------------------------------------------- Summary of changes: webcit/messages.c | 249 +++++++++++++++++++++++++++++------------------------- 1 file changed, 133 insertions(+), 116 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099299973Mon, 02 May 2022 19:44:05 +05002099299973@Uncensored Date: Mon May 2 19:43:17 2022 -0400 Taking a peek at serv_expire.c to see what would be involved in deleting users who aren't in LDAP anymore. And you know what that means: I can't help myself but to update the comment style all over that file. ----------------------------------------------------------------------- Summary of changes: citadel/ldap.c | 9 +- citadel/modules/expire/serv_expire.c | 270 +++++++++++++++-------------------- 2 files changed, 116 insertions(+), 163 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099298919Tue, 19 Apr 2022 20:03:40 +05002099298919@Uncensored Date: Tue Apr 19 20:03:36 2022 -0400 Meow meow! Applied patches sent by LadySerenaKitty for improved FreeBSD compatibility. ----------------------------------------------------------------------- Summary of changes: citadel/clientsocket.c | 3 +++ citadel/domain.c | 3 +++ citadel/missing | 0 citadel/modules/nntp/serv_nntp.c | 6 ++++++ citadel/scripts/mk_module_init.sh | 2 +- citadel/scripts/mk_svn_revision.sh | 2 +- libcitadel/conftools/libtool.m4 | 8 ++++---- textclient/citadel.rc | 5 +++-- textclient/commands.c | 3 +++ textclient/configure | 4 ++-- webcit/fmt_date.c | 4 ++++ webcit/http_datestring.c | 4 ++++ webcit/scripts/get_ical_data.sh | 12 +++++++----- 13 files changed, 41 insertions(+), 15 deletions(-) mode change 100644 => 100755 citadel/missing hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099297741Sat, 09 Apr 2022 16:17:57 +05002099297741@Uncensored/info.txt now fetches the room info banner ctdl-roomlist-floor class for the floor banner over each floor's room list more divs Initial commit of the "new" room list. It's going to be a lot more "traditional web forum" looking. I hope I don't regret this. Made the bubble icons in the Forums list round, and colored differently based on the presence of new messages. Rooms in the Forums List are now clickable anywhere in the box, not just the room name. Now it has a button look. "Forum list" is now more or less in its final form. More gratuitous style cleanup. Re-encode the auth cookie with the properly formatted user name. This makes the client side parse it properly. Fixed a bug in the "goto next room" logic that was causing the first click of Goto (or Skip) to load the march list but then didn't actually change rooms. Only add _BASEROOM_ to the march list if the number of rooms added to it was zero -- implying that there are no rooms with new messages. Keep track of the last message number we saw Client side of SLRP is done Skip/Goto are functionally complete. Anything that looks like a button should act like a button. Anything that acts like a button should look like a button. moved vars to vars.js Use the Font Awesome 6.0.0 hosted version instead of 5.whatever ... note to self: now that I know they just randomly pull back versions off the CDN, we need to host our own or include it in the package during final distribution. Bad form, FA people. Bad form. Upgrade W3.CSS to version 4.15 Use the w3-badge class for circular badges instead of rounding them manually in the stylesheet. The sidebar buttons are now unhighlighted by default. When rendering a room view, iterate through all of them, unhighlight any that are highlighted, and then highlight the correct one. Tuned up some of the iconography Handle messages that are empty (or which appear empty to MSG4 because they consist solely of a non-renderable attachment in Part 0) by delivering a null json instead of locking up. some comments click on the envelope to go to the inbox Wowzers! Copied the login modal example from the w3css web site. Looks better than what I did ... of course. Click on a user or their avatar to go to their profile from the forum view derive_uid_from_ldap() converted to use ldap_get_values_len() which is not deprecated Updated LDAP code to be compatible with more modern OpenLDAP API Improved compatibility with POSIX LDAP Schema. Tested with FreeIPA demo site. Release version 950 generated by do-release.sh ----------------------------------------------------------------------- hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099297740Sat, 09 Apr 2022 16:17:55 +05002099297740@Uncensored Date: Sat Apr 9 16:17:42 2022 -0400 Release version 950 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099297739Sat, 09 Apr 2022 16:17:15 +05002099297739@Uncensored Date: Sat Apr 9 16:17:09 2022 -0400 Improved compatibility with POSIX LDAP Schema. Tested with FreeIPA demo site. ----------------------------------------------------------------------- Summary of changes: citadel/ldap.c | 27 ++++++++++++++++++++++----- 1 file changed, 22 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099297657Fri, 08 Apr 2022 19:13:10 +05002099297657@Uncensored Date: Fri Apr 8 19:13:04 2022 -0400 Updated LDAP code to be compatible with more modern OpenLDAP API http://code.citadel.org/?p=citadel.git&a=commit&h=443e28bffb93d19bee5f23b6ab7eb3e4c5db05be commit 443e28bffb93d19bee5f23b6ab7eb3e4c5db05be Author: Art Cancro Date: Sat Mar 12 15:47:10 2022 -0500 derive_uid_from_ldap() converted to use ldap_get_values_len() which is not deprecated http://code.citadel.org/?p=citadel.git&a=commit&h=79412060b67837fa9abf382f2b5ad7549aacff37 commit 79412060b67837fa9abf382f2b5ad7549aacff37 Author: Art Cancro Date: Sat Mar 5 18:30:15 2022 -0500 Click on a user or their avatar to go to their profile from the forum view http://code.citadel.org/?p=citadel.git&a=commit&h=e1db8dc1018a6be544dcbfd2901e30eac6769bdb commit e1db8dc1018a6be544dcbfd2901e30eac6769bdb Author: Art Cancro Date: Sun Feb 27 13:34:35 2022 -0500 Wowzers! Copied the login modal example from the w3css web site. Looks better than what I did ... of course. http://code.citadel.org/?p=citadel.git&a=commit&h=19710bbd0199cdd1418a3b885a1f7ab33eb9093a commit 19710bbd0199cdd1418a3b885a1f7ab33eb9093a Author: Art Cancro Date: Sun Feb 27 12:23:21 2022 -0500 click on the envelope to go to the inbox http://code.citadel.org/?p=citadel.git&a=commit&h=9e4c8ba1d0926e41409cfe6c584215a90c952600 commit 9e4c8ba1d0926e41409cfe6c584215a90c952600 Author: Art Cancro Date: Sat Feb 26 16:42:40 2022 -0500 some comments ----------------------------------------------------------------------- Summary of changes: citadel/ldap.c | 431 +++++++++++++++++------------------- citadel/modules/vcard/serv_vcard.c | 2 +- textclient/messages.c | 17 +- webcit-ng/api.txt | 2 +- webcit-ng/ctdlclient.c | 6 +- webcit-ng/forum_view.c | 5 +- webcit-ng/http.c | 6 + webcit-ng/static/index.html | 5 +- webcit-ng/static/js/login.js | 42 ++-- webcit-ng/static/js/user_profile.js | 16 ++ webcit-ng/static/js/view_forum.js | 4 +- webcit-ng/webcit.h | 2 +- 12 files changed, 275 insertions(+), 263 deletions(-) create mode 100644 webcit-ng/static/js/user_profile.js hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099293698Sat, 26 Feb 2022 15:14:41 +05002099293698@Uncensored Date: Sat Feb 26 15:13:14 2022 -0500 Handle messages that are empty (or which appear empty to MSG4 because they consist solely of a non-renderable attachment in Part 0) by delivering a null json instead of locking up. ----------------------------------------------------------------------- Summary of changes: webcit-ng/ctdlclient.c | 2 +- webcit-ng/forum_view.c | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099292502Wed, 16 Feb 2022 20:34:38 +05002099292502@Uncensored Date: Wed Feb 16 20:16:02 2022 -0500 Tuned up some of the iconography http://code.citadel.org/?p=citadel.git&a=commit&h=15251e3508ee3096309295ed94aa88755053a615 commit 15251e3508ee3096309295ed94aa88755053a615 Author: Art Cancro Date: Wed Feb 16 19:41:50 2022 -0500 The sidebar buttons are now unhighlighted by default. When rendering a room view, iterate through all of them, unhighlight any that are highlighted, and then highlight the correct one. http://code.citadel.org/?p=citadel.git&a=commit&h=fecefc0819466a21cfd77b52aeb4bf50805b65af commit fecefc0819466a21cfd77b52aeb4bf50805b65af Author: Art Cancro Date: Wed Feb 16 19:11:10 2022 -0500 Use the w3-badge class for circular badges instead of rounding them manually in the stylesheet. http://code.citadel.org/?p=citadel.git&a=commit&h=bab90b063da7b356b7e692df3f34373b3e5dcde8 commit bab90b063da7b356b7e692df3f34373b3e5dcde8 Author: Art Cancro Date: Wed Feb 16 18:59:22 2022 -0500 Upgrade W3.CSS to version 4.15 http://code.citadel.org/?p=citadel.git&a=commit&h=c1e039189b3fa057c09df40c422412bfb486b796 commit c1e039189b3fa057c09df40c422412bfb486b796 Author: Art Cancro Date: Wed Feb 16 18:53:34 2022 -0500 Use the Font Awesome 6.0.0 hosted version instead of 5.whatever ... note to self: now that I know they just randomly pull back versions off the CDN, we need to host our own or include it in the package during final distribution. Bad form, FA people. Bad form. http://code.citadel.org/?p=citadel.git&a=commit&h=da6390f9b0429c2ca984c7d95a9c06c0cb2fd1e4 commit da6390f9b0429c2ca984c7d95a9c06c0cb2fd1e4 Author: Art Cancro Date: Sun Feb 13 19:01:57 2022 -0500 moved vars to vars.js http://code.citadel.org/?p=citadel.git&a=commit&h=4f2a5bee20cd3893518d8200aece29fc730aab38 commit 4f2a5bee20cd3893518d8200aece29fc730aab38 Author: Art Cancro Date: Sun Feb 13 17:58:06 2022 -0500 Anything that looks like a button should act like a button. Anything that acts like a button should look like a button. ----------------------------------------------------------------------- Summary of changes: webcit-ng/api.txt | 2 +- webcit-ng/room_functions.c | 2 +- webcit-ng/static/css/w3.css | 464 ++++++++++++++++++++-------------------- webcit-ng/static/css/webcit.css | 8 - webcit-ng/static/index.html | 20 +- webcit-ng/static/js/defs.js | 19 ++ webcit-ng/static/js/main.js | 28 +-- webcit-ng/static/js/roomlist.js | 4 +- webcit-ng/static/js/views.js | 9 + webcit-ng/webcit.h | 1 + 10 files changed, 282 insertions(+), 275 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099292043Sun, 13 Feb 2022 16:54:04 +05002099292043@Uncensored Date: Sun Feb 13 16:53:26 2022 -0500 Skip/Goto are functionally complete. http://code.citadel.org/?p=citadel.git&a=commit&h=761d6c3c8a476a2ed327db5cf115c19d66d081b7 commit 761d6c3c8a476a2ed327db5cf115c19d66d081b7 Author: Art Cancro Date: Sat Feb 12 18:34:36 2022 -0500 Client side of SLRP is done http://code.citadel.org/?p=citadel.git&a=commit&h=0925c75e318e1422cf015d35715fbea94cbd5120 commit 0925c75e318e1422cf015d35715fbea94cbd5120 Author: Art Cancro Date: Sat Feb 12 18:10:22 2022 -0500 Keep track of the last message number we saw http://code.citadel.org/?p=citadel.git&a=commit&h=e21116e69d96864d23e1201f13d2cfd4ee6c3069 commit e21116e69d96864d23e1201f13d2cfd4ee6c3069 Author: Art Cancro Date: Fri Feb 11 18:00:47 2022 -0500 Only add _BASEROOM_ to the march list if the number of rooms added to it was zero -- implying that there are no rooms with new messages. http://code.citadel.org/?p=citadel.git&a=commit&h=740ade63a6c6d217126f40d72095677a4fcd3d48 commit 740ade63a6c6d217126f40d72095677a4fcd3d48 Author: Art Cancro Date: Fri Feb 11 16:56:42 2022 -0500 Fixed a bug in the "goto next room" logic that was causing the first click of Goto (or Skip) to load the march list but then didn't actually change rooms. http://code.citadel.org/?p=citadel.git&a=commit&h=0efde55e4be0e77fc4621796e1d2fd49f3eb0b4d commit 0efde55e4be0e77fc4621796e1d2fd49f3eb0b4d Author: Art Cancro Date: Tue Feb 8 18:19:17 2022 -0500 Re-encode the auth cookie with the properly formatted user name. This makes the client side parse it properly. http://code.citadel.org/?p=citadel.git&a=commit&h=2542c00b998db674963f97bfe44d5578050437d0 commit 2542c00b998db674963f97bfe44d5578050437d0 Author: Art Cancro Date: Sun Feb 6 18:22:07 2022 -0500 More gratuitous style cleanup. ----------------------------------------------------------------------- Summary of changes: citadel/modules/ctdlproto/serv_user.c | 10 +- citadel/user_ops.c | 376 +++++++++++++--------------------- citadel/user_ops.h | 43 ++-- webcit-ng/admin_functions.c | 39 +++- webcit-ng/api.txt | 13 +- webcit-ng/ctdlclient.c | 23 ++- webcit-ng/request.c | 7 + webcit-ng/room_functions.c | 19 ++ webcit-ng/static/index.html | 8 +- webcit-ng/static/js/login.js | 9 +- webcit-ng/static/js/main.js | 49 +++-- webcit-ng/static/js/view_forum.js | 17 +- webcit-ng/webcit.h | 10 +- 13 files changed, 308 insertions(+), 315 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099291182Sat, 05 Feb 2022 00:42:38 +05002099291182@Uncensored Date: Sat Feb 5 00:19:06 2022 -0500 "Forum list" is now more or less in its final form. http://code.citadel.org/?p=citadel.git&a=commit&h=b89f471bde5e7f977e39b18fc7bdf263f25df14b commit b89f471bde5e7f977e39b18fc7bdf263f25df14b Author: Art Cancro Date: Thu Feb 3 19:37:09 2022 -0500 Now it has a button look. http://code.citadel.org/?p=citadel.git&a=commit&h=fecc838e9557ec265ccc782f6f58cc600486e8f9 commit fecc838e9557ec265ccc782f6f58cc600486e8f9 Author: Art Cancro Date: Thu Feb 3 19:30:41 2022 -0500 Rooms in the Forums List are now clickable anywhere in the box, not just the room name. http://code.citadel.org/?p=citadel.git&a=commit&h=e1e2aa83ac54faa3ebe75974bc27a7de9869ca41 commit e1e2aa83ac54faa3ebe75974bc27a7de9869ca41 Author: Art Cancro Date: Thu Feb 3 19:25:44 2022 -0500 Made the bubble icons in the Forums list round, and colored differently based on the presence of new messages. http://code.citadel.org/?p=citadel.git&a=commit&h=ac8a06f0b34b85b6a08f6e9464267860f8c59786 commit ac8a06f0b34b85b6a08f6e9464267860f8c59786 Author: Art Cancro Date: Tue Feb 1 18:46:06 2022 -0500 Initial commit of the "new" room list. It's going to be a lot more "traditional web forum" looking. I hope I don't regret this. http://code.citadel.org/?p=citadel.git&a=commit&h=cce1aef734a8b026eeea7c01beaeb6aad90729ea commit cce1aef734a8b026eeea7c01beaeb6aad90729ea Author: Art Cancro Date: Fri Jan 28 00:01:12 2022 -0500 more divs http://code.citadel.org/?p=citadel.git&a=commit&h=4703d1247bd54173f8decf7a5bcccd7c72789f18 commit 4703d1247bd54173f8decf7a5bcccd7c72789f18 Author: Art Cancro Date: Thu Jan 27 19:22:36 2022 -0500 ctdl-roomlist-floor class for the floor banner over each floor's room list http://code.citadel.org/?p=citadel.git&a=commit&h=8c84e52d8bccbca567938548ea8e1be9a10ec4e1 commit 8c84e52d8bccbca567938548ea8e1be9a10ec4e1 Author: Art Cancro Date: Thu Jan 27 18:41:18 2022 -0500 /ctdl/r//info.txt now fetches the room info banner http://code.citadel.org/?p=citadel.git&a=commit&h=3ce828c1d40f262c0a6eb592246c3494567a4a6e commit 3ce828c1d40f262c0a6eb592246c3494567a4a6e Author: Art Cancro Date: Mon Jan 24 19:38:19 2022 -0500 Sort room list by floor but also put them in different divs ----------------------------------------------------------------------- Summary of changes: webcit-ng/README.txt | 4 +-- webcit-ng/api.txt | 1 + webcit-ng/room_functions.c | 51 +++++++++++++++++++++---------- webcit-ng/static/css/webcit.css | 55 ++++++++++++++++++++++++++++++++- webcit-ng/static/js/roomlist.js | 67 ++++++++++++++++++++++++----------------- 5 files changed, 132 insertions(+), 46 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099289897Mon, 24 Jan 2022 15:40:51 +05002099289897@Uncensored Date: Mon Jan 24 15:40:45 2022 -0500 /ctdl/f/ to get a list of all floors http://code.citadel.org/?p=citadel.git&a=commit&h=1a6ba52d8841262a040ec5ef35203b41a942642b commit 1a6ba52d8841262a040ec5ef35203b41a942642b Author: Art Cancro Date: Sun Jan 23 16:14:05 2022 -0500 room list renderer is now aware of which rooms are forum view: http://code.citadel.org/?p=citadel.git&a=commit&h=1a19ee6d0d0f0d7a30b3f710bd7f024969999ea3 commit 1a19ee6d0d0f0d7a30b3f710bd7f024969999ea3 Author: Art Cancro Date: Sun Jan 23 16:01:16 2022 -0500 Moved the room list from the sidebar to the main viewing pane. This is going to turn into a "forum list" and we'll do something else for mailboxes. ----------------------------------------------------------------------- Summary of changes: citadel/modules/ctdlproto/serv_rooms.c | 423 ++++++++++++------------------ webcit-ng/Makefile | 3 +- webcit-ng/api.txt | 1 + webcit-ng/floor_functions.c | 63 +++++ webcit-ng/request.c | 3 + webcit-ng/room_functions.c | 11 +- webcit-ng/static/index.html | 6 +- webcit-ng/static/js/{views.js => defs.js} | 33 --- webcit-ng/static/js/main.js | 52 ---- webcit-ng/static/js/roomlist.js | 71 +++++ webcit-ng/static/js/views.js | 19 -- webcit-ng/webcit.h | 1 + 12 files changed, 318 insertions(+), 368 deletions(-) create mode 100644 webcit-ng/floor_functions.c copy webcit-ng/static/js/{views.js => defs.js} (53%) create mode 100644 webcit-ng/static/js/roomlist.js hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099289697Sun, 23 Jan 2022 01:28:28 +05002099289697@Uncensored Date: Sun Jan 23 01:28:23 2022 -0500 Tweaked the icons a bit http://code.citadel.org/?p=citadel.git&a=commit&h=68025879f6cc4fa13ea1b483d62186b900fcef15 commit 68025879f6cc4fa13ea1b483d62186b900fcef15 Author: Art Cancro Date: Sat Jan 22 16:56:29 2022 -0500 The "Post message" button in forum view is now active. http://code.citadel.org/?p=citadel.git&a=commit&h=30298e9cfd5f9e877cbdc0339a751c90e4b57ba7 commit 30298e9cfd5f9e877cbdc0339a751c90e4b57ba7 Author: Art Cancro Date: Sat Jan 22 16:24:09 2022 -0500 Set up a "new item" dispatcher so it can be different for each view http://code.citadel.org/?p=citadel.git&a=commit&h=3369a03c83b538ac411117319f6a17d591df03ff commit 3369a03c83b538ac411117319f6a17d591df03ff Author: Art Cancro Date: Sat Jan 22 16:02:22 2022 -0500 Added a button to the screen that can be populated and brought into view whenever a "new item" command is available, such as "Post message" or "Enter mail" or "New calendar item" http://code.citadel.org/?p=citadel.git&a=commit&h=9256c25d9651e77db1d648937aebfa6345387423 commit 9256c25d9651e77db1d648937aebfa6345387423 Author: Art Cancro Date: Sat Jan 15 15:58:46 2022 -0500 Explain in comments how the connection pool works. ----------------------------------------------------------------------- Summary of changes: webcit-ng/ctdlclient.c | 13 +++++++++---- webcit-ng/static/index.html | 14 ++++++-------- webcit-ng/static/js/login.js | 2 +- webcit-ng/static/js/view_forum.js | 11 +++++++++++ webcit-ng/static/js/views.js | 20 +++++++++++++++++--- 5 files changed, 44 insertions(+), 16 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288966Sat, 15 Jan 2022 15:42:01 +05002099288966@Uncensored Date: Sat Jan 15 15:41:53 2022 -0500 I was able to simplify the login code too. ctdl_startup() is now called at landing, at login, and logout. It always does The Right Thing. http://code.citadel.org/?p=citadel.git&a=commit&h=11d43a21157b7932c2b21669b2e52145c6276943 commit 11d43a21157b7932c2b21669b2e52145c6276943 Author: Art Cancro Date: Sat Jan 15 15:37:44 2022 -0500 ok, that function needed to be async http://code.citadel.org/?p=citadel.git&a=commit&h=6973136f78f394893af279bb5ebb0c4a800ca129 commit 6973136f78f394893af279bb5ebb0c4a800ca129 Author: Art Cancro Date: Sat Jan 15 15:28:54 2022 -0500 Simplified the logout javascript ----------------------------------------------------------------------- Summary of changes: webcit-ng/admin_functions.c | 1 - webcit-ng/api.txt | 7 +++++-- webcit-ng/ctdlclient.c | 23 +++++++++++++---------- webcit-ng/static/js/login.js | 31 +++++++++++++------------------ 4 files changed, 31 insertions(+), 31 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288865Fri, 14 Jan 2022 11:31:11 +05002099288865@Uncensored Date: Fri Jan 14 11:29:17 2022 -0500 A little more cosmetic work on the login modal. Still not in its final ultra-pretty form but it looks semi-presentable now. http://code.citadel.org/?p=citadel.git&a=commit&h=be18f75f26fba6fe03f88d9d4fca3160b1862c42 commit be18f75f26fba6fe03f88d9d4fca3160b1862c42 Author: Art Cancro Date: Fri Jan 14 11:10:46 2022 -0500 banner change http://code.citadel.org/?p=citadel.git&a=commit&h=366e4c2fd1d8ee0036ee9705c49241655874ae92 commit 366e4c2fd1d8ee0036ee9705c49241655874ae92 Author: Art Cancro Date: Fri Jan 14 11:08:55 2022 -0500 This is a better version of detect_logged_in() for webcit-ng that checks the server cookie instead of clumsily attempting a command. This works synchronously so it can be combined with other commands without creating a race condition. Also moved the login screen to a modal. http://code.citadel.org/?p=citadel.git&a=commit&h=224e9cc7a1a084568e136f7b959c32e177ce7ef8 commit 224e9cc7a1a084568e136f7b959c32e177ce7ef8 Author: Art Cancro Date: Thu Jan 13 18:38:34 2022 -0500 Removed some debugs that are no longer needed now that the listsub rework is complete. Also updated the netconfig specification to remove the obsolete pending command. ----------------------------------------------------------------------- Summary of changes: citadel/docs/netconfigs.txt | 21 ----------- citadel/modules/listsub/serv_listsub.c | 11 +++--- webcit-ng/ctdlclient.c | 4 +-- webcit-ng/http.c | 2 +- webcit-ng/static/index.html | 6 +--- webcit-ng/static/js/login.js | 66 +++++++++++++++++----------------- webcit-ng/static/js/main.js | 28 ++++++++++----- webcit-ng/static/js/util.js | 9 +++++ webcit/listsub.c | 1 + 9 files changed, 69 insertions(+), 79 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288741Thu, 13 Jan 2022 11:56:28 +05002099288741@Uncensored Date: Thu Jan 13 11:48:37 2022 -0500 Big change to mailing list subscription/unsubscription! The old confirmation method involved generating a confirmation token during the first opt, which was mailed to the user and saved to disk so they could confirm it in the second opt. In the new code, the token can be re-generated persistently by the server using a combination of the email address, the room name, and a host key that is known only to the site operator (stored in the config db). So there is no longer a need to store the pending request, and the confirmation links are valid forever (and reusable!). Aside from being algorithmically nifty, this will also give us the ability to implement "one click unsubscribe" in the near future. http://code.citadel.org/?p=citadel.git&a=commit&h=6473885628e33ec5633bb05caa92391aa34cff03 commit 6473885628e33ec5633bb05caa92391aa34cff03 Author: Art Cancro Date: Wed Jan 12 16:18:11 2022 -0500 Generate a random 100-byte string to be used as a host key for hashing various things. http://code.citadel.org/?p=citadel.git&a=commit&h=d3a76479a895c71eb734d2c39a116e0f4f31537d commit d3a76479a895c71eb734d2c39a116e0f4f31537d Author: Art Cancro Date: Wed Jan 12 16:04:12 2022 -0500 Seed the random number generator before the config system is initialized. ----------------------------------------------------------------------- Summary of changes: citadel/citserver.c | 44 +++--- citadel/config.c | 166 ++++++++++------------ citadel/configure.ac | 19 +++ citadel/modules/listsub/serv_listsub.c | 245 ++++++++++----------------------- webcit/listsub.c | 41 +++--- webcit/static/t/listsub/display.html | 18 ++- 6 files changed, 223 insertions(+), 310 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288624Wed, 12 Jan 2022 14:29:22 +05002099288624@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288623Wed, 12 Jan 2022 14:29:17 +05002099288623@Uncensored Date: Wed Jan 12 14:29:10 2022 -0500 Release version 949 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=30f9f1332e7dcf9d30a40768dd9c2070bc674957 commit 30f9f1332e7dcf9d30a40768dd9c2070bc674957 Author: Art Cancro Date: Wed Jan 12 13:51:09 2022 -0500 Change TLS_server_method() to SSLv23_server_method() because people are still using older builds that don't have the new name. http://code.citadel.org/?p=citadel.git&a=commit&h=f1f58a18c13d95baa27c846692cdc3410f902806 commit f1f58a18c13d95baa27c846692cdc3410f902806 Author: Art Cancro Date: Tue Jan 11 18:54:49 2022 -0500 missed a few references to delete http://code.citadel.org/?p=citadel.git&a=commit&h=625a1931ab7c581002bb6ffd573c5ead6b0eb236 commit 625a1931ab7c581002bb6ffd573c5ead6b0eb236 Author: Art Cancro Date: Tue Jan 11 18:27:00 2022 -0500 Removed APOP authentication from the text client. No one has ever used it and the server doesn't even support it anymore. http://code.citadel.org/?p=citadel.git&a=commit&h=932fdb7b5cf0052dfa8632bf2df068c79ade995e commit 932fdb7b5cf0052dfa8632bf2df068c79ade995e Author: Art Cancro Date: Tue Jan 11 00:00:59 2022 -0500 Multiple invocations of HELO and/or EHLO from an SMTP client now replace, rather than append to, the helo_node variable. ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- citadel/modules/crypto/serv_crypto.c | 2 +- citadel/modules/smtp/serv_smtp.c | 261 +++++++++----------------- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/Makefile | 4 +- textclient/citadel.c | 46 +---- textclient/citadel_ipc.c | 25 --- textclient/md5.c | 351 ----------------------------------- textclient/textclient.h | 33 +--- webcit-ng/tls.c | 2 +- webcit/crypto.c | 2 +- webcit/webcit.h | 2 +- 13 files changed, 107 insertions(+), 627 deletions(-) delete mode 100644 textclient/md5.c hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288370Mon, 10 Jan 2022 18:12:22 +05002099288370@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288362Mon, 10 Jan 2022 18:03:21 +05002099288362@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288361Mon, 10 Jan 2022 18:03:16 +05002099288361@Uncensored Date: Mon Jan 10 18:03:11 2022 -0500 Release version 948 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=e7fa57d8628023a97451ff690a5906b70412f4a5 commit e7fa57d8628023a97451ff690a5906b70412f4a5 Author: Art Cancro Date: Mon Jan 10 17:42:26 2022 -0500 ssl ciphers had to be set to its old value of "ALL:RC4+RSA:+SSLv2:+TLSv1:!MD5:@STRENGTH" instead of "DEFAULT" even though the latter works just fine in WebCit, works just fine in all protocols on the development host, but causes all sorts of chaos on Uncensored. I don't know why. ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- citadel/modules/crypto/serv_crypto.c | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288349Mon, 10 Jan 2022 17:37:57 +05002099288349@Uncensored Date: Mon Jan 10 17:37:52 2022 -0500 ANGRY SCREED WITH CAPS LOCK ON ----------------------------------------------------------------------- Summary of changes: citadel/modules/crypto/serv_crypto.c | 12 ++++++++++-- citadel/modules/crypto/serv_crypto.h | 3 +-- 2 files changed, 11 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288342Mon, 10 Jan 2022 16:58:04 +05002099288342@Uncensored Date: Mon Jan 10 16:58:00 2022 -0500 FFFFFFFFFFFFFFFFFUUUUUUUUUUUUUuu---------------- ----------------------------------------------------------------------- Summary of changes: citadel/modules/crypto/serv_crypto.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288337Mon, 10 Jan 2022 16:39:12 +05002099288337@Uncensored Date: Mon Jan 10 16:37:57 2022 -0500 Testing to see if SSLv23_server_method() is actually the one we want ----------------------------------------------------------------------- Summary of changes: citadel/modules/crypto/serv_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288330Mon, 10 Jan 2022 16:10:38 +05002099288330@Uncensored Date: Mon Jan 10 16:10:34 2022 -0500 LONG STRING OF EXPLETIVES ----------------------------------------------------------------------- Summary of changes: citadel/modules/crypto/serv_crypto.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288323Mon, 10 Jan 2022 14:55:07 +05002099288323@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288322Mon, 10 Jan 2022 14:55:04 +05002099288322@Uncensored Date: Mon Jan 10 14:54:58 2022 -0500 Release version 947 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=6cff5cc155fd1d73eaf8576c03027e55ead724c6 commit 6cff5cc155fd1d73eaf8576c03027e55ead724c6 Author: Art Cancro Date: Mon Jan 10 14:54:54 2022 -0500 I got a little too eager in removing old cruft from the TLS code. Not setting the correct cipher list broke production in a way that didn't fail in development. ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- citadel/modules/crypto/serv_crypto.c | 20 +++++++------------- citadel/modules/crypto/serv_crypto.h | 4 +++- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 7 files changed, 15 insertions(+), 19 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288309Mon, 10 Jan 2022 13:31:46 +05002099288309@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288308Mon, 10 Jan 2022 13:31:44 +05002099288308@Uncensored Date: Mon Jan 10 13:31:36 2022 -0500 Release version 946 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288307Mon, 10 Jan 2022 13:31:32 +05002099288307@Uncensored Date: Mon Jan 10 11:59:07 2022 -0500 Switch out the key/cert in a critical section (mutex wrapped). This will prevent multiple threads from doing it at once and leaking memory (thanks zcw159357) http://code.citadel.org/?p=citadel.git&a=commit&h=41a68e93ee5d46eec3cf12f4614e53c1bac84e43 commit 41a68e93ee5d46eec3cf12f4614e53c1bac84e43 Author: Art Cancro Date: Mon Jan 10 11:28:03 2022 -0500 Unified the openssl library initialization code http://code.citadel.org/?p=citadel.git&a=commit&h=c3f4724c1d230b6ff86426702e9de9241518ebd6 commit c3f4724c1d230b6ff86426702e9de9241518ebd6 Author: Art Cancro Date: Mon Jan 10 11:16:43 2022 -0500 Replaced all instances of SSLv23_server_method() with TLS_server_method() (thanks to zcw159357 for suggesting this) ----------------------------------------------------------------------- Summary of changes: citadel/modules/crypto/serv_crypto.c | 74 +++++++++++++++++------------------- citadel/modules/crypto/serv_crypto.h | 6 +-- webcit-ng/tls.c | 8 ++-- webcit/crypto.c | 12 +++--- webcit/sysdep.c | 5 --- 5 files changed, 45 insertions(+), 60 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288139Sat, 08 Jan 2022 16:32:46 +05002099288139@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288138Sat, 08 Jan 2022 16:32:35 +05002099288138@Uncensored Date: Sat Jan 8 16:32:09 2022 -0500 Release version 945 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- do-release.sh | 12 ++++++++++++ libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- textclient/textclient.h | 2 +- webcit/webcit.h | 2 +- 6 files changed, 17 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288132Sat, 08 Jan 2022 16:18:22 +05002099288132@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099288131Sat, 08 Jan 2022 16:18:19 +05002099288131@Uncensored Date: Sat Jan 8 16:18:08 2022 -0500 Release version 944 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=56bc6fc43cd875760437b7799cd47d4230351dbb commit 56bc6fc43cd875760437b7799cd47d4230351dbb Author: Art Cancro Date: Sat Jan 8 16:17:18 2022 -0500 New ctx change semantics in WebCit-NG http://code.citadel.org/?p=citadel.git&a=commit&h=2d3e9d753288b0ce7d6b725f7d6414907d0ef485 commit 2d3e9d753288b0ce7d6b725f7d6414907d0ef485 Author: Art Cancro Date: Sat Jan 8 16:14:08 2022 -0500 New ctx change semantics in WebCit-classic http://code.citadel.org/?p=citadel.git&a=commit&h=214f7cd80411cad5df0ae846ac6658d05baa56ef commit 214f7cd80411cad5df0ae846ac6658d05baa56ef Author: Art Cancro Date: Sat Jan 8 13:42:27 2022 -0500 When a new certificate is installed, allocate a new ssl_ctx and bind to it; then wait a moment before freeing the old one to let any in-progress binds complete. http://code.citadel.org/?p=citadel.git&a=commit&h=1d576031a65f6b1b8cc2195e21821857c1465953 commit 1d576031a65f6b1b8cc2195e21821857c1465953 Author: Art Cancro Date: Sat Jan 8 13:30:23 2022 -0500 Significant cleanup of the code that generates a self-signed certificate. There is no need to keep the CSR around so we don't do that anymore. The remainder of the code contains only what is needed; the rest I had copied from OpenSSL example code 20 years ago and never looked at again. http://code.citadel.org/?p=citadel.git&a=commit&h=af39420443861eed8d56b852d15410e09af0e9a6 commit af39420443861eed8d56b852d15410e09af0e9a6 Author: Art Cancro Date: Fri Jan 7 16:20:39 2022 -0500 removed some unused variables http://code.citadel.org/?p=citadel.git&a=commit&h=dbac6fe2830f3ecacc09be5f3e722b5806fab4c7 commit dbac6fe2830f3ecacc09be5f3e722b5806fab4c7 Author: Art Cancro Date: Fri Jan 7 11:54:54 2022 -0500 Removed the local implementation of snprintf() and vsnprintf() that we hacked in two decades ago to work around broken or missing system libraries. Not needed anymore. http://code.citadel.org/?p=citadel.git&a=commit&h=b8cdf72394178327432dd541aefb8a9031e29c2a commit b8cdf72394178327432dd541aefb8a9031e29c2a Author: Art Cancro Date: Fri Jan 7 11:38:19 2022 -0500 ssl_ctx = SSL_CTX_new(SSLv23_server_method()) instead of using a temporary variable f or the server method. (Changed in Citadel Server, WebCit Classic, and WebCit-NG) ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- citadel/citadel_dirs.h | 1 - citadel/modules/crypto/serv_crypto.c | 299 +++++++++++++++++------------------ citadel/server.h | 3 +- citadel/snprintf.c | 79 --------- citadel/snprintf.h | 11 -- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- webcit-ng/tls.c | 45 +++--- webcit/crypto.c | 71 +++------ webcit/webcit.h | 2 +- 11 files changed, 197 insertions(+), 320 deletions(-) delete mode 100644 citadel/snprintf.c delete mode 100644 citadel/snprintf.h hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287962Thu, 06 Jan 2022 17:23:00 +05002099287962@Uncensored > After a lot of effort I am still unable to reproduce the problem you > are describing.    Are you able to watch the citserver log while you > change an account's email aliases?  I would like to see what it > "thinks" it's doing. > > On 1/5/22 14:40, Art Cancro wrote: >> >> Is this the correct summary of the problem? >> >> On 12/31/21 14:36, s3cr3to wrote: >>> But sadly, the aliases are not preserved neither from the text >>> client, and even less from webcit; every time I edit a new alias; it >>> eliminates the previous ones: It go through the first alias and >>> places it as primary address, but it eliminates that 1st alias from >>> the aliases; and worse: does not preserve any new alias that is >>> identical to the primary email (even though it is no longer listed >>> in the text client or webcit). >> >> I want to focus on this specific problem: "When I edit an account's >> email addresses, some addresses do not stay saved." Would you say >> that is a good description?   You said a lot of things about old >> versions, text client and webcit, but I want to make sure I >> understand the real problem. > ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287952Thu, 06 Jan 2022 17:18:48 +05002099287952@Uncensored > After a lot of effort I am still unable to reproduce the problem you > are describing.    Are you able to watch the citserver log while you > change an account's email aliases?  I would like to see what it > "thinks" it's doing. > > On 1/5/22 14:40, Art Cancro wrote: >> >> Is this the correct summary of the problem? >> >> On 12/31/21 14:36, s3cr3to wrote: >>> But sadly, the aliases are not preserved neither from the text >>> client, and even less from webcit; every time I edit a new alias; it >>> eliminates the previous ones: It go through the first alias and >>> places it as primary address, but it eliminates that 1st alias from >>> the aliases; and worse: does not preserve any new alias that is >>> identical to the primary email (even though it is no longer listed >>> in the text client or webcit). >> >> I want to focus on this specific problem: "When I edit an account's >> email addresses, some addresses do not stay saved." Would you say >> that is a good description?   You said a lot of things about old >> versions, text client and webcit, but I want to make sure I >> understand the real problem. > ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287949Thu, 06 Jan 2022 17:13:17 +05002099287949@Uncensored > Is this the correct summary of the problem? > > On 12/31/21 14:36, s3cr3to wrote: >> But sadly, the aliases are not preserved neither from the text >> client, and even less from webcit; every time I edit a new alias; it >> eliminates the previous ones: It go through the first alias and >> places it as primary address, but it eliminates that 1st alias from >> the aliases; and worse: does not preserve any new alias that is >> identical to the primary email (even though it is no longer listed in >> the text client or webcit). > > I want to focus on this specific problem: "When I edit an account's > email addresses, some addresses do not stay saved." Would you say that > is a good description?   You said a lot of things about old versions, > text client and webcit, but I want to make sure I understand the real > problem. > > ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287859Wed, 05 Jan 2022 23:41:52 +05002099287859@Uncensored Date: Wed Jan 5 23:41:41 2022 -0500 random acts of style cleanup http://code.citadel.org/?p=citadel.git&a=commit&h=547a20bfefa1815d5bef48bc2a6b24cf38736c09 commit 547a20bfefa1815d5bef48bc2a6b24cf38736c09 Author: Art Cancro Date: Wed Jan 5 16:52:23 2022 -0500 While hunting for an internet address bug, cleaning up more style. http://code.citadel.org/?p=citadel.git&a=commit&h=ed47669c2e35647dc288f9cfa0186565788b9ed1 commit ed47669c2e35647dc288f9cfa0186565788b9ed1 Author: Art Cancro Date: Wed Jan 5 16:10:06 2022 -0500 I was checking something in serv_user.c and just couldn't help myself -- style cleanup http://code.citadel.org/?p=citadel.git&a=commit&h=8e09a2927df885bd83dd6361b6a70242069083ce commit 8e09a2927df885bd83dd6361b6a70242069083ce Author: Art Cancro Date: Wed Jan 5 13:49:17 2022 -0500 When checking to see whether we have to rebind a new key and/or certificate, the stored "previous value" is now the sum of the existing key *and* certificate modification times. This causes a rebind to occur if either file's modification time is touched. It does not matter if this rolls over on 32-bit systems because we are only checking to see if the value changed, not for any particular date comparison. http://code.citadel.org/?p=citadel.git&a=commit&h=9e24fd4e798bd6871d71531015b839d04c0dbd22 commit 9e24fd4e798bd6871d71531015b839d04c0dbd22 Author: Art Cancro Date: Tue Jan 4 09:49:35 2022 -0500 More of me not being able to look at code without poking around changing everything to C99 style comments ----------------------------------------------------------------------- Summary of changes: citadel/COPYING | 2 +- citadel/Makefile.in | 2 +- citadel/citadel_dirs.c | 14 +- citadel/citmail.c | 49 ++----- citadel/citserver.c | 67 ++++----- citadel/clientsocket.c | 136 +++++++---------- citadel/config.c | 33 ++--- citadel/context.c | 85 ++++------- citadel/contrib/getdoku.sh | 52 ------- citadel/euidindex.c | 96 +++++------- citadel/internet_addressing.c | 15 +- citadel/modules/crypto/serv_crypto.c | 8 +- citadel/modules/ctdlproto/serv_user.c | 260 +++++++++++++-------------------- citadel/modules/upgrade/serv_upgrade.c | 192 +++++++++--------------- citadel/msgbase.c | 37 ++--- citadel/netconfig.c | 57 +++----- citadel/room_ops.c | 194 ++++++++++-------------- citadel/server_main.c | 72 ++++----- citadel/support.c | 31 ++-- citadel/user_ops.c | 159 ++++++++------------ webcit-ng/Makefile | 2 +- webcit-ng/static/js/main.js | 7 +- webcit-ng/{ssl.c => tls.c} | 7 +- webcit/crypto.c | 8 +- 24 files changed, 574 insertions(+), 1011 deletions(-) delete mode 100755 citadel/contrib/getdoku.sh rename webcit-ng/{ssl.c => tls.c} (97%) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287837Wed, 05 Jan 2022 17:09:05 +05002099287837@Uncensored > Is this the correct summary of the problem? > > On 12/31/21 14:36, s3cr3to wrote: >> But sadly, the aliases are not preserved neither from the text >> client, and even less from webcit; every time I edit a new alias; it >> eliminates the previous ones: It go through the first alias and >> places it as primary address, but it eliminates that 1st alias from >> the aliases; and worse: does not preserve any new alias that is >> identical to the primary email (even though it is no longer listed in >> the text client or webcit). > > I want to focus on this specific problem: "When I edit an account's > email addresses, some addresses do not stay saved." Would you say that > is a good description?   You said a lot of things about old versions, > text client and webcit, but I want to make sure I understand the real > problem. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287820Wed, 05 Jan 2022 14:40:22 +05002099287820@Uncensored But sadly, the aliases are not preserved neither from the text client, > and even less from webcit; every time I edit a new alias; it > eliminates the previous ones: It go through the first alias and places > it as primary address, but it eliminates that 1st alias from the > aliases; and worse: does not preserve any new alias that is identical > to the primary email (even though it is no longer listed in the text > client or webcit). I want to focus on this specific problem: "When I edit an account's email addresses, some addresses do not stay saved." Would you say that is a good description?   You said a lot of things about old versions, text client and webcit, but I want to make sure I understand the real problem. ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287653Mon, 03 Jan 2022 17:56:20 +05002099287653@Uncensored Date: Mon Jan 3 17:56:01 2022 -0500 the crufty code, it stings... http://code.citadel.org/?p=citadel.git&a=commit&h=659f9df00a54c841b8c3ba6619664029dfe92437 commit 659f9df00a54c841b8c3ba6619664029dfe92437 Author: Art Cancro Date: Mon Jan 3 17:33:19 2022 -0500 I went looking for something in the text client, and was reminded how absolutely rubbish my coding style was in the late 1980s. I did a few bits of cleanup but most of that code ought to be rewritten. The good news is that unlike WebCit, I believe we can redo the text client in place over a period of time. http://code.citadel.org/?p=citadel.git&a=commit&h=57622467a89225656104d31d167621300afa7732 commit 57622467a89225656104d31d167621300afa7732 Author: Art Cancro Date: Mon Jan 3 17:04:37 2022 -0500 ReplyQuoted works now. http://code.citadel.org/?p=citadel.git&a=commit&h=2df6ecf6700b267596c15ccc4dbb53091f4d363b commit 2df6ecf6700b267596c15ccc4dbb53091f4d363b Author: Art Cancro Date: Mon Jan 3 16:47:43 2022 -0500 Cleaned up the editor-div-replacement thing ----------------------------------------------------------------------- Summary of changes: textclient/README.txt | 2 +- textclient/citadel_ipc.c | 268 +++++++++++++------------------------- textclient/messages.c | 202 ++++++++++++++-------------- textclient/textclient.h | 2 - webcit-ng/static/css/webcit.css | 33 +++++ webcit-ng/static/js/view_forum.js | 33 ++--- 6 files changed, 245 insertions(+), 295 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287637Mon, 03 Jan 2022 15:21:36 +05002099287637@Uncensored Date: Mon Jan 3 15:21:00 2022 -0500 The current local date and time now displays in the message entry div. http://code.citadel.org/?p=citadel.git&a=commit&h=9bc6e22ca790e9ea0917a95a156306345f59e1e8 commit 9bc6e22ca790e9ea0917a95a156306345f59e1e8 Author: Art Cancro Date: Mon Jan 3 15:13:44 2022 -0500 Message date/time is now sent to the browser in unix timestamp format and converted to a displayable date/time in the local timezone by the browser. http://code.citadel.org/?p=citadel.git&a=commit&h=0d2b829009528b4128e35508500b2f07451cefca commit 0d2b829009528b4128e35508500b2f07451cefca Author: Art Cancro Date: Sat Jan 1 18:23:47 2022 -0500 ssl error handling http://code.citadel.org/?p=citadel.git&a=commit&h=56706cb10c88d412303807456338e1bcdf3c1f9d commit 56706cb10c88d412303807456338e1bcdf3c1f9d Author: Art Cancro Date: Sat Jan 1 18:15:00 2022 -0500 Removed some comments ----------------------------------------------------------------------- Summary of changes: webcit-ng/forum_view.c | 7 +------ webcit-ng/ssl.c | 30 +----------------------------- webcit-ng/static/js/util.js | 32 ++++++++++++++++++++++++++++++++ webcit-ng/static/js/view_forum.js | 14 +++++++------- 4 files changed, 41 insertions(+), 42 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287467Sat, 01 Jan 2022 17:50:48 +05002099287467@Uncensored Date: Sat Jan 1 17:50:37 2022 -0500 minor comment change http://code.citadel.org/?p=citadel.git&a=commit&h=03f8ea2b9c9ca63c0dfb47fb03b0a15c46e33294 commit 03f8ea2b9c9ca63c0dfb47fb03b0a15c46e33294 Author: Art Cancro Date: Sat Jan 1 17:32:03 2022 -0500 Set up a proper favicon.ico in both webcit-classic and webcit-ng with a version of the Citadel logo in it http://code.citadel.org/?p=citadel.git&a=commit&h=d7f68b0dfe66ac64d03db972eed370392c400d55 commit d7f68b0dfe66ac64d03db972eed370392c400d55 Author: Art Cancro Date: Sat Jan 1 15:49:08 2022 -0500 The "reply" function in webcit-ng now correctly replaces the editor div with the final rendered version of the message that came back from the server. It looks nice. http://code.citadel.org/?p=citadel.git&a=commit&h=65829aa92817c7bfd1346a59c0411d25344d5aec commit 65829aa92817c7bfd1346a59c0411d25344d5aec Author: Art Cancro Date: Sat Jan 1 15:31:31 2022 -0500 randomString() is now always the same length and always begins with "ctdl_" http://code.citadel.org/?p=citadel.git&a=commit&h=45d55c0f8fc2b7fb56409467f1d058103368531f commit 45d55c0f8fc2b7fb56409467f1d058103368531f Author: Art Cancro Date: Sat Jan 1 15:20:21 2022 -0500 It's 2022 ... updating all of the copyright notices in webcit-ng ----------------------------------------------------------------------- Summary of changes: webcit-ng/admin_functions.c | 2 +- webcit-ng/caldav_reports.c | 2 +- webcit-ng/ctdl_commands.c | 2 +- webcit-ng/ctdlclient.c | 2 +- webcit-ng/ctdlfunctions.c | 2 +- webcit-ng/forum_view.c | 2 +- webcit-ng/html2html.c | 2 +- webcit-ng/http.c | 2 +- webcit-ng/main.c | 4 +- webcit-ng/messages.c | 2 +- webcit-ng/request.c | 5 +++ webcit-ng/room_functions.c | 2 +- webcit-ng/static.c | 7 +++- webcit-ng/static/css/webcit.css | 2 +- webcit-ng/static/{ => images}/citadel-logo.gif | Bin webcit-ng/static/images/favicon.ico | Bin 0 -> 2238 bytes webcit-ng/static/{ => images}/throbber.gif | Bin webcit-ng/static/index.html | 2 +- webcit-ng/static/js/main.js | 2 +- webcit-ng/static/js/util.js | 15 ++------ webcit-ng/static/js/view_forum.js | 51 +++++++++++++++++++------ webcit-ng/static/js/views.js | 2 +- webcit-ng/tcp_sockets.c | 2 +- webcit-ng/text2html.c | 2 +- webcit-ng/user_functions.c | 5 +-- webcit-ng/util.c | 2 +- webcit-ng/webcit.h | 2 +- webcit-ng/webserver.c | 2 +- webcit/static/favicon.ico | Bin 894 -> 2238 bytes 29 files changed, 77 insertions(+), 48 deletions(-) rename webcit-ng/static/{ => images}/citadel-logo.gif (100%) create mode 100644 webcit-ng/static/images/favicon.ico rename webcit-ng/static/{ => images}/throbber.gif (100%) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287343Fri, 31 Dec 2021 14:36:38 +05002099287343@Uncensored In my current old version (debian) I need to run:

sendcommand IGAB

I don't know how often Citadel runs this command automatically.
But when I do it manually it appears almost instantaneously in the new contacts.

And a new related situation arose this week:
When I make a new account and try to configure the mail client on Android; it can take many minutes (~30) to allow me to connect to that account; but if I run the command I can register it almost immediately.


Preventing this situation that I currently live, and due to the problem I have with the aliases (in Docker) I am looking for if using this command I can immediately notice the changes to the aliases that I add.

But sadly, the aliases are not preserved neither from the text client, and even less from webcit; every time I edit a new alias; it eliminates the previous ones: It go through the first alias and places it as primary address, but it eliminates that 1st alias from the aliases; and worse: does not preserve any new alias that is identical to the primary email (even though it is no longer listed in the text client or webcit).

This reference I borrowed from a friend who was troubleshooting a problem:

I think Sherlock is going to need a lot of pipes to find/fix this error in the aliases.

On 12/30/21 16:56, IGnatius T Foobar wrote:

  
 The sendcommand binary should be in /usr/local/citadel in the container's
filesystem. 
  
 But if you *need* sendcommand for something, I should probably know what
it is, so we can provide a better way to do it. 
 

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287233Thu, 30 Dec 2021 18:56:31 +05002099287233@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287205Thu, 30 Dec 2021 14:40:44 +05002099287205@Uncensored Hi Art (Here I go again)

But first, wishing you a great new year and a healthy+happy end of year.

So. I upgrade my docker with this new version.
It seems that in this version the aliases do remain stored.
Although it leaves the first address as @em(hostname).domain.
And of course, here I can't edit it; so I decided to delete it and add it without the host; but apparently I can't add an address similar to the primary one I already deleted; except different ones. See attached images

One not related questions:
The sendcommand no longer exists in docker?
I look for the updated files in /usb/bin/ (inside the container) in December; hoping to find which that sendcommand. But I didn't find anything.

root@citadel:/# ls /usr/bin/ -l|grep Dec
lrwxrwxrwx 1 root root         25 Dec 28 11:34 aclocal -> /etc/alternatives/aclocal
-rwxr-xr-x 1 root root      14768 Dec 25  2020 autoconf
-rwxr-xr-x 1 root root       8534 Dec 25  2020 autoheader
-rwxr-xr-x 1 root root      32669 Dec 25  2020 autom4te
lrwxrwxrwx 1 root root         26 Dec 28 11:34 automake -> /etc/alternatives/automake
-rwxr-xr-x 1 root root      21161 Dec 25  2020 autoreconf
-rwxr-xr-x 1 root root      17130 Dec 25  2020 autoscan
-rwxr-xr-x 1 root root      33872 Dec 25  2020 autoupdate
lrwxrwxrwx 1 root root         21 Dec 20 00:00 awk -> /etc/alternatives/awk
lrwxrwxrwx 1 root root         21 Dec 28 11:35 c89 -> /etc/alternatives/c89
lrwxrwxrwx 1 root root         21 Dec 28 11:35 c99 -> /etc/alternatives/c99
lrwxrwxrwx 1 root root         20 Dec 28 11:34 cc -> /etc/alternatives/cc
-rwxr-xr-x 1 root root     238160 Dec 28 11:40 citadel
-rwxr-xr-x 1 root root      21394 Dec 14  2020 deb-systemd-helper
-rwxr-xr-x 1 root root       4411 Dec 14  2020 deb-systemd-invoke
-rwxr-xr-x 1 root root       1836 Dec 21  2020 dh_autotools-dev_restoreconfig
-rwxr-xr-x 1 root root       1849 Dec 21  2020 dh_autotools-dev_updateconfig
-rwxr-xr-x 1 root root       4128 Dec 25  2020 ifnames
lrwxrwxrwx 1 root root         22 Dec 20 00:00 nawk -> /etc/alternatives/nawk
lrwxrwxrwx 1 root root         23 Dec 20 00:00 pager -> /etc/alternatives/pager
lrwxrwxrwx 1 root root         21 Dec 28 11:34 rcp -> /etc/alternatives/rcp
lrwxrwxrwx 1 root root         24 Dec 28 11:34 rlogin -> /etc/alternatives/rlogin
lrwxrwxrwx 1 root root         21 Dec 28 11:34 rsh -> /etc/alternatives/rsh
lrwxrwxrwx 1 root root         10 Dec 20 00:00 touch -> /bin/touch
-rwxr-xr-x 1 root root        234 Dec 28  2018 xdg-user-dir
-rwxr-xr-x 1 root root      26696 Dec 28  2018 xdg-user-dirs-update
lrwxrwxrwx 1 root root         22 Dec 28 11:34 yacc -> /etc/alternatives/yacc
root@citadel:/# man citadel
bash: man: command not found
root@citadel:/# citadel --help
Attaching to server...
[--help:504]
Can't connect: Invalid argument
root@citadel:/# citadel -h
Attaching to server...
[-h:504]
Can't connect: Invalid argument

And one suggestion:
Using docker ps; I see that the container for "portainer" show info about the Ports used; maybe for the citadel container will be a nice addition

On 12/30/21 10:39, noreply wrote:

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Citadel Server, WebCit, utilities".

The annotated tag, v943 has been created
        at  0fecb7481a5f97ca1c788cd5b360ac7a4c8cd3b3 (tag)
   tagging  34dbf6c32f8d2163784799aeaa0c039ba10f1417 (commit)
  replaces  v941
 tagged by  Art Cancro
        on  Thu Dec 30 12:38:21 2021 -0500

- Log -----------------------------------------------------------------
Version 943 release

Art Cancro (48):
      Changed the reject message to be identical to the one used by Mailman so we can steal their translations later
      When delivering mail from a mailing list room, it is not enough to set the Reply-To: header to the room's address; we must set the From: address too.  Doing otherwise annoys the recipient's DKIM validators.
      Display an alert if we cannot connect to Citadel Server, instead of leaving the user sitting there bewildered.
      Don't use \r\n with ctdl_printf() because it adds a \n on its own.  Only add \r when CRLF is needed.  Also some UI tweaks.
      Begin gathering references and message IDs for replies
      Change all instances of "URI" to "URL" because that's more sensible
      HTTP headers are shown in purple in the syslog
      http request headers are now an array instead of a linked list
      response headers now use an array instead of a linked list
      It's Friday night, Wesley is out, Sammi is not hungry, and Miss Melissa is asleep on the couch.  Instead of making dinner I added URL parameter parsing to the web server.  I didn't think we'd need it but I want to be able to transmit some parameters to ENT0 and this seems like a reasonable way to do it.
      How about that ... we're now correctly handling the reply-references and carrying over the subject, and Wes is on the way here with a burger for me.
      do-release.sh now generates more meaningful descriptions of tags
      beautiful
      new div name
      open the reply box with .append() instead of tweaking outerHTML
      Major change to the javascript forum view.  We now wait for all messages to be loaded before rendering them all in one shot.  Rendering works, opening the reply box works, saving a message works, but we still have to figure out how to render a message in the location where it was entered.  Or maybe that's not a good idea?  Also the scroll_to semantics are broken but we are in a better position to redo this in a simpler way.
      Append messages to the DOM tree as div elements instead of as text.  This preserves the document tree's integrity when a malformed message arrives.
      scroll_to works again
      Slowly becoming a good JavaScript developer.  :)    Don't pass around div names when we can actually pass around references to the divs themselves.  This should shave off a few cycles because we don't have to keep calling document.getElementById()
      If div names are random strings, they don't need to start with "ctdl_"
      New functions to activate and deactivate the Loading... modal
      serv_pop3.c: updated to latest style guidelines
      Removed SSL cleanup function.  Let the operating system do this for us.
      OpenSSL no longer requires thread locking callbacks.  REMOVED FROM CITSERVER
      OpenSSL no longer requires thread locking callbacks.  REMOVED FROM WEBCIT CLASSIC
      OpenSSL no longer requires thread locking callbacks.  REMOVED FROM WEBCIT-NG
      Removed more legacy cruft no longer needed when OpenSSL>=v1.1
      Cleanup of crypto.c in wc-classic to prepare for certificate updates during runtime
      I need to make the static web server just a static web server.  I hate working in webcit classic because it's such a tangled mess.  The present commit just cleans up some old cruft; there is no actual change in functionality yet.  The next couple of commits will attempt to only cache the templates while using a regular file open for everything else.  There's no need to cache everything else because the operating system can do it better than we can.  KISS principle.  Coming soon to a webcit near you.
      Removed the epic editor from the tree.  Why was it even there?  It wasn't being used.
      Removed vestiges of the epic editor
      Finally removed the cached/hashed static directory stuff.  This should put us into a position to get the http-01 challenge working.
      Removed the obsolete 'setup' utility.  It is not used by any currently supported installation method. Removed the unfinished 'setup wizard'. Removed the unused 'tests' directory.
      Removed the unused 'selenium' directory
      BIG CHANGES: PAY ATTENTION 1. WebCit must now run on the same host as Citadel Server, which is how everyone runs it anyway. 2. WebCit now uses the SSL key and Certificate from the Citadel Server directory.
      Not sure what the point of that second call to SSL_accept() was for, but it was always failing, and removing it seems to be fine
      Citadel Server and WebCit (classic) now both reload the key and cert if the modification time of either one changes.  This should allow us to replace or renew the certificate during normal operation without restarting.
      Release version 942 generated by do-release.sh
      We have to push the changes *and* the tags
      setup was still in the makefile , oooops
      WebCit-NG: * Force webcit to be on the same host as citserver * Remove local keys directory, use the ones from citserver directory * Auto re-bind key and cert if either one changes * Support .well-known directory for static content, supporting HTTP-01
      Fucking hell.  We actually HAVE a "Allow non-subscribers to mail to this room" flag.  I was confused by the poor wording of this option in the text client, and screwed up the server's behavior when I rewrote the mailing list server.  It's fixed now, and once again has the correct behavior: anyone can email a room when the flag is set, and subscribers can email the room regardless of the flag.
      When delivering mailing list messages, populate the sending_room field of the recipient list.  This in turn populates the source_room directive in the SMTP delivery list, which we will use soon.
      Extend the source_room field all the way into the SMTP delivery loop. Tested adding SMTP headers directly into the outgoing message at the moment of transmission -- it worked really well.  Temporarily adding an "X-Citadel-Room:" header as a placeholder, but in the next couple of commits we will make it a "List-Unsubscribe:" header.
      listsub.c: style cleanup
      more idle style-cleanup work
      List-Unsubscribe: header is now being generated and is correct!
      Release version 943 generated by do-release.sh

-----------------------------------------------------------------------


hooks/post-receive

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287185Thu, 30 Dec 2021 12:39:19 +05002099287185@Uncensored=v1.1 Cleanup of crypto.c in wc-classic to prepare for certificate updates during runtime I need to make the static web server just a static web server. I hate working in webcit classic because it's such a tangled mess. The present commit just cleans up some old cruft; there is no actual change in functionality yet. The next couple of commits will attempt to only cache the templates while using a regular file open for everything else. There's no need to cache everything else because the operating system can do it better than we can. KISS principle. Coming soon to a webcit near you. Removed the epic editor from the tree. Why was it even there? It wasn't being used. Removed vestiges of the epic editor Finally removed the cached/hashed static directory stuff. This should put us into a position to get the http-01 challenge working. Removed the obsolete 'setup' utility. It is not used by any currently supported installation method. Removed the unfinished 'setup wizard'. Removed the unused 'tests' directory. Removed the unused 'selenium' directory BIG CHANGES: PAY ATTENTION 1. WebCit must now run on the same host as Citadel Server, which is how everyone runs it anyway. 2. WebCit now uses the SSL key and Certificate from the Citadel Server directory. Not sure what the point of that second call to SSL_accept() was for, but it was always failing, and removing it seems to be fine Citadel Server and WebCit (classic) now both reload the key and cert if the modification time of either one changes. This should allow us to replace or renew the certificate during normal operation without restarting. Release version 942 generated by do-release.sh We have to push the changes *and* the tags setup was still in the makefile , oooops WebCit-NG: * Force webcit to be on the same host as citserver * Remove local keys directory, use the ones from citserver directory * Auto re-bind key and cert if either one changes * Support .well-known directory for static content, supporting HTTP-01 Fucking hell. We actually HAVE a "Allow non-subscribers to mail to this room" flag. I was confused by the poor wording of this option in the text client, and screwed up the server's behavior when I rewrote the mailing list server. It's fixed now, and once again has the correct behavior: anyone can email a room when the flag is set, and subscribers can email the room regardless of the flag. When delivering mailing list messages, populate the sending_room field of the recipient list. This in turn populates the source_room directive in the SMTP delivery list, which we will use soon. Extend the source_room field all the way into the SMTP delivery loop. Tested adding SMTP headers directly into the outgoing message at the moment of transmission -- it worked really well. Temporarily adding an "X-Citadel-Room:" header as a placeholder, but in the next couple of commits we will make it a "List-Unsubscribe:" header. listsub.c: style cleanup more idle style-cleanup work List-Unsubscribe: header is now being generated and is correct! Release version 943 generated by do-release.sh ----------------------------------------------------------------------- hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287184Thu, 30 Dec 2021 12:39:04 +05002099287184@Uncensored Date: Thu Dec 30 12:38:21 2021 -0500 Release version 943 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=3bb79ddafcaf2407173223816312c6e6ce2ee5a8 commit 3bb79ddafcaf2407173223816312c6e6ce2ee5a8 Author: Art Cancro Date: Thu Dec 30 12:38:11 2021 -0500 List-Unsubscribe: header is now being generated and is correct! http://code.citadel.org/?p=citadel.git&a=commit&h=1565ead95bdbdd998350363a27f2b57945f86b28 commit 1565ead95bdbdd998350363a27f2b57945f86b28 Author: Art Cancro Date: Thu Dec 30 12:24:53 2021 -0500 more idle style-cleanup work http://code.citadel.org/?p=citadel.git&a=commit&h=a8800744f21d4cebd56bd74bbad900b4aca364bb commit a8800744f21d4cebd56bd74bbad900b4aca364bb Author: Art Cancro Date: Thu Dec 30 12:13:13 2021 -0500 listsub.c: style cleanup ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- citadel/modules/smtp/serv_smtpclient.c | 12 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- webcit/calendar.c | 272 +++++++++++++-------------------- webcit/listsub.c | 67 ++++---- webcit/webcit.h | 2 +- 7 files changed, 151 insertions(+), 208 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099287074Wed, 29 Dec 2021 17:55:45 +05002099287074@Uncensored Date: Wed Dec 29 17:53:59 2021 -0500 Extend the source_room field all the way into the SMTP delivery loop. Tested adding SMTP headers directly into the outgoing message at the moment of transmission -- it worked really well. Temporarily adding an "X-Citadel-Room:" header as a placeholder, but in the next couple of commits we will make it a "List-Unsubscribe:" header. http://code.citadel.org/?p=citadel.git&a=commit&h=5e6be359b17c74ae2b7ccd473c4315cfd7036fa0 commit 5e6be359b17c74ae2b7ccd473c4315cfd7036fa0 Author: Art Cancro Date: Wed Dec 29 14:47:34 2021 -0500 When delivering mailing list messages, populate the sending_room field of the recipient list. This in turn populates the source_room directive in the SMTP delivery list, which we will use soon. http://code.citadel.org/?p=citadel.git&a=commit&h=c152a35075c5a2c7403e310309331fe7061fb60d commit c152a35075c5a2c7403e310309331fe7061fb60d Author: Art Cancro Date: Wed Dec 29 11:28:48 2021 -0500 Fucking hell. We actually HAVE a "Allow non-subscribers to mail to this room" flag. I was confused by the poor wording of this option in the text client, and screwed up the server's behavior when I rewrote the mailing list server. It's fixed now, and once again has the correct behavior: anyone can email a room when the flag is set, and subscribers can email the room regardless of the flag. ----------------------------------------------------------------------- Summary of changes: citadel/internet_addressing.c | 11 +- citadel/modules/listdeliver/serv_listdeliver.c | 63 ++++----- citadel/modules/smtp/serv_smtpclient.c | 171 +++++++++++-------------- textclient/rooms.c | 69 +++++----- 4 files changed, 144 insertions(+), 170 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286863Tue, 28 Dec 2021 16:31:59 +05002099286863@Uncensored Date: Tue Dec 28 16:31:53 2021 -0500 WebCit-NG: * Force webcit to be on the same host as citserver * Remove local keys directory, use the ones from citserver directory * Auto re-bind key and cert if either one changes * Support .well-known directory for static content, supporting HTTP-01 ----------------------------------------------------------------------- Summary of changes: citadel/modules/crypto/serv_crypto.h | 2 +- webcit-ng/ctdlclient.c | 97 +------------- webcit-ng/http.c | 2 +- webcit-ng/main.c | 14 +- webcit-ng/request.c | 12 +- webcit-ng/ssl.c | 252 ++++++++--------------------------- webcit-ng/static.c | 14 +- webcit-ng/webcit.h | 14 +- 8 files changed, 97 insertions(+), 310 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286697Mon, 27 Dec 2021 17:49:04 +05002099286697@Uncensored Date: Mon Dec 27 17:49:01 2021 -0500 setup was still in the makefile , oooops ----------------------------------------------------------------------- Summary of changes: webcit/Makefile.in | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286691Mon, 27 Dec 2021 17:43:05 +05002099286691@Uncensored Date: Mon Dec 27 17:43:02 2021 -0500 We have to push the changes *and* the tags ----------------------------------------------------------------------- Summary of changes: do-release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286690Mon, 27 Dec 2021 17:41:12 +05002099286690@Uncensored Date: Mon Dec 27 17:40:40 2021 -0500 Release version 942 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=ab376f8217b148b8d0896a31e6a2502100f134ac commit ab376f8217b148b8d0896a31e6a2502100f134ac Author: Art Cancro Date: Mon Dec 27 17:30:09 2021 -0500 Citadel Server and WebCit (classic) now both reload the key and cert if the modification time of either one changes. This should allow us to replace or renew the certificate during normal operation without restarting. ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- citadel/modules/crypto/serv_crypto.c | 25 +++++++++++++++ libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- webcit/crypto.c | 61 ++++++++++++++++++++++++++++-------- webcit/serv_func.c | 3 -- webcit/webcit.h | 2 +- 7 files changed, 77 insertions(+), 20 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286678Mon, 27 Dec 2021 15:52:01 +05002099286678@Uncensored Date: Mon Dec 27 15:51:58 2021 -0500 Not sure what the point of that second call to SSL_accept() was for, but it was always failing, and removing it seems to be fine ----------------------------------------------------------------------- Summary of changes: webcit/crypto.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286677Mon, 27 Dec 2021 15:49:43 +05002099286677@Uncensored Date: Mon Dec 27 15:49:38 2021 -0500 BIG CHANGES: PAY ATTENTION 1. WebCit must now run on the same host as Citadel Server, which is how everyone runs it anyway. 2. WebCit now uses the SSL key and Certificate from the Citadel Server directory. ----------------------------------------------------------------------- Summary of changes: webcit/Makefile.in | 6 +- webcit/auth.c | 5 +- webcit/crypto.c | 278 ++---------------------------------- webcit/serv_func.c | 120 +++++++--------- webcit/{tcp_sockets.c => sockets.c} | 269 ++++++++-------------------------- webcit/{tcp_sockets.h => sockets.h} | 4 +- webcit/sysdep.c | 18 --- webcit/webcit.h | 27 ++-- webcit/webserver.c | 35 ++--- 9 files changed, 154 insertions(+), 608 deletions(-) rename webcit/{tcp_sockets.c => sockets.c} (83%) rename webcit/{tcp_sockets.h => sockets.h} (96%) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286661Mon, 27 Dec 2021 14:32:01 +05002099286661@Uncensored Date: Mon Dec 27 14:31:57 2021 -0500 Removed the unused 'selenium' directory ----------------------------------------------------------------------- Summary of changes: webcit/selenium/ChangeIdentity | 107 ---------------- webcit/selenium/LoginEditcontactLogout | 212 -------------------------------- webcit/selenium/LoginLogOut | 52 -------- webcit/selenium/LoginNoteseditingLogout | 117 ------------------ webcit/selenium/Tasks | 127 ------------------- webcit/selenium/login_out | 47 ------- webcit/selenium/webcit | 18 --- 7 files changed, 680 deletions(-) delete mode 100644 webcit/selenium/ChangeIdentity delete mode 100644 webcit/selenium/LoginEditcontactLogout delete mode 100644 webcit/selenium/LoginLogOut delete mode 100644 webcit/selenium/LoginNoteseditingLogout delete mode 100644 webcit/selenium/Tasks delete mode 100644 webcit/selenium/login_out delete mode 100644 webcit/selenium/webcit hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286658Mon, 27 Dec 2021 14:27:12 +05002099286658@Uncensored Date: Mon Dec 27 14:27:08 2021 -0500 Removed the obsolete 'setup' utility. It is not used by any currently supported installation method. Removed the unfinished 'setup wizard'. Removed the unused 'tests' directory. ----------------------------------------------------------------------- Summary of changes: webcit/Makefile.in | 12 +- webcit/auth.c | 38 +-- webcit/configure.ac | 2 +- webcit/setup.c | 765 --------------------------------------------- webcit/setup_wizard.c | 53 ---- webcit/tests/.gitignore | 4 - webcit/tests/Makefile.in | 139 -------- webcit/tests/test_main.c | 232 -------------- webcit/tests/test_tools.c | 322 ------------------- webcit/tests/webcit_test.h | 15 - webcit/webcit.h | 2 - webcit/webserver.c | 34 +- 12 files changed, 18 insertions(+), 1600 deletions(-) delete mode 100644 webcit/setup.c delete mode 100644 webcit/setup_wizard.c delete mode 100644 webcit/tests/.gitignore delete mode 100644 webcit/tests/Makefile.in delete mode 100644 webcit/tests/test_main.c delete mode 100644 webcit/tests/test_tools.c delete mode 100644 webcit/tests/webcit_test.h hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286639Mon, 27 Dec 2021 11:28:53 +05002099286639@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286634Mon, 27 Dec 2021 11:09:16 +05002099286634@Uncensored Date: Mon Dec 27 11:09:11 2021 -0500 Finally removed the cached/hashed static directory stuff. This should put us into a position to get the http-01 challenge working. ----------------------------------------------------------------------- Summary of changes: webcit/context_loop.c | 33 ++++---- webcit/static.c | 226 +++++--------------------------------------------- webcit/webcit.c | 35 ++++---- 3 files changed, 53 insertions(+), 241 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286564Sun, 26 Dec 2021 10:54:10 +05002099286564@Uncensored Date: Sun Dec 26 10:54:02 2021 -0500 Removed vestiges of the epic editor ----------------------------------------------------------------------- Summary of changes: webcit/Makefile.in | 14 +------------- webcit/configure.ac | 3 --- webcit/static.c | 1 - 3 files changed, 1 insertion(+), 17 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286563Sun, 26 Dec 2021 10:53:43 +05002099286563@Uncensored Date: Sun Dec 26 10:49:33 2021 -0500 Removed the epic editor from the tree. Why was it even there? It wasn't being used. ----------------------------------------------------------------------- Summary of changes: webcit/epic/js/epiceditor.js | 2899 --------------------------- webcit/epic/js/epiceditor.min.js | 5 - webcit/epic/themes/base/epiceditor.css | 70 - webcit/epic/themes/editor/epic-dark.css | 13 - webcit/epic/themes/editor/epic-light.css | 12 - webcit/epic/themes/preview/bartik.css | 167 -- webcit/epic/themes/preview/github.css | 368 ---- webcit/epic/themes/preview/preview-dark.css | 121 -- webcit/static.c | 2 +- webcit/subst.c | 70 +- 10 files changed, 20 insertions(+), 3707 deletions(-) delete mode 100644 webcit/epic/js/epiceditor.js delete mode 100644 webcit/epic/js/epiceditor.min.js delete mode 100644 webcit/epic/themes/base/epiceditor.css delete mode 100644 webcit/epic/themes/editor/epic-dark.css delete mode 100644 webcit/epic/themes/editor/epic-light.css delete mode 100644 webcit/epic/themes/preview/bartik.css delete mode 100644 webcit/epic/themes/preview/github.css delete mode 100644 webcit/epic/themes/preview/preview-dark.css hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286283Wed, 22 Dec 2021 16:46:55 +05002099286283@Uncensored Date: Wed Dec 22 16:46:50 2021 -0500 I need to make the static web server just a static web server. I hate working in webcit classic because it's such a tangled mess. The present commit just cleans up some old cruft; there is no actual change in functionality yet. The next couple of commits will attempt to only cache the templates while using a regular file open for everything else. There's no need to cache everything else because the operating system can do it better than we can. KISS principle. Coming soon to a webcit near you. ----------------------------------------------------------------------- Summary of changes: webcit/static.c | 148 +++++++++++++++----------------------------------------- webcit/subst.c | 119 ++++++++++++--------------------------------- 2 files changed, 70 insertions(+), 197 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286168Tue, 21 Dec 2021 13:45:40 +05002099286168@Uncensored Date: Tue Dec 21 13:45:33 2021 -0500 Cleanup of crypto.c in wc-classic to prepare for certificate updates during runtime ----------------------------------------------------------------------- Summary of changes: webcit/crypto.c | 289 ++++++++++++++++++++++---------------------------------- 1 file changed, 115 insertions(+), 174 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286164Tue, 21 Dec 2021 13:35:35 +05002099286164@Uncensored Date: Tue Dec 21 13:35:27 2021 -0500 Removed more legacy cruft no longer needed when OpenSSL>=v1.1 ----------------------------------------------------------------------- Summary of changes: citadel/modules/crypto/serv_crypto.c | 58 +++++++++++++++++++++--------------- 1 file changed, 34 insertions(+), 24 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286080Mon, 20 Dec 2021 15:50:05 +05002099286080@Uncensored Date: Mon Dec 20 15:50:00 2021 -0500 OpenSSL no longer requires thread locking callbacks. REMOVED FROM WEBCIT-NG http://code.citadel.org/?p=citadel.git&a=commit&h=3bfc4076f3c0d461a84cc39fc2641f31bc948549 commit 3bfc4076f3c0d461a84cc39fc2641f31bc948549 Author: Art Cancro Date: Mon Dec 20 15:47:01 2021 -0500 OpenSSL no longer requires thread locking callbacks. REMOVED FROM WEBCIT CLASSIC ----------------------------------------------------------------------- Summary of changes: webcit-ng/ssl.c | 41 ----------------------------------------- webcit/crypto.c | 56 ++------------------------------------------------------ 2 files changed, 2 insertions(+), 95 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099286075Mon, 20 Dec 2021 15:42:59 +05002099286075@Uncensored Date: Mon Dec 20 15:42:51 2021 -0500 OpenSSL no longer requires thread locking callbacks. REMOVED FROM CITSERVER ----------------------------------------------------------------------- Summary of changes: citadel/modules/crypto/serv_crypto.c | 37 ------------------------------------ citadel/modules/crypto/serv_crypto.h | 1 - 2 files changed, 38 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285997Sun, 19 Dec 2021 17:39:05 +05002099285997@Uncensored Date: Sun Dec 19 17:39:01 2021 -0500 Removed SSL cleanup function. Let the operating system do this for us. ----------------------------------------------------------------------- Summary of changes: citadel/modules/crypto/serv_crypto.c | 117 +++++++++++++---------------------- citadel/modules/crypto/serv_crypto.h | 1 - citadel/sysdep.c | 5 +- 3 files changed, 44 insertions(+), 79 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285991Sun, 19 Dec 2021 16:58:08 +05002099285991@Uncensored Date: Sun Dec 19 16:58:01 2021 -0500 serv_pop3.c: updated to latest style guidelines ----------------------------------------------------------------------- Summary of changes: citadel/modules/pop3/serv_pop3.c | 256 +++++++++++++++------------------------ 1 file changed, 98 insertions(+), 158 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285609Wed, 15 Dec 2021 17:36:20 +05002099285609@Uncensored Hi Art

(Today I was playing the the Docker and I found that I can use a letsencrypt in the /citade-data/keys WOW!)


Then, it occurred to me to review the cookies, trying to remember a security problem that someone reported.

It strikes me that one of the cookies has an expiration date one day before its creation.
Maybe it has a reason to be, or maybe it is a bug or potential problem.

I attach the image.
Is it ok for me to write the issues I find here or send it to the issue tracker room?

In this case I sent it to both.


]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285510Wed, 15 Dec 2021 00:03:17 +05002099285510@Uncensored Date: Wed Dec 15 00:03:15 2021 -0500 New functions to activate and deactivate the Loading... modal ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 9 +++++++++ webcit-ng/static/js/main.js | 15 +++++++++++++++ webcit-ng/static/js/view_forum.js | 6 +++--- 3 files changed, 27 insertions(+), 3 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285485Tue, 14 Dec 2021 19:31:24 +05002099285485@Uncensored Date: Tue Dec 14 19:31:21 2021 -0500 If div names are random strings, they don't need to start with "ctdl_" ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285480Tue, 14 Dec 2021 19:14:53 +05002099285480@Uncensored Date: Tue Dec 14 19:14:51 2021 -0500 Slowly becoming a good JavaScript developer. :) Don't pass around div names when we can actually pass around references to the divs themselves. This should shave off a few cycles because we don't have to keep calling document.getElementById() ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285470Tue, 14 Dec 2021 18:23:42 +05002099285470@Uncensored Date: Tue Dec 14 18:23:39 2021 -0500 scroll_to works again ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285454Tue, 14 Dec 2021 17:48:35 +05002099285454@Uncensored Date: Tue Dec 14 17:48:31 2021 -0500 Append messages to the DOM tree as div elements instead of as text. This preserves the document tree's integrity when a malformed message arrives. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 120 +++++++++++++++++++++----------------- 1 file changed, 65 insertions(+), 55 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285436Tue, 14 Dec 2021 16:17:57 +05002099285436@Uncensored Date: Tue Dec 14 16:17:53 2021 -0500 Major change to the javascript forum view. We now wait for all messages to be loaded before rendering them all in one shot. Rendering works, opening the reply box works, saving a message works, but we still have to figure out how to render a message in the location where it was entered. Or maybe that's not a good idea? Also the scroll_to semantics are broken but we are in a better position to redo this in a simpler way. ----------------------------------------------------------------------- Summary of changes: webcit-ng/forum_view.c | 11 --- webcit-ng/static/js/main.js | 52 ----------- webcit-ng/static/js/util.js | 49 ++++++++++ webcit-ng/static/js/view_forum.js | 192 +++++++++++++++++++++----------------- 4 files changed, 154 insertions(+), 150 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285320Mon, 13 Dec 2021 15:18:55 +05002099285320@Uncensored Date: Mon Dec 13 15:18:54 2021 -0500 open the reply box with .append() instead of tweaking outerHTML ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285312Mon, 13 Dec 2021 14:25:50 +05002099285312@Uncensored Date: Mon Dec 13 14:25:48 2021 -0500 new div name ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285239Sun, 12 Dec 2021 20:10:37 +05002099285239@Uncensored Date: Sun Dec 12 20:10:35 2021 -0500 beautiful ----------------------------------------------------------------------- Summary of changes: webcit-ng/http.c | 22 ++++++++++++++-------- webcit-ng/main.c | 1 - webcit-ng/request.c | 14 ++++++-------- webcit-ng/static.c | 1 - webcit-ng/static/js/view_forum.js | 12 ++---------- 5 files changed, 22 insertions(+), 28 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285233Sun, 12 Dec 2021 19:40:47 +05002099285233@Uncensored Date: Sun Dec 12 19:40:44 2021 -0500 do-release.sh now generates more meaningful descriptions of tags ----------------------------------------------------------------------- Summary of changes: do-release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285072Fri, 10 Dec 2021 21:11:15 +05002099285072@Uncensored Date: Fri Dec 10 21:11:13 2021 -0500 How about that ... we're now correctly handling the reply-references and carrying over the subject, and Wes is on the way here with a burger for me. ----------------------------------------------------------------------- Summary of changes: webcit-ng/http.c | 18 ++++++++++++++++++ webcit-ng/messages.c | 8 +++++++- webcit-ng/static/js/view_forum.js | 16 +++++++++++++--- webcit-ng/webcit.h | 1 + 4 files changed, 39 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285065Fri, 10 Dec 2021 20:19:45 +05002099285065@Uncensored Date: Fri Dec 10 20:19:42 2021 -0500 It's Friday night, Wesley is out, Sammi is not hungry, and Miss Melissa is asleep on the couch. Instead of making dinner I added URL parameter parsing to the web server. I didn't think we'd need it but I want to be able to transmit some parameters to ENT0 and this seems like a reasonable way to do it. ----------------------------------------------------------------------- Summary of changes: webcit-ng/http.c | 26 ++++++++++++++++++++++++++ webcit-ng/webcit.h | 1 + 2 files changed, 27 insertions(+) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285059Fri, 10 Dec 2021 19:04:14 +05002099285059@Uncensored Date: Fri Dec 10 19:04:13 2021 -0500 response headers now use an array instead of a linked list ----------------------------------------------------------------------- Summary of changes: webcit-ng/http.c | 48 ++++++++++++++++++++++++------------------------ webcit-ng/webcit.h | 8 +------- 2 files changed, 25 insertions(+), 31 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285055Fri, 10 Dec 2021 18:51:55 +05002099285055@Uncensored Date: Fri Dec 10 18:51:53 2021 -0500 http request headers are now an array instead of a linked list ----------------------------------------------------------------------- Summary of changes: webcit-ng/http.c | 46 ++++++++++++++++++++++++++-------------------- webcit-ng/webcit.h | 7 ++++++- 2 files changed, 32 insertions(+), 21 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285051Fri, 10 Dec 2021 18:31:37 +05002099285051@Uncensored Date: Fri Dec 10 18:31:36 2021 -0500 HTTP headers are shown in purple in the syslog ----------------------------------------------------------------------- Summary of changes: webcit-ng/http.c | 12 ++++++------ webcit-ng/webcit.h | 10 +++++----- 2 files changed, 11 insertions(+), 11 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285044Fri, 10 Dec 2021 18:22:30 +05002099285044@Uncensored Date: Fri Dec 10 18:22:28 2021 -0500 Change all instances of "URI" to "URL" because that's more sensible ----------------------------------------------------------------------- Summary of changes: webcit-ng/README.txt | 2 +- webcit-ng/admin_functions.c | 6 +++--- webcit-ng/api.txt | 2 +- webcit-ng/ctdl_commands.c | 2 +- webcit-ng/http.c | 12 ++++++------ webcit-ng/request.c | 22 +++++++++++----------- webcit-ng/room_functions.c | 16 ++++++++-------- webcit-ng/static.c | 2 +- webcit-ng/user_functions.c | 12 ++++++------ webcit-ng/webcit.h | 2 +- 10 files changed, 39 insertions(+), 39 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285042Fri, 10 Dec 2021 18:15:46 +05002099285042@Uncensored Date: Fri Dec 10 18:15:43 2021 -0500 Begin gathering references and message IDs for replies ----------------------------------------------------------------------- Summary of changes: webcit-ng/forum_view.c | 6 ++++++ webcit-ng/messages.c | 8 +++++--- webcit-ng/static/js/view_forum.js | 40 +++++++++++++++++++++++++++++++-------- 3 files changed, 43 insertions(+), 11 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099285006Fri, 10 Dec 2021 10:32:39 +05002099285006@Uncensored Date: Fri Dec 10 10:32:37 2021 -0500 Don't use \r\n with ctdl_printf() because it adds a \n on its own. Only add \r when CRLF is needed. Also some UI tweaks. ----------------------------------------------------------------------- Summary of changes: webcit-ng/messages.c | 7 ++++--- webcit-ng/static/css/webcit.css | 12 ++++++++---- webcit-ng/static/index.html | 14 ++++++-------- webcit-ng/static/js/view_forum.js | 4 ++-- 4 files changed, 20 insertions(+), 17 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099284941Thu, 09 Dec 2021 18:20:39 +05002099284941@Uncensored Date: Thu Dec 9 18:20:36 2021 -0500 Display an alert if we cannot connect to Citadel Server, instead of leaving the user sitting there bewildered. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/main.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099284928Thu, 09 Dec 2021 17:48:28 +05002099284928@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099284927Thu, 09 Dec 2021 17:43:19 +05002099284927@Uncensored Date: Thu Dec 9 17:43:17 2021 -0500 When delivering mail from a mailing list room, it is not enough to set the Reply-To: header to the room's address; we must set the From: address too. Doing otherwise annoys the recipient's DKIM validators. ----------------------------------------------------------------------- Summary of changes: citadel/modules/listdeliver/serv_listdeliver.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283860Mon, 29 Nov 2021 15:45:16 +05002099283860@Uncensored Date: Mon Nov 29 15:45:14 2021 -0500 Changed the reject message to be identical to the one used by Mailman so we can steal their translations later http://code.citadel.org/?p=citadel.git&a=commit&h=843a57e7e729af628bc3781231f1f2e62bf01129 commit 843a57e7e729af628bc3781231f1f2e62bf01129 Author: Art Cancro Date: Mon Nov 29 14:24:14 2021 -0500 Release version 941 generated by do-release.sh ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- citadel/modules/smtp/serv_smtp.c | 2 +- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- webcit/webcit.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283844Mon, 29 Nov 2021 14:24:17 +05002099283844@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283843Mon, 29 Nov 2021 14:24:08 +05002099283843@Uncensored Date: Mon Nov 29 14:24:06 2021 -0500 Mail to a mailing list room must be from a subscriber (or a logged in user) otherwise incoming message is rejected. ----------------------------------------------------------------------- Summary of changes: citadel/internet_addressing.c | 33 +++++++++++++++++++++++++++++++-- citadel/internet_addressing.h | 1 + citadel/modules/smtp/serv_smtp.c | 10 ++++++++++ 3 files changed, 42 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283813Mon, 29 Nov 2021 10:43:19 +05002099283813@Uncensored Date: Mon Nov 29 10:43:14 2021 -0500 Cleaned up another set of conditionals in the SMTP server. ----------------------------------------------------------------------- Summary of changes: citadel/modules/smtp/serv_smtp.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283809Mon, 29 Nov 2021 10:31:55 +05002099283809@Uncensored Date: Mon Nov 29 10:31:50 2021 -0500 Updated the comments in do-release.sh ----------------------------------------------------------------------- Summary of changes: do-release.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283759Sun, 28 Nov 2021 19:47:22 +05002099283759@Uncensored Date: Sun Nov 28 19:47:20 2021 -0500 Another win for short circuit evaluation ----------------------------------------------------------------------- Summary of changes: citadel/modules/smtp/serv_smtp.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283754Sun, 28 Nov 2021 19:25:58 +05002099283754@Uncensored Date: Sun Nov 28 19:25:55 2021 -0500 Made the RBL evaluation conditional cleaner by assuming short-circuit evaluation. ----------------------------------------------------------------------- Summary of changes: citadel/modules/smtp/serv_smtp.c | 90 +++++++++++++++++++--------------------- do-release.sh | 2 +- 2 files changed, 43 insertions(+), 49 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283591Fri, 26 Nov 2021 16:27:16 +05002099283591@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283590Fri, 26 Nov 2021 16:27:15 +05002099283590@Uncensoredide ysconfig nternet , when encountering a "directory" domain, substitutes "localhost" WebCit (classic) now loads obsolete "directory" domains as "localhost" domains small cleanup of serv_user.c before I work on it AGEA and ASEA server commands to get and set a user's email addresses more progress on email address editing in the text client Completed initial version of text client admin edit of user email addresses Experiment with DB->compact() to reduce the size of database files on disk when possible. Commented out while we test it. Editing of account email addresses using the new server commands in WebCit-classic. This completes the transition. Log a warning message if housekeeping has not run in more than 5 minutes Run db->compact() to shrink DB files on disk after an auto-purger run, only if the undocumented configuration option c_shrink_db_files is set to nonzero. CURUSESSL_TRY for outbound SMTP (currently commented out) New config option 'c_smtpclient_try_starttls' if nonzero outbound SMTP attempts STARTTLS if offered Remove code which creates or references the 'bitbucket' directory. We haven't used that in ages. Moved the remaining help files for the text client out of the server and into the text client. Removed remaining bits of funambol config from server Removed remnants of dspam module config Applied patch sent by Chris West to fix Debian bug 859789 (compatibility with libssl) Merge branch 'master' of ssh://git.citadel.org:/appl/gitroot/citadel started working on code for extracting email addresses from ldap Copy email addresses from LDAP LDAP search grml test get display name and uid from ldap , show in log libical_errors_are_fatal is now opaque. Change to a call to icalerror_set_errors_are_fatal() try to work with libical1 and libical2 remove syntax error same fix in webcit remove DH parameter stuff that isn't needed and doesn't work with newer openssl Started prepping for the move from LDAP Access to LDAP Sync CDB_OPENID is now CDB_EXTAUTH More prep for turning openid table into generic external auth DAV: getcontenttype tag belongs inside prop tag (thanks bravegnu) LOCK HER UP Refactored CtdlGetUser() API Remove unused parameter Change the become_user parameter of create_user() to an enum, to make calling code easier to read Internal API change, create_user() now expects to be given a uid wtf, people? we indent with tabs not spaces. Repurposed an old upgrade module for upcoming index pass for uids More use of %m instead of strerror(errno) combined single utility function for deriving display name from ldap search result combined single utility function for deriving UID from ldap search result more moving towards ldap sync ... lots of refactoring Index by UID Internal version number to 913 to activate UID indexing at all sites getuserbyuid() now uses the extauth index, so we can do ldap sync fix indentation All functions which connect and bind to LDAP using the Bind DN now flow through a single function instead of duplicating all that code four times. ctdlsh: don't crash on the mailq command if the queue is empty. A little more work on the LDAP Sync fixed a memory leak Synchronization of LDAP users to Citadel is now complete, including email addresses. FIXME: need to make the email piece a site-configurable setting. New site setting c_ldap_sync_email_addrs to toggle synchronization of email addresses from LDAP to Citadel. Remove comment about site configurable setting in a place where we already made it a site configurable setting. minor cosmetic cleanups remove installation system references to obsolete openldap directory minor style cleanups * oldver is the version number of Citadel Server which was active on the previous run of the program, learned from the system configuration. * If we are running a new Citadel Server for the first time, oldver will be 0. * We keep this value around for the entire duration of the program run because we'll need it during several stages of startup. serv_upgrade.c now has pre- and post- startup sections. The import of email addresses from vcards to the user configuration records has to take place after serv_inetcfg is initialized. Also versioned everything at 914 for new release. When a server port number is unset (value 0) , don't just warn in the log ... set it to the default value. removed some declarations that are no longer used Reordered the locking and setting of user email addresses to avoid a race condition right after an upgrade if a user logs in OpenLDAP is now a required dependency. We will be removing all optional dependencies to avoid build variabilty hell. version 915 specifies libical2 for debian dependencies replace deprecated readdir_r() with readdir() More work on replace deprecated readdir_r() configure.ac blah serv_crypto.c: minor style cleanups before we try to make it work with openssl 1.1 More work on using the OpenSSL 1.1 API It's 2018 here in the civilized world. Changed the copyright banners of both Citadel Server and WebCit to read 2018 as the copyright date. Also included in citserver the 'full' GPL disclaimer, right next to the words 'open source software' just to piss off Richard Stallman and other communists. citserver updated to openssl 1.1 API More OpenSSL 1.1 update openssl 1.1 in client Version 916 tag everything for release webcit-ng openssl 1.1 compatibility no more help directory or notify_about_newmail.js releaseversion.sh simplified to handle integer version numbers releaseversion.sh simplified to handle integer version numbers sdfjsdklfjsdlkfjds sdfl;mshdfsaldhfiusdhkasdsds libcitadel/configure.in: extract version number from libcitadel.h citadel/configure.in extract version number from source code completed the auto versioning m4 macros fixed a syntax error create package-version.txt in each dir during bootstrap MAKE WEBCIT GREAT AGAIN! Ended the use of the CC macro in rbl_check() , made the address to check a calling parameter moved a close-paren onto the next line. HK Rowling is a big yeasty cunt. began work on a theme change need an awesome slider removed IGnet functions from text client began removing IGnet from the server aagh Revert "aagh" Revert "began removing IGnet from the server" More orderly this time. Removed serv_networkclient.c module. removed node display and network parameters from text client Removed netfilterlist module Removed spoolin processing scraping the bits away network_usetable() no longer needed whittling away the ignet pieces... whittle whittle whittle whittle whittle whittle more trimming away of ignet stuffs whittle whittle more whittling away ... plus memory leak tests Semi-permanent implementation of memory leak checking Removed all references to network/spoolout/ directory Started removing eNodename references war on eNodeName Hide obsolete server functions from webcit UI A little more work on the threaded view tabs not spaces Added a few spaces Fix call to daemon() to make it not change the working directory initial work on flat view Starting to pull some rendering out of the C code and put it back in JS track c_lastseen so we can use it in read operations disabled server-side message sequencing code initial work on inline rendering setup reshufflize the parameters to room renderers foo older and newer I think we finally have the older/newer messages buttons functioning properly. javascript moved the renderer down to its own (currently empty) function do we need the inner div? inner div not needed anymore wowzers! we can survive a server problem now. put the original div text back if there's an error. Got it! Temporarily working with the server-side C renderer ok, that's all for today. this was fun. Style and cruft skeleton code for json render html render replaced by json render in the C server. next needs to be the json-to-html in the client side... JSON render complete! Began moving style to a proper style sheet. Style, baby! scroll to async css tuning Removed some more ignet cruft more removal of ignet cruft more removal of ignet cruft more removal of ignet cruft ssl.c - change style ssl.c - change style Fix error in Makefile.in , patch submitted by Adrian Bunk libical3 compatibility , patches submitted by Adrian Bunk Renderers cleanup part 1 Renderers cleanup part 2 Ultra-simplification of the build system for the text client. Eliminated the use of GNU Autotools because Richard Stallman is a communist who hates America. Now we use "conf-IG-ure" , a new build system which is patriotic and has screeching eagles and American flags and Bibles and guns and can win at NASCAR without even trying. bootstrap script merely creates package-version.txt , nothing else Deal with text/x-markdown in the text client by displaying it as plain text. Capture the actual SMTP response from the server, ugly hack using libcurl debug get_ical_data.sh is now run at compile time Removed obsolete mkdirs from Makefile fixed makefile to not try to install stuff that is not there anymore remove unused trace function change to db-open flags textclient: OpenSSL detection in conf-IG-ure Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel Rewrote mimepart() as view_or_download_mimepart() which uses the DLAT server command to load attachments from the server as one big happy object instead of chunking it. Hopefully this will take care of the problems people have been having downloading attachments. webcit version 921 richard stallman is a communist jerk ... donald trump is the most awesome leader EVER fixed an error in one of the log messages b0rk d0rk aaak tweaked old docs The "c_smtpclient_use_starttls" configuration option has been replaced with a new "c_smtpclient_disable_starttls" option, making the attempt of encryption for outbound SMTP connections the default. indent -kr -i8 auth.c indent -kr -i8 md5.c indent -kr -i132 citserver.c indent indent -kr -i8 -l132 on everything in textclient indent -kr -i8 -l132 on everything in webcit-ng database.c cleanup added more diagnostic messages to mmnext sanity checks sanity check diagnostic mode more diags more diags database_cleanup.sh backs up cdb.0d but doesn't restore it! OMFG THIS IS GOING TO CAUSE A CATACLYSMIC CHAIN REACTION THAT RIPS APART THE ENTIRE SPACE-TIME CONTINUUM!!!!!1 Fixed. tuning the index cache Removed vestiges of .Known Shared command struct MetaData has an unused member "mimetype" that doesn't appear to be used anywhere (other than import/export, which doesn't count). Removed this element from import/export and renamed the member to "unused_field_1" in preparation for removing it. msgbase.c style cleanup Removed the unused field (mimetype) from struct MetaData The new server API no longer uses upload_type. Removed it from CitContext. random documentation updates cleaned up some compiler warnings RSS feed reader now accepts as a substitute for if the latter is not present. quick comment change AdjRefCount() now runs synchronously, eliminating the refcount_adjustments.dat queue file. This is the last piece of server state not kept in the database, except for files/ and keys/ Increment version to 922 cleaned up some compiler warnings New file user_functions.c contains skeleton code for the /ctdl/u/... calls object_in_user() is a master function which calls slave functions fetch_user_bio() and fetch_user_photo(). Fuck political correctness. I will not bow to the demands of social justice warriors. Die, fuckers. /ctdl/u/username/userpic is now complete begin work on displaying avatars next to messages html_to_ascii() , removed unused option do_citaformat Found the correct JavaScript incantation to display a FontAwesome character in place of a user avatar if the latter is not found. html_to_ascii() - removed display of italics like /this/, bold like *this*, and underline like _this_. It was too distracting. Starting to look into why we still have 'Purge this vCard' messages ... there's an entire section of code that needs to get cleaned up now that we don't have the networker anymore. Removed the chunked-io stuff from libcitadel. Nothing was using it and it isn't written portably. We need to be better about making stuff work outside of Linux now that the kernel has been taken over by far-left social justice communists like C. Emkhe. Citadel Server and libcitadel version 922 Removed ical_dezonify() from the citserver build ... it isn't used anymore 80 columns is so 20 century minor style cleanup Removed the "base64" utility program. We've been doing base64 with a library function for many years now. Removed the standalone "msgform" utility. It isn't needed anymore. Removed the stress tester source file ... this is also obsolete Removed the developers.txt file ... this isn't used anymore Deleted more obsolete files. The objective is to reduce sprawl. Ideally we would have a single binary. more minor style cleanups removed more old stuff Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel Suppress 'message 0 appears to be corrupted' log messages As per RFC3920 section 7, if an XMPP client does not specify a resource ID, generate one. Generate a synthetic user@host for XMPP JID if the user does not have an Internet email address. populate cs_inet_email with a default generated address ... we need it for XMPP If we have to generate an XMPP resource name, make it a simple integer cs_pid and not a giant UUID. xmpp non sasl authenticate does not need the resource name comment change Auto-generate email address at login if user does not have one , also save it to the user record and the index properly using the correct function call. The form of the generated address has also changed. version 924 Address generator is moved into internet_addressing.c because that's where it belongs! Also I'm going to enhance it later. Auto-generated email address is now derived from the screen name. Fall back to other methods if that address already exists. Removed the 'master user' feature ... if we still need this we'll find another way cosmetic cleanup of files in xmpp directory Removed the obsolete netproc hooks from the vcard module Changed the year in the copyright banner(s) to 2019. removed old script One more field in the xml-vcard What was I thinking? The style experiment in views.js looked horrible. Put it back the way it was before. Links for older and newer blocks of messages in the BBS view have been centered, changed to _("Older posts") and _("Newer posts") (which were both in the .po file already) and centered. Also I added some adorable little FA arrow icons to them. SQUEEEEEEEE! Cleaned up some messy rendering in the bbs view. Trim SMTP responses down to one line when putting them into bounce records. Also put that in a separate function. Removed the obsolete MSG3 command. cleaned a few things up in messages.c ... geez this is such old code Removed the MRTG module. No one is using this anymore. Reject url_keys of invalid size instead of crashing The battle against bit rot continues! * Removed support for Berkeley DB versions older than 5.0 * Removed the "public_clients" configuration file and code which uses it * Removed all remaining code that references "mail.aliases" Do not check for DB_H definition anymore. doco fix Removed the <.W>holist oomname and <.W>holist ostname commands from the text client removed user/host/room masquerade from both clients more work on removing masqueraded user/room/host names fix to previous commit Version 925 release Started working on march mode! march mode list is loaded and works, now just need to filter it a little closer to the march list march_list functionality is complete! mild change to navbar Rooms with new messages boldface in room list Indents are 8 positions, NEVER 4, and are comprised of tabs, not spaces. Anyone who believes otherwise is a racist. ungoto/skip/goto ui taking shape... Orthodontic adjustments (moved some braces around) Accept the origin host as indicated by the client, if the connection is from 127.0.0.1 or ::1 (or on a local socket, as before) nter-message command in the text client now warns the user that this creates a top level blog post instead of a comment. Removing things that depend on sysvinit. It's a systemd world now. Moved makeuserkey() and cutuserkey() from user_ops.h to user_ops.c Added header to user_ops.h Renamed cutuserkey() to cutusername(). Function has nothing to do with keys. Modified the behavior of ForEachUser() to do the two phase load/perform cycle as part of the function, since so many callbacks were implementing this anyway. People who disagree with me are always wrong and need to die. Initialize TSD key earlier in the startup process. Newer Linux/Linux distributions were beginning to crash on an uninitialized key. Server restart via command no longer requires running as a daemon , uses execv() to restart. Server restart via command no longer requires running as a daemon , uses execv() to restart. testing AC_SEARCH_LIBS(gettext, intl libintl) reversed previous change ctdl_tcp_server and ctdl_uds_server improved handling of error conditions in places like getprotobyname() which normally never throw an error, but in container universe it's a new game. minor changes Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel oops Mark Zuckerberg is the Hitler of our era there it is ... found a stray endif Removed a lot of legacy cruft out of the setup utility. Eventually I want to remove this utility entirely. Removed all of the SYS_ user contexts, they aren't needed anymore cleanup Removed md5.c and md5.h because the APOP implementation which used it is no longer part of Citadel Server The index key for user records now omits non-alphanumeric characters, in addition to the previous behavior of converting to lower case. ForEachUser() now uses a linked list ForEachUser() linked list , keep track of last item so we don't have to traverse backwards Removed the fixnss() step from setup. I don't think it's needed anymore. Moving towards eliminating setup entirely. fix_other_mtas() is old news cosmetic cleanup to serv_virus.c On the first run of the server on an empty database, create a default administrator account. This should eliminate the need to run setup on most systems. Real zombies are undead, not the kind you see on TV. moving towards the new autocompleter do nothing with blank lines, exit on EOF do nothing with blank lines, exit on EOF playing around with readline The user principal identity is now used as the JID in all XMPP protocol stanzas. Suppress output of inline HTML styles when converting to plain text Applied patch sent by Vijay Kumar to correct SMTP dot de-stuffing Shamlessly slapped a 2020 copyright date on all startup banners. cleaned up some spacing while admiring how clean this code is 'Network User' is now 'Normal User' Fixed a bug in username key usage that was causing email aliases to disappear Removed some leftover dependencies on message fields which no longer exist Code cleanup. Added template conditional for suppressing email fields in a vcard edit. When editing a vCard, suppress the email fields from being displayed when editing an account's vCard ZZMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel Removed all mail filtering options except the rules editor in WebCit Remove managesieve framework because we are removing sieve Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel it now builds but does not do inbox filtering module 'sieve' is renamed to 'inboxrules' Handling is now to the point where user accounts requiring potential inbox processing are brought to the handler's attention. Please substitute this comment with whatever you feel like reading right now. work on serialization schtuffs shift around the order of the functions because we're going to remove some duplicated effort ok, we're actually at the point now where we can fetch some inbox messages and process them. Next step for inbox rules processing: retrieve each message in the room using a CtdlForEachMessage() callback with the MSGS_GT operator for maximum allowance of the API to do the hard part instead of writing the comparison code ourselves. Really, that work was already done, so why do it again? Duplication of effort is necessary. For that matter, why does Google insist on maintaining their own email and forums software when they could just use Citadel? Citadel is way better than anything Google or Microsoft have ever produced. And don't get me started about Facebook. Facebook is the absolute worst thing to ever happen to the universe and it should be shut down. Richard Stallman is a pinko commie bastard. minor formatting Removed support for 'before read hooks' because there is no such thing. More chiseling away at the replacement inbox filter. more work on the inboxrules module. don't run this in production. it isn't finished. more inbox filter testing, and yes the build is still broken Removed BSD style curly braces from serv_expire.c and database.c ... Warren embarrassed me into doing it war on BSD style curly braces CM_SetField() and CM_SetAsField() now accept -1 as a length to have the function measure the field for the caller. Make use of the functionality provided in the preceding commit serv_rssclient.c: RFC2047-encode fields where needed msgbase.c: some of the field conversion buffer fields were too small, increased them from 100 bytes to 1024 bytes to handle messages converted from RFC822 or RSS. Fixed an edge case that could crash the server from a malformed message filled out some of the field comparison code Field comparison code is functionally complete Implemented the 'stop' final action fleshed out the actions in pseudocode Implemented keep_message flag to determine whether to keep or delete the copy of a message that is still in the inbox after rules processing Completed the code for the 'reject' action Decided not to attempt normalizing the parameters to action functions meaningless shuffle of parentheses When appropriate, delete the message from the inbox after processing rules. Action functions will return a keep or delete instruction Completed the 'fileinto' action There is no tabs vs. spaces debate. There are only tab users and communists. completed the 'redirect' action inbox_do_reject() does not need to return a value, the message is always deleted This may be the completion of the rewrite bits. Need to test more. Removed unused RSEN server command New field in user record "lastproc_inboxrules" which keeps track of the most recent message processed by the inbox rules filter, since we're now going to make the ruleset something that is only written to when the user changes it. Record the 'last message processed' in the user record instead of in the inbox config message. This eliminates any need to rewrite the config Implemented the 'vacation' action Send a hash of an auto-response to the use table. This keeps us from spamming the same correspondent with an auto-reply over and over. Just a little bit less debug logging When comparing the sender, compare both the name and address. Removed extra references to thread keys that are not extern fix to auto generated messages from inbox handler Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel Ugh. The sloppiness of the code in the text client really reflects how bad I was at this 30+ years ago. In the text client - fixed the logic for determining whether to display the email address of a message author next to their display name. Since we ALWAYS include at least a UPN now, we were getting superfluous displays of them. Must fix the same thing in webcit next. Removed from WebCit Classic all code which handles display of legacy CitaNet node information. Citadel Server doesn't generate these anymore so there's no point in displaying them. Still need to remove them from the templates. This is leading somewhere, so bear with me... missed a few Removed 'node' and 'hnode' items from the templates. Changed the display logic for message author. New conditional COND:MAIL:LOCAL which activates if we believe a message originated locally. This currently only detects c_fqdn and we need to modify it to handle all local domains. If a message originated locally then we display the user name by itself with a link to their profile. If a message originated somewhere else we display the user name and email address. The 'N' (Node) field in the message database has been resurrected, this time as a flag to indicate that a message originated on the local system, as opposed to an inbound email or some other nonlocal source. This field is not populated yet. If old messages with CitaNet remote nodes are discovered by the new code, the desired behavior should still work (suppress display of RFC822 email addresses) Removed an unused parameter from CtdlSubmitMsg(). Why was it even there? Reverted my work on the 'originated locally' field. I found a much simpler way to do it. The server now uses its own knowledge of local domains to set or clear the 'locl' field. This field gives the client a hint about whether the message originated locally. Handle display of local and nonlocal messages correctly in text client WebCit now handles the 'local message' flag correctly. fixed error: 'for' loop initial declarations are only allowed in C99 or C11 mode more of that Rewrote ctdl_startup() using fetch/await Rewrote ctdl_startup() using fetch/await Richard Stallman is a communist and an asshole. Replaced all XHR in main.js with fetch/await No more XHR in views.js the dreaded style cleanup more style cleanup ... ugh more sorting out of the headers more sorting out of the headers Fixed mini_2047_decode() in textclient. It ... actually works now. Moved the defunct server-side renderer into another file to keep as a reference. More distancing of our project from Richard Marx Stallman's linguistic communism Removed a test in html2html() that would cause it to go null every time. Removed chdir() from setup.c - this program requires no run directory. Removed calls to chdir() from citserver. Not needed, and we are trying to make the program relocatable. XMPP Mortuary blocks are now tagged with the user they represent, so if they delete their config room we know who is responsible. Moved the appimage project into the main tree appimage supervisor is functionally complete Remove install directories after build Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel add readme trying to figure out why webcit doesn't chdir properly when run from appimage Update config.guess and config.sub. Fix chdir() and -h in webcit More fine tuning of the AppImage Build citadel server and webcit in temp directories. This allows the builder to enjoy a persistent /usr/local/citadel on the build host. Removed an old debugging harness More work on the appimage Eliminated all destructor hooks. The operating system can clean this up for us better than we can. No more cleanup hooks. The OS can reclaim memory better than we can. We want to get to the database close as soon as possible. cleanup troubleshooting the appimage ctdlvisor is now more sensible about how it stops its child processes. working on the options more appimage stuff related to installation -c option to citserver to only check for binary compatibility compatibility tests Moved most of the command line logic to the shell script look at me , i am a build monkey , see what I can type more diagnostics ulimit -c unlimited Officially declare war on LHFS war on lhfs don't run this, it's broken war on lfhs continues ... what a mess stable now but there are GIANT PIECES MISSING pop3 retrieval working again holy crap there is some old cruft in here I have to rewrite! All of the old network modules are now completely gone. Unfortunately this includes the parts that handled mailing lists, so that has to be put back in. sendcommand now uses the new directory semantics setup now uses the new directory semantics citmail now uses the new directory semantics ctdlmigrate now uses the new directory semantics New listdeliver module (skeleton) Work on the new mailing list engine mkinstalldirs needs to be executable more work on the new listdeliver module listdeliver modules continued remove typedef from struct recptypes syntax cleanup internet_addressing.c serv_smtp.c: don't cache the client context Don't cache this pointer either, it doesn't save enough CPU cycles to be worth the confusion When I don't have the time or focus to deep code, I spend time doing style cleanup and coding standards fixed a spelling error Removed the register/callback stuff from serv_smtp.c , it added more complexity than it saved Added an elastic string buffer class to libcitadel. Why do I have a feeling I'm going to regret this. Use the new elastic array class to queue the list of rooms to be swept for mailing list activity Fixed a bug in the startup sanity checks. When it had to make a fix it was trying to do so during an open cursor. Refactored those functions. Filter out zero-length MX records Write lastsent back to netconfig after sending list messages /* We used to wait for all threads to exit. Fuck that. The only thing important is that the databases are * cleanly unmounted. After that, exit the whole program. For messages delivered to a mailing list, add the room name to the subject line, and Reply-to: to the address of the list. Delivery of messages to mailing list recipients is complete. getmx() now uses our array class more work on listsub stuff Generate subscription/unsubscription confirmation emails Renamed SUBS command to LSUB and changed its parameters. Subscription Type no longer applies because it never worked right anyway. There will now be only one variety of list subscription, and you will like it. Am I making myself clear? Also updated the version of citadel/libcitadel/webcit to 931 across the board, because we changed everything. Fixed an omitted 'break' statement in RFC822 output that was causing multiple To: lines to appear. This was a significant enough bug that I also released it as an out-of-repo patch to Easy Install. Mention in the AppImage docs that we are building the x64 version on ubuntu 16 now. appimage updates build changes 931 Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel fix build name Finished the installer There can be only two. Fixed a bug in StrBufReadBLOBBuffered() that would make the read go into an infinite loop if the client closed the connection during transmission. In the XML export, move the 100% progress tag inside the final closing tag. remove_any_whitespace_to_the_left_or_right_of_at_symbol() is awesomized and no longer throws a compiler warning moved utils directory files into the root removed StartLibCitadel() regretting my brief fling with BSD style braces ctdlmigrate now uses a direct socket connection to the local server instead of sendcommand. Also removed the use of buffered I/O from serv_migrate.c because it was locking up. move braces ctdlmigrate: changed flow of program to avoid gotos, changed SSH to fork() Polishing up ctdlmigrate with lots of ANSI color and box drawing characters because non-ANSI terminals are extinct and now unix people finally get to have the same fun DOS weenies had 40 years ago. Added a comma after each msgnum exported. The parser was globbing them all together when it was just a newline. This unfortunately resets the oldest-compatible-export version to the current version, but it wasn't working anyway. Removed obsolete portions of the tree fix a c99 compile bug ctdlmigrate: exit cleanly when a signal is received, tell the user the exit code Simplified disable_housekeeping ctdlmigrate: use libreadline for prompts When exporting a message, write to the client 10 KB at a time. Fixed an incorrect box drawing character Large migrations over SSH continue failing despite the addition of keepalives in the control channel. Permitting export over TCP to see if it fares better on our own protocol. My current love affair is with C++ style comments. Will it last? formatting updated config.guess in libcitadel Various changes to appimage. Removed some old docs. add some db_ utils to the appimage dir updated database_cleanup.sh Removed the comments about RMS being an asshole communist. I don't want anyone to think that I am part of the fascist 'MeToo' movement. My objection to RMS is that he is a far-left asshole communist, not that other far-left asshole communists want to cancel him. Added 'database_cleanup' to the AppImage Added more exit points to build_appimage.sh so we know where it failed Removed help text in database_cleanup.sh which suggested that the intermediate dump files could be anywhere other than /tmp. Removed test_binary_compatibility() from ctdlvisor.c because we don't do it that way anymore. try to sense the architecture better more cpu detect working on ctdlmigrate in the appimage Removed exit code definitions that are no longer used Fixed .Help SUMMARY Updated the boilerplate on each file Cleaning up the code in the text client a bit Remove support for the old inline paging mode ... geez, we've only had extended paging for 21 years Assume the server supports the QNOP command, do not test for it, this is another command we've supported for 20 years Save the text client! Display stack trace on caught signal. Also do this on segv now. New server option -b to specify the name of a file to which backtrace should be written if the server crashes. Add backtrace to the appimage Removed the backtrace stuff. It wasn't producing traces that were useful. Added undocumented mount and debug modes to the appimage arrgh ZZMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel Try to use the published excludelist for libraries in the appimage Toying around with more boilerplate. Epstein didn't kill himself. here have code fixed a bug with ctdlmigrate running in appimage Include libexpat with the appimage, do not exclude it random boilerplate 2021-06-02 03:45 from jmb100770 Subject: Re: 500 No such user on AUTH LOGIN I encountered this same authentication problem with version 931 built via easy-install.  I think the problem is with citadel/modules/smtp/serv_smtp.c where smtp_get_user(5) is called in smtp_command_loop.  From this context, the offset parameter 5 should be replaced by zero (0).  I modified the easy-install script to work with a patched copy of the tarball and the resulting build seems to work correctly. remove libz from excludelist Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel test commit version.sh Getting ready for a new do-release.sh script ZZ Release version 932 generated by do-release.sh appimage filename now uses ../release_version.txt instead of the timestamp armhf aarch64 Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel began making the client AppImage-aware add the ability to run the client from the appimage ARCH needs to be set to 'arm' for 32-bit appimage improvements to installation cleanup run-client.sh script This is it, I figured out how to create a client link A bit of prep work to bring back the global alias table. This time I want to be able to expand aliases to multiple recipients, so it will be a bit more complex. This commit enhances validate_recipients() to read the recipient list into an array before processing. Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel Reworked validate_recipients() and expand_aliases() in preparation for expanding aliases into multiple recipients Expansion of aliases is working. Still need to restore the behavior of underscores in room aliases, and handle infinite aliasing loops. Do not expand aliases once we get past the original length of the recipient array. This prevents endless aliasing loops. Slightly better logic for preventing endless aliasing loops The overhaul of recipient parsing code is complete. We can now handle a global alias table. Now I just have to write that :) misc cleanup Added a delete element method to the array class in libcitadel. CtdlGetSysConfig() and CtdlPutSysConfig() now have the ability to store large configuration items as message texts in the Local System Configuration room by saving their message numbers as items in the regular configuration database. This eliminates the last place where we did 'Delete all other messages in this room which have the same MIME type' and that ability has therefore been removed from the code. There is enough code remaining to read configurations saved the old way, but they are upgraded the first time they are read. CONF LOADVAL and CONF STOREVAL are deprecated and probably safe to remove. Initial version of global alias table is in place. But it seems to have a Heisenbug. This completes the server portion of the Global Alias table. Abandoned the AppImage Remove APPDIR support in database_cleanup.sh Removed a bit of diagnostic code no longer needed Removed the WebCit tab for 'push email' since the server doesn't do that anymore. Replaced it with a 'Global email aliases' tab. Skeleton code for the Global Email Aliases tab. To hell with the existing template engine. We are switching to the design pattern used in WebCit-NG and hopefully I won't have to rewrite this thing again. made it async using fetch/await Fine tuning the design pattern Additional work on the alias table. This is taking longer than it ought to because I am using it to prototype a design pattern for WebCit-NG. Also began removing some of the cached session stuff. Trivial commit to test automated builds another trivial commit to test builds Moved the global email aliases editing screen to its own page to avoid having to mess with the multi tab form. CtdlPutSysConfig() don't delete the old copy of the config until after the new one has been written. This eliminates data loss if the server is stopped in between. do_generic now supports a return_to variable, so it can be used by commands which just want to do generic citadel server stuff. When a client of any protocol handler sends a command to initiate SSL/TLS on a connection that is already using encryption, throw a clean error instead of crashing. Finished the WebCit screen for the Global Alias Table. Do not attempt to search for database records of length 0. Well, it doesn't crash anymore, but it also doesn't work at all. Is that an improvement? Saving my place while we try something... I got the bug to stop biting me, and even made the code more beautiful in the process. Now it also works when receiving messages over SMTP. Still need to eliminate dupes. validate_recipients() now strips out duplicate recipients ... probably some 15 years after I wrote the FIXME comment saying to do that. Release version 933 generated by do-release.sh Release version 934 generated by do-release.sh Release version 935 generated by do-release.sh Release version 936 generated by do-release.sh Release version 937 generated by do-release.sh Fixed some rendering problems in webcit that resulted from the removal of VIEW_WIKIMD from the header file Release version 938 generated by do-release.sh Release version 939 generated by do-release.sh root (6): Removed the superfluous function fmt_date() in libcitadel since it just calls strftime() anyway. Converted the two client calls in textclient to strftime() silenced a silly little compiler warning removed some old cruft input type="date" here will allow datepicker.js to be eliminated and should fall back to type="text" in the few remaining browsers that don't support it. This wraps up the ctdlmigrate fixes. Fixed a bug in the new aliasing code that broke mail to rooms with spaces in their names. ----------------------------------------------------------------------- hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283521Fri, 26 Nov 2021 00:54:16 +05002099283521@Uncensored Date: Fri Nov 26 00:54:14 2021 -0500 make a note that we have to retain the reply message number ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283516Fri, 26 Nov 2021 00:51:15 +05002099283516@Uncensored Date: Fri Nov 26 00:51:12 2021 -0500 Capture the new message number from the etag of the post transaction ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283514Fri, 26 Nov 2021 00:39:06 +05002099283514@Uncensored Date: Fri Nov 26 00:39:04 2021 -0500 Link entry in the editor now works. The example code at https://www.thatsoftwaredude.com/content/8912/create-a-basic-text-editor-in-javascript was a bit naive because it assumes the URL is already known at the moment the user presses the Link button. We open a box for URL entry, but when the user clicks into that box the original selection disappears. So we have to save the selection range in hidden fields so we know where to replace the text. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 1 + webcit-ng/static/js/view_forum.js | 58 +++++++++++++++++++++++++++++++++++---- 2 files changed, 53 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283479Thu, 25 Nov 2021 15:36:05 +05002099283479@Uncensored Date: Thu Nov 25 15:36:03 2021 -0500 bold, italic, and list buttons now work. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 37 +++++++++++++++++++++++++------------ 1 file changed, 25 insertions(+), 12 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283365Wed, 24 Nov 2021 15:05:46 +05002099283365@Uncensored Date: Wed Nov 24 15:05:42 2021 -0500 split utility function out into a separate util.js ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 1 + webcit-ng/static/js/util.js | 44 +++++++++++++++++++++++++++++++++++++++ webcit-ng/static/js/view_forum.js | 32 ---------------------------- 3 files changed, 45 insertions(+), 32 deletions(-) create mode 100644 webcit-ng/static/js/util.js hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283348Wed, 24 Nov 2021 12:54:28 +05002099283348@Uncensored Date: Wed Nov 24 12:54:24 2021 -0500 Placed the bold/italic/list/link buttons in the editor. (They don't work yet.) ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283343Wed, 24 Nov 2021 11:51:54 +05002099283343@Uncensored Date: Wed Nov 24 11:51:51 2021 -0500 Prettied up the qp encoder function a bit. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283292Wed, 24 Nov 2021 00:47:17 +05002099283292@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283291Wed, 24 Nov 2021 00:42:10 +05002099283291@Uncensored Date: Wed Nov 24 00:42:08 2021 -0500 Post messages in quoted-printable instead of base64, just like WebCit Classic does. This avoids double-base64-encoding of inline images. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 54 ++++++++++++++++++++++++++++++--------- 1 file changed, 42 insertions(+), 12 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283288Wed, 24 Nov 2021 00:27:17 +05002099283288@Uncensored Date: Wed Nov 24 00:27:13 2021 -0500 Save messages as multipart/mixed with the HTML component in base64 encoding. We probably should rethink this because now we're double-base64-encoding inline images. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283282Tue, 23 Nov 2021 23:53:02 +05002099283282@Uncensored Date: Tue Nov 23 23:53:00 2021 -0500 Revert previous commit because it didn't work. Furthermore, remove the content-length header from the PUT operation because the browser wants to do that on its own. ----------------------------------------------------------------------- Summary of changes: webcit-ng/messages.c | 7 ------- webcit-ng/static/js/view_forum.js | 9 --------- 2 files changed, 16 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283281Tue, 23 Nov 2021 23:48:38 +05002099283281@Uncensored Date: Tue Nov 23 23:48:36 2021 -0500 Permit the Content-Transfer-Encoding: header to be forwarded from an HTTP transaction to a post on a Citadel server. This isn't typical for HTTP but we need it. ----------------------------------------------------------------------- Summary of changes: webcit-ng/messages.c | 7 +++++++ 1 file changed, 7 insertions(+) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283278Tue, 23 Nov 2021 23:44:07 +05002099283278@Uncensored Date: Tue Nov 23 23:44:04 2021 -0500 Moved the remaining else blocks ----------------------------------------------------------------------- Summary of changes: webcit-ng/admin_functions.c | 2 +- webcit-ng/api.txt | 2 +- webcit-ng/caldav_reports.c | 14 +++++++++----- webcit-ng/ctdl_commands.c | 5 +++-- webcit-ng/ctdlclient.c | 14 +++++++++----- webcit-ng/ctdlfunctions.c | 5 +++-- webcit-ng/forum_view.c | 5 +++-- webcit-ng/html2html.c | 15 ++++++++++----- webcit-ng/http.c | 2 +- webcit-ng/main.c | 2 +- webcit-ng/messages.c | 25 ++++++++++++++++--------- webcit-ng/room_functions.c | 3 ++- webcit-ng/ssl.c | 2 +- webcit-ng/static.c | 2 +- webcit-ng/static/js/view_forum.js | 9 ++++++++- webcit-ng/tcp_sockets.c | 2 +- webcit-ng/user_functions.c | 5 +++-- webcit-ng/util.c | 2 +- webcit-ng/webserver.c | 2 +- 19 files changed, 75 insertions(+), 43 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283268Tue, 23 Nov 2021 20:09:25 +05002099283268@Uncensored Date: Tue Nov 23 20:09:23 2021 -0500 Handle posting errors a little more elegantly. ----------------------------------------------------------------------- Summary of changes: webcit-ng/messages.c | 2 +- webcit-ng/static/js/view_forum.js | 15 +++++++-------- 2 files changed, 8 insertions(+), 9 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283262Tue, 23 Nov 2021 19:57:09 +05002099283262@Uncensored Date: Tue Nov 23 19:57:07 2021 -0500 Detect whether the save operation succeeded by checking the response status of the XHR transaction. Also made the default Citadel server dev.citadel.org instead of uncensored.citadel.org because I am posting a lot of test messages. ----------------------------------------------------------------------- Summary of changes: webcit-ng/api.txt | 1 + webcit-ng/static/js/view_forum.js | 16 +++++++++++----- webcit-ng/webcit.h | 2 +- 3 files changed, 13 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283250Tue, 23 Nov 2021 19:04:32 +05002099283250@UncensoredThis message is being posted with WebCit-NG!

There's a lot of stuff to be cleaned up, of course, but the basic framework is in place.  I can't believe it was so easy to write my own editor.  The "contenteditable" attribute made it a no-brainer.  This was so much easier than trying to decide which third-party editor to integrate.  In fact, it's easy enough that I can write and maintain separate editors for forum rooms and mailbox rooms.

That'll be a good thing, actually.  Right now I'm working on the forum view, and it encourages the desired style of discourse by making the editor box appear directly below the message to which you are replying, just like it does in text mode and on non-Citadel forums.  For a mailbox room, it'll clear the screen and display a big empty window with a lot of editor and attachment options.

I am so jazzed!

]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283245Tue, 23 Nov 2021 18:41:13 +05002099283245@Uncensored Date: Tue Nov 23 18:41:11 2021 -0500 Wow! Posting a message to the server worked on the first try, even using the existing DAV operation and no new C code. That was a pleasant surprise. ----------------------------------------------------------------------- Summary of changes: webcit-ng/api.txt | 3 +++ webcit-ng/static/js/view_forum.js | 33 +++++++++++++++++++++++++++++---- 2 files changed, 32 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283232Tue, 23 Nov 2021 16:24:53 +05002099283232@Uncensored Date: Tue Nov 23 16:24:50 2021 -0500 Got it working, now it's pretty http://code.citadel.org/?p=citadel.git&a=commit&h=1bdbdb234926764fd9097f3621f878f749e6b4c7 commit 1bdbdb234926764fd9097f3621f878f749e6b4c7 Author: Art Cancro Date: Tue Nov 23 16:13:48 2021 -0500 content editable window with focus and cursor ----------------------------------------------------------------------- Summary of changes: webcit-ng/http.c | 2 +- webcit-ng/static/js/view_forum.js | 9 ++++++++- 2 files changed, 9 insertions(+), 2 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283142Mon, 22 Nov 2021 19:22:59 +05002099283142@Uncensored Date: Mon Nov 22 19:22:57 2021 -0500 Fixed the vertical float issue by specifying the height of the text div and letting the rest wrap around as it wants to. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283064Sun, 21 Nov 2021 17:43:50 +05002099283064@Uncensored Date: Sun Nov 21 17:43:48 2021 -0500 how about that scroll? ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099283000Sat, 20 Nov 2021 17:09:55 +05002099283000@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099282999Sat, 20 Nov 2021 17:03:58 +05002099282999@Uncensored Date: Sat Nov 20 17:03:56 2021 -0500 Hot damn! I just discovered scrollIntoView() ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099282715Wed, 17 Nov 2021 21:10:15 +05002099282715@Uncensored Date: Wed Nov 17 21:10:12 2021 -0500 save/cancel ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099282710Wed, 17 Nov 2021 20:30:13 +05002099282710@Uncensored Date: Wed Nov 17 20:30:10 2021 -0500 replybox adornments ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 41 +++++++++++++++++++++++++++++++++------ 1 file changed, 35 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099282709Wed, 17 Nov 2021 20:25:28 +05002099282709@Uncensored Date: Wed Nov 17 20:25:23 2021 -0500 more work on the reply box ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099282701Wed, 17 Nov 2021 20:15:07 +05002099282701@Uncensored Date: Wed Nov 17 20:15:04 2021 -0500 Intermediate commit: open a new div beneath the existing one when Reply or ReplyQuoted is selected ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099282688Wed, 17 Nov 2021 18:04:33 +05002099282688@Uncensored Date: Wed Nov 17 18:04:30 2021 -0500 fujobi ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099282497Mon, 15 Nov 2021 18:56:40 +05002099282497@Uncensored Date: Mon Nov 15 18:56:35 2021 -0500 Release version 940 generated by do-release.sh http://code.citadel.org/?p=citadel.git&a=commit&h=24d1e719dd6b40e0eb4153b928b758abb17863a1 commit 24d1e719dd6b40e0eb4153b928b758abb17863a1 Author: Art Cancro Date: Mon Nov 15 18:56:29 2021 -0500 Removed the remaining code where LDAP was optional. ----------------------------------------------------------------------- Summary of changes: citadel/citadel.h | 2 +- citadel/config.c | 9 --------- citadel/control.c | 8 -------- citadel/housekeeping.c | 3 +-- citadel/ldap.c | 31 +++++++++++++------------------ citadel/modules/ctdlproto/serv_session.c | 5 ----- citadel/modules/vcard/serv_vcard.c | 8 ++------ citadel/user_ops.c | 30 +++++++++++------------------- libcitadel/lib/libcitadel.h | 2 +- release_version.txt | 2 +- webcit/webcit.h | 2 +- 11 files changed, 31 insertions(+), 71 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099282383Sun, 14 Nov 2021 18:34:34 +05002099282383@Uncensored Date: Sun Nov 14 18:34:32 2021 -0500 Removed the 'old threaded view save for reference' code from the tree. It's still in the git history if we need it, and JWZ is still a self-righteous asshole. ----------------------------------------------------------------------- Summary of changes: webcit-ng/old_threaded_view_save_for_reference.c | 286 ----------------------- webcit-ng/room_functions.c | 25 +- 2 files changed, 13 insertions(+), 298 deletions(-) delete mode 100644 webcit-ng/old_threaded_view_save_for_reference.c hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099282380Sun, 14 Nov 2021 18:28:40 +05002099282380@Uncensored Date: Sun Nov 14 18:28:35 2021 -0500 increased the margin around the message reading boxes ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281738Sat, 06 Nov 2021 16:55:39 +05002099281738@Uncensored Date: Sat Nov 6 16:55:37 2021 -0400 notes ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/view_forum.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281737Sat, 06 Nov 2021 16:56:41 +05002099281737@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281734Sat, 06 Nov 2021 16:43:07 +05002099281734@Uncensored Date: Sat Nov 6 16:43:05 2021 -0400 Split the forum view into a separate .js file. We will do this for all views. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/index.html | 13 +- webcit-ng/static/js/{views.js => view_forum.js} | 40 +----- webcit-ng/static/js/views.js | 171 +----------------------- 3 files changed, 12 insertions(+), 212 deletions(-) copy webcit-ng/static/js/{views.js => view_forum.js} (83%) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281729Sat, 06 Nov 2021 16:07:05 +05002099281729@Uncensored Date: Sat Nov 6 16:07:02 2021 -0400 nip and tuck ----------------------------------------------------------------------- Summary of changes: webcit-ng/text2html.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281728Sat, 06 Nov 2021 16:05:17 +05002099281728@Uncensored Date: Sat Nov 6 16:05:13 2021 -0400 Reply/ReplyAll/Delete buttons are pretty now ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 6 ++++-- webcit-ng/static/js/views.js | 18 ++++++++++++++---- 2 files changed, 18 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281660Fri, 05 Nov 2021 19:41:07 +05002099281660@Uncensored Date: Fri Nov 5 19:41:04 2021 -0400 The buttons now look like buttons, the reply button has a nice reply icon in it, and they change color when you hover over them. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 20 +++++++++++++++++--- webcit-ng/static/js/views.js | 9 ++++++--- 2 files changed, 23 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281653Fri, 05 Nov 2021 17:54:08 +05002099281653@Uncensored Date: Fri Nov 5 17:54:06 2021 -0400 When sending MSGS commands, unescape the command being sent to the server ----------------------------------------------------------------------- Summary of changes: webcit-ng/room_functions.c | 10 ++++------ webcit-ng/static/js/views.js | 7 ------- 2 files changed, 4 insertions(+), 13 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281650Fri, 05 Nov 2021 17:40:28 +05002099281650@Uncensored Date: Fri Nov 5 17:40:25 2021 -0400 Tinkering with the headers some more ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 2 ++ webcit-ng/static/js/views.js | 4 ++++ 2 files changed, 6 insertions(+) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281647Fri, 05 Nov 2021 17:32:50 +05002099281647@Uncensored Date: Fri Nov 5 17:32:45 2021 -0400 Added CSS style for the Loading Messages, Older Posts, Newer Posts divs ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 16 +++++++++++++--- webcit-ng/static/js/views.js | 6 +++--- 2 files changed, 16 insertions(+), 6 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281235Mon, 01 Nov 2021 09:38:17 +05002099281235@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281232Mon, 01 Nov 2021 09:27:32 +05002099281232@Uncensored Date: Mon Nov 1 09:27:30 2021 -0400 Display the subject line -- only if present ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/js/views.js | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281121Sat, 30 Oct 2021 16:29:08 +05002099281121@Uncensored Date: Sat Oct 30 16:29:06 2021 -0400 Add subject to json output ----------------------------------------------------------------------- Summary of changes: webcit-ng/forum_view.c | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281118Sat, 30 Oct 2021 16:14:55 +05002099281118@Uncensored Date: Sat Oct 30 16:14:53 2021 -0400 Tuned up the CSS for message board view. It looks pretty good now. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 28 +++++++++++++++++++++++++++- webcit-ng/static/js/views.js | 12 ++++++++++-- 2 files changed, 37 insertions(+), 3 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099281114Sat, 30 Oct 2021 15:42:42 +05002099281114@Uncensored Date: Sat Oct 30 15:42:39 2021 -0400 Use overflow:hidden style to keep the user avatar photo from breaking through the rounded corner of the container. ----------------------------------------------------------------------- Summary of changes: webcit-ng/static/css/webcit.css | 2 ++ webcit-ng/static/js/views.js | 31 +++++++++++++++---------------- 2 files changed, 17 insertions(+), 16 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099280684Mon, 25 Oct 2021 13:25:19 +05002099280684@Uncensored Date: Mon Oct 25 13:25:17 2021 -0400 Changing signal handlers to the correct type eliminates the last of the warning messages ----------------------------------------------------------------------- Summary of changes: textclient/screen.c | 2 +- textclient/textclient.h | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099280680Mon, 25 Oct 2021 13:21:51 +05002099280680@Uncensored Date: Mon Oct 25 13:21:47 2021 -0400 Suppress format-truncation warnings because they are WRONG ----------------------------------------------------------------------- Summary of changes: textclient/configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099280425Thu, 21 Oct 2021 22:37:50 +05002099280425@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099280399Thu, 21 Oct 2021 16:06:17 +05002099280399@Uncensored Date: Thu Oct 21 16:06:13 2021 -0400 Poking around in the text client to determine whether we can remove dependency on libcitadel. ----------------------------------------------------------------------- Summary of changes: textclient/citadel.c | 2 +- textclient/citadel_ipc.c | 16 ++++++++-------- textclient/client_chat.c | 2 +- textclient/messages.c | 12 ++++++------ textclient/rooms.c | 10 +++++----- textclient/routines2.c | 20 ++++++++++---------- 6 files changed, 31 insertions(+), 31 deletions(-) hooks/post-receive -- ]]>http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099278239Thu, 23 Sep 2021 09:17:06 +05002099278239@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099278172Wed, 22 Sep 2021 13:52:56 +05002099278172@Uncensoredhttp://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099278154Wed, 22 Sep 2021 10:38:13 +05002099278154@Uncensored

Thanks to you

Basically that is the problem.

The other weird effects seem to be related to the Firefox cache (which I periodically clear) or to the SSL certificate (see image); I had to clear it and create an exception.

Note: When I click "View Certificate", Firefox shows a blank screen. Strange, isn't it?

Tue Sep 21 2021 04:57:32 PM EDT from IGnatius T Foobar

Confirmed! I reproduced the problem on a test machine. I am able to send email to a room that has no spaces in its name ("room1") but not to a room with spaces ("Citadel Development").

Does that sound like the problem you have been having? I'm going to fix that next. Thanks for the bug report.